2019-07-15 05:35:02 +00:00
|
|
|
#![cfg_attr(feature = "deny-warnings", deny(warnings))]
|
|
|
|
|
2020-02-21 08:39:38 +00:00
|
|
|
use rustc_tools_util::VersionInfo;
|
2018-09-06 06:19:47 +00:00
|
|
|
|
2016-10-24 14:04:00 +00:00
|
|
|
const CARGO_CLIPPY_HELP: &str = r#"Checks a package to catch common mistakes and improve your Rust code.
|
2016-10-24 13:31:11 +00:00
|
|
|
|
|
|
|
Usage:
|
|
|
|
cargo clippy [options] [--] [<opts>...]
|
|
|
|
|
|
|
|
Common options:
|
|
|
|
-h, --help Print this message
|
2016-11-08 12:54:08 +00:00
|
|
|
-V, --version Print version info and exit
|
2016-10-24 13:31:11 +00:00
|
|
|
|
2018-03-28 22:17:48 +00:00
|
|
|
Other options are the same as `cargo check`.
|
2016-10-24 13:31:11 +00:00
|
|
|
|
2016-10-25 13:09:56 +00:00
|
|
|
To allow or deny a lint from the command line you can use `cargo clippy --`
|
|
|
|
with:
|
2016-10-24 13:31:11 +00:00
|
|
|
|
|
|
|
-W --warn OPT Set lint warnings
|
|
|
|
-A --allow OPT Set lint allowed
|
|
|
|
-D --deny OPT Set lint denied
|
2016-10-24 14:04:00 +00:00
|
|
|
-F --forbid OPT Set lint forbidden
|
|
|
|
|
2018-12-25 16:11:57 +00:00
|
|
|
You can use tool lints to allow or deny lints from your code, eg.:
|
2016-10-24 14:04:00 +00:00
|
|
|
|
2018-12-25 16:11:57 +00:00
|
|
|
#[allow(clippy::needless_lifetimes)]
|
2016-10-24 14:04:00 +00:00
|
|
|
"#;
|
2016-10-24 13:31:11 +00:00
|
|
|
|
2016-10-24 14:29:36 +00:00
|
|
|
fn show_help() {
|
|
|
|
println!("{}", CARGO_CLIPPY_HELP);
|
|
|
|
}
|
|
|
|
|
2016-11-08 13:28:46 +00:00
|
|
|
fn show_version() {
|
2018-09-06 06:19:47 +00:00
|
|
|
let version_info = rustc_tools_util::get_version_info!();
|
|
|
|
println!("{}", version_info);
|
2016-11-08 13:28:46 +00:00
|
|
|
}
|
|
|
|
|
2016-05-24 16:25:25 +00:00
|
|
|
pub fn main() {
|
2016-11-08 12:54:08 +00:00
|
|
|
// Check for version and help flags even when invoked as 'cargo-clippy'
|
|
|
|
if std::env::args().any(|a| a == "--help" || a == "-h") {
|
|
|
|
show_help();
|
|
|
|
return;
|
|
|
|
}
|
2018-09-06 06:19:47 +00:00
|
|
|
|
2016-11-08 12:54:08 +00:00
|
|
|
if std::env::args().any(|a| a == "--version" || a == "-V") {
|
2016-11-08 13:28:46 +00:00
|
|
|
show_version();
|
2016-11-08 12:54:08 +00:00
|
|
|
return;
|
|
|
|
}
|
2016-05-24 16:25:25 +00:00
|
|
|
|
2018-03-28 22:17:48 +00:00
|
|
|
if let Err(code) = process(std::env::args().skip(2)) {
|
|
|
|
std::process::exit(code);
|
2016-05-24 16:25:25 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-03-28 09:50:17 +00:00
|
|
|
fn process<I>(mut old_args: I) -> Result<(), i32>
|
2017-08-09 07:30:56 +00:00
|
|
|
where
|
|
|
|
I: Iterator<Item = String>,
|
2016-06-05 23:42:39 +00:00
|
|
|
{
|
2018-03-28 09:50:17 +00:00
|
|
|
let mut args = vec!["check".to_owned()];
|
2016-05-24 16:25:25 +00:00
|
|
|
|
2020-03-27 19:47:57 +00:00
|
|
|
let mut fix = false;
|
|
|
|
let mut unstable_options = false;
|
|
|
|
|
2018-03-28 09:50:17 +00:00
|
|
|
for arg in old_args.by_ref() {
|
2020-03-27 20:23:06 +00:00
|
|
|
match arg.as_str() {
|
2020-03-27 19:47:57 +00:00
|
|
|
"--fix" => {
|
|
|
|
fix = true;
|
|
|
|
continue;
|
2020-03-27 20:23:06 +00:00
|
|
|
}
|
2020-03-27 19:47:57 +00:00
|
|
|
"--" => break,
|
|
|
|
// Cover -Zunstable-options and -Z unstable-options
|
|
|
|
s if s.ends_with("unstable-options") => unstable_options = true,
|
2020-03-27 20:23:06 +00:00
|
|
|
_ => {}
|
2020-03-23 17:41:19 +00:00
|
|
|
}
|
|
|
|
|
2016-05-24 16:25:25 +00:00
|
|
|
args.push(arg);
|
|
|
|
}
|
2018-03-28 09:50:17 +00:00
|
|
|
|
2020-03-27 20:23:06 +00:00
|
|
|
if fix {
|
|
|
|
if !unstable_options {
|
|
|
|
panic!("Usage of `--fix` requires `-Z unstable-options`");
|
|
|
|
} else {
|
|
|
|
args[0] = "fix".to_owned();
|
|
|
|
}
|
2020-03-27 19:47:57 +00:00
|
|
|
}
|
|
|
|
|
2020-03-27 20:23:06 +00:00
|
|
|
let path_env = if unstable_options {
|
2020-03-27 19:47:57 +00:00
|
|
|
"RUSTC_WORKSPACE_WRAPPER"
|
|
|
|
} else {
|
|
|
|
"RUSTC_WRAPPER"
|
|
|
|
};
|
|
|
|
|
2018-03-28 09:50:17 +00:00
|
|
|
let clippy_args: String = old_args.map(|arg| format!("{}__CLIPPY_HACKERY__", arg)).collect();
|
2016-05-27 13:31:19 +00:00
|
|
|
|
2018-01-17 07:52:41 +00:00
|
|
|
let mut path = std::env::current_exe()
|
2017-09-18 10:47:33 +00:00
|
|
|
.expect("current executable path invalid")
|
|
|
|
.with_file_name("clippy-driver");
|
2018-01-17 07:52:41 +00:00
|
|
|
if cfg!(windows) {
|
|
|
|
path.set_extension("exe");
|
|
|
|
}
|
2018-04-01 07:28:53 +00:00
|
|
|
|
2018-04-02 07:28:08 +00:00
|
|
|
let target_dir = std::env::var_os("CLIPPY_DOGFOOD")
|
|
|
|
.map(|_| {
|
|
|
|
std::env::var_os("CARGO_MANIFEST_DIR").map_or_else(
|
2019-01-27 00:44:52 +00:00
|
|
|
|| std::ffi::OsString::from("clippy_dogfood"),
|
2018-04-02 07:28:08 +00:00
|
|
|
|d| {
|
|
|
|
std::path::PathBuf::from(d)
|
|
|
|
.join("target")
|
|
|
|
.join("dogfood")
|
|
|
|
.into_os_string()
|
|
|
|
},
|
|
|
|
)
|
2018-11-27 20:12:13 +00:00
|
|
|
})
|
|
|
|
.map(|p| ("CARGO_TARGET_DIR", p));
|
2018-04-01 07:28:53 +00:00
|
|
|
|
2019-01-26 09:10:13 +00:00
|
|
|
// Run the dogfood tests directly on nightly cargo. This is required due
|
|
|
|
// to a bug in rustup.rs when running cargo on custom toolchains. See issue #3118.
|
|
|
|
if std::env::var_os("CLIPPY_DOGFOOD").is_some() && cfg!(windows) {
|
|
|
|
args.insert(0, "+nightly".to_string());
|
|
|
|
}
|
|
|
|
|
2016-05-27 13:31:19 +00:00
|
|
|
let exit_status = std::process::Command::new("cargo")
|
|
|
|
.args(&args)
|
2020-03-27 20:23:06 +00:00
|
|
|
.env(path_env, path)
|
2018-03-28 09:50:17 +00:00
|
|
|
.env("CLIPPY_ARGS", clippy_args)
|
2018-04-02 07:28:08 +00:00
|
|
|
.envs(target_dir)
|
2016-12-20 09:20:41 +00:00
|
|
|
.spawn()
|
|
|
|
.expect("could not run cargo")
|
|
|
|
.wait()
|
|
|
|
.expect("failed to wait for cargo?");
|
2016-05-27 13:31:19 +00:00
|
|
|
|
2016-06-06 09:28:09 +00:00
|
|
|
if exit_status.success() {
|
|
|
|
Ok(())
|
|
|
|
} else {
|
2016-06-06 14:43:58 +00:00
|
|
|
Err(exit_status.code().unwrap_or(-1))
|
2016-05-27 13:31:19 +00:00
|
|
|
}
|
2016-05-24 16:25:25 +00:00
|
|
|
}
|