rust-clippy/tests/ui/needless_if.fixed

93 lines
1.8 KiB
Rust
Raw Normal View History

2023-06-10 11:43:30 +00:00
//@run-rustfix
2023-04-20 15:19:36 +00:00
//@aux-build:proc_macros.rs:proc-macro
#![feature(let_chains)]
2023-06-10 11:43:30 +00:00
#![allow(
clippy::blocks_in_if_conditions,
clippy::if_same_then_else,
clippy::ifs_same_cond,
clippy::let_unit_value,
2023-06-10 11:43:30 +00:00
clippy::needless_else,
clippy::no_effect,
clippy::nonminimal_bool,
clippy::short_circuit_statement,
clippy::unnecessary_operation,
2023-06-10 11:43:30 +00:00
unused
)]
#![warn(clippy::needless_if)]
extern crate proc_macros;
use proc_macros::{external, with_span};
2023-06-10 11:43:30 +00:00
fn maybe_side_effect() -> bool {
true
}
2023-06-10 11:43:30 +00:00
fn main() {
// Lint
// Do not remove the condition
maybe_side_effect();
2023-06-10 11:43:30 +00:00
// Do not lint
if (true) {
} else {
}
({
return;
});
2023-06-10 11:43:30 +00:00
// Do not lint if `else if` is present
if (true) {
} else if (true) {
}
// Do not lint `if let` or let chains
if let true = true {}
if let true = true && true {}
if true && let true = true {}
// Can lint nested `if let`s
({
2023-06-11 12:12:46 +00:00
if let true = true && true { true } else { false }
} && true);
2023-06-10 11:43:30 +00:00
external! { if (true) {} }
with_span! {
span
if (true) {}
}
if true {
// comment
}
if true {
#[cfg(any())]
foo;
}
macro_rules! empty_expansion {
() => {};
}
if true {
empty_expansion!();
}
macro_rules! empty_repetition {
($($t:tt)*) => {
if true {
$($t)*
}
}
}
empty_repetition!();
// Must be placed into an expression context to not be interpreted as a block
({ maybe_side_effect() });
// Would be a block followed by `&&true` - a double reference to `true`
({ maybe_side_effect() } && true);
// Don't leave trailing attributes
#[allow(unused)]
true;
let () = if maybe_side_effect() {};
2023-06-10 11:43:30 +00:00
}