rust-clippy/tests/ui/blocks_in_conditions.rs

103 lines
2.1 KiB
Rust
Raw Normal View History

#![warn(clippy::blocks_in_conditions)]
2023-06-10 11:43:30 +00:00
#![allow(unused, clippy::let_and_return, clippy::needless_if)]
2018-07-28 15:34:52 +00:00
#![warn(clippy::nonminimal_bool)]
2015-11-20 05:22:52 +00:00
macro_rules! blocky {
() => {{ true }};
}
2016-01-31 22:25:10 +00:00
macro_rules! blocky_too {
() => {{
let r = true;
r
2018-12-09 22:26:16 +00:00
}};
2016-01-31 22:25:10 +00:00
}
fn macro_if() {
2018-12-09 22:26:16 +00:00
if blocky!() {}
2016-12-21 11:30:41 +00:00
2018-12-09 22:26:16 +00:00
if blocky_too!() {}
}
2016-01-31 22:25:10 +00:00
2015-11-20 05:22:52 +00:00
fn condition_has_block() -> i32 {
2017-02-08 13:58:07 +00:00
if {
//~^ ERROR: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
2015-11-20 05:22:52 +00:00
let x = 3;
x == 3
} {
6
} else {
10
}
}
fn condition_has_block_with_single_expression() -> i32 {
if { true } { 6 } else { 10 }
//~^ ERROR: omit braces around single expression condition
2015-11-20 05:22:52 +00:00
}
fn condition_is_normal() -> i32 {
let x = 3;
if true && x == 3 { 6 } else { 10 }
2015-11-20 05:22:52 +00:00
}
fn condition_is_unsafe_block() {
let a: i32 = 1;
// this should not warn because the condition is an unsafe block
if unsafe { 1u32 == std::mem::transmute(a) } {
println!("1u32 == a");
}
}
2019-08-27 07:43:19 +00:00
fn block_in_assert() {
let opt = Some(42);
assert!(
opt.as_ref()
.map(|val| {
let mut v = val * 2;
v -= 1;
v * 3
})
.is_some()
);
2019-08-27 07:43:19 +00:00
}
// issue #11814
fn block_in_match_expr(num: i32) -> i32 {
match {
//~^ ERROR: in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
let opt = Some(2);
opt
} {
Some(0) => 1,
Some(n) => num * 2,
None => 0,
};
match unsafe {
let hearty_hearty_hearty = vec![240, 159, 146, 150];
String::from_utf8_unchecked(hearty_hearty_hearty).as_str()
} {
"💖" => 1,
"what" => 2,
_ => 3,
}
}
// issue #12162
macro_rules! timed {
($name:expr, $body:expr $(,)?) => {{
let __scope = ();
$body
}};
}
fn issue_12162() {
if timed!("check this!", false) {
println!();
}
}
fn main() {}