rust-clippy/tests/ui/identity_op.rs

70 lines
1.2 KiB
Rust
Raw Normal View History

2018-12-09 22:26:16 +00:00
const ONE: i64 = 1;
const NEG_ONE: i64 = -1;
const ZERO: i64 = 0;
struct A(String);
impl std::ops::Shl<i32> for A {
type Output = A;
fn shl(mut self, other: i32) -> Self {
self.0.push_str(&format!("{}", other));
self
}
}
struct Length(u8);
struct Meter;
impl core::ops::Mul<Meter> for u8 {
type Output = Length;
fn mul(self, _: Meter) -> Length {
Length(self)
}
}
2018-12-09 22:26:16 +00:00
#[allow(
clippy::eq_op,
clippy::no_effect,
clippy::unnecessary_operation,
clippy::op_ref,
2018-12-09 22:26:16 +00:00
clippy::double_parens
)]
2018-07-28 15:34:52 +00:00
#[warn(clippy::identity_op)]
#[rustfmt::skip]
fn main() {
let x = 0;
2017-02-08 13:58:07 +00:00
x + 0;
x + (1 - 1);
2015-08-17 09:46:45 +00:00
x + 1;
2017-02-08 13:58:07 +00:00
0 + x;
2015-08-17 09:46:45 +00:00
1 + x;
2018-12-09 22:26:16 +00:00
x - ZERO; //no error, as we skip lookups (for now)
2017-02-08 13:58:07 +00:00
x | (0);
((ZERO)) | x; //no error, as we skip lookups (for now)
2017-02-08 13:58:07 +00:00
x * 1;
1 * x;
2018-12-09 22:26:16 +00:00
x / ONE; //no error, as we skip lookups (for now)
2018-12-09 22:26:16 +00:00
x / 2; //no false positive
2015-08-17 09:46:45 +00:00
2018-12-09 22:26:16 +00:00
x & NEG_ONE; //no error, as we skip lookups (for now)
2017-02-08 13:58:07 +00:00
-1 & x;
2018-12-09 22:26:16 +00:00
let u: u8 = 0;
u & 255;
1 << 0; // no error, this case is allowed, see issue 3430
42 << 0;
1 >> 0;
42 >> 0;
&x >> 0;
x >> &0;
let mut a = A("".into());
let b = a << 0; // no error: non-integer
1 * Meter; // no error: non-integer
}