2021-03-16 00:55:45 +00:00
|
|
|
use clippy_utils::diagnostics::span_lint_and_sugg;
|
2021-03-14 23:17:44 +00:00
|
|
|
use clippy_utils::source::snippet;
|
2021-03-16 16:06:34 +00:00
|
|
|
use clippy_utils::{match_def_path, paths};
|
2020-08-28 09:40:22 +00:00
|
|
|
use if_chain::if_chain;
|
|
|
|
use rustc_errors::Applicability;
|
2020-08-28 10:35:04 +00:00
|
|
|
use rustc_hir::{Expr, ExprKind};
|
2020-08-28 09:40:22 +00:00
|
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
|
|
|
|
declare_clippy_lint! {
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### What it does
|
|
|
|
/// Checks usage of `std::fs::create_dir` and suggest using `std::fs::create_dir_all` instead.
|
2020-08-28 09:40:22 +00:00
|
|
|
///
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### Why is this bad?
|
|
|
|
/// Sometimes `std::fs::create_dir` is mistakenly chosen over `std::fs::create_dir_all`.
|
2020-08-28 09:40:22 +00:00
|
|
|
///
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### Example
|
2022-06-05 20:06:47 +00:00
|
|
|
/// ```rust,ignore
|
2020-08-28 10:56:03 +00:00
|
|
|
/// std::fs::create_dir("foo");
|
2020-08-28 09:40:22 +00:00
|
|
|
/// ```
|
2022-06-05 20:06:47 +00:00
|
|
|
///
|
2020-08-28 09:40:22 +00:00
|
|
|
/// Use instead:
|
2022-06-05 20:06:47 +00:00
|
|
|
/// ```rust,ignore
|
2020-08-28 10:56:03 +00:00
|
|
|
/// std::fs::create_dir_all("foo");
|
2020-08-28 09:40:22 +00:00
|
|
|
/// ```
|
Added `clippy::version` attribute to all normal lints
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
2021-10-21 19:06:26 +00:00
|
|
|
#[clippy::version = "1.48.0"]
|
2020-08-28 09:40:22 +00:00
|
|
|
pub CREATE_DIR,
|
|
|
|
restriction,
|
|
|
|
"calling `std::fs::create_dir` instead of `std::fs::create_dir_all`"
|
|
|
|
}
|
|
|
|
|
|
|
|
declare_lint_pass!(CreateDir => [CREATE_DIR]);
|
|
|
|
|
|
|
|
impl LateLintPass<'_> for CreateDir {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) {
|
|
|
|
if_chain! {
|
2022-08-02 04:01:36 +00:00
|
|
|
if let ExprKind::Call(func, [arg, ..]) = expr.kind;
|
2020-08-28 09:40:22 +00:00
|
|
|
if let ExprKind::Path(ref path) = func.kind;
|
2020-08-31 13:40:47 +00:00
|
|
|
if let Some(def_id) = cx.qpath_res(path, func.hir_id).opt_def_id();
|
|
|
|
if match_def_path(cx, def_id, &paths::STD_FS_CREATE_DIR);
|
2020-08-28 09:40:22 +00:00
|
|
|
then {
|
|
|
|
span_lint_and_sugg(
|
|
|
|
cx,
|
|
|
|
CREATE_DIR,
|
|
|
|
expr.span,
|
|
|
|
"calling `std::fs::create_dir` where there may be a better way",
|
|
|
|
"consider calling `std::fs::create_dir_all` instead",
|
2022-08-02 04:01:36 +00:00
|
|
|
format!("create_dir_all({})", snippet(cx, arg.span, "..")),
|
2020-08-29 05:20:01 +00:00
|
|
|
Applicability::MaybeIncorrect,
|
2020-08-28 09:40:22 +00:00
|
|
|
)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|