rust-clippy/tests/ui/unnecessary_sort_by.fixed

65 lines
1.7 KiB
Rust
Raw Normal View History

// run-rustfix
2020-05-20 05:57:27 +00:00
use std::cmp::Reverse;
fn unnecessary_sort_by() {
fn id(x: isize) -> isize {
x
}
2020-05-20 05:57:27 +00:00
let mut vec: Vec<isize> = vec![3, 6, 1, 2, 5];
2020-05-25 02:45:41 +00:00
// Forward examples
2020-05-25 03:05:58 +00:00
vec.sort();
2020-05-31 22:09:12 +00:00
vec.sort_unstable();
2020-05-25 02:45:41 +00:00
vec.sort_by_key(|&a| (a + 5).abs());
2020-05-31 22:09:12 +00:00
vec.sort_unstable_by_key(|&a| id(-a));
2020-05-25 02:45:41 +00:00
// Reverse examples
2020-05-20 05:57:27 +00:00
vec.sort_by_key(|&b| Reverse(b));
vec.sort_by_key(|&b| Reverse((b + 5).abs()));
2020-05-31 22:09:12 +00:00
vec.sort_unstable_by_key(|&b| Reverse(id(-b)));
// Negative examples (shouldn't be changed)
let c = &7;
vec.sort_by(|a, b| (b - a).cmp(&(a - b)));
vec.sort_by(|_, b| b.cmp(&5));
vec.sort_by(|_, b| b.cmp(c));
2020-05-31 22:09:12 +00:00
vec.sort_unstable_by(|a, _| a.cmp(c));
}
// Should not be linted to avoid hitting https://github.com/rust-lang/rust/issues/34162
mod issue_5754 {
struct Test(String);
#[derive(PartialOrd, Ord, PartialEq, Eq)]
struct Wrapper<'a>(&'a str);
impl Test {
fn name(&self) -> &str {
&self.0
}
fn wrapped(&self) -> Wrapper<'_> {
Wrapper(&self.0)
}
}
pub fn test() {
let mut args: Vec<Test> = vec![];
// Forward
args.sort_by(|a, b| a.name().cmp(b.name()));
args.sort_by(|a, b| a.wrapped().cmp(&b.wrapped()));
args.sort_unstable_by(|a, b| a.name().cmp(b.name()));
args.sort_unstable_by(|a, b| a.wrapped().cmp(&b.wrapped()));
// Reverse
args.sort_by(|a, b| b.name().cmp(a.name()));
args.sort_by(|a, b| b.wrapped().cmp(&a.wrapped()));
args.sort_unstable_by(|a, b| b.name().cmp(a.name()));
args.sort_unstable_by(|a, b| b.wrapped().cmp(&a.wrapped()));
}
}
fn main() {
unnecessary_sort_by();
issue_5754::test();
}