2016-03-30 17:53:43 +00:00
|
|
|
use rustc::lint::*;
|
|
|
|
use rustc::hir;
|
2017-08-01 07:11:05 +00:00
|
|
|
use rustc::hir::BindingAnnotation;
|
2017-09-12 12:26:40 +00:00
|
|
|
use rustc::hir::def::Def;
|
|
|
|
use syntax::ast;
|
2018-05-30 08:15:50 +00:00
|
|
|
use crate::utils::{snippet, span_lint_and_then};
|
2016-03-30 17:53:43 +00:00
|
|
|
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **What it does:** Checks for variable declarations immediately followed by a
|
2016-03-30 17:53:43 +00:00
|
|
|
/// conditional affectation.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** This is not idiomatic Rust.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust,ignore
|
|
|
|
/// let foo;
|
|
|
|
///
|
|
|
|
/// if bar() {
|
|
|
|
/// foo = 42;
|
|
|
|
/// } else {
|
|
|
|
/// foo = 0;
|
|
|
|
/// }
|
|
|
|
///
|
|
|
|
/// let mut baz = None;
|
|
|
|
///
|
|
|
|
/// if bar() {
|
|
|
|
/// baz = Some(42);
|
|
|
|
/// }
|
|
|
|
/// ```
|
|
|
|
///
|
|
|
|
/// should be written
|
|
|
|
///
|
|
|
|
/// ```rust,ignore
|
|
|
|
/// let foo = if bar() {
|
2016-11-24 09:09:09 +00:00
|
|
|
/// 42
|
2016-03-30 17:53:43 +00:00
|
|
|
/// } else {
|
2016-11-24 09:09:09 +00:00
|
|
|
/// 0
|
2016-03-30 17:53:43 +00:00
|
|
|
/// };
|
|
|
|
///
|
|
|
|
/// let baz = if bar() {
|
2016-11-24 09:09:09 +00:00
|
|
|
/// Some(42)
|
2016-03-30 17:53:43 +00:00
|
|
|
/// } else {
|
|
|
|
/// None
|
|
|
|
/// };
|
|
|
|
/// ```
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2016-03-30 17:53:43 +00:00
|
|
|
pub USELESS_LET_IF_SEQ,
|
2018-03-28 13:24:26 +00:00
|
|
|
style,
|
2016-08-06 08:18:36 +00:00
|
|
|
"unidiomatic `let mut` declaration followed by initialization in `if`"
|
2016-03-30 17:53:43 +00:00
|
|
|
}
|
|
|
|
|
2017-08-09 07:30:56 +00:00
|
|
|
#[derive(Copy, Clone)]
|
2016-03-30 17:53:43 +00:00
|
|
|
pub struct LetIfSeq;
|
|
|
|
|
|
|
|
impl LintPass for LetIfSeq {
|
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array!(USELESS_LET_IF_SEQ)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-07 12:13:40 +00:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for LetIfSeq {
|
|
|
|
fn check_block(&mut self, cx: &LateContext<'a, 'tcx>, block: &'tcx hir::Block) {
|
2016-03-30 17:53:43 +00:00
|
|
|
let mut it = block.stmts.iter().peekable();
|
2016-08-01 14:59:14 +00:00
|
|
|
while let Some(stmt) = it.next() {
|
2017-10-23 19:18:02 +00:00
|
|
|
if_chain! {
|
|
|
|
if let Some(expr) = it.peek();
|
|
|
|
if let hir::StmtDecl(ref decl, _) = stmt.node;
|
|
|
|
if let hir::DeclLocal(ref decl) = decl.node;
|
2018-06-28 13:46:58 +00:00
|
|
|
if let hir::PatKind::Binding(mode, canonical_id, ident, None) = decl.pat.node;
|
2017-10-23 19:18:02 +00:00
|
|
|
if let hir::StmtExpr(ref if_, _) = expr.node;
|
2018-07-12 07:30:57 +00:00
|
|
|
if let hir::ExprKind::If(ref cond, ref then, ref else_) = if_.node;
|
2017-10-23 19:18:02 +00:00
|
|
|
if !used_in_expr(cx, canonical_id, cond);
|
2018-07-12 07:30:57 +00:00
|
|
|
if let hir::ExprKind::Block(ref then, _) = then.node;
|
2017-10-23 19:18:02 +00:00
|
|
|
if let Some(value) = check_assign(cx, canonical_id, &*then);
|
|
|
|
if !used_in_expr(cx, canonical_id, value);
|
|
|
|
then {
|
|
|
|
let span = stmt.span.to(if_.span);
|
2017-11-04 19:55:56 +00:00
|
|
|
|
2017-10-23 19:18:02 +00:00
|
|
|
let (default_multi_stmts, default) = if let Some(ref else_) = *else_ {
|
2018-07-12 07:30:57 +00:00
|
|
|
if let hir::ExprKind::Block(ref else_, _) = else_.node {
|
2017-10-23 19:18:02 +00:00
|
|
|
if let Some(default) = check_assign(cx, canonical_id, else_) {
|
|
|
|
(else_.stmts.len() > 1, default)
|
|
|
|
} else if let Some(ref default) = decl.init {
|
|
|
|
(true, &**default)
|
|
|
|
} else {
|
|
|
|
continue;
|
|
|
|
}
|
2016-03-30 17:53:43 +00:00
|
|
|
} else {
|
|
|
|
continue;
|
|
|
|
}
|
2017-10-23 19:18:02 +00:00
|
|
|
} else if let Some(ref default) = decl.init {
|
|
|
|
(false, &**default)
|
2016-03-30 17:53:43 +00:00
|
|
|
} else {
|
|
|
|
continue;
|
2017-10-23 19:18:02 +00:00
|
|
|
};
|
2017-11-04 19:55:56 +00:00
|
|
|
|
2017-10-23 19:18:02 +00:00
|
|
|
let mutability = match mode {
|
|
|
|
BindingAnnotation::RefMut | BindingAnnotation::Mutable => "<mut> ",
|
|
|
|
_ => "",
|
|
|
|
};
|
2017-11-04 19:55:56 +00:00
|
|
|
|
2017-10-23 19:18:02 +00:00
|
|
|
// FIXME: this should not suggest `mut` if we can detect that the variable is not
|
|
|
|
// use mutably after the `if`
|
2017-11-04 19:55:56 +00:00
|
|
|
|
2017-10-23 19:18:02 +00:00
|
|
|
let sug = format!(
|
|
|
|
"let {mut}{name} = if {cond} {{{then} {value} }} else {{{else} {default} }};",
|
|
|
|
mut=mutability,
|
2018-06-28 13:46:58 +00:00
|
|
|
name=ident.name,
|
2017-10-23 19:18:02 +00:00
|
|
|
cond=snippet(cx, cond.span, "_"),
|
|
|
|
then=if then.stmts.len() > 1 { " ..;" } else { "" },
|
|
|
|
else=if default_multi_stmts { " ..;" } else { "" },
|
|
|
|
value=snippet(cx, value.span, "<value>"),
|
|
|
|
default=snippet(cx, default.span, "<default>"),
|
|
|
|
);
|
|
|
|
span_lint_and_then(cx,
|
|
|
|
USELESS_LET_IF_SEQ,
|
|
|
|
span,
|
|
|
|
"`if _ { .. } else { .. }` is an expression",
|
|
|
|
|db| {
|
|
|
|
db.span_suggestion(span,
|
|
|
|
"it is more idiomatic to write",
|
|
|
|
sug);
|
|
|
|
if !mutability.is_empty() {
|
|
|
|
db.note("you might not need `mut` at all");
|
|
|
|
}
|
|
|
|
});
|
|
|
|
}
|
|
|
|
}
|
2016-03-30 17:53:43 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
struct UsedVisitor<'a, 'tcx: 'a> {
|
|
|
|
cx: &'a LateContext<'a, 'tcx>,
|
2017-09-12 12:26:40 +00:00
|
|
|
id: ast::NodeId,
|
2016-03-30 17:53:43 +00:00
|
|
|
used: bool,
|
|
|
|
}
|
|
|
|
|
2016-12-06 10:32:21 +00:00
|
|
|
impl<'a, 'tcx> hir::intravisit::Visitor<'tcx> for UsedVisitor<'a, 'tcx> {
|
|
|
|
fn visit_expr(&mut self, expr: &'tcx hir::Expr) {
|
2017-10-23 19:18:02 +00:00
|
|
|
if_chain! {
|
2018-07-12 07:30:57 +00:00
|
|
|
if let hir::ExprKind::Path(ref qpath) = expr.node;
|
2017-10-23 19:18:02 +00:00
|
|
|
if let Def::Local(local_id) = self.cx.tables.qpath_def(qpath, expr.hir_id);
|
|
|
|
if self.id == local_id;
|
|
|
|
then {
|
|
|
|
self.used = true;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
2016-03-30 17:53:43 +00:00
|
|
|
hir::intravisit::walk_expr(self, expr);
|
|
|
|
}
|
2016-12-06 10:32:21 +00:00
|
|
|
fn nested_visit_map<'this>(&'this mut self) -> hir::intravisit::NestedVisitorMap<'this, 'tcx> {
|
2017-05-12 10:02:42 +00:00
|
|
|
hir::intravisit::NestedVisitorMap::None
|
2016-12-06 10:32:21 +00:00
|
|
|
}
|
2016-03-30 17:53:43 +00:00
|
|
|
}
|
|
|
|
|
2016-12-21 11:14:54 +00:00
|
|
|
fn check_assign<'a, 'tcx>(
|
|
|
|
cx: &LateContext<'a, 'tcx>,
|
2017-09-12 12:26:40 +00:00
|
|
|
decl: ast::NodeId,
|
2017-08-09 07:30:56 +00:00
|
|
|
block: &'tcx hir::Block,
|
2016-12-21 11:14:54 +00:00
|
|
|
) -> Option<&'tcx hir::Expr> {
|
2017-10-23 19:18:02 +00:00
|
|
|
if_chain! {
|
|
|
|
if block.expr.is_none();
|
|
|
|
if let Some(expr) = block.stmts.iter().last();
|
|
|
|
if let hir::StmtSemi(ref expr, _) = expr.node;
|
2018-07-12 07:30:57 +00:00
|
|
|
if let hir::ExprKind::Assign(ref var, ref value) = expr.node;
|
|
|
|
if let hir::ExprKind::Path(ref qpath) = var.node;
|
2017-10-23 19:18:02 +00:00
|
|
|
if let Def::Local(local_id) = cx.tables.qpath_def(qpath, var.hir_id);
|
|
|
|
if decl == local_id;
|
|
|
|
then {
|
|
|
|
let mut v = UsedVisitor {
|
2018-03-15 15:07:15 +00:00
|
|
|
cx,
|
2017-10-23 19:18:02 +00:00
|
|
|
id: decl,
|
|
|
|
used: false,
|
|
|
|
};
|
2017-11-04 19:55:56 +00:00
|
|
|
|
2017-10-23 19:18:02 +00:00
|
|
|
for s in block.stmts.iter().take(block.stmts.len()-1) {
|
|
|
|
hir::intravisit::walk_stmt(&mut v, s);
|
2017-11-04 19:55:56 +00:00
|
|
|
|
2017-10-23 19:18:02 +00:00
|
|
|
if v.used {
|
|
|
|
return None;
|
|
|
|
}
|
2016-06-03 17:35:39 +00:00
|
|
|
}
|
2017-11-04 19:55:56 +00:00
|
|
|
|
2017-10-23 19:18:02 +00:00
|
|
|
return Some(value);
|
2016-03-30 17:53:43 +00:00
|
|
|
}
|
2017-10-23 19:18:02 +00:00
|
|
|
}
|
2016-03-30 17:53:43 +00:00
|
|
|
|
|
|
|
None
|
|
|
|
}
|
2016-06-05 19:38:15 +00:00
|
|
|
|
2017-09-12 12:26:40 +00:00
|
|
|
fn used_in_expr<'a, 'tcx: 'a>(cx: &LateContext<'a, 'tcx>, id: ast::NodeId, expr: &'tcx hir::Expr) -> bool {
|
2016-06-05 19:38:15 +00:00
|
|
|
let mut v = UsedVisitor {
|
2018-03-15 15:07:15 +00:00
|
|
|
cx,
|
|
|
|
id,
|
2016-06-05 23:42:39 +00:00
|
|
|
used: false,
|
2016-06-05 19:38:15 +00:00
|
|
|
};
|
|
|
|
hir::intravisit::walk_expr(&mut v, expr);
|
|
|
|
v.used
|
|
|
|
}
|