rust-clippy/tests/ui/ptr_arg.stderr

error: elided lifetime has a name
  --> tests/ui/ptr_arg.rs:295:56
   |
LL |     fn cow_good_ret_ty<'a>(input: &'a Cow<'a, str>) -> &str {
   |                        -- lifetime `'a` declared here  ^ this elided lifetime gets resolved as `'a`
   |
   = note: `-D elided-named-lifetimes` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(elided_named_lifetimes)]`

error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:13:14
   |
LL | fn do_vec(x: &Vec<i64>) {
   |              ^^^^^^^^^ help: change this to: `&[i64]`
   |
   = note: `-D clippy::ptr-arg` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]`

error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:19:18
   |
LL | fn do_vec_mut(x: &mut Vec<i64>) {
   |                  ^^^^^^^^^^^^^ help: change this to: `&mut [i64]`

error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:24:19
   |
LL | fn do_vec_mut2(x: &mut Vec<i64>) {
   |                   ^^^^^^^^^^^^^ help: change this to: `&mut [i64]`

error: writing `&String` instead of `&str` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:30:14
   |
LL | fn do_str(x: &String) {
   |              ^^^^^^^ help: change this to: `&str`

error: writing `&mut String` instead of `&mut str` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:35:18
   |
LL | fn do_str_mut(x: &mut String) {
   |                  ^^^^^^^^^^^ help: change this to: `&mut str`

error: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:40:15
   |
LL | fn do_path(x: &PathBuf) {
   |               ^^^^^^^^ help: change this to: `&Path`

error: writing `&mut PathBuf` instead of `&mut Path` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:45:19
   |
LL | fn do_path_mut(x: &mut PathBuf) {
   |                   ^^^^^^^^^^^^ help: change this to: `&mut Path`

error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:54:18
   |
LL |     fn do_vec(x: &Vec<i64>);
   |                  ^^^^^^^^^ help: change this to: `&[i64]`

error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:68:14
   |
LL | fn cloned(x: &Vec<u8>) -> Vec<u8> {
   |              ^^^^^^^^
   |
help: change this to
   |
LL ~ fn cloned(x: &[u8]) -> Vec<u8> {
LL |
LL ~     let e = x.to_owned();
LL |     let f = e.clone(); // OK
LL |     let g = x;
LL ~     let h = g.to_owned();
LL |     let i = (e).clone();
LL ~     x.to_owned()
   |

error: writing `&String` instead of `&str` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:78:18
   |
LL | fn str_cloned(x: &String) -> String {
   |                  ^^^^^^^
   |
help: change this to
   |
LL ~ fn str_cloned(x: &str) -> String {
LL |
LL ~     let a = x.to_owned();
LL ~     let b = x.to_owned();
LL |     let c = b.clone();
LL |     let d = a.clone().clone().clone();
LL ~     x.to_owned()
   |

error: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:87:19
   |
LL | fn path_cloned(x: &PathBuf) -> PathBuf {
   |                   ^^^^^^^^
   |
help: change this to
   |
LL ~ fn path_cloned(x: &Path) -> PathBuf {
LL |
LL ~     let a = x.to_path_buf();
LL ~     let b = x.to_path_buf();
LL |     let c = b.clone();
LL |     let d = a.clone().clone().clone();
LL ~     x.to_path_buf()
   |

error: writing `&String` instead of `&str` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:96:44
   |
LL | fn false_positive_capacity(x: &Vec<u8>, y: &String) {
   |                                            ^^^^^^^
   |
help: change this to
   |
LL ~ fn false_positive_capacity(x: &Vec<u8>, y: &str) {
LL |
LL |     let a = x.capacity();
LL ~     let b = y.to_owned();
LL ~     let c = y;
   |

error: using a reference to `Cow` is not recommended
  --> tests/ui/ptr_arg.rs:111:25
   |
LL | fn test_cow_with_ref(c: &Cow<[i32]>) {}
   |                         ^^^^^^^^^^^ help: change this to: `&[i32]`

error: writing `&String` instead of `&str` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:141:66
   |
LL |     fn some_allowed(#[allow(clippy::ptr_arg)] _v: &Vec<u32>, _s: &String) {}
   |                                                                  ^^^^^^^ help: change this to: `&str`

error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:171:21
   |
LL |     fn foo_vec(vec: &Vec<u8>) {
   |                     ^^^^^^^^
   |
help: change this to
   |
LL ~     fn foo_vec(vec: &[u8]) {
LL |
LL ~         let _ = vec.to_owned().pop();
LL ~         let _ = vec.to_owned().clone();
   |

error: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:177:23
   |
LL |     fn foo_path(path: &PathBuf) {
   |                       ^^^^^^^^
   |
help: change this to
   |
LL ~     fn foo_path(path: &Path) {
LL |
LL ~         let _ = path.to_path_buf().pop();
LL ~         let _ = path.to_path_buf().clone();
   |

error: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:183:21
   |
LL |     fn foo_str(str: &PathBuf) {
   |                     ^^^^^^^^
   |
help: change this to
   |
LL ~     fn foo_str(str: &Path) {
LL |
LL ~         let _ = str.to_path_buf().pop();
LL ~         let _ = str.to_path_buf().clone();
   |

error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:190:29
   |
LL | fn mut_vec_slice_methods(v: &mut Vec<u32>) {
   |                             ^^^^^^^^^^^^^ help: change this to: `&mut [u32]`

error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:253:17
   |
LL | fn dyn_trait(a: &mut Vec<u32>, b: &mut String, c: &mut PathBuf) {
   |                 ^^^^^^^^^^^^^ help: change this to: `&mut [u32]`

error: writing `&mut String` instead of `&mut str` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:253:35
   |
LL | fn dyn_trait(a: &mut Vec<u32>, b: &mut String, c: &mut PathBuf) {
   |                                   ^^^^^^^^^^^ help: change this to: `&mut str`

error: writing `&mut PathBuf` instead of `&mut Path` involves a new object where a slice will do
  --> tests/ui/ptr_arg.rs:253:51
   |
LL | fn dyn_trait(a: &mut Vec<u32>, b: &mut String, c: &mut PathBuf) {
   |                                                   ^^^^^^^^^^^^ help: change this to: `&mut Path`

error: using a reference to `Cow` is not recommended
  --> tests/ui/ptr_arg.rs:279:39
   |
LL |     fn cow_elided_lifetime<'a>(input: &'a Cow<str>) -> &'a str {
   |                                       ^^^^^^^^^^^^ help: change this to: `&str`

error: using a reference to `Cow` is not recommended
  --> tests/ui/ptr_arg.rs:285:36
   |
LL |     fn cow_bad_ret_ty_1<'a>(input: &'a Cow<'a, str>) -> &'static str {
   |                                    ^^^^^^^^^^^^^^^^ help: change this to: `&str`

error: using a reference to `Cow` is not recommended
  --> tests/ui/ptr_arg.rs:289:40
   |
LL |     fn cow_bad_ret_ty_2<'a, 'b>(input: &'a Cow<'a, str>) -> &'b str {
   |                                        ^^^^^^^^^^^^^^^^ help: change this to: `&str`

error: aborting due to 25 previous errors