rust-clippy/tests/ui/block_in_if_condition.stderr

63 lines
1.8 KiB
Text
Raw Normal View History

error: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
--> $DIR/block_in_if_condition.rs:26:8
|
2018-12-27 15:57:55 +00:00
LL | if {
| ________^
2018-12-27 15:57:55 +00:00
LL | | let x = 3;
LL | | x == 3
LL | | } {
| |_____^
|
= note: `-D clippy::block-in-if-condition-stmt` implied by `-D warnings`
= help: try
2017-02-08 13:58:07 +00:00
let res = {
let x = 3;
x == 3
};
if res {
6
} ...
error: omit braces around single expression condition
--> $DIR/block_in_if_condition.rs:37:8
|
2018-12-27 15:57:55 +00:00
LL | if { true } {
| ^^^^^^^^
|
= note: `-D clippy::block-in-if-condition-expr` implied by `-D warnings`
= help: try
2017-02-08 13:58:07 +00:00
if true {
6
} ...
error: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
2019-03-10 21:07:10 +00:00
--> $DIR/block_in_if_condition.rs:58:17
2018-12-10 05:27:19 +00:00
|
2018-12-27 15:57:55 +00:00
LL | |x| {
2018-12-10 05:27:19 +00:00
| _________________^
2018-12-27 15:57:55 +00:00
LL | | let target = 3;
LL | | x == target
LL | | },
2018-12-10 05:27:19 +00:00
| |_____________^
error: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
2019-03-10 21:07:10 +00:00
--> $DIR/block_in_if_condition.rs:67:13
2018-12-10 05:27:19 +00:00
|
2018-12-27 15:57:55 +00:00
LL | |x| {
2018-12-10 05:27:19 +00:00
| _____________^
2018-12-27 15:57:55 +00:00
LL | | let target = 3;
LL | | x == target
LL | | },
2018-12-10 05:27:19 +00:00
| |_________^
error: this boolean expression can be simplified
2019-03-10 21:07:10 +00:00
--> $DIR/block_in_if_condition.rs:77:8
|
2018-12-27 15:57:55 +00:00
LL | if true && x == 3 {
2017-07-21 08:40:23 +00:00
| ^^^^^^^^^^^^^^ help: try: `x == 3`
|
= note: `-D clippy::nonminimal-bool` implied by `-D warnings`
2018-01-16 16:06:27 +00:00
error: aborting due to 5 previous errors