rust-clippy/tests/ui/trivially_copy_pass_by_ref.rs

174 lines
3.3 KiB
Rust
Raw Normal View History

//@normalize-stderr-test: "\(\d+ byte\)" -> "(N byte)"
//@normalize-stderr-test: "\(limit: \d+ byte\)" -> "(limit: N byte)"
#![deny(clippy::trivially_copy_pass_by_ref)]
#![allow(
clippy::disallowed_names,
2022-10-30 10:47:35 +00:00
clippy::needless_lifetimes,
clippy::redundant_field_names,
clippy::uninlined_format_args,
clippy::needless_pass_by_ref_mut
)]
#[derive(Copy, Clone)]
struct Foo(u32);
#[derive(Copy, Clone)]
struct Bar([u8; 24]);
#[derive(Copy, Clone)]
pub struct Color {
2018-12-09 22:26:16 +00:00
pub r: u8,
pub g: u8,
pub b: u8,
pub a: u8,
}
struct FooRef<'a> {
foo: &'a Foo,
}
type Baz = u32;
2018-12-09 22:26:16 +00:00
fn good(a: &mut u32, b: u32, c: &Bar) {}
fn good_return_implicit_lt_ref(foo: &Foo) -> &u32 {
&foo.0
}
2018-07-28 15:34:52 +00:00
#[allow(clippy::needless_lifetimes)]
fn good_return_explicit_lt_ref<'a>(foo: &'a Foo) -> &'a u32 {
&foo.0
}
fn good_return_implicit_lt_struct(foo: &Foo) -> FooRef {
2018-12-09 22:26:16 +00:00
FooRef { foo }
}
2018-07-28 15:34:52 +00:00
#[allow(clippy::needless_lifetimes)]
fn good_return_explicit_lt_struct<'a>(foo: &'a Foo) -> FooRef<'a> {
2018-12-09 22:26:16 +00:00
FooRef { foo }
}
2018-12-09 22:26:16 +00:00
fn bad(x: &u32, y: &Foo, z: &Baz) {}
impl Foo {
2018-12-09 22:26:16 +00:00
fn good(self, a: &mut u32, b: u32, c: &Bar) {}
2018-12-09 22:26:16 +00:00
fn good2(&mut self) {}
2018-12-09 22:26:16 +00:00
fn bad(&self, x: &u32, y: &Foo, z: &Baz) {}
2018-12-09 22:26:16 +00:00
fn bad2(x: &u32, y: &Foo, z: &Baz) {}
fn bad_issue7518(self, other: &Self) {}
}
impl AsRef<u32> for Foo {
fn as_ref(&self) -> &u32 {
&self.0
}
}
impl Bar {
2018-12-09 22:26:16 +00:00
fn good(&self, a: &mut u32, b: u32, c: &Bar) {}
2018-12-09 22:26:16 +00:00
fn bad2(x: &u32, y: &Foo, z: &Baz) {}
}
trait MyTrait {
fn trait_method(&self, _foo: &Foo);
}
pub trait MyTrait2 {
fn trait_method2(&self, _color: &Color);
}
impl MyTrait for Foo {
fn trait_method(&self, _foo: &Foo) {
unimplemented!()
}
}
#[allow(unused_variables)]
mod issue3992 {
pub trait A {
#[allow(clippy::trivially_copy_pass_by_ref)]
fn a(b: &u16) {}
}
#[allow(clippy::trivially_copy_pass_by_ref)]
pub fn c(d: &u16) {}
}
mod issue5876 {
// Don't lint here as it is always inlined
#[inline(always)]
fn foo_always(x: &i32) {
println!("{}", x);
}
#[inline(never)]
fn foo_never(x: &i32) {
println!("{}", x);
}
#[inline]
fn foo(x: &i32) {
println!("{}", x);
}
}
fn _ref_to_opt_ref_implicit(x: &u32) -> Option<&u32> {
Some(x)
}
#[allow(clippy::needless_lifetimes)]
fn _ref_to_opt_ref_explicit<'a>(x: &'a u32) -> Option<&'a u32> {
Some(x)
}
fn _with_constraint<'a, 'b: 'a>(x: &'b u32, y: &'a u32) -> &'a u32 {
if true { x } else { y }
}
async fn _async_implicit(x: &u32) -> &u32 {
x
}
#[allow(clippy::needless_lifetimes)]
async fn _async_explicit<'a>(x: &'a u32) -> &'a u32 {
x
}
fn _unrelated_lifetimes<'a, 'b>(_x: &'a u32, y: &'b u32) -> &'b u32 {
y
}
fn _return_ptr(x: &u32) -> *const u32 {
x
}
fn _return_field_ptr(x: &(u32, u32)) -> *const u32 {
&x.0
}
fn _return_field_ptr_addr_of(x: &(u32, u32)) -> *const u32 {
core::ptr::addr_of!(x.0)
}
fn main() {
let (mut foo, bar) = (Foo(0), Bar([0; 24]));
let (mut a, b, c, x, y, z) = (0, 0, Bar([0; 24]), 0, Foo(0), 0);
good(&mut a, b, &c);
good_return_implicit_lt_ref(&y);
good_return_explicit_lt_ref(&y);
bad(&x, &y, &z);
foo.good(&mut a, b, &c);
foo.good2();
foo.bad(&x, &y, &z);
Foo::bad2(&x, &y, &z);
bar.good(&mut a, b, &c);
Bar::bad2(&x, &y, &z);
foo.as_ref();
}