2023-04-20 14:37:15 +00:00
|
|
|
//@run-rustfix
|
|
|
|
//@aux-build:proc_macros.rs
|
2021-07-13 13:57:47 +00:00
|
|
|
|
2022-06-09 07:17:46 +00:00
|
|
|
#![feature(lint_reasons)]
|
2021-07-13 13:57:47 +00:00
|
|
|
#![warn(clippy::default_numeric_fallback)]
|
2022-03-17 23:53:28 +00:00
|
|
|
#![allow(
|
|
|
|
unused,
|
|
|
|
clippy::never_loop,
|
|
|
|
clippy::no_effect,
|
|
|
|
clippy::unnecessary_operation,
|
|
|
|
clippy::branches_sharing_code,
|
2023-03-08 16:31:00 +00:00
|
|
|
clippy::let_unit_value,
|
|
|
|
clippy::let_with_type_underscore
|
2022-03-17 23:53:28 +00:00
|
|
|
)]
|
2021-07-13 13:57:47 +00:00
|
|
|
|
2023-03-07 14:40:55 +00:00
|
|
|
extern crate proc_macros;
|
|
|
|
use proc_macros::{external, inline_macros};
|
2021-07-13 13:57:47 +00:00
|
|
|
|
|
|
|
mod basic_expr {
|
|
|
|
fn test() {
|
|
|
|
// Should lint unsuffixed literals typed `i32`.
|
|
|
|
let x = 22_i32;
|
|
|
|
let x = [1_i32, 2_i32, 3_i32];
|
|
|
|
let x = if true { (1_i32, 2_i32) } else { (3_i32, 4_i32) };
|
|
|
|
let x = match 1_i32 {
|
|
|
|
1_i32 => 1_i32,
|
|
|
|
_ => 2_i32,
|
|
|
|
};
|
|
|
|
|
|
|
|
// Should NOT lint suffixed literals.
|
|
|
|
let x = 22_i32;
|
|
|
|
|
|
|
|
// Should NOT lint literals in init expr if `Local` has a type annotation.
|
|
|
|
let x: [i32; 3] = [1, 2, 3];
|
|
|
|
let x: (i32, i32) = if true { (1, 2) } else { (3, 4) };
|
|
|
|
let x: _ = 1;
|
2022-10-12 10:04:41 +00:00
|
|
|
let x: u64 = 1;
|
|
|
|
const CONST_X: i8 = 1;
|
2021-07-13 13:57:47 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
mod nested_local {
|
|
|
|
fn test() {
|
|
|
|
let x: _ = {
|
|
|
|
// Should lint this because this literal is not bound to any types.
|
|
|
|
let y = 1_i32;
|
|
|
|
|
|
|
|
// Should NOT lint this because this literal is bound to `_` of outer `Local`.
|
|
|
|
1
|
|
|
|
};
|
|
|
|
|
|
|
|
let x: _ = if true {
|
|
|
|
// Should lint this because this literal is not bound to any types.
|
|
|
|
let y = 1_i32;
|
|
|
|
|
|
|
|
// Should NOT lint this because this literal is bound to `_` of outer `Local`.
|
|
|
|
1
|
|
|
|
} else {
|
|
|
|
// Should lint this because this literal is not bound to any types.
|
|
|
|
let y = 1_i32;
|
|
|
|
|
|
|
|
// Should NOT lint this because this literal is bound to `_` of outer `Local`.
|
|
|
|
2
|
|
|
|
};
|
2022-10-12 10:04:41 +00:00
|
|
|
|
|
|
|
const CONST_X: i32 = {
|
|
|
|
// Should lint this because this literal is not bound to any types.
|
|
|
|
let y = 1_i32;
|
|
|
|
|
|
|
|
// Should NOT lint this because this literal is bound to `_` of outer `Local`.
|
|
|
|
1
|
|
|
|
};
|
2021-07-13 13:57:47 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
mod function_def {
|
|
|
|
fn ret_i32() -> i32 {
|
|
|
|
// Even though the output type is specified,
|
|
|
|
// this unsuffixed literal is linted to reduce heuristics and keep codebase simple.
|
|
|
|
1_i32
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test() {
|
|
|
|
// Should lint this because return type is inferred to `i32` and NOT bound to a concrete
|
|
|
|
// type.
|
|
|
|
let f = || -> _ { 1_i32 };
|
|
|
|
|
|
|
|
// Even though the output type is specified,
|
|
|
|
// this unsuffixed literal is linted to reduce heuristics and keep codebase simple.
|
|
|
|
let f = || -> i32 { 1_i32 };
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
mod function_calls {
|
|
|
|
fn concrete_arg(x: i32) {}
|
|
|
|
|
|
|
|
fn generic_arg<T>(t: T) {}
|
|
|
|
|
|
|
|
fn test() {
|
|
|
|
// Should NOT lint this because the argument type is bound to a concrete type.
|
|
|
|
concrete_arg(1);
|
|
|
|
|
|
|
|
// Should lint this because the argument type is inferred to `i32` and NOT bound to a concrete type.
|
|
|
|
generic_arg(1_i32);
|
|
|
|
|
|
|
|
// Should lint this because the argument type is inferred to `i32` and NOT bound to a concrete type.
|
|
|
|
let x: _ = generic_arg(1_i32);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
mod struct_ctor {
|
|
|
|
struct ConcreteStruct {
|
|
|
|
x: i32,
|
|
|
|
}
|
|
|
|
|
|
|
|
struct GenericStruct<T> {
|
|
|
|
x: T,
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test() {
|
|
|
|
// Should NOT lint this because the field type is bound to a concrete type.
|
|
|
|
ConcreteStruct { x: 1 };
|
|
|
|
|
|
|
|
// Should lint this because the field type is inferred to `i32` and NOT bound to a concrete type.
|
|
|
|
GenericStruct { x: 1_i32 };
|
|
|
|
|
|
|
|
// Should lint this because the field type is inferred to `i32` and NOT bound to a concrete type.
|
|
|
|
let _ = GenericStruct { x: 1_i32 };
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
mod enum_ctor {
|
|
|
|
enum ConcreteEnum {
|
|
|
|
X(i32),
|
|
|
|
}
|
|
|
|
|
|
|
|
enum GenericEnum<T> {
|
|
|
|
X(T),
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test() {
|
|
|
|
// Should NOT lint this because the field type is bound to a concrete type.
|
|
|
|
ConcreteEnum::X(1);
|
|
|
|
|
|
|
|
// Should lint this because the field type is inferred to `i32` and NOT bound to a concrete type.
|
|
|
|
GenericEnum::X(1_i32);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
mod method_calls {
|
2022-03-27 12:41:09 +00:00
|
|
|
struct StructForMethodCallTest;
|
2021-07-13 13:57:47 +00:00
|
|
|
|
|
|
|
impl StructForMethodCallTest {
|
|
|
|
fn concrete_arg(&self, x: i32) {}
|
|
|
|
|
|
|
|
fn generic_arg<T>(&self, t: T) {}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test() {
|
|
|
|
let s = StructForMethodCallTest {};
|
|
|
|
|
|
|
|
// Should NOT lint this because the argument type is bound to a concrete type.
|
|
|
|
s.concrete_arg(1);
|
|
|
|
|
|
|
|
// Should lint this because the argument type is bound to a concrete type.
|
|
|
|
s.generic_arg(1_i32);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
mod in_macro {
|
2023-03-07 14:40:55 +00:00
|
|
|
use super::*;
|
2021-07-13 13:57:47 +00:00
|
|
|
|
|
|
|
// Should lint in internal macro.
|
2023-03-07 14:40:55 +00:00
|
|
|
#[inline_macros]
|
2021-07-13 13:57:47 +00:00
|
|
|
fn internal() {
|
2023-03-07 14:40:55 +00:00
|
|
|
inline!(let x = 22_i32;);
|
2021-07-13 13:57:47 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Should NOT lint in external macro.
|
|
|
|
fn external() {
|
2023-03-07 14:40:55 +00:00
|
|
|
external!(let x = 22;);
|
2021-07-13 13:57:47 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-06-09 07:17:46 +00:00
|
|
|
fn check_expect_suppression() {
|
|
|
|
#[expect(clippy::default_numeric_fallback)]
|
|
|
|
let x = 21;
|
|
|
|
}
|
|
|
|
|
2021-07-13 13:57:47 +00:00
|
|
|
fn main() {}
|