2017-02-20 03:50:31 +00:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:21:23
|
2018-08-01 14:30:44 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
21 | fn foo<T: Default>(v: Vec<T>, w: Vec<T>, mut x: Vec<T>, y: Vec<T>) -> Vec<T> {
|
2018-08-01 14:30:44 +00:00
|
|
|
| ^^^^^^ help: consider changing the type to: `&[T]`
|
|
|
|
|
|
|
|
|
= note: `-D clippy::needless-pass-by-value` implied by `-D warnings`
|
2017-02-20 03:50:31 +00:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:35:11
|
2017-02-20 03:50:31 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
35 | fn bar(x: String, y: Wrapper) {
|
2017-07-21 08:40:23 +00:00
|
|
|
| ^^^^^^ help: consider changing the type to: `&str`
|
2017-02-20 03:50:31 +00:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:35:22
|
2017-02-20 03:50:31 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
35 | fn bar(x: String, y: Wrapper) {
|
2017-07-21 08:40:23 +00:00
|
|
|
| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
|
2017-02-20 03:50:31 +00:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:41:71
|
2017-02-20 03:50:31 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
41 | fn test_borrow_trait<T: Borrow<str>, U: AsRef<str>, V>(t: T, u: U, v: V) {
|
2017-10-08 01:23:41 +00:00
|
|
|
| ^ help: consider taking a reference instead: `&V`
|
2017-02-20 03:50:31 +00:00
|
|
|
|
2017-02-20 07:45:37 +00:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:53:18
|
2017-02-20 07:45:37 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
53 | fn test_match(x: Option<Option<String>>, y: Option<Option<String>>) {
|
2017-02-20 07:45:37 +00:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
help: consider taking a reference instead
|
2017-07-10 13:29:29 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
53 | fn test_match(x: &Option<Option<String>>, y: Option<Option<String>>) {
|
|
|
|
54 | match *x {
|
2017-07-10 13:29:29 +00:00
|
|
|
|
|
2017-02-20 07:45:37 +00:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:66:24
|
2017-02-20 07:45:37 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
66 | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
|
2017-07-21 08:40:23 +00:00
|
|
|
| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
|
2017-02-20 07:45:37 +00:00
|
|
|
|
2017-02-20 09:18:31 +00:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:66:36
|
2017-02-20 09:18:31 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
66 | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
|
2017-02-20 09:18:31 +00:00
|
|
|
| ^^^^^^^
|
|
|
|
help: consider taking a reference instead
|
2017-07-10 13:29:29 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
66 | fn test_destructure(x: Wrapper, y: &Wrapper, z: Wrapper) {
|
|
|
|
67 | let Wrapper(s) = z; // moved
|
|
|
|
68 | let Wrapper(ref t) = *y; // not moved
|
|
|
|
69 | let Wrapper(_) = *y; // still not moved
|
2017-10-08 01:23:41 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:82:49
|
2017-07-10 13:29:29 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
82 | fn test_blanket_ref<T: Foo, S: Serialize>(_foo: T, _serializable: S) {}
|
2017-10-08 01:23:41 +00:00
|
|
|
| ^ help: consider taking a reference instead: `&T`
|
2017-02-20 09:18:31 +00:00
|
|
|
|
2017-10-08 08:51:44 +00:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:84:18
|
2017-10-08 08:51:44 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
84 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
2017-10-08 08:51:44 +00:00
|
|
|
| ^^^^^^ help: consider taking a reference instead: `&String`
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:84:29
|
2017-10-08 08:51:44 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
84 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
2017-10-08 08:51:44 +00:00
|
|
|
| ^^^^^^
|
|
|
|
help: consider changing the type to
|
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
84 | fn issue_2114(s: String, t: &str, u: Vec<i32>, v: Vec<i32>) {
|
2017-10-08 08:51:44 +00:00
|
|
|
| ^^^^
|
|
|
|
help: change `t.clone()` to
|
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
86 | let _ = t.to_string();
|
2017-10-08 08:51:44 +00:00
|
|
|
| ^^^^^^^^^^^^^
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:84:40
|
2017-10-08 08:51:44 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
84 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
2017-10-08 08:51:44 +00:00
|
|
|
| ^^^^^^^^ help: consider taking a reference instead: `&Vec<i32>`
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:84:53
|
2017-10-08 08:51:44 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
84 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
2017-10-08 08:51:44 +00:00
|
|
|
| ^^^^^^^^
|
|
|
|
help: consider changing the type to
|
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
84 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: &[i32]) {
|
2017-10-08 08:51:44 +00:00
|
|
|
| ^^^^^^
|
|
|
|
help: change `v.clone()` to
|
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
88 | let _ = v.to_owned();
|
2017-10-08 08:51:44 +00:00
|
|
|
| ^^^^^^^^^^^^
|
|
|
|
|
2017-11-03 08:24:10 +00:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:96:12
|
2017-11-03 08:24:10 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
96 | s: String,
|
2017-11-03 08:24:10 +00:00
|
|
|
| ^^^^^^ help: consider changing the type to: `&str`
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:97:12
|
2017-11-03 08:24:10 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
97 | t: String,
|
2017-11-03 08:24:10 +00:00
|
|
|
| ^^^^^^ help: consider taking a reference instead: `&String`
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:109:13
|
|
|
|
|
|
|
|
|
109 | _u: U,
|
|
|
|
| ^ help: consider taking a reference instead: `&U`
|
2017-11-03 08:24:10 +00:00
|
|
|
|
2017-11-03 08:56:26 +00:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:110:13
|
2018-08-01 14:30:44 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
110 | _s: Self,
|
2018-08-01 14:30:44 +00:00
|
|
|
| ^^^^ help: consider taking a reference instead: `&Self`
|
2018-01-18 13:27:47 +00:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:132:24
|
2018-01-18 13:27:47 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
132 | fn bar_copy(x: u32, y: CopyWrapper) {
|
2018-01-18 13:27:47 +00:00
|
|
|
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
|
|
|
|
|
|
|
|
|
help: consider marking this type as Copy
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:130:1
|
2018-01-18 13:27:47 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
130 | struct CopyWrapper(u32);
|
2018-01-18 13:27:47 +00:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:138:29
|
2018-01-18 13:27:47 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
138 | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
|
2018-01-18 13:27:47 +00:00
|
|
|
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
|
|
|
|
|
|
|
|
|
help: consider marking this type as Copy
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:130:1
|
2018-01-18 13:27:47 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
130 | struct CopyWrapper(u32);
|
2018-01-18 13:27:47 +00:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:138:45
|
2018-01-18 13:27:47 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
138 | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
|
2018-01-18 13:27:47 +00:00
|
|
|
| ^^^^^^^^^^^
|
|
|
|
|
|
|
|
|
help: consider marking this type as Copy
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:130:1
|
2018-01-18 13:27:47 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
130 | struct CopyWrapper(u32);
|
2018-01-18 13:27:47 +00:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
help: consider taking a reference instead
|
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
138 | fn test_destructure_copy(x: CopyWrapper, y: &CopyWrapper, z: CopyWrapper) {
|
|
|
|
139 | let CopyWrapper(s) = z; // moved
|
|
|
|
140 | let CopyWrapper(ref t) = *y; // not moved
|
|
|
|
141 | let CopyWrapper(_) = *y; // still not moved
|
2018-01-18 13:27:47 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:138:61
|
2018-01-18 13:27:47 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
138 | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
|
2018-01-18 13:27:47 +00:00
|
|
|
| ^^^^^^^^^^^
|
|
|
|
|
|
|
|
|
help: consider marking this type as Copy
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:130:1
|
2018-01-18 13:27:47 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
130 | struct CopyWrapper(u32);
|
2018-01-18 13:27:47 +00:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
help: consider taking a reference instead
|
2018-01-18 08:45:41 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
138 | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: &CopyWrapper) {
|
|
|
|
139 | let CopyWrapper(s) = *z; // moved
|
2018-01-18 08:45:41 +00:00
|
|
|
|
|
2017-11-03 08:56:26 +00:00
|
|
|
|
2018-10-01 20:33:20 +00:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:150:40
|
2018-10-01 20:33:20 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
150 | fn some_fun<'b, S: Bar<'b, ()>>(_item: S) {}
|
2018-10-01 20:33:20 +00:00
|
|
|
| ^ help: consider taking a reference instead: `&S`
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2018-10-06 16:18:06 +00:00
|
|
|
--> $DIR/needless_pass_by_value.rs:155:20
|
2018-10-01 20:33:20 +00:00
|
|
|
|
|
2018-10-06 16:18:06 +00:00
|
|
|
155 | fn more_fun(_item: impl Club<'static, i32>) {}
|
2018-10-01 20:33:20 +00:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&impl Club<'static, i32>`
|
|
|
|
|
|
|
|
error: aborting due to 22 previous errors
|
2018-01-16 16:06:27 +00:00
|
|
|
|