rust-analyzer

mirror of https://github.com/rust-lang/rust-analyzer synced 2025-01-10 12:18:49 +00:00

No description

Find a file

bors f532c7020f Auto merge of #110837 - scottmcm:offset-for-add, r=compiler-errors Use MIR's `Offset` for pointer `add` too ~~Status: draft while waiting for #110822 to land, since this is built atop that.~~ ~~r? `@ghost~~` Canonical Rust code has mostly moved to `add`/`sub` on pointers, which take `usize`, instead of `offset` which takes `isize`. (And, relatedly, when `sub_ptr` was added it turned out it replaced every single in-tree use of `offset_from`, because `usize` is just so much more useful than `isize` in Rust.) Unfortunately, `intrinsics::offset` could only accept `const` and `isize`, so there's a huge* amount of type conversions back and forth being done. They're identity conversions in the backend, but still end up producing quite a lot of unhelpful MIR. This PR changes `intrinsics::offset` to accept `const` and* `mut` along with `isize` and* `usize`. Conveniently, the backends and CTFE already handle this, since MIR's `BinOp::Offset` [already supports all four combinations](`adaac6b166/compiler/rustc_const_eval/src/transform/validate.rs (L523-L528)`). To demonstrate the difference, I added some `mir-opt/pre-codegen/` tests around slice indexing. Here's the difference to `[T]::get_mut`, since it uses `<mut _>::add` internally: ```diff `@@` -79,30 +70,21 `@@` fn slice_get_mut_usize(_1: &mut [u32], _2: usize) -> Option<&mut u32> { StorageLive(_12); // scope 3 at $SRC_DIR/core/src/slice/index.rs:LL:COL StorageLive(_9); // scope 6 at $SRC_DIR/core/src/slice/index.rs:LL:COL _9 = _8 as mut u32 (PtrToPtr); // scope 11 at $SRC_DIR/core/src/ptr/mut_ptr.rs:LL:COL - StorageLive(_13); // scope 13 at $SRC_DIR/core/src/ptr/mut_ptr.rs:LL:COL - _13 = _2 as isize (IntToInt); // scope 13 at $SRC_DIR/core/src/ptr/mut_ptr.rs:LL:COL - StorageLive(_14); // scope 15 at $SRC_DIR/core/src/ptr/mut_ptr.rs:LL:COL - StorageLive(_15); // scope 15 at $SRC_DIR/core/src/ptr/mut_ptr.rs:LL:COL - _15 = _9 as const u32 (Pointer(MutToConstPointer)); // scope 15 at $SRC_DIR/core/src/ptr/mut_ptr.rs:LL:COL - _14 = Offset(move _15, _13); // scope 15 at $SRC_DIR/core/src/ptr/mut_ptr.rs:LL:COL - StorageDead(_15); // scope 15 at $SRC_DIR/core/src/ptr/mut_ptr.rs:LL:COL - _7 = move _14 as mut u32 (PtrToPtr); // scope 15 at $SRC_DIR/core/src/ptr/mut_ptr.rs:LL:COL - StorageDead(_14); // scope 15 at $SRC_DIR/core/src/ptr/mut_ptr.rs:LL:COL - StorageDead(_13); // scope 13 at $SRC_DIR/core/src/ptr/mut_ptr.rs:LL:COL + _7 = Offset(_9, _2); // scope 13 at $SRC_DIR/core/src/ptr/mut_ptr.rs:LL:COL StorageDead(_9); // scope 6 at $SRC_DIR/core/src/slice/index.rs:LL:COL StorageDead(_12); // scope 3 at $SRC_DIR/core/src/slice/index.rs:LL:COL StorageDead(_11); // scope 3 at $SRC_DIR/core/src/slice/index.rs:LL:COL ``` `1c1c8e442a (diff-a841b6a4538657add3f39bc895744331453d0625e7aace128b1f604f0b63c8fdR80)`		2023-04-28 09:26:59 +00:00
.cargo	Add CARGO_WORKSPACE_DIR env var in `.cargo/config.toml`	2022-07-19 13:02:16 +02:00
.github	⬆️ rust-analyzer	2023-02-13 13:55:14 +02:00
.vscode	Take into account renamed extension id when launching	2022-08-12 18:06:58 +02:00
assets	Automatically change text color in logo based on dark mode	2022-03-06 23:06:53 +11:00
bench_data	internal: Rename AstDatabase to ExpandDatabase	2023-03-13 16:35:41 +01:00
crates	Rollup merge of #110766 - m-ou-se:fmt-rt, r=jyn514	2023-04-28 07:34:02 +02:00
docs	⬆️ rust-analyzer	2023-03-13 10:42:24 +02:00
editors/code	Auto merge of #14307 - davidbarsky:davidbarsky/add-cargo-style-project-discovery-for-buck-and-bazel-sickos, r=Veykril	2023-03-14 17:48:49 +00:00
lib	⬆️ rust-analyzer	2023-03-13 10:42:24 +02:00
xtask	⬆️ rust-analyzer	2023-02-13 13:55:14 +02:00
.editorconfig	prettier config	2022-05-17 18:12:49 +01:00
.git-blame-ignore-revs	add prettier format commit to ignored revisions	2022-05-17 18:15:51 +01:00
.gitattributes	Fix .gitattributes for test_data	2022-07-24 14:05:35 +02:00
.gitignore	internal: add "Shuffle Crate Graph" command	2021-12-07 16:37:19 +01:00
Cargo.lock	Bump chalk to 0.89	2023-03-19 16:45:26 +09:00
Cargo.toml	⬆️ rust-analyzer	2023-02-20 10:14:12 +02:00
LICENSE-APACHE	Licenses	2018-01-10 22:47:04 +03:00
LICENSE-MIT	Licenses	2018-01-10 22:47:04 +03:00
PRIVACY.md	Update privacy note	2021-12-23 14:04:15 +02:00
README.md	Fix r-a spelling in some places	2022-08-01 13:47:09 +02:00
rustfmt.toml	Remove forcing \n via rustfmt	2019-11-02 22:19:59 +03:00
triagebot.toml	Add rustbot features related to PR state labels	2022-11-04 15:27:50 +03:30

README.md

rust-analyzer is a modular compiler frontend for the Rust language. It is a part of a larger rls-2.0 effort to create excellent IDE support for Rust.

Quick Start

https://rust-analyzer.github.io/manual.html#installation

Documentation

If you want to contribute to rust-analyzer or are just curious about how things work under the hood, check the ./docs/dev folder.

If you want to use rust-analyzer's language server with your editor of choice, check the manual folder. It also contains some tips & tricks to help you be more productive when using rust-analyzer.

Security and Privacy

See the corresponding sections of the manual.

Communication

For usage and troubleshooting requests, please use "IDEs and Editors" category of the Rust forum:

https://users.rust-lang.org/c/ide/14

For questions about development and implementation, join rust-analyzer working group on Zulip:

https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer

Quick Links

Website: https://rust-analyzer.github.io/
Metrics: https://rust-analyzer.github.io/metrics/
API docs: https://rust-lang.github.io/rust-analyzer/ide/
Changelog: https://rust-analyzer.github.io/thisweek

License

rust-analyzer is primarily distributed under the terms of both the MIT license and the Apache License (Version 2.0).

See LICENSE-APACHE and LICENSE-MIT for details.