mirror of
https://github.com/rust-lang/rust-analyzer
synced 2025-01-25 11:25:06 +00:00
3ec86f1978
Detect `NulInCStr` error earlier. By making it an `EscapeError` instead of a `LitError`. This makes it like the other errors produced when checking string literals contents, e.g. for invalid escape sequences or bare CR chars. NOTE: this means these errors are issued earlier, before expansion, which changes behaviour. It will be possible to move the check back to the later point if desired. If that happens, it's likely that all the string literal contents checks will be delayed together. One nice thing about this: the old approach had some code in `report_lit_error` to calculate the span of the nul char from a range. This code used a hardwired `+2` to account for the `c"` at the start of a C string literal, but this should have changed to a `+3` for raw C string literals to account for the `cr"`, which meant that the caret in `cr"` nul error messages was one short of where it should have been. The new approach doesn't need any of this and avoids the off-by-one error. r? ```@fee1-dead``` |
||
|---|---|---|
| .. | ||
| ast | ||
| parsing | ||
| tests | ||
| validation | ||
| algo.rs | ||
| ast.rs | ||
| fuzz.rs | ||
| hacks.rs | ||
| lib.rs | ||
| parsing.rs | ||
| ptr.rs | ||
| syntax_error.rs | ||
| syntax_node.rs | ||
| ted.rs | ||
| tests.rs | ||
| token_text.rs | ||
| utils.rs | ||
| validation.rs | ||