rust-analyzer/crates
Yuri Astrakhan d3dbf9c194 Moar linting: needless_borrow, let_unit_value, ...
* There are a few needless borrows that don't seem to be needed. I even did a quick assembly comparison and posted a q to stackoveflow on it. See [here](https://stackoverflow.com/questions/74910196/advantages-of-pass-by-ref-val-with-impl-intoiteratoritem-impl-asrefstr)
* removed several `let _ = ...` when they don't look necessary (even a few ones that were not suggested by clippy (?))
* there were a few `then(|| ctor{})` that clippy suggested to replace with `then_some(ctor{})` -- seems reasonable?
* some unneeded assignment+return - keep the code a bit leaner
* a few `writeln!` instead of `write!`, or even consolidate write!
* a nice optimization to use `ch.is_ascii_digit` instead of `ch.is_digit(10)`
2022-12-25 05:07:47 -05:00
..
base-db Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
cfg Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
flycheck Moar linting: needless_borrow, let_unit_value, ... 2022-12-25 05:07:47 -05:00
hir Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
hir-def Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
hir-expand Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
hir-ty Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
ide Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
ide-assists Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
ide-completion Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
ide-db Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
ide-diagnostics Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
ide-ssr Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
limit Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
mbe Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
parser Moar linting: needless_borrow, let_unit_value, ... 2022-12-25 05:07:47 -05:00
paths ⬆️ rust-analyzer 2022-11-23 17:24:03 +02:00
proc-macro-api Moar linting: needless_borrow, let_unit_value, ... 2022-12-25 05:07:47 -05:00
proc-macro-srv Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
proc-macro-srv-cli ⬆️ rust-analyzer 2022-11-23 17:24:03 +02:00
proc-macro-test Moar linting: needless_borrow, let_unit_value, ... 2022-12-25 05:07:47 -05:00
profile Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
project-model Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
rust-analyzer Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
sourcegen Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
stdx Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
syntax Moar linting: needless_borrow, let_unit_value, ... 2022-12-25 05:07:47 -05:00
test-utils Moar linting: needless_borrow, let_unit_value, ... 2022-12-25 05:07:47 -05:00
text-edit ⬆️ rust-analyzer 2022-11-23 17:24:03 +02:00
toolchain Moar linting: needless_borrow, let_unit_value, ... 2022-12-25 05:07:47 -05:00
tt Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
vfs Inline all format arguments where possible 2022-12-24 14:36:10 -05:00
vfs-notify ⬆️ rust-analyzer 2022-11-23 17:24:03 +02:00