mirror of
https://github.com/rust-lang/rust-analyzer
synced 2025-01-10 20:28:51 +00:00
d5366b5c19
fix: Acknowledge `pub(crate)` imports in import suggestions
rust-analyzer has logic that discounts suggesting `use`s for private imports, but that logic is unnecessarily strict - for instance given this code:
```rust
mod foo {
pub struct Foo;
}
pub(crate) use self::foo::*;
mod bar {
fn main() {
Foo$0;
}
}
```
... RA will suggest to add `use crate::foo::Foo;`, which not only makes the code overly verbose (especially in larger code bases), but also is disjoint with what rustc itself suggests.
This commit adjusts the logic, so that `pub(crate)` imports are taken into account when generating the suggestions; considering rustc's behavior, I think this change doesn't warrant any extra configuration flag.
Note that this is my first commit to RA, so I guess the approach taken here might be suboptimal - certainly feels somewhat hacky, maybe there's some better way of finding out the optimal import path 😅
|
||
|---|---|---|
| .. | ||
| generated | ||
| imports | ||
| syntax_helpers | ||
| test_data | ||
| tests | ||
| active_parameter.rs | ||
| apply_change.rs | ||
| assists.rs | ||
| defs.rs | ||
| documentation.rs | ||
| famous_defs.rs | ||
| helpers.rs | ||
| items_locator.rs | ||
| label.rs | ||
| lib.rs | ||
| path_transform.rs | ||
| rename.rs | ||
| rust_doc.rs | ||
| search.rs | ||
| source_change.rs | ||
| symbol_index.rs | ||
| traits.rs | ||
| ty_filter.rs | ||
| use_trivial_constructor.rs | ||