rust-analyzer/crates
bors[bot] 98020ef2f3 Merge #1394
1394: Fix hover for pat that shadows items r=matklad a=sinkuu

```rust
fn x() {}

fn y() {
    let x = 0i32;
    x; // hover on `x` is expected to be `i32`, but the actual result was `fn x()`
}
```

This was because: if [`res.is_empty()`](656a0fa9f9/crates/ra_ide_api/src/hover.rs (L205)), it fallbacks to "index based approach" and adds `fn x()` to `res`, which makes [`res.extend(type_of)` below](656a0fa9f9/crates/ra_ide_api/src/hover.rs (L260-L266)) not happen.

Co-authored-by: Shotaro Yamada <sinkuu@sinkuu.xyz>
2019-06-11 17:24:28 +00:00
..
gen_lsp_server updated gen_lsp_server examples 2019-05-22 20:35:12 -05:00
ra_arena Add is_empty to Arena 2019-04-26 11:42:10 -04:00
ra_assists remove inherent source impls 2019-06-11 18:28:51 +03:00
ra_batch Fix clippy::identity_conversion 2019-06-04 18:05:07 -04:00
ra_cli fix compilation 2019-06-11 18:28:51 +03:00
ra_db switch to upstream salsa 2019-05-30 13:05:09 +03:00
ra_fmt apply T! macro where it is possible 2019-05-15 15:35:47 +03:00
ra_hir move docs under code model 2019-06-11 18:28:51 +03:00
ra_ide_api Merge #1394 2019-06-11 17:24:28 +00:00
ra_lsp_server make Docs handing more ideomatic 2019-06-08 14:16:05 +03:00
ra_mbe fix: clean up warnings 2019-06-06 10:06:46 +08:00
ra_parser fix: never type with binding 2019-06-07 19:49:49 +08:00
ra_prof fix debug scopes 2019-06-04 14:46:22 +03:00
ra_project_model Fix clippy::identity_conversion 2019-06-04 18:05:07 -04:00
ra_syntax fix: never type with binding 2019-06-07 19:49:49 +08:00
ra_text_edit Fix clippy::match_ref_pats 2019-06-04 18:05:07 -04:00
ra_tools rename tools -> ra_tools 2019-06-11 01:47:37 +03:00
ra_tt Fix clippy::needless_return 2019-06-04 18:05:07 -04:00
test_utils Fix clippy::expect_fun_call 2019-06-04 18:05:07 -04:00
thread_worker Fix clippy::single_match 2019-06-04 18:05:07 -04:00