mirror of
https://github.com/rust-lang/rust-analyzer
synced 2025-01-08 11:18:48 +00:00
3fdf26a6fc
7898: generate_function assist: infer return type r=JoshMcguigan a=JoshMcguigan
This PR makes two changes to the generate function assist:
1. Attempt to infer an appropriate return type for the generated function
2. If a return type is inferred, and that return type is not unit, don't render the snippet
```rust
fn main() {
let x: u32 = foo$0();
// ^^^ trigger the assist to generate this function
}
// BEFORE
fn foo() ${0:-> ()} {
todo!()
}
// AFTER (only change 1)
fn foo() ${0:-> u32} {
todo!()
}
// AFTER (change 1 and 2, note the lack of snippet around the return type)
fn foo() -> u32 {
todo!()
}
```
These changes are made as two commits, in case we want to omit change 2. I personally feel like it is a nice change, but I could understand there being some opposition.
#### Pros of change 2
If we are able to infer a return type, and especially if that return type is not the unit type, the return type is almost as likely to be correct as the argument names/types. I think this becomes even more true as people learn how this feature works.
#### Cons of change 2
We could never be as confident about the return type as we are about the function argument types, so it is more likely a user will want to change that. Plus it is a confusing UX to sometimes have the cursor highlight the return type after triggering this assist and sometimes not have that happen.
#### Why omit unit type?
The assumption is that if we infer the return type as unit, it is likely just because of the current structure of the code rather than that actually being the desired return type. However, this is obviously just a heuristic and will sometimes be wrong. But being wrong here just means falling back to the exact behavior that existed before this PR.
Co-authored-by: Josh Mcguigan <joshmcg88@gmail.com>
|
||
|---|---|---|
| .. | ||
| add_explicit_type.rs | ||
| add_lifetime_to_type.rs | ||
| add_missing_impl_members.rs | ||
| add_turbo_fish.rs | ||
| apply_demorgan.rs | ||
| auto_import.rs | ||
| change_visibility.rs | ||
| convert_comment_block.rs | ||
| convert_integer_literal.rs | ||
| early_return.rs | ||
| expand_glob_import.rs | ||
| extract_function.rs | ||
| extract_struct_from_enum_variant.rs | ||
| extract_variable.rs | ||
| fill_match_arms.rs | ||
| fix_visibility.rs | ||
| flip_binexpr.rs | ||
| flip_comma.rs | ||
| flip_trait_bound.rs | ||
| generate_default_from_enum_variant.rs | ||
| generate_default_from_new.rs | ||
| generate_derive.rs | ||
| generate_enum_is_method.rs | ||
| generate_enum_projection_method.rs | ||
| generate_from_impl_for_enum.rs | ||
| generate_function.rs | ||
| generate_getter.rs | ||
| generate_getter_mut.rs | ||
| generate_impl.rs | ||
| generate_new.rs | ||
| generate_setter.rs | ||
| infer_function_return_type.rs | ||
| inline_function.rs | ||
| inline_local_variable.rs | ||
| introduce_named_lifetime.rs | ||
| invert_if.rs | ||
| merge_imports.rs | ||
| merge_match_arms.rs | ||
| move_bounds.rs | ||
| move_guard.rs | ||
| move_module_to_file.rs | ||
| pull_assignment_up.rs | ||
| qualify_path.rs | ||
| raw_string.rs | ||
| remove_dbg.rs | ||
| remove_mut.rs | ||
| remove_unused_param.rs | ||
| reorder_fields.rs | ||
| reorder_impl.rs | ||
| replace_derive_with_manual_impl.rs | ||
| replace_for_loop_with_for_each.rs | ||
| replace_if_let_with_match.rs | ||
| replace_impl_trait_with_generic.rs | ||
| replace_let_with_if_let.rs | ||
| replace_qualified_name_with_use.rs | ||
| replace_string_with_char.rs | ||
| replace_unwrap_with_match.rs | ||
| split_import.rs | ||
| toggle_ignore.rs | ||
| unmerge_use.rs | ||
| unwrap_block.rs | ||
| wrap_return_type_in_result.rs | ||