rust-analyzer/crates
Wilfred Hughes 3cf28f1fc6 fix: Updating settings should not clobber discovered projects
`linkedProjects` is owned by the user's configuration, so when users
update this setting, `linkedProjects` is reset. This is problematic when
`linkedProjects` also contains projects discovered with `discoverCommand`.

The buggy behaviour occurred when:

(1) The user configures `discoverCommand` and loads a Rust project.

(2) The user changes any setting in VS Code, so rust-analyzer receives
`workspace/didChangeConfiguration`.

(3) `handle_did_change_configuration` ultimately calls
`Client::apply_change_with_sink()`, which updates `config.user_config`
and discards any items we added in `linkedProjects`.

Instead, separate out `discovered_projects_from_filesystem` and
`discovered_projects_from_command` from user configuration, so user
settings cannot affect any type of discovered project.

This fixes the subtle issue mentioned here:
https://github.com/rust-lang/rust-analyzer/pull/17246#issuecomment-2185259122
2024-09-05 15:46:03 -07:00
..
base-db minor: Downgrade cyclic deps error to warning 2024-09-01 10:02:41 +02:00
cfg Remove unnecessary CfgFlag definition in project-model 2024-08-07 14:27:59 +02:00
hir asm! parsing and lowering fixes 2024-09-05 15:08:16 +02:00
hir-def asm! parsing and lowering fixes 2024-09-05 15:08:16 +02:00
hir-expand Lower asm expressions 2024-09-05 09:59:08 +02:00
hir-ty fix: Fix parser panicking on invalid asm options 2024-09-05 17:07:10 +02:00
ide asm! parsing and lowering fixes 2024-09-05 15:08:16 +02:00
ide-assists Auto merge of #17984 - ShoyuVanilla:cast, r=Veykril 2024-09-03 06:00:10 +00:00
ide-completion Add Definition kind for asm register classes 2024-09-05 10:23:00 +02:00
ide-db Support more IDE features for asm operands 2024-09-05 13:19:02 +02:00
ide-diagnostics feat: Implement cast typechecks 2024-09-03 04:11:36 +09:00
ide-ssr Properly account for editions in names 2024-08-16 16:46:24 +03:00
intern chore: fix some comments 2024-09-02 18:33:23 +08:00
limit Replace [package.repository] = "…" of published crates with [package.repository.workspace] = true 2024-08-06 00:26:42 +02:00
load-cargo Auto merge of #17864 - Veykril:lsif, r=Veykril 2024-08-12 12:34:31 +00:00
mbe internal: Lay basic ground work for standalone mbe tests 2024-09-01 12:42:44 +02:00
parser fix: Fix parser panicking on invalid asm options 2024-09-05 17:07:10 +02:00
paths Replace [package.repository] = "…" of published crates with [package.repository.workspace] = true 2024-08-06 00:26:42 +02:00
proc-macro-api Expand proc-macros in workspace root, not package root 2024-08-27 13:40:24 +02:00
proc-macro-srv fix: Fix TokenStream::to_string implementation dropping quotation marks 2024-08-29 08:45:35 +02:00
proc-macro-srv-cli Replace [package.repository] = "…" of published crates with [package.repository.workspace] = true 2024-08-06 00:26:42 +02:00
profile Replace [package.repository] = "…" of published crates with [package.repository.workspace] = true 2024-08-06 00:26:42 +02:00
project-model fix: Updating settings should not clobber discovered projects 2024-09-05 15:46:03 -07:00
rust-analyzer fix: Updating settings should not clobber discovered projects 2024-09-05 15:46:03 -07:00
salsa Drop Apache license appendices 2024-08-27 14:52:34 +03:00
span chore: fix some comments 2024-09-02 18:33:23 +08:00
stdx Use crossbeam-channel from the workspace 2024-08-09 23:48:03 +02:00
syntax Give InlineAsmOperand a HIR representation 2024-09-05 12:40:48 +02:00
syntax-bridge internal: Lay basic ground work for standalone mbe tests 2024-09-01 12:42:44 +02:00
test-fixture Newtype ErasedFileAstId 2024-08-05 13:46:47 +02:00
test-utils Add Definition kind for asm register classes 2024-09-05 10:23:00 +02:00
text-edit Replace [package.repository] = "…" of published crates with [package.repository.workspace] = true 2024-08-06 00:26:42 +02:00
toolchain Replace [package.repository] = "…" of published crates with [package.repository.workspace] = true 2024-08-06 00:26:42 +02:00
tt fix: Fix TokenStream::to_string implementation dropping quotation marks 2024-08-29 08:45:35 +02:00
vfs internal: Lay basic ground work for standalone mbe tests 2024-09-01 12:42:44 +02:00
vfs-notify Auto merge of #17843 - mo8it:flycheck, r=Veykril 2024-08-12 09:27:47 +00:00