mirror of
https://github.com/rust-lang/rust-analyzer
synced 2025-01-15 22:54:00 +00:00
eeceba7480
Support generic function in `generate_function` assist Part of #3639 This PR adds support for generic function generation in `generate_function` assist. Now the assist looks for generic parameters and trait bounds in scope, filters out irrelevant ones, and generates new function with them. See `fn_generic_params()` for the outline of the procedure, and see comments on `filter_unnecessary_bounds()` for criteria for filtering. I think it's good criteria for most cases, but I'm open to opinions and suggestions. The diff is pretty big, but it should run in linear time w.r.t. the number of nodes we operate on and should be fast enough. Some notes: - When we generate function in an existing impl, generic parameters may cause name conflict. While we can detect the conflict and rename conflicting params, I didn't find it worthwhile mainly because it's really easy to resolve on IDE: use Rename functionality. - I've implemented graph structure myself, because we don't have graph library as a dependency and we only need the simplest one. - Although `petgraph` is in our dependency graph and I was initially looking to use it, we don't actually depend on it AFAICT since it's only used in chalk's specialization graph handling, which we don't use. I'd be happy to replace my implementation with `petgraph` if it's okay to use it though. - There are some caveats that I consider out of scope of this PR. See FIXME notes on added tests. |
||
|---|---|---|
| .. | ||
| generated | ||
| imports | ||
| syntax_helpers | ||
| test_data | ||
| tests | ||
| active_parameter.rs | ||
| apply_change.rs | ||
| assists.rs | ||
| defs.rs | ||
| famous_defs.rs | ||
| helpers.rs | ||
| items_locator.rs | ||
| label.rs | ||
| lib.rs | ||
| line_index.rs | ||
| path_transform.rs | ||
| rename.rs | ||
| rust_doc.rs | ||
| search.rs | ||
| source_change.rs | ||
| symbol_index.rs | ||
| traits.rs | ||
| ty_filter.rs | ||
| use_trivial_contructor.rs | ||