bors[bot]
daffdd8674
Merge #3179
...
3179: Introduce AsMacroCall trait r=matklad a=edwin0cheng
This PR introduce `AsMacroCall` trait to help convert `ast::MacroCall` to `MacroCallId`. The main goal here is to centralize various conversions to single place and make implementing eager macro calls without further ado.
```rust
pub trait AsMacroCall {
fn as_call_id(
&self,
db: &(impl db::DefDatabase + AstDatabase),
resolver: impl Fn(path::ModPath) -> Option<MacroDefId>,
) -> Option<MacroCallId>;
}
```
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2020-02-17 08:38:09 +00:00
Edwin Cheng
2d4e79e1e6
Introduce AsMacroCall trait
2020-02-17 12:57:24 +08:00
Veetaha
bd113623a0
vscode: minor refactorings
2020-02-17 02:07:11 +02:00
Veetaha
31ae646448
vscode: add comment on possible UnhandledPromise rejection error
2020-02-17 01:39:58 +02:00
Veetaha
2d7fe230f5
docs: Fix grammar mistakes
2020-02-16 23:52:41 +02:00
Veetaha
884e382fb8
Fix typo
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:47:12 +02:00
Veetaha
5bf7e9a455
Remove ptrace note
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:43:13 +02:00
Veetaha
bb9844e195
Add more verbose description
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:42:48 +02:00
Veetaha
7050697871
Add the article
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:42:10 +02:00
Veetaha
3db91db421
Reworded abit
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:40:31 +02:00
Veetaha
329a1b665d
Add an article
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:38:25 +02:00
Veetaha
dc90507dbe
Migrate from 'npm i' to 'npm install'
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:36:16 +02:00
Veetaha
1a96d4c15c
Make Rust Great Again
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:35:41 +02:00
Veetaha
79625e2dc2
Apply better wording as per lnicola
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:35:10 +02:00
Veetaha
351cc9021e
Add the article
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:33:23 +02:00
Veetaha
200a2475a2
docs: fix typo
2020-02-16 23:21:11 +02:00
Veetaha
64112b0b61
docs: update debugging.md with the freshest VSCode debugging information
2020-02-16 23:00:10 +02:00
Veetaha
43a41819cb
docs: remove obsolescence notice in debugging.md
2020-02-16 21:03:24 +02:00
bors[bot]
32fc890de8
Merge #3175
...
3175: vscode: skip node internals while debugging r=matklad a=Veetaha
Before:
After:
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-16 18:51:51 +00:00
Veetaha
54432c3ae8
vscode: apply lnicolas amendments to comments in launch.json
2020-02-16 20:38:04 +02:00
Veetaha
cc280aba0f
vscode: remove extra comment lone
2020-02-16 20:22:27 +02:00
Veetaha
29c7cbb46f
vscode: skip node internals while debugging
2020-02-16 20:20:30 +02:00
bors[bot]
3a1c7808a4
Merge #3174
...
3174: Added description and disable-extensions r=matklad a=Fihtangolz
Co-authored-by: Dmitry <mamhigtt@gmail.com>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-16 17:55:04 +00:00
Aleksey Kladov
5b781de56c
Apply suggestions from code review
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 18:54:32 +01:00
bors[bot]
a90f5b0787
Merge #3173
...
3173: vscode: fix stupid mistake of mine r=matklad a=Veetaha
Shame on me...
Fixes #3056
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-16 17:40:23 +00:00
Dmitry
58e15d12e4
Merge remote-tracking branch 'origin/master'
2020-02-17 00:36:48 +07:00
bors[bot]
10f910df4b
Merge #3172
...
3172: 1-based columns r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-16 17:31:16 +00:00
Aleksey Kladov
ca7e9ab0da
1-based columns
2020-02-16 18:30:48 +01:00
Veetaha
6e22e33d7d
vscode: fix stupid mistake
2020-02-16 19:30:13 +02:00
Dmitry
b446384956
Added short description and disable-extensions
2020-02-17 00:28:14 +07:00
Aleksey Kladov
0f79ec76d6
Support goto def in bences
2020-02-16 18:24:06 +01:00
Aleksey Kladov
6a3ec2dfa5
Refactor arg parsing
2020-02-16 18:20:22 +01:00
Aleksey Kladov
2ba918775c
Refactor position parsing
2020-02-16 18:17:35 +01:00
bors[bot]
742b3b5744
Merge #3171
...
3171: Enable profiling for bench r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-16 17:04:39 +00:00
Aleksey Kladov
98cc51580d
Enable profiling for bench
2020-02-16 18:04:08 +01:00
Kirill Bulatov
f0338cea5b
Fix a slow test
2020-02-16 18:55:52 +02:00
Kirill Bulatov
dabdb57067
Simplify module retrieval
2020-02-16 18:44:46 +02:00
bors[bot]
b98967d765
Merge #3170
...
3170: Add module colors to css r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-16 16:08:36 +00:00
Aleksey Kladov
28fa5edbce
Add module colors to css
2020-02-16 17:06:01 +01:00
bors[bot]
004b74d554
Merge #3168
...
3168: vscode: update exclusiveMinimum validation according to JSONSchemaV4 r=Veetaha a=Veetaha
It seems that vscode uses 4+ version of json schema where `exclusiveMinimum` [was changed to be a boolean](http://json-schema.org/understanding-json-schema/reference/numeric.html#7f93d6925e80_Draft%204 )
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-16 16:01:29 +00:00
Veetaha
56b64cac9c
vscode: added minimum bound for lruCapacity option
2020-02-16 18:00:49 +02:00
Veetaha
0565657ed1
vscode: fix all integer -> number and add nullablitiy to maxInlayHintLength
2020-02-16 17:55:15 +02:00
adamrk
e88eb89132
add space before/after wrapping braces
2020-02-16 16:33:15 +01:00
adamrk
68d3743faf
replace uses of VariantData::is_unit with VariantData::kind
2020-02-16 16:10:32 +01:00
adamrk
04aff742b1
show names for record fields in enum completion
2020-02-16 16:10:23 +01:00
Veetaha
53b5f4ba98
vscode: update exclusiveMinimum validation according to JSONSchemaV4 specs
2020-02-16 16:48:17 +02:00
bors[bot]
77d27c67c1
Merge #3165
...
3165: Fix coercion of &T to itself r=matklad a=flodiebold
The autoderef coercion logic did not handle matching placeholders. This led to
some type mismatches.
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
2020-02-16 12:03:42 +00:00
Florian Diebold
e14e7ffa34
Fix coercion of &T to itself
...
The autoderef coercion logic did not handle matching placeholders. This led to
some type mismatches.
2020-02-16 12:58:20 +01:00
bors[bot]
a15c8739b9
Merge #3162
...
3162: Feature: vscode always downloads only the matching ra_lsp_server version r=matklad a=Veetaha
I tried to separate logically connected changes into separate commits, so enjoy!
Now TypeScript extension saves installed binary version in global state and always checks that the installed binary version equals the version of the TypeScript extension itself (to prevent version drifts).
Also, changed `fetchLatestArtifactReleaseInfo()` to `fetchArtifactReleaseInfo()` that takes an optional release tag (when not specified fetches the latest release). The version without a release tag will be useful in the future when adding auto-checking for updates.
I decided not to do `Download latest language server` command (I have stated the rationale for this in #3073 ) and let the extension itself decide which version of the binary it wants. This way the users will be able to get the latest `ra_lsp_server` binary after the approaching 2020-02-17 release, without having to manually delete the outdated one from `~/.config/Code/User/globalStorage/matklad.rust-analyzer`!
Closes #3073
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-16 11:54:38 +00:00
Aleksey Kladov
617b5b3b31
Merge pull request #3161 from Veetaha/feature/cicd-simplify-vsce-call
...
cicd: simplify vsce call
2020-02-16 11:51:37 +01:00
