bors
355c9444e1
Auto merge of #16448 - Young-Flash:typos, r=lnicola
...
minor: correct typos
I use [crate-ci/typos](https://github.com/crate-ci/typos ) to check typos in codebase, if it's ok with you, I'd like to add a typo check CI using [typos](https://github.com/crate-ci/typos ) (with Apache-2.0, MIT licenses).
BTW, we can add a [_typos.toml](https://github.com/crate-ci/typos/blob/master/docs/reference.md ) as white list for some intentional typos
2024-01-31 13:29:55 +00:00
David Barsky
e1ea7c8844
internal: switch to tracing from log
...
This commit also adds `tracing` to NotificationDispatcher/RequestDispatcher,
bumps `rust-analyzer-salsa` to 0.17.0-pre.6, `always-assert` to 0.2, and
removes the homegrown `hprof` implementation in favor of a vendored
tracing-span-tree.
2024-01-30 12:27:31 -05:00
Young-Flash
db9fd370ee
minor: correct typos
2024-01-30 21:43:43 +08:00
Ali Bektas
b0101da116
Ignore doc(hidden) attr if no body is present
2023-11-09 02:12:53 +01:00
ponyii
61cabe029f
the "add missing members" assists: supported bracketed default const values
2023-08-08 21:57:55 +04:00
ponyii
4e2be8e959
the "add missing members" assists: implemented the transformation of const param default values
2023-08-08 21:57:55 +04:00
ponyii
52b4392724
the "add missing members" assists: implemented substitution of default values of const params
2023-08-08 21:57:54 +04:00
Ali Bektas
915ddb05fa
HiddenDocAttr becomes DocHiddenAttr
2023-07-07 14:15:15 +02:00
Ali Bektas
18ea9245c6
v2
2023-07-04 19:32:48 +02:00
Ali Bektas
8a2c5d215b
Still in need of more test cases
2023-07-04 19:27:50 +02:00
Ali Bektas
0df1153277
bugfix : skip doc(hidden) default members
...
fixes #14957
2023-07-04 19:27:50 +02:00
bors
a1b536ec6f
Auto merge of #15054 - ponyii:fix/implement-missing-members-do-not-transform-const-params, r=lowr
...
fix: implement missing members doesn't transform const params and default types
Fixes https://github.com/rust-lang/rust-analyzer/issues/13363
2023-06-18 09:30:13 +00:00
ponyii
7e08933a26
the "implement missing members" assist's const transformation patched
2023-06-16 20:34:44 +04:00
ponyii
b07490ffe9
made the add_missing_impl_members and add_missing_default_members assists transform default generic types
2023-06-14 17:37:34 +04:00
ponyii
5ce65a1d92
the "implement missing members" assist's const transformation implemented
2023-06-12 20:16:22 +04:00
Ryo Yoshida
008f5065d1
fix(assist): derive source scope from syntax node to be transformed
2023-06-11 15:25:36 +09:00
bors
95228d23bb
Auto merge of #14875 - ponyii:fix/implement-missing-members-do-not-transform-lifetimes, r=Veykril
...
fix: implemeted lifetime transformation fot assits
A part of https://github.com/rust-lang/rust-analyzer/issues/13363
I expect to implement transformation of const params in a separate PR
Other assists and a completion affected:
- `generate_function` currently just ignores lifetimes and, consequently, is not affected
- `inline_call` and `replace_derive_with...` don't seem to need lifetime transformation
- `trait_impl` (a completion) is fixed and tested
2023-06-10 13:22:50 +00:00
DropDemBits
e6e72bf9d5
Migrate add_missing_impl_members to mutable ast
...
`replace_derive_with_manual_impl` was slightly since it used
`add_trait_assoc_items_to_impl`
(which was also used by `add_missing_impl_members`)
2023-06-05 00:23:10 -04:00
ponyii
fe8f862757
made the add_missing_impl_members and add_missing_default_members assists transform lifetimes
2023-06-03 21:12:11 +04:00
bors
21e5dc2af9
Auto merge of #14881 - Veykril:name-display, r=Veykril
...
internal: Replace Display impl for Name
This allows us to plug in interner for `Name`s that live inside the database.
2023-05-25 12:04:16 +00:00
Lukas Wirth
c7ef6c25b7
internal: Replace Display impl for Name
2023-05-24 20:55:12 +02:00
ponyii
49f1092f14
add_missing_impl_members and add_missing_default_members break indentation no longer
2023-05-10 22:27:05 +04:00
ponyii
e07d6382de
add_missing_impl_members no longer breaks indentation
2023-05-10 16:35:48 +04:00
Josh Soref
bc7d84c3ce
Spelling
...
* a rule
* access
* after
* amount
* annotations
* assignment
* assist
* associated
* attribute
* borrowed
* built-in type
* clarification
* command
* const
* constructor
* corresponding
* counterparts
* curlies
* dependencies
* deterministic
* diagnostic
* duplicates
* edge
* edited
* efficient
* elsewhere
* execution
* expression
* extensions
* extracted
* fill
* github
* helper
* heuristic
* incomplete
* indent end
* inlay
* invocation
* lifetime
* looking
* maybe
* move
* mutability
* mutable
* necessarily
* necessary
* negative
* nonexistent
* occurred
* offsets
* offsetted
* overridden
* parameters
* params
* params_and_where_preds_in_scope
* paredit
* parent
* parentheses
* prepended if
* punctuation
* receive
* receiver
* referring
* repeated
* representing
* semantically
* separately
* shouldnot
* siblings
* similar
* something's
* statement
* struct
* structure
* surprise
* the
* this
* transparent
* unimplemented
* unnamed
* unnecessary
* unneeded
* unreachable
* unterminated
* utilities
* variant
* variants
* visibility
* work around (v)
* workaround
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-04-19 09:45:55 -04:00
Jonas Schievink
e7a2d13ff6
Fix "add missing impl members" assist for impls inside blocks
2023-01-27 16:51:55 +01:00
Ryo Yoshida
fc56cacfc1
Test TraitRef equality before generating missing impl method body
2023-01-16 20:55:56 +09:00
bors
63a676eedf
Auto merge of #13576 - Bben01:supress_missing_impl_inside_block, r=jonas-schievink
...
Suppress "Implement default members" inside contained items
Fixes #13561
2022-11-24 15:16:36 +00:00
Bben01
95b4a7487b
Suppress "Implement default members" inside contained items
2022-11-21 22:17:04 +02:00
bvanjoi
a4f071afd5
fix(assists): remove item_const which had default value when implement missing members`
2022-11-19 19:38:53 +08:00
Ryo Yoshida
19306c070d
Fix tests that depended on loose visibility restriction
2022-11-11 20:31:46 +09:00
Edwin Cheng
c47914c6cf
Fixes tests
2022-08-10 16:29:23 +08:00
bors
894d6a232c
Auto merge of #12832 - lowr:fix/impl-default-members-no-codegen, r=Veykril
...
fix: don't replace default members' body
cc #12779 , #12821
addresses https://github.com/rust-lang/rust-analyzer/pull/12821#issuecomment-1190157506
`gen_trait_fn_body()` only attempts to implement required trait member functions, so we shouldn't call it for `Implement default members` assist.
This patch also documents the precondition of `gen_trait_fn_body()` and inserts `debug_assert!`, but I'm not entirely sure if the assertions are appropriate.
2022-07-24 12:46:08 +00:00
Ryo Yoshida
7e0bd377c2
fix: don't replace default members' body
2022-07-20 22:30:16 +09:00
Amos Wenger
7e285e1ef5
Run cargo fmt
2022-07-20 15:06:15 +02:00
Amos Wenger
816f7fe12a
Run cargo fix --edition-idioms
2022-07-20 15:02:08 +02:00
Michael Chisolm
1c32fcfeb4
Fix generated PartialEq::ne
2022-07-20 00:26:50 -04:00
Lukas Wirth
86d1d9067e
fix: Insert whitespace into trait-impl completions when coming from macros
2022-05-24 22:56:33 +02:00
Peh
1f011fa4a3
style: rename crates to kebab case
2022-05-01 10:48:58 +00:00
