2707 commits

Author	SHA1	Message	Date
Alex Kladov	f852a6fc7d	ide: add a new test	2024-04-16 17:17:46 +01:00
Alex Kladov	9bd8eee21e	ide: improve ReferenceCategoryType ... It is bitset semantically --- many categorical things can be true about a reference at the same time. In parciular, a reference can be a "test" and a "write" at the same time.	2024-04-16 17:17:46 +01:00
roife	6bb85985d7	fix: adjust the limitation for ADTs' fields to 5	2024-04-16 16:28:23 +08:00
roife	c06d670f8f	fix: the fields or variants of ADT was not restricted by limitations when hovering on Self type	2024-04-16 16:27:57 +08:00
roife	01c3559bf3	Update tests and docs for hover_show_adtFieldsOrVariants	2024-04-16 16:27:56 +08:00
roife	21da6c6164	Add config hover_show_adtFieldsOrVariants to handle hovering limitation for ADTs	2024-04-16 16:26:23 +08:00
bors	1179c3ee83	Auto merge of #16639 - alibektas:13529/config_restruct, r=Veykril ... internal : redesign rust-analyzer::config This PR aims to cover the infrastructural requirements for the `rust-analyzer.toml` ( #13529 ) issue. This means, that 1. We no longer have a single config base. The once single `ConfigData` has been divided into 4 : A tree of `.ratoml` files, a set of configs coming from the client ( this is what was called before the `CrateData` except that now values do not default to anything when they are not defined) , a set of configs that will reflect what the contents of a `ratoml` file defined in user's config directory ( e.g `~/.config/rust-analyzer/.rust-analyzer.toml` and finally a tree root that is populated by default values only. 2. Configs have also been divided into 3 different blocks : `global` , `local` , `client`. The current status of a config may change until #13529 got merged. Once again many thanks to `@cormacrelf` for doing all the serde work.	2024-04-16 07:52:07 +00:00
Lukas Wirth	597c293a69	Adjust package.json semantic highlighting items	2024-04-15 17:00:03 +02:00
Lukas Wirth	6b98e55dbb	Add Static and Const highlighting token types	2024-04-15 16:54:17 +02:00
Lukas Wirth	1915980031	fix: Fix impl Trait<Self> causing stackoverflows	2024-04-15 15:41:20 +02:00
Lukas Wirth	60d3a7320e	Differentiate between full configs and toml only config groupings	2024-04-15 14:16:43 +02:00
Ali Bektas	67d8d2d4a0	Make ConfigData Ser and TOML De ... This commit makes rust-analyzer::config module TOML ser and de. Co-Authored-By: Cormac Relf <web@cormacrelf.net>	2024-04-15 14:14:23 +02:00
Lukas Wirth	a483d3bc37	internal: Thread edition through to parsing/tt-to-syntax-tree routines for macros	2024-04-14 16:02:38 +02:00
Lukas Wirth	2c5c12acfe	fix: Fix inlay hint resolution being broken	2024-04-14 08:27:24 +02:00
Lukas Wirth	f3567bb604	Arc CrateData::cfg_options	2024-04-06 13:55:10 +02:00
Lukas Wirth	5957835cdf	Consider exported_name="main" functions in test modules as tests	2024-04-04 14:51:10 +02:00
Lukas Wirth	86967032f7	Consider ADT generic parameter defaults for unsubstituted layout calculations	2024-04-03 09:01:27 +02:00
Lukas Wirth	707be6b99c	Adjust display impls to respect lifetime bounds	2024-04-02 14:51:08 +02:00
bors	3691380c35	Auto merge of #16920 - Veykril:clippy-lints, r=Veykril ... internal: Fix new nightly clippy lints	2024-04-01 16:00:18 +00:00
Lukas Wirth	2ae3e57c26	Fix new clippy lints	2024-04-01 17:55:56 +02:00
bors	a8b7acf22f	Auto merge of #16971 - HKalbasi:test-explorer, r=HKalbasi ... Resolve tests per file instead of per crate in test explorer Fix part of #16827	2024-03-29 02:06:22 +00:00
hkalbasi	beec6914c8	Resolve tests per file instead of per crate in test explorer	2024-03-29 05:34:43 +03:30
dfireBird	34a8cd6a7a	fix ADT hover considering only type or const len not lifetimes	2024-03-28 21:53:22 +05:30
dfireBird	20b12c2bac	fix lifetime length are not added in count of params in highlight	2024-03-27 23:21:17 +05:30
Young-Flash	58013ad70d	add test for struct field hover display limit	2024-03-25 19:55:19 +08:00
Young-Flash	ba8c9810aa	review update	2024-03-25 19:55:19 +08:00
Young-Flash	a89e417ce5	adjust test	2024-03-25 19:55:19 +08:00
Young-Flash	1c85234bcd	limit struct field hover display nums	2024-03-25 19:55:19 +08:00
Nilstrieb	2dfe7de8b6	Handle panicking like rustc CTFE does ... Instead of using `core::fmt::format` to format panic messages, which may in turn panic too and cause recursive panics and other messy things, redirect `panic_fmt` to `const_panic_fmt` like CTFE, which in turn goes to `panic_display` and does the things normally. See the tests for the full call stack.	2024-03-24 15:40:26 +01:00
Lukas Wirth	8e324e98a1	Rename ProcMacroKind::FuncLike to Bang	2024-03-22 11:20:56 +01:00
Lukas Wirth	928d847cc2	Keep the span for Attr::Literal	2024-03-21 10:28:25 +01:00
Lukas Wirth	255a8aef92	Move Edition into span crate	2024-03-21 10:21:44 +01:00
bors	4e54b4bd6c	Auto merge of #16889 - Veykril:utf8-path, r=Veykril ... internal: Enforce utf8 paths Cargo already requires this, and I highly doubt r-a works with non-utf8 paths generally either. This just makes dealing with paths a lot easier.	2024-03-19 14:57:18 +00:00
Lukas Wirth	399dbc074b	internal: Enforce utf8 paths	2024-03-19 15:39:00 +01:00
Shoyu Vanilla	967a864d03	fix: Goto implementation to impls inside blocks	2024-03-19 22:04:48 +09:00
bors	7c2bb75bc8	Auto merge of #16860 - Veykril:macarons, r=Veykril ... feat: Syntax highlighting improvements Specifically - Adds a new `constant` modifier, attached to keyword `const` (except for `*const ()` and `&raw const ()`), `const` items and `const` functions - Adds (or rather reveals) `associated` modifier for associated items - Fixes usage of the standard `static` modifier, now it acts like `associated` except being omitted for methods. - Splits `SymbolKind::Function` into `Function` and `Method`. We already split other things like that (notable self param from params), so the split makes sense in general as a lot special cases around it anyways.	2024-03-18 09:14:08 +00:00
Lukas Wirth	4a93368590	Use a hash to find the correct inlay hint when resolving	2024-03-18 09:51:51 +01:00
Lukas Wirth	3115fd8b41	Simplify inlay hints needs_resolve	2024-03-18 09:50:27 +01:00
roife	109344cfb7	fix: handle attributes when typing curly bracket	2024-03-18 13:29:14 +08:00
Lukas Wirth	20d521db74	Adjust benchmark_syntax_highlighting_parser for changes	2024-03-17 11:38:10 +01:00
Lukas Wirth	77607ab99a	More precise highlighting rules for constant modifier	2024-03-17 11:26:05 +01:00
Lukas Wirth	23fff55f0c	Split SymbolKind::Function into Function and Method	2024-03-17 11:07:22 +01:00
Lukas Wirth	c8f6655327	Don't emit modifiers depending on the symbol kind in lsp conversion layer	2024-03-17 10:40:32 +01:00
Lukas Wirth	66adc1cc94	Emit Const modifier in syntax highlighting for const-like things	2024-03-17 10:35:33 +01:00
bors	b94c2852fa	Auto merge of #16856 - Veykril:macarons, r=Veykril ... fix: Fix wrong where clause rendering on hover We were not accounting for proper newline indentation in some places making the hover look weird (or just straight up wrong for type aliases)	2024-03-16 17:23:02 +00:00
Lukas Wirth	d69a81fddb	fix: Fix wrong where clause rendering on hover	2024-03-16 17:49:59 +01:00
hkalbasi	dcfc9ccace	Distinguish integration tests from crates in test explorer	2024-03-15 17:16:28 +03:30
Lukas Wirth	d2f8eae2ec	feat: Support macro calls in eager macros for IDE features	2024-03-14 15:40:35 +01:00
Wilfred Hughes	30d3d68044	Fix unwanted leading whitespace in hover text ... PR #16366 moved layout information to a separate line, so the leading whitespace is no longer necessary.	2024-03-12 12:27:57 -07:00
Lukas Wirth	9ba4493918	internal: Improve rooted upmapping	2024-03-12 13:46:58 +01:00
bors	8f8bcfc131	Auto merge of #16335 - lnicola:salsa-lz4-file-text, r=Veykril ... internal: Compress file text using LZ4 I haven't tested properly, but this roughly looks like: ``` 1246 MB 59mb 4899 FileTextQuery 1008 MB 20mb 4899 CompressedFileTextQuery 555kb 1790 FileTextQuery ``` We might want to test on something more interesting, like `bevy`.	2024-03-11 13:43:33 +00:00
bors	2f872156fe	Auto merge of #16808 - ShoyuVanilla:proc-macro-sem-token, r=Veykril ... feat: Add proc macro semantic token type Closes #11529	2024-03-11 13:20:29 +00:00
Shoyu Vanilla	fc11216ad5	feat: Add proc macro semantic token type	2024-03-11 22:14:59 +09:00
bors	2320e12541	Auto merge of #16771 - Veykril:self-param-split, r=Veykril ... internal: Don't desugar self param into a pattern Small experiment to see if this simplifies things	2024-03-11 12:45:46 +00:00
bors	1069f57d8b	Auto merge of #16784 - Veykril:body-invalid, r=Veykril ... internal: Remove synstructure const hack support The latest version of it no longer emits these	2024-03-11 09:05:26 +00:00
Lukas Wirth	458f4a2960	internal: Treat the self param as different from patterns when lowering	2024-03-11 09:46:28 +01:00
Lukas Wirth	558feeab61	internal: Remove synstructure const hack support	2024-03-11 09:44:40 +01:00
Laurențiu Nicola	ce642071d8	Bring back in-rust-tree feature to ide	2024-03-10 11:08:11 +02:00
Laurențiu Nicola	aa74d57825	Merge commit '574e23ec508064613783cba3d1833a95fd9a5080' into sync-from-ra	2024-03-10 08:47:38 +02:00
Laurențiu Nicola	0f43b55e83	Stop using an Arc when setting the file text	2024-03-08 20:30:12 +02:00
bors	b85d38f7d6	Auto merge of #16755 - Veykril:rustup-bins, r=Veykril ... For toolchain binaries use the full path found in $PATH Fixes https://github.com/rust-lang/rust-analyzer/issues/16754	2024-03-06 14:47:32 +00:00
hkalbasi	44be2432f5	Add test explorer	2024-03-06 00:05:29 +03:30
roife	9cc3a9cfc2	fix: formatting	2024-03-05 19:55:31 +08:00
roife	16995ceda9	test: add tests for constants inside range pattern	2024-03-05 19:31:20 +08:00
bors	2898c4217d	Auto merge of #16758 - Veykril:cargo-lock, r=Veykril ... Update Cargo.lock	2024-03-05 11:17:42 +00:00
Lukas Wirth	00a6cc0664	Update Cargo.lock	2024-03-05 12:16:19 +01:00
Lukas Wirth	b20e467373	internal: Adjust a few things for trait assoc item hovers	2024-03-05 11:06:36 +01:00
Lukas Wirth	c310aee8d6	For toolchain binaries ue the full path found in $PATH	2024-03-05 10:17:09 +01:00
bors	ce3216e0ae	Auto merge of #15938 - Young-Flash:display_trait_item_when_hover, r=Veykril ... feat: add hover display for trait assoc items This PR enable preview assoc items when hover on `trait`  inspired by https://github.com/rust-lang/rust-analyzer/pull/15847	2024-03-05 08:26:53 +00:00
Lukas Wirth	b9dbb8afd9	Regenerate lints table	2024-03-04 17:42:18 +01:00
Lukas Wirth	0964374274	Move diagnostics docs generation into xtask/codegen	2024-03-04 17:14:14 +01:00
bors	99a1b8f7a8	Auto merge of #16747 - Veykril:cleanup, r=Veykril ... internal: Clean some stuff up Just a bunch of small refactorings, mainly from browsing through `hir-def`	2024-03-04 10:30:17 +00:00
Lukas Wirth	4303e741de	Cleanup	2024-03-04 11:10:06 +01:00
bors	d8feb908be	Auto merge of #16703 - regexident:sema-ast-to-hir, r=Veykril ... Add more methods for resolving definitions from AST to their corresponding HIR types In order to be able to add these methods with consistent naming I had to also rename two existing methods that would otherwise be conflicting/confusing: `Semantics::to_module_def(&self, file: FileId) -> Option<Module>` (before) `Semantics::file_to_module_def(&self, file: FileId) -> Option<Module>` (after) `Semantics::to_module_defs(&self, file: FileId) -> impl Iterator<Item = Module>` (before) `Semantics::file_to_module_defs(&self, file: FileId) -> impl Iterator<Item = Module>` (after) (the PR is motivated by an outside use of the `ra_ap_hir` crate that would benefit from being able to walk a `hir::Function`'s AST, resolving its exprs/stmts/items to their HIR equivalents)	2024-03-04 09:02:32 +00:00
bors	0b7d4cc6ff	Auto merge of #16690 - roife:fix-issue-16471, r=Veykril ... fix: use 4 spaces for indentation in macro expansion Partial fix for #16471. In the previous code, the indentation produced by macro expansion was set to 2 spaces. This PR modifies it to 4 spaces for the sake of consistency.	2024-03-04 08:49:51 +00:00
Laurențiu Nicola	80470d5ce8	Merge commit '4ef6a49b44e8aa380da7522442234bfd7a52c55e' into sync-from-ra	2024-03-03 09:17:31 +02:00
bors	4ef6a49b44	Auto merge of #16702 - Veykril:intra-doc-links-generic, r=Veykril ... fix: Ignore generic arguments in intra doc link path resolution Fixes https://github.com/rust-lang/rust-analyzer/issues/16699	2024-03-02 09:51:16 +00:00
Young-Flash	dba67b46a1	update for review	2024-03-02 10:01:04 +08:00
Lukas Wirth	aabaa47bfb	fix: Don't highlight related assoc items of super traits	2024-03-01 14:03:12 +01:00
bors	b3b9b53df8	Auto merge of #16706 - Veykril:load-cargo-ide-db, r=Veykril ... internal: Remove load-cargo dependency on ide This lightens up the dep tree for projects using r-a as a library that do not need the ide crate itself.	2024-02-29 14:59:27 +00:00
Lukas Wirth	4ee0dbdc04	internal: Remove load-cargo dependency on ide	2024-02-28 16:59:04 +01:00
Shoyu Vanilla	83f6dd14f8	Add a new failing test for Goto index_mut definition	2024-02-29 00:52:30 +09:00
Lukas Wirth	ab533d887d	fix: Ignore generic arguments in intra doc link path resolution	2024-02-28 14:47:47 +01:00
Vincent Esche	6112ddfabb	Add prefix file_ to Semantics's to_module_defs()/to_module_def() methods	2024-02-28 10:27:28 +01:00
Shoyu Vanilla	d1bdebf2b9	Add a new failing test for goto deref_mut	2024-02-27 23:54:05 +09:00
roife	ec5236f3a8	test: use 4 spaces for indetation in macro expansion	2024-02-27 20:53:07 +08:00
Lukas Wirth	91554e0ae7	fix: Fix modules in blocks not resolving in ide layer	2024-02-26 14:54:47 +01:00
Laurențiu Nicola	9e4ecc60a5	Merge commit '4a8d0f7f565b6df45da5522dd7366a4df3460cd7' into sync-from-ra	2024-02-25 09:45:26 +02:00
Young-Flash	2e87f31fe9	add HoverDisplayConfig	2024-02-22 17:37:40 +08:00
Young-Flash	35ec5955eb	add config item for hover display	2024-02-21 11:08:45 +08:00
Young-Flash	00358b1fe0	rebase on lastest master	2024-02-21 10:57:39 +08:00
Young-Flash	dba167592e	feat: add hover display for trait assoc items	2024-02-21 10:57:39 +08:00
bors	c8887241f9	Auto merge of #16606 - Veykril:hover-extern, r=Veykril ... internal: Render assoc item owner in hover for items other than functions Closes https://github.com/rust-lang/rust-analyzer/issues/16603	2024-02-20 13:51:47 +00:00
Lukas Wirth	85203d9721	Render assoc item owner in hover for items other than functions	2024-02-20 13:16:12 +01:00
Lukas Wirth	d93096ecc0	internal: Fetch toolchain and datalayout for DetachedFiles	2024-02-20 10:40:39 +01:00
Lukas Wirth	a822291a02	Infallible definition hovers	2024-02-19 18:16:02 +01:00
UserIsntAvailable	6dd5dc10ef	test: fix disallow_renaming_for_non_local_definition to follow PR changes.	2024-02-19 12:38:00 +01:00
UserIsntAvailable	6e16edb3bf	feat: append as <name> when renaming inside an "UseTree". ... test: include `rename_path_inside_use_tree`. Keeps tracks the progress of the changes. 3 other tests broke with the changes of this. feat: rename all other usages within the current file. feat: fix most of the implementation problems. test: `rename_path_inside_use_tree` tests a more complicated scenario.	2024-02-19 12:24:36 +01:00
Laurențiu Nicola	6b17dba68c	Merge commit 'ac998a74b3c8ff4b81c3eeb9a18811d4cc76226d' into sync-from-ra	2024-02-18 09:41:20 +02:00
Lukas Wirth	ead369117a	CrateOrigin::Local means local to the project workspace, not cargo workspace	2024-02-16 16:28:17 +01:00
Lukas Wirth	b1404d387a	fix: Split toolchain and datalayout out of CrateData	2024-02-16 14:48:25 +01:00
Wilfred Hughes	dda641c62c	Set documentation field in SCIP from doc comment ... Previously, the documentation field was the same as the text shown to users when they hover over that symbol. The documentation should really just be the doc comment, and as of #16179 the signature is already stored in the signatureDocumentation field.	2024-02-14 14:46:32 -08:00
Lukas Wirth	1e6cef94df	fix: Fix build scripts not being rebuilt in some occasions	2024-02-14 15:20:45 +01:00
Chengxu Bian	ca64359945	remove eprintln! overwrite	2024-02-12 23:54:32 -05:00
Tavo Annus	125791386d	Cleanup term search related changes	2024-02-11 14:35:54 +02:00
Laurențiu Nicola	e41ab350d6	Merge commit 'ddf105b646c6749a2de2451c9a499a354eec79c2' into sync-from-ra	2024-02-11 08:40:19 +02:00
bors	1ef7a2329b	Auto merge of #16525 - Veykril:item-loc, r=Veykril ... Abstract more over ItemTreeLoc-like structs Allows reducing some code duplication by using functions generic over said structs. The diff isn't negative due to me adding some additional impls for completeness.	2024-02-10 10:47:37 +00:00
Lukas Wirth	2ebf0c87c2	Deduplicate some code	2024-02-10 01:51:22 +01:00
Tetsuharu Ohzeki	8c2f301a41	ide: Fix warnings about clippy str_to_string rule	2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki	adddd14afb	ide: Fix cargo test -p ide --doc	2024-02-10 00:14:17 +09:00
Tetsuharu Ohzeki	a3e60e7f7a	clippy: Enable needless_doctest_main rule	2024-02-10 00:14:17 +09:00
Lukas Wirth	ddddc9c0e2	Update test outputs	2024-02-08 14:57:21 +01:00
Lukas Wirth	81ea48a573	fix: Fix tuple structs not rendering visibility in their fields	2024-02-08 10:05:28 +01:00
bors	66cec4d11a	Auto merge of #16470 - Veykril:clippy-disallow, r=lnicola ... internal: Lint debug prints and disallowed types with clippy	2024-02-05 17:20:43 +00:00
Laurențiu Nicola	b8a3180a60	Merge commit '0113bc9388b480fa42c632f57f4f0f7af5813ec1' into sync-from-ra	2024-02-04 10:37:58 +02:00
bors	8f6a72871e	Auto merge of #16469 - Young-Flash:ci_typos, r=lnicola ... internal: add typos check CI (part 2) follow up https://github.com/rust-lang/rust-analyzer/pull/16448	2024-02-02 12:02:48 +00:00
Young-Flash	ba2910a3a7	minor: correct some typos	2024-02-02 18:22:54 +08:00
Lukas Wirth	9e8a0fae0c	Lint debug prints and disallowed types with clippy	2024-02-01 17:57:27 +01:00
Johann Hemmann	04ccef80cb	field_reassign_with_default	2024-01-31 19:06:18 +01:00
bors	355c9444e1	Auto merge of #16448 - Young-Flash:typos, r=lnicola ... minor: correct typos I use [crate-ci/typos](https://github.com/crate-ci/typos) to check typos in codebase, if it's ok with you, I'd like to add a typo check CI using [typos](https://github.com/crate-ci/typos) (with Apache-2.0, MIT licenses). BTW, we can add a [_typos.toml](https://github.com/crate-ci/typos/blob/master/docs/reference.md) as white list for some intentional typos	2024-01-31 13:29:55 +00:00
bors	2661c272c9	Auto merge of #16461 - Veykril:expansion-info, r=Veykril ... internal: Remove unnecessary usages of ExpansionInfo And some follow up simplifications to https://github.com/rust-lang/rust-analyzer/pull/16439	2024-01-31 08:58:55 +00:00
Lukas Wirth	d252247ab7	internal: Remove unnecessary usages of ExpansionInfo	2024-01-31 09:57:17 +01:00
bors	e4146af294	Auto merge of #16441 - Young-Flash:exclude_tests_refs, r=Veykril ... feat: enable excluding refs search results in test ## Change Here I introduce a new `ReferenceCategory::Test` type to indicate whether the function where this reference is located is marked as `#[test]`, and expose an config item (`rust-analyzer.references.excludeTests`) to client. I also changed the signature of `ReferenceCategory::new`, adding a `sema: &Semantics<'_, RootDatabase>` param to do some hir analysis. Hope the current implementation is good to go. ## Demo `"rust-analyzer.references.excludeTests": false`  `"rust-analyzer.references.excludeTests": true`  close https://github.com/rust-lang/rust-analyzer/issues/14530	2024-01-31 07:53:28 +00:00
David Barsky	e1ea7c8844	internal: switch to tracing from log ... This commit also adds `tracing` to NotificationDispatcher/RequestDispatcher, bumps `rust-analyzer-salsa` to 0.17.0-pre.6, `always-assert` to 0.2, and removes the homegrown `hprof` implementation in favor of a vendored tracing-span-tree.	2024-01-30 12:27:31 -05:00
Young-Flash	db9fd370ee	minor: correct typos	2024-01-30 21:43:43 +08:00
bors	11b401d0b4	Auto merge of #16447 - Veykril:mir-errors, r=Veykril ... intenral: Cleanup error variants in MIR code a bit	2024-01-30 11:38:41 +00:00
bors	22b6f9679d	Auto merge of #16439 - wasd96040501:feat/gotodef3, r=Veykril ... feat: Support for GOTO def from *inside* files included with include! macro close #14937 Try to implement goto def from *inside* files included with include! macro. This implementation has two limitations: 1. Only **one** file which calls include! will be tracked. (I think multiple file be included is a rare case and we may let it go for now) 2. Mapping token from included file to macro call file (semantics.rs:646~658) works fine but I am not sure is this the correct way to implement.	2024-01-30 11:27:18 +00:00
Lukas Wirth	5860763f18	Cleanup error variants in MIR code slightly	2024-01-30 09:53:39 +01:00
Young-Flash	2b71acac4f	test: add full path ref exclude test case	2024-01-29 18:47:58 +08:00
Laurențiu Nicola	f43cea0878	Merge commit '7219414e81810fd4d967136c4a0650523892c157' into sync-from-ra	2024-01-28 15:56:54 +02:00
Young-Flash	1bd21e98c0	test: add test for excluding refs	2024-01-28 18:39:42 +08:00
Young-Flash	6f303f49fe	feat: enable excluding refs search results in test	2024-01-28 18:28:13 +08:00
YangzeLuo	b22e772cab	feat: Support for GOTO def from *inside* files included with include! macro	2024-01-27 23:36:01 +08:00
Lukas Wirth	8a5829cf28	Re-order mod declarations	2024-01-27 11:02:34 +01:00
Waqar Ahmed	231f730e87	internal: Make TryToNav trait public ... Currently there is no proper way to get a target FileRange for a given Definition.	2024-01-22 15:20:58 +05:00
Laurențiu Nicola	e4866b6ddb	Merge commit 'a9116523604c998e7781f60d3b5a6f586e0414a9' into sync-from-ra	2024-01-21 16:53:06 +02:00
Johann Hemmann	b1a0c9ac40	single_match	2024-01-19 18:31:15 +01:00
Johann Hemmann	159b4c9fe9	search_is_some	2024-01-19 17:52:55 +01:00
Johann Hemmann	71d4dba960	redundant_pattern_matching	2024-01-19 17:31:01 +01:00
Johann Hemmann	9527e245c9	redundant_locals	2024-01-19 17:31:01 +01:00
Johann Hemmann	d351cb8dfb	match_single_binding	2024-01-19 17:31:01 +01:00
bors	2a239b9833	Auto merge of #16401 - Urhengulas:lint-table, r=Veykril ... Expand lint tables && make clippy happy 🎉 This PR expands the lint tables on `./Cargo.toml` and thereby makes `cargo clippy` exit successfully! 🎉 Fixes #15918 ## How? In the beginning there are some warnings for rustc. Next, and most importantly, there is the clippy lint table. There are a few sections in there. First there are the lint groups. Second there are all lints which are permanently allowed with the reasoning why they are allowed. Third there is a huge list of temporarily allowed lints. They should be removed in the mid-term, but incur a substantial amount of work, therefore they are allowed for now and can be worked on bit by bit. Fourth there are all lints which should warn. Additionally there are a few allow statements in the code for lints which should be permanently allowed in this specific place, but not in the whole code base. ## Follow up work - [ ] Run clippy in CI - [ ] Remove tidy test (at least `@Veykril` wrote this in #15017) - [ ] Work on temporarily allowed lints	2024-01-19 16:09:02 +00:00
bors	03d4a6dd9a	Auto merge of #16400 - alibektas:15656/update_bail_message_ref_config, r=Veykril ... Update bail message referencing config Even though we changed the name of the config I forgot to update the warning message that referenced it.	2024-01-19 14:19:11 +00:00
Ali Bektas	0347f81244	Update tests	2024-01-19 15:01:46 +01:00
Johann Hemmann	3041164301	Temporarily allow all lints which occur ... They will be removed one by one	2024-01-19 12:52:12 +01:00
bors	85c9a83262	Auto merge of #16398 - Urhengulas:satisfy-clippy, r=Veykril ... `cargo clippy --fix` This PR is the result of running `cargo clippy --fix && cargo fmt` in the root of the repository. I did not manually review all the changes, but just skimmed through a few of them. The tests still pass, so it seems fine.	2024-01-19 09:43:35 +00:00
bors	6d3141679d	Auto merge of #16385 - Urhengulas:fix-tra-doc-links, r=Veykril ... Fix intra doc links Fixes #15848	2024-01-18 14:00:35 +00:00
bors	a5b89fffb6	Auto merge of #16391 - alibektas:15656/renaming_allowed_by_config, r=Veykril ... Add a new config to allow renaming of non-local defs With #15656 we started disallowing renaming of non-local items. Although this makes sense there are some false positives that impacted users' workflows. So this config aims to mitigate this by giving users the liberty to disable this feature. The reason why this is a draft is that I saw one of the tests fail and I am not sure if the "got" result even syntactically makes sense Test case is : ```rust check( "Baz", r#" //- /lib.rs crate:lib new_source_root:library pub struct S; //- /main.rs crate:main deps:lib new_source_root:local use lib::S$0; "#, "use lib::Baz;" ); ``` ``` Left: use lib::Baz; Right: use lib::Baz;Baz Diff: use lib::Baz;Baz ```	2024-01-18 13:49:14 +00:00
Johann Hemmann	fad4fa163c	cargo clippy --fix	2024-01-18 13:59:49 +01:00
Johann Hemmann	c81728634b	Handle intra-doc links with anchor	2024-01-18 13:36:11 +01:00
Johann Hemmann	bfc2e568dd	Add tests for intra-doc links ... The first one succeeds because the functionality is already implemented. The second one fails and represents the functionality to be implemented in this PR.	2024-01-18 12:59:43 +01:00
Johann Hemmann	f913d4f4b7	Refactor if-else	2024-01-18 12:59:43 +01:00
Lukas Wirth	507448652a	Fix rename test fixtures not accounting for multi file edits	2024-01-18 10:47:02 +01:00
Ali Bektas	9bd9a17ce5	Add a new config to allow renaming of non-local items ... With #15656 we started disallowing renaming of non-local items. Although this makes sense there are some false positives that impacted users' workflows. So this config aims to mitigate this by giving users the liberty to disable this feature.	2024-01-18 00:26:22 +01:00
Lukas Wirth	83591268ab	minor: Make use of some new SmolStr improvements	2024-01-17 13:47:15 +01:00
Lukas Wirth	0bdbf497b6	fix: Fix progress reporting getting stuck	2024-01-17 13:23:00 +01:00
Lukas Wirth	0a75a8c061	Notable traits for type info hovers	2024-01-16 20:15:31 +01:00
Lukas Wirth	ffeaee84af	Goto type actions for notable trait hovers	2024-01-16 19:59:55 +01:00
Lukas Wirth	82e8355492	feat: Show notable trait impls on hover	2024-01-16 19:17:33 +01:00
Lukas Wirth	384488c157	feat: Hover for literals showing additional value information	2024-01-16 14:28:47 +01:00
Lukas Wirth	6584e63506	minor: Simplify	2024-01-16 13:36:07 +01:00
Lukas Wirth	cf905cff76	Put layout comment to the top of hovers	2024-01-16 10:46:53 +01:00
Laurențiu Nicola	6bbd106c70	Merge commit '9d8889cdfcc3aa0302353fc988ed21ff9bc9925c' into sync-from-ra	2024-01-15 11:40:09 +02:00
Lukas Wirth	06aaf20f10	Some minor perf improvements	2024-01-09 20:43:17 +01:00
Lukas Wirth	7dd9f20ce3	Builtin derives are hygienic	2024-01-08 12:50:11 +01:00
Laurențiu Nicola	3afeb24198	Merge commit 'af40101841c45aa75b56f4e9ca745369da8fb4ba' into sync-from-ra	2024-01-08 11:29:25 +02:00
bors	6ce3f44597	Auto merge of #16298 - riverbl:exclusive-range-hint, r=Veykril ... feat: Add inlay hint for exclusive ranges Adds an inlay hint containing a '<' character to exclusive range expressions and patterns that specify an upper bound.  Inspired by [this comment](https://github.com/rust-lang/rust/issues/37854#issuecomment-1865124907) noting that IntelliJ Rust has this feature.	2024-01-07 10:21:39 +00:00
riverbl	3c378b9c70	Add inlay hint for exclusive ranges ... Adds an inlay hint containing a '<' character to exclusive range expressions and patterns that specify an upper bound.	2024-01-07 09:33:56 +00:00
Matthias Krüger	b22bd36f6e	remove more redundant clones manually	2024-01-07 00:26:49 +01:00
bors	f8eab9b7d2	Auto merge of #16279 - Veykril:ide-tuple-fields, r=Veykril ... feat: IDE features for primitive tuple fields Fixes https://github.com/rust-lang/rust-analyzer/issues/13018	2024-01-06 18:30:10 +00:00
Lukas Wirth	963568b46f	feat: IDE features for primitive tuple fields	2024-01-06 15:04:58 +01:00
bors	e53792b7cb	Auto merge of #16256 - Urhengulas:ide-runnables-assert_eq, r=Veykril ... internal: Only compare relevant parts in `ide::{runnables,inlay_hints}` tests This PR limits the data being compared. Therefore the tests should be more readable, as well as being more robust to changes to the data structure. Part of https://github.com/rust-lang/rust-analyzer/issues/14268.	2024-01-05 13:49:30 +00:00
bors	c84352a346	Auto merge of #16261 - Veykril:import-map-fix, r=Veykril ... internal: Move query limits to the caller Prior we calculated up to `limit` entries from a query, then filtered from that leaving us with less entries than the limit in some cases (which might give odd completion behavior due to items disappearing). This changes it so we filter before checking the limit.	2024-01-04 18:27:38 +00:00
Lukas Wirth	2666349392	Remove limit from symbol_index::Query	2024-01-04 19:20:10 +01:00
Johann Hemmann	f8ff4fb75b	Conditionally include use_name_in_title and cfg	2024-01-04 18:47:08 +01:00
Johann Hemmann	61b552124a	Move check_expect and check_expect_clear_loc to inlayhints::chaining	2024-01-04 17:32:16 +01:00
Johann Hemmann	594e0a5de6	Only compare range and label	2024-01-04 17:29:20 +01:00
Johann Hemmann	dbeb27e05d	Refactor check	2024-01-04 16:10:34 +01:00
Johann Hemmann	971fc1b3e8	Also compare navigation targets for tests	2024-01-04 15:21:57 +01:00
Johann Hemmann	9bc005a3bf	Only iterate through runnables once	2024-01-04 15:14:05 +01:00
Johann Hemmann	3f8083fc81	Only compare navigation targets	2024-01-04 15:14:05 +01:00
Johann Hemmann	f3770c14cf	Compare test ids instead of names, seems more robust	2024-01-04 15:14:05 +01:00
Johann Hemmann	e9632bd48b	Only compare test name	2024-01-04 15:14:05 +01:00
Johann Hemmann	656ac104c9	Do not extract FileId for file_system_edits	2024-01-04 14:29:41 +01:00
Johann Hemmann	ea675ab888	Insert newline at the end	2024-01-04 14:01:03 +01:00
Johann Hemmann	f2b872a3c5	Switch to Vec, because we do want to have duplicate keys	2024-01-04 14:01:03 +01:00
Johann Hemmann	dea149d733	Switch to BTreeMap for stable ordering	2024-01-04 14:01:03 +01:00
Johann Hemmann	05a3c2ff20	Make filtering a function	2024-01-04 14:01:03 +01:00
Johann Hemmann	d1f4171bb6	Refactor to iterators	2024-01-04 14:01:03 +01:00
Johann Hemmann	084acc287a	Extract relevant information into hashmaps	2024-01-04 14:01:02 +01:00
bors	c3c07c66d3	Auto merge of #15933 - 71:inherent-items-in-docs, r=Veykril ... feat: resolve inherent and implemented associated items in docs This partially fixes #9694. Supported: - Trait methods and constants. * Due to resolution differences pointed out during the review of the PR, trait associated types are _not_ supported. - Inherent methods, constants and associated types. * Inherent associated types are a [nightly feature](https://github.com/rust-lang/rust/issues/8995), and are supported with no additional work in this PR. Screenshot of VS Code running with the change: <img width="513" alt="image" src="https://github.com/rust-lang/rust-analyzer/assets/7189784/c37ed8b7-b572-4684-8e81-2a817b0027c4"> You can see that the items are resolved (excl. trait associated types) since they are semantically highlighted in the doc comment.	2024-01-03 14:28:38 +00:00
Grégoire Geis	fe6f931ac2	hir: resolve associated items in docs (excl. type aliases)	2024-01-03 23:04:24 +09:00
bors	078183231b	Auto merge of #16179 - nicolas-guichard:scip/new_fields, r=Veykril ... SCIP: populate new SymbolInformation fields Fixes #15919	2024-01-03 12:56:47 +00:00
Nicolas Guichard	73d9c77f2a	scip: Populate SymbolInformation::kind ... SymbolInformation::kind is finer-grained than the SCIP symbol suffix. This also fixes a bug where all type aliases where treated like type parameters. ``` trait SomeTrait { type AssociatedType; // ← this is SomeTrait#[AssociatedType] } type MyTypeAlias = u8; // ← this used to be [MyTypeAlias] // and now is MyTypeAlias# ```	2024-01-03 13:05:36 +01:00
Lukas Wirth	cf22f02dc5	fix: Fix focus range being discarded in attributes/derives when upmapping	2024-01-03 12:15:28 +01:00
Nicolas Guichard	566bb77f91	scip: Populate SymbolInformation::signature_documentation	2024-01-03 10:56:12 +01:00
Nicolas Guichard	b24914970f	Refactor label & docs from ide::hover::render to ide-db::defs::Definition ... To build the SymbolInformation::signature_documentation we need access to the “label” when building the TokenStaticData, preferably without any markdown markup. Therefore this refactors ide::hover::render::definition and its helper functions to give easier access to the label alone.	2024-01-03 10:54:57 +01:00
Nicolas Guichard	495a55689b	scip: Populate SymbolInformation::enclosing_symbol ... For local variables, this gets the moniker from the enclosing definition and stores it into the TokenStaticData. Then it builds the scip symbol for that moniker when building the SymbolInformation.	2024-01-03 10:54:57 +01:00
Nicolas Guichard	375f1cca4f	scip: Populate SymbolInformation::display_name	2024-01-03 10:54:57 +01:00
Laurențiu Nicola	932d85b529	Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2	2024-01-03 11:35:07 +02:00
bors	86e559bf3f	Auto merge of #16211 - tetsuharuohzeki:update-lint, r=Veykril ... Use Cargo's [workspace.lints.*] to config clippy This change begin to use [`[workspace.lints.*]`](https://doc.rust-lang.org/cargo/reference/workspaces.html#the-lints-table) that is stabilized since [Rust 1.74](https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html). By this change, we make the configure more readable and simplify `xargo lint` more.	2024-01-02 14:53:22 +00:00
Lukas Wirth	06be1b1f34	minor: Render more crate information in status command	2024-01-01 13:32:04 +01:00
Tetsuharu Ohzeki	efc87092b3	Use Cargo's [workspace.lints.*] to config clippy	2023-12-29 23:51:32 +09:00
bors	23a1280106	Auto merge of #16137 - unexge:complete-macros-in-macro-use, r=Veykril ... Complete exported macros in `#[macro_use($0)]` Closes https://github.com/rust-lang/rust-analyzer/issues/15657. Originally added a test case for incomplete input: ```rust #[test] fn completes_incomplete_syntax() { check( r#" //- /dep.rs crate:dep #[macro_export] macro_rules! foo { () => {}; } //- /main.rs crate:main deps:dep #[macro_use($0 extern crate dep; "#, expect![[r#" ma foo "#]], ) } ``` but couldn't make it pass and removed it 😅 Our current recovering logic doesn't work for token trees and for this code: ```rust #[macro_use( extern crate lazy_static; fn main() {} ``` we ended up with this syntax tree: ``` SOURCE_FILE@0..53 ATTR@0..52 POUND@0..1 "#" L_BRACK@1..2 "[" META@2..52 PATH@2..11 PATH_SEGMENT@2..11 NAME_REF@2..11 IDENT@2..11 "macro_use" TOKEN_TREE@11..52 L_PAREN@11..12 "(" WHITESPACE@12..13 "\n" EXTERN_KW@13..19 "extern" WHITESPACE@19..20 " " CRATE_KW@20..25 "crate" WHITESPACE@25..26 " " IDENT@26..37 "lazy_static" SEMICOLON@37..38 ";" WHITESPACE@38..40 "\n\n" FN_KW@40..42 "fn" WHITESPACE@42..43 " " IDENT@43..47 "main" TOKEN_TREE@47..49 L_PAREN@47..48 "(" R_PAREN@48..49 ")" WHITESPACE@49..50 " " TOKEN_TREE@50..52 L_CURLY@50..51 "{" R_CURLY@51..52 "}" WHITESPACE@52..53 "\n" ``` Maybe we can try to parse the token tree in `crates/ide-completion/src/context/analysis.rs` but I'm not sure what's the best way forward.	2023-12-22 10:42:38 +00:00
bors	337e2abb67	Auto merge of #16167 - Veykril:dummy-spans, r=Veykril ... fix: Fully remove dummy spans Fixes https://github.com/rust-lang/rust-analyzer/issues/16008 Some of these spans are certainly wrong, but since we discard invisible delimiters currently it doesn't really matter.	2023-12-20 13:33:36 +00:00
Lukas Wirth	4ec81230db	Remove usages of Span::DUMMY	2023-12-20 12:53:46 +01:00
bors	7bdf48ce37	Auto merge of #16165 - Veykril:meta-vars, r=Veykril ... fix: Update metavariable expression implementation Fixes https://github.com/rust-lang/rust-analyzer/issues/16154 This duplicates behavior of that before and after PR https://github.com/rust-lang/rust/pull/117050 based on the toolchain version. There are some 1.76 nightlies that are still broken (any before that PR basically) but fetching and storing the commit makes little sense to me (opposed to the toolchain version).	2023-12-20 10:30:58 +00:00
Lukas Wirth	f48ecb6e09	Try to support pre and post-change metavars	2023-12-19 20:45:12 +01:00
bors	7204ee1262	Auto merge of #16163 - Veykril:goto-impl-fix, r=Veykril ... fix: Deduplicate annotations Fixes https://github.com/rust-lang/rust-analyzer/issues/16157	2023-12-19 07:50:23 +00:00
Lukas Wirth	002e611d09	fix: Deduplicate annotations	2023-12-19 08:49:00 +01:00
bors	dbd0b035e6	Auto merge of #16155 - Waqar144:work/fix-16142, r=lnicola ... fix: Dont assume ascii in remove_markdown Fixes #16142	2023-12-19 07:22:46 +00:00
bors	1c4c2200eb	Auto merge of #16160 - Waqar144:work/use-reserve, r=Veykril ... minor: Use reserve when removing markdown from text After markdown syntax removal the length of the text is roughly the same so we can reserve memory beforehand	2023-12-19 07:11:20 +00:00
Waqar Ahmed	13177e314d	minor: Use reserve when removing markdown from text ... After markdown syntax removal the length of the text is roughly the same so we can reserve memory beforehand	2023-12-19 11:22:02 +05:00
Waqar Ahmed	9f4d26901b	minor: use a single push_str instead of 2 push	2023-12-19 11:17:09 +05:00
Waqar Ahmed	5318e89b8a	fix: Dont assume ascii in remove_markdown ... Fixes #16142	2023-12-19 01:27:36 +05:00
Lukas Wirth	f49a2fed3f	internal: Move out WithFixture into dev-dep only crate	2023-12-18 15:24:08 +01:00
Lukas Wirth	35620306a6	internal: Move proc-macro knowledge out of base-db	2023-12-18 12:37:18 +01:00
Laurențiu Nicola	e37cf75791	Merge commit '21b06c1beb9bb59369ffd652f5d617bcf6952e05' into sync-from-ra	2023-12-18 09:21:55 +02:00
unexge	3b8801c3ac	Go to definition for macros in #[macro_use(...)]	2023-12-16 18:00:29 +00:00
hkalbasi	7b9595a5ab	Run rust-analyzer on rustc tests in metrics	2023-12-15 02:10:25 +03:30
Kirill Bulatov	8ae42b55e7	Search for parent blocks and items when resolving inlay hints	2023-12-11 15:16:55 +02:00
Kirill Bulatov	be6d34b810	Query for nearest parent block around the hint to resolve ... This way, parameter hints will be found for resolution	2023-12-11 14:53:51 +02:00
Laurențiu Nicola	f532576ac5	Merge commit '457b966b171b09a7e57acb710fbca29a4b3526f0' into sync-from-ra	2023-12-11 11:16:01 +02:00
Lukas Wirth	306c907425	fix: Fix view mir, hir and eval function not working when cursor is inside macros	2023-12-10 14:44:40 +01:00
Lukas Wirth	cf083fefc4	fix: Fix completion failing in format_args! with invalid template	2023-12-08 20:35:33 +01:00
Lukas Wirth	35fbc0210c	Fallback to method resolution on unresolved field access with matching method name	2023-12-08 16:36:41 +01:00
bors	bc9c952b6d	Auto merge of #16028 - Young-Flash:fix-issue-16012, r=HKalbasi ... fix: make drop inlay hint more readable  follow up https://github.com/rust-lang/rust-analyzer/pull/16000, close https://github.com/rust-lang/rust-analyzer/issues/16012	2023-12-07 21:45:24 +00:00
Lukas Wirth	80dc20f7d8	fix: Don't print proc-macro panic backtraces in the logs	2023-12-06 17:49:48 +01:00
Lukas Wirth	634d588fd7	Simplify	2023-12-06 14:36:39 +01:00
Lukas Wirth	9cb13b6efb	Allow navigation targets to be duplicated when the focus range lies in the macro definition site	2023-12-06 12:38:19 +01:00
Lukas Wirth	9b7ec5e31b	Ignore strings in token trees in syntax highlighting	2023-12-05 17:07:00 +01:00
Lukas Wirth	4525787ed5	Add test for implicit format args support through nested macro call	2023-12-05 17:07:00 +01:00
Lukas Wirth	fe0a85ca29	Resolve implicit format args in syntax highlighting	2023-12-05 17:07:00 +01:00
Lukas Wirth	d2cd30007c	Implicit format args support	2023-12-05 17:07:00 +01:00
Lukas Wirth	5b8e386bae	Improve macro descension API	2023-12-05 17:06:57 +01:00
Young-Flash	afc4075c7c	fix: make drop inlay hint more readable	2023-12-05 22:56:51 +08:00
Igor Matuszewski	a7224c998d	Don't explicitly warn against semicolon_in_expressions_from_macros ... This has been warn-by-default for two years now and has already been added to the future-incompat lints in 1.68.	2023-12-05 11:35:09 +01:00
bors	e91fdf7860	Auto merge of #15959 - Veykril:macro-shower3, r=lnicola ... TokenMap -> SpanMap rewrite Opening early so I can have an overview over the full diff more easily, still very unfinished and lots of work to be done. The gist of what this PR does is move away from assigning IDs to tokens in arguments and expansions and instead gives the subtrees the text ranges they are sourced from (made relative to some item for incrementality). This means we now only have a single map per expension, opposed to map for expansion and arguments. A few of the things that are not done yet (in arbitrary order): - [x] generally clean up the current mess - [x] proc-macros, have been completely ignored so far - [x] syntax fixups, has been commented out for the time being needs to be rewritten on top of some marker SyntaxContextId - [x] macro invocation syntax contexts are not properly passed around yet, so $crate hygiene does not work in all cases (but most) - [x] builtin macros do not set spans properly, $crate basically does not work with them rn (which we use) ~~- [ ] remove all uses of dummy spans (or if that does not work, change the dummy entries for dummy spans so that tests will not silently pass due to havin a file id for the dummy file)~~ - [x] de-queryfy `macro_expand`, the sole caller of it is `parse_macro_expansion`, and both of these are lru-cached with the same limit so having it be a query is pointless - [x] docs and more docs - [x] fix eager macro spans and other stuff - [x] simplify include! handling - [x] Figure out how to undo the sudden `()` expression wrapping in expansions / alternatively prioritize getting invisible delimiters working again - [x] Simplify InFile stuff and HirFIleId extensions ~~- [ ] span crate containing all the file ids, span stuff, ast ids. Then remove the dependency injection generics from tt and mbe~~ Fixes https://github.com/rust-lang/rust-analyzer/issues/10300 Fixes https://github.com/rust-lang/rust-analyzer/issues/15685	2023-12-04 19:59:53 +00:00
Laurențiu Nicola	30fc9329d1	Merge commit 'e402c494b7c7d94a37c6d789a216187aaf9ccd3e' into sync-from-ra	2023-12-04 09:19:15 +02:00
Lukas Wirth	81410ab500	Cleanup FileId stuff	2023-12-02 19:32:53 +01:00
Lukas Wirth	02a3a9438a	Some more minor cleanups	2023-12-02 17:04:13 +01:00
hkalbasi	4d55cac466	Initial support for implicit drop inlay hint	2023-12-01 16:16:46 +03:30
Lukas Wirth	92d447f976	🧹	2023-11-28 10:55:40 +01:00
Lukas Wirth	c43078f99d	Re-implement InFile wrappers as type aliases over generic InFileWrapper	2023-11-28 10:55:40 +01:00
Lukas Wirth	30093a6d81	spans always come from real file	2023-11-28 10:55:39 +01:00
Lukas Wirth	890eb17b4e	Replace ID based TokenMap with proper relative text-ranges / spans	2023-11-28 10:55:39 +01:00
Laurențiu Nicola	81606ecf68	Merge commit '237712fa314237e428e7ef2ab83b979f928a43a1' into sync-from-ra	2023-11-27 12:40:39 +02:00
David Tolnay	b68f5311b5	Replace option.map(cond) == Some(true) with option.is_some_and(cond)	2023-11-24 09:06:44 -08:00
bors	375142902c	Auto merge of #15885 - RunDevelopment:patch-1, r=lnicola ... Fix typo in highlight_related.rs While reading the user manual, I noticed a random tick, so I went ahead and fixed it. The `await` keyword should be properly rendered as inline code. 	2023-11-20 17:37:59 +00:00
Laurențiu Nicola	59f5d51852	Merge commit '141fc695dca1df7cfc3c9803972ec19bb178dcbc' into sync-from-ra	2023-11-16 22:27:35 +02:00
Laurențiu Nicola	cb8434e594	Bump either	2023-11-15 13:07:36 +02:00
Laurențiu Nicola	f53368dd3f	Bump tracing	2023-11-15 13:00:32 +02:00
Laurențiu Nicola	f66df10f87	Bump itertools	2023-11-15 12:53:56 +02:00
Laurențiu Nicola	6b53c09ef5	Merge branch 'master' into sync-from-rust	2023-11-15 09:46:27 +02:00
Laurențiu Nicola	610eafe009	Merge commit '76633199f4316b9c659d4ec0c102774d693cd940' into sync-from-rust	2023-11-15 09:45:17 +02:00
Lukas Wirth	d5faad1dae	Fix inlay-hint tests being invalidated by minicore chanes	2023-11-14 18:53:48 +01:00
Laurențiu Nicola	b6951defa6	Add missing rustc_private features	2023-11-13 21:38:57 +02:00
Michael Schmidt	67058605d8	FIxed typo in highlight_related.rs	2023-11-13 13:13:39 +01:00
Laurențiu Nicola	cace36cade	Make Expand macro command title more explicit	2023-11-12 11:43:46 +02:00
bors	5afaf680b8	Auto merge of #15864 - Young-Flash:find_self, r=lnicola ... fix: find `Self` reference took a lot of time to debug to find the problem, here should compare the actual `Adt` type close https://github.com/rust-lang/rust-analyzer/issues/12693	2023-11-10 13:13:14 +00:00
Young-Flash	e0276dc5dd	fix: find Self reference	2023-11-10 19:54:43 +08:00
YangzeLuo	41bcd542e2	feat: preview adt field when hover	2023-11-08 21:45:32 +08:00
Laurențiu Nicola	d1d111d09e	Merge commit '3b7c7f97e4a7bb253a8d398ee4f8346f6cf2817b' into sync-from-ra	2023-11-08 08:15:03 +02:00
Laurențiu Nicola	19bf0da9d7	Fix docs path for derive macros	2023-11-04 13:33:19 +02:00
Lukas Wirth	40acc5250f	Update rustc_abi dependency	2023-10-15 18:57:40 +02:00
cui fliter	58239f2990	Remove repetitive words ... Signed-off-by: cui fliter <imcusg@gmail.com>	2023-10-05 19:40:41 +08:00
Lukas Wirth	fe398163b6	Recognize custom main function as binary entrypoint for runnables	2023-10-04 12:07:41 +02:00
DaniPopes	53f5c1c13f	internal: re-generate lints.rs	2023-09-29 14:20:17 +02:00
bors	972a19f4cb	Auto merge of #15659 - HKalbasi:unused-var, r=HKalbasi ... Add `unused_variables` native diagnostic	2023-09-25 06:38:14 +00:00
DaniPopes	588c7d9182	minor: hover_simple refactor	2023-09-24 22:47:29 +02:00
hkalbasi	ab52ba2de7	Fix unused_variables in tests	2023-09-24 23:45:36 +03:30
Tom Alexander	91b012f91d	Documentation: Add parenthesis to the list of on-typing assists.	2023-09-21 14:58:24 -04:00
Laurențiu Nicola	bcfc997eac	Merge commit '258b15c506a2d3ad862fd17ae24eaf272443f477' into sync-from-ra	2023-09-18 12:33:49 +03:00
bors	089ae47ebe	Auto merge of #15606 - Veykril:annotation-above-item-fi, r=Veykril ... fix: Fix lens location "above_whole_item" breaking lenses Fixes https://github.com/rust-lang/rust-analyzer/issues/15602	2023-09-13 20:02:06 +00:00
Lukas Wirth	712e67cf11	fix: Fix lens location "above_whole_item" breaking lenses	2023-09-13 22:01:04 +02:00
Ali Bektas	6dc7fa9423	v3	2023-09-10 23:19:58 +02:00
Ali Bektas	43edb51b21	Generalize disallowing of definition renaming	2023-09-10 23:19:58 +02:00
Ali Bektas	7ae70a06ce	Disallow renaming of non-local structs	2023-09-10 23:19:58 +02:00
Lukas Wirth	ccff704c25	Shrink some stuff	2023-09-10 08:24:26 +02:00
bors	70a6cf0ef7	Auto merge of #15522 - SomeoneToIgnore:resolve-inlay-hints, r=Veykril ... Resolve inlay hint data Part of https://github.com/rust-lang/rust-analyzer/issues/13962 Support https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#inlayHint_resolve better, by omitting all inlay hint fields specified in the client hint resolve capabilities. Current list of all capabilities possible to resolve later: ``` "textEdits" "tooltip" "label.tooltip" "label.location" "label.command" ``` and every one specified in the client capabilities is now resolved by r-a, being omitted in the initial response. -------------- When editing `inlay_hints.rs` file around line `457` with no resolve capabilities, I get <details> <summary>resolved json, 10803 characters</summary> ```json {"jsonrpc":"2.0","id":55,"result":[{"position":{"line":477,"character":1},"label":[{"value":"fn inlay_hints","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/ide/src/inlay_hints.rs","range":{"start":{"line":445,"character":14},"end":{"line":445,"character":25}}}}],"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":451,"character":10},"label":[{"value":": "},{"value":"ProfileSpan","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/profile/src/hprof.rs","range":{"start":{"line":85,"character":11},"end":{"line":85,"character":22}}}},{"value":""}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":451,"character":27},"label":[{"value":"label:","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/profile/src/hprof.rs","range":{"start":{"line":60,"character":12},"end":{"line":60,"character":17}}}}],"kind":2,"paddingLeft":false,"paddingRight":true,"data":{"file_id":0}},{"position":{"line":452,"character":12},"label":[{"value":": "},{"value":"Semantics","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/hir/src/semantics.rs","range":{"start":{"line":108,"character":11},"end":{"line":108,"character":20}}}},{"value":"<'_, "},{"value":"RootDatabase","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/ide-db/src/lib.rs","range":{"start":{"line":75,"character":11},"end":{"line":75,"character":23}}}},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":453,"character":12},"label":[{"value":": "},{"value":"SourceFile","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/ast/generated/nodes.rs","range":{"start":{"line":223,"character":11},"end":{"line":223,"character":21}}}},{"value":""}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":454,"character":12},"label":[{"value":": &"},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":456,"character":12},"label":": i32","kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":458,"character":15},"label":[{"value":": "},{"value":"Vec","location":{"uri":"file:///Users/someonetoignore/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/alloc/src/vec/mod.rs","range":{"start":{"line":395,"character":11},"end":{"line":395,"character":14}}}},{"value":"<"},{"value":"InlayHint","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/ide/src/inlay_hints.rs","range":{"start":{"line":149,"character":11},"end":{"line":149,"character":20}}}},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":460,"character":21},"label":[{"value":": "},{"value":"SemanticsScope","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/hir/src/semantics.rs","range":{"start":{"line":1651,"character":11},"end":{"line":1651,"character":25}}}},{"value":"<'_>"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":460,"character":36},"label":[{"value":"node:","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/hir/src/semantics.rs","range":{"start":{"line":482,"character":24},"end":{"line":482,"character":28}}}}],"kind":2,"paddingLeft":false,"paddingRight":true,"data":{"file_id":0}},{"position":{"line":461,"character":23},"label":[{"value":": "},{"value":"FamousDefs","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/ide-db/src/famous_defs.rs","range":{"start":{"line":20,"character":11},"end":{"line":20,"character":21}}}},{"value":"<'_, '_>"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":463,"character":17},"label":[{"value":": impl FnMut("},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">)"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":463,"character":25},"label":[{"value":": "},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":463,"character":33},"label":[{"value":"hints:","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/ide/src/inlay_hints.rs","range":{"start":{"line":480,"character":4},"end":{"line":480,"character":9}}}}],"kind":2,"paddingLeft":false,"paddingRight":true,"data":{"file_id":0}},{"position":{"line":465,"character":22},"label":[{"value":": "},{"value":"TextRange","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/text-size-1.1.0/src/range.rs","range":{"start":{"line":14,"character":11},"end":{"line":14,"character":20}}}},{"value":""}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":467,"character":35},"label":[{"value":": "},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":469,"character":92},"label":[{"value":"impl "},{"value":"Iterator","location":{"uri":"file:///Users/someonetoignore/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs","range":{"start":{"line":72,"character":10},"end":{"line":72,"character":18}}}},{"value":"<"},{"value":"Item","location":{"uri":"file:///Users/someonetoignore/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs","range":{"start":{"line":76,"character":9},"end":{"line":76,"character":13}}}},{"value":" = "},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">>"}],"kind":1,"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":468,"character":34},"label":[{"value":"impl "},{"value":"Iterator","location":{"uri":"file:///Users/someonetoignore/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs","range":{"start":{"line":72,"character":10},"end":{"line":72,"character":18}}}},{"value":"<"},{"value":"Item","location":{"uri":"file:///Users/someonetoignore/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs","range":{"start":{"line":76,"character":9},"end":{"line":76,"character":13}}}},{"value":" = "},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">>"},{"value":""}],"kind":1,"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":467,"character":41},"label":[{"value":""},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">"}],"kind":1,"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":469,"character":40},"label":" -> bool","kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":469,"character":39},"label":[{"value":": &"},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}}]} ``` </details> for the visible editor range alone, pretty much repeated on every consequent edit. With this patch and all inlay hint resolve capabilities enabled, for the same example I observe quite a footprint reduction: <details> <summary>unresolved json, 4142 characters</summary> ```json {"jsonrpc":"2.0","id":49,"result":[{"position":{"line":477,"character":1},"label":[{"value":"fn inlay_hints"}],"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":451,"character":10},"label":[{"value":": "},{"value":"ProfileSpan"},{"value":""}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":451,"character":27},"label":[{"value":"label:"}],"kind":2,"paddingLeft":false,"paddingRight":true,"data":{"file_id":0}},{"position":{"line":452,"character":12},"label":[{"value":": "},{"value":"Semantics"},{"value":"<'_, "},{"value":"RootDatabase"},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":453,"character":12},"label":[{"value":": "},{"value":"SourceFile"},{"value":""}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":454,"character":12},"label":[{"value":": &"},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":456,"character":12},"label":": i32","kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":458,"character":15},"label":[{"value":": "},{"value":"Vec"},{"value":"<"},{"value":"InlayHint"},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":460,"character":21},"label":[{"value":": "},{"value":"SemanticsScope"},{"value":"<'_>"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":460,"character":36},"label":[{"value":"node:"}],"kind":2,"paddingLeft":false,"paddingRight":true,"data":{"file_id":0}},{"position":{"line":461,"character":23},"label":[{"value":": "},{"value":"FamousDefs"},{"value":"<'_, '_>"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":463,"character":17},"label":[{"value":": impl FnMut("},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">)"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":463,"character":25},"label":[{"value":": "},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":463,"character":33},"label":[{"value":"hints:"}],"kind":2,"paddingLeft":false,"paddingRight":true,"data":{"file_id":0}},{"position":{"line":465,"character":22},"label":[{"value":": "},{"value":"TextRange"},{"value":""}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":467,"character":35},"label":[{"value":": "},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":469,"character":92},"label":[{"value":"impl "},{"value":"Iterator"},{"value":"<"},{"value":"Item"},{"value":" = "},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">>"}],"kind":1,"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":468,"character":34},"label":[{"value":"impl "},{"value":"Iterator"},{"value":"<"},{"value":"Item"},{"value":" = "},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">>"},{"value":""}],"kind":1,"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":467,"character":41},"label":[{"value":""},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">"}],"kind":1,"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":469,"character":40},"label":" -> bool","kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":469,"character":39},"label":[{"value":": &"},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}}]} ``` </details> with all unresolved parts needing only for navigation, hover or applying the hint edit — dynamic parts that are made after mouse hover or similar events, that resolve the hint data.	2023-09-08 11:12:27 +00:00
bors	77b359ae31	Auto merge of #15532 - SomeoneToIgnore:more-brackets-on-type-formatting, r=Veykril ... On type format '(', by adding closing ')' automatically If I understand right, `()` can surround pretty much the same `{}` can, so add another on type formatting pair for convenience: sometimes it's not that pleasant to write parenthesis in `Some(2).map(|i| (i, i+1))` cases and I would prefer r-a to do that for me. One note: currently, b06503b6ec/crates/rust-analyzer/src/handlers/request.rs (L357) fires always. Should we remove the assertion entirely now, since apparently things work in release despite that check?	2023-09-06 20:32:04 +00:00
Lukas Wirth	c0e402637e	Emit builtin#format_args in builtin format_args expander	2023-09-06 18:08:20 +02:00
Lukas Wirth	3431d586e5	Insert builtin#asm into asm! expansion	2023-09-05 14:00:49 +02:00
Lukas Wirth	9b8eb807a3	Parse builtin# syntax	2023-09-05 10:36:35 +02:00
Kirill Bulatov	7f450da39e	Omit hint resolve data better ... Omit sending inlay hint resolve data if inlay has no properties that client resolve capabilities support.	2023-09-02 23:56:48 +03:00
Kirill Bulatov	7b3dba5d77	Provide resolve data only when it can actually be resolved	2023-09-02 22:14:08 +03:00
Kirill Bulatov	10464c7c42	Simplify InlayFieldsToResolve handling	2023-09-02 18:28:36 +03:00
Kirill Bulatov	e07fbabcfe	Resolve inlay hint data ... Skip every propery set in inlay hint client resolve capabilities, reducing overall json footprint.	2023-09-02 18:28:35 +03:00
Lukas Wirth	81f0108067	Remove markdown module from rust-analyzer crate	2023-09-02 17:27:52 +02:00
Lukas Wirth	8eddc64f86	Simplify	2023-09-02 17:12:57 +02:00
Lukas Wirth	b1575528c0	Move doc comment handling into ide-db	2023-09-02 16:27:26 +02:00
Kirill Bulatov	0f1cde709a	On type format '(', by adding closing ')' automatically	2023-09-01 21:49:50 +03:00
Lukas Wirth	c09f175d59	Less once_cell more std	2023-09-01 17:30:59 +02:00
Laurențiu Nicola	30d8aa1bec	Merge commit '9b3d03408c66749d56466bb09baf2a7177deb6ce' into sync-from-ra	2023-08-21 12:44:09 +03:00
Lukas Wirth	53b292478d	internal: Add offset param to token descending API	2023-08-16 10:07:18 +02:00
ponyii	fec5ff9890	start hovering default values of generic constants	2023-08-15 20:26:42 +04:00
bors	0fa822dfe1	Auto merge of #15418 - oxalica:fix/sig-from-macro, r=Veykril ... Fix signature help of methods from macros Currently the receiver type is copied from AST instead re-formatting through `HirDisplay`. Macro generated functions seem to have no spaces and their signature help are rendered like `fn foo(&'amutself)` instead of `fn foo(&'a mut self)`.	2023-08-15 06:25:13 +00:00
Lukas Wirth	d6d188fce2	fix: Fix only_types config filtering out traits from world symbols	2023-08-12 06:40:49 +02:00
oxalica	de86444756	Prefer hir::SelfParam and fix signature help of methods from macros	2023-08-09 02:42:08 +08:00
oxalica	3bfe1d5d78	Display fully qualified associated types correctly ... Currently they are formatted in the internal `Trait<Self = Type>::Assoc` forms where `hir_ty::TypeRef` is formatted, like hover.	2023-08-09 00:04:55 +08:00