bors[bot]
|
fcf15cc05a
|
Merge #3169
3169: Show record field names in Enum completion r=flodiebold a=adamrk
Adresses https://github.com/rust-analyzer/rust-analyzer/issues/2947.
Previously the details shown when autocompleting an Enum variant would look like the variant was a tuple even if it was a record:
![2020-02-16-15:59:32_crop](https://user-images.githubusercontent.com/16367467/74607233-64f21980-50d7-11ea-99db-e973e29c71d7.png)
This change will show the names of the fields for a record and use curly braces instead of parentheses:
![2020-02-16-15:33:00_crop](https://user-images.githubusercontent.com/16367467/74607251-8ce17d00-50d7-11ea-9d4d-38d198a4aec0.png)
This required exposing the type `adt::StructKind` from `ra_hir` and adding a function
```
kind(self, db: &impl HirDatabase) -> StructKind
```
in the `impl` of `EnumVariant`.
There was also a previously existing function `is_unit(self, db: &impl HirDatabase) -> bool` for `EnumVariant` which I removed because it seemed redundant after adding `kind`.
Co-authored-by: adamrk <ark.email@gmail.com>
|
2020-02-17 10:54:32 +00:00 |
|
adamrk
|
e88eb89132
|
add space before/after wrapping braces
|
2020-02-16 16:33:15 +01:00 |
|
adamrk
|
04aff742b1
|
show names for record fields in enum completion
|
2020-02-16 16:10:23 +01:00 |
|
Kevin DeLorey
|
057d0bee55
|
Added module doc comment to explain the purpose of the completion.
|
2020-02-15 10:27:04 -06:00 |
|
Kevin DeLorey
|
ae8ae650fc
|
Fixed bug that allowed for completion in a nested method.
|
2020-02-15 09:50:07 -06:00 |
|
Kevin DeLorey
|
fc13b7fc9a
|
Reordered the use items.
|
2020-02-14 18:54:00 -06:00 |
|
Kevin DeLorey
|
be97cbfdb4
|
Adjusted the completion lookups to filter by just the name.
|
2020-02-13 19:10:08 -06:00 |
|
Kevin DeLorey
|
0bc9e62374
|
Completion now replaces whole fn/const/type def with snippet.
|
2020-02-12 21:00:47 -06:00 |
|
Kevin DeLorey
|
43e62a87ab
|
Cheese const tests as they requre an ident before becoming a CONST_DEF.
|
2020-02-12 20:46:55 -06:00 |
|
Kevin DeLorey
|
877cfbacf9
|
Started to refactor the trigger of the trait_impl completion.
|
2020-02-12 20:21:43 -06:00 |
|
Kevin DeLorey
|
6f130e7ef8
|
Formatting.
|
2020-02-11 10:07:23 -06:00 |
|
Kevin DeLorey
|
47d314e856
|
Fixing minor suggestions and added module level documentation.
|
2020-02-11 10:04:30 -06:00 |
|
Kevin DeLorey
|
e664cd73e3
|
Removed doc comments entirely from the changes.
|
2020-02-11 09:48:26 -06:00 |
|
Kevin DeLorey
|
3aaf46afa1
|
Formatted changes.
|
2020-02-11 09:40:08 -06:00 |
|
Kevin DeLorey
|
d7e36c3dd2
|
Removed docs from private method.
|
2020-02-11 07:31:39 -06:00 |
|
Kevin DeLorey
|
785723e0d9
|
Added tests to test associated types and consts.
|
2020-02-10 21:02:51 -06:00 |
|
Kevin DeLorey
|
52c4324e31
|
Added some documentation to the complete_trait_impl completion.
|
2020-02-10 20:55:49 -06:00 |
|
Kevin DeLorey
|
3ffc84fd15
|
Added associated const magic completion.
|
2020-02-09 20:59:12 -06:00 |
|
Kevin DeLorey
|
d85abd77b9
|
Added a utility function that can be used to determine the missing impl items.
|
2020-02-09 12:24:59 -06:00 |
|
Kevin DeLorey
|
a957c473fd
|
Merge branch 'master' into kdelorey/complete-trait-impl
|
2020-02-09 10:37:43 -06:00 |
|
Aleksey Kladov
|
409f8e1fb0
|
Remove hard-coded auto-import during completion
We now have a real auto-import system, so we can do a proper thing.
|
2020-02-09 10:04:47 +01:00 |
|
Kevin DeLorey
|
22caf982b9
|
Added associated type completion.
|
2020-02-08 15:41:25 -06:00 |
|
Kevin DeLorey
|
5c0c18926b
|
Cleaning up unessicary code that the Magic completion takes care of.
|
2020-02-08 13:22:31 -06:00 |
|
Kevin DeLorey
|
f801723dd2
|
Got the magic completion working.
|
2020-02-08 11:28:39 -06:00 |
|
Kevin DeLorey
|
5216b09ed6
|
Update completion kind to Magic in the unit tests.
|
2020-02-07 21:02:01 -06:00 |
|
Kirill Bulatov
|
740a26b7d2
|
Rename add import assist
|
2020-02-07 23:53:08 +02:00 |
|
Aleksey Kladov
|
88267c86c0
|
cleanup imports
|
2020-02-06 14:03:45 +01:00 |
|
Kevin DeLorey
|
fc46ed81ee
|
Add detection for a user already starting a fn impl and still providing completion.
|
2020-02-04 22:04:57 -06:00 |
|
Kirill Bulatov
|
c669b2f489
|
Code review fixes
|
2020-02-02 14:27:52 +02:00 |
|
Kirill Bulatov
|
6dae5cbb11
|
Require ModPath for importing
|
2020-02-02 14:06:51 +02:00 |
|
Kevin DeLorey
|
698ff91c13
|
Already implemented fn will no longer be suggested for trait implementations.
|
2020-01-28 20:33:12 -06:00 |
|
Kevin DeLorey
|
bc1fc6239d
|
Renamed the trait completion mod.
|
2020-01-22 22:38:03 -06:00 |
|
Kevin DeLorey
|
e3cda83f90
|
Added basic support for completing fn for trait impl.
|
2020-01-22 22:34:00 -06:00 |
|
Aleksey Kladov
|
595b06a1b8
|
Create modules via SourceBinder
|
2020-01-16 17:33:07 +01:00 |
|
Aleksey Kladov
|
a38540771f
|
Move Type API to type
|
2020-01-14 14:42:52 +01:00 |
|
Aleksey Kladov
|
52e7f67128
|
Move impls_future to Type, where it belongs
|
2020-01-14 11:29:43 +01:00 |
|
Aleksey Kladov
|
0358f5fdeb
|
Use lang-items to resolve future trait
|
2020-01-14 11:29:43 +01:00 |
|
kjeremy
|
a82c679c97
|
Some clippy lints
|
2020-01-13 11:27:06 -05:00 |
|
memoryruins
|
5575588387
|
Add macro_rules item snippet
|
2020-01-12 18:47:15 -05:00 |
|
Florian Diebold
|
9fd2c813ca
|
visible_from -> is_visible_from
|
2019-12-27 11:25:04 +01:00 |
|
Florian Diebold
|
9e9c4be48a
|
Hide completions for private struct fields
|
2019-12-26 16:23:40 +01:00 |
|
Aleksey Kladov
|
e424545c0f
|
Rudimentary name resolution for local items
|
2019-12-22 22:41:21 +01:00 |
|
Aleksey Kladov
|
4e0168ec14
|
Remove imports from hir
|
2019-12-21 15:18:14 +01:00 |
|
Aleksey Kladov
|
973b5cf7e2
|
Revert "Merge #2629"
This reverts commit cdc9d682b0 , reversing
changes made to 90ef070db3 .
|
2019-12-21 15:04:33 +01:00 |
|
Aleksey Kladov
|
67ba9072fa
|
Remove hir for imports
|
2019-12-21 12:18:20 +01:00 |
|
kjeremy
|
0d5d63a80e
|
Clippy lints
|
2019-12-20 15:14:30 -05:00 |
|
Aleksey Kladov
|
2619950b3b
|
Use different types for path with and without generics
|
2019-12-14 19:15:40 +01:00 |
|
Aleksey Kladov
|
61c3887b70
|
Remove one more Ty
|
2019-12-08 17:50:43 +01:00 |
|
ice1000
|
009437f5d9
|
Replace ra_hir_expand::either with crate
|
2019-12-03 11:07:56 -05:00 |
|
Florian Diebold
|
a5a07bde04
|
Add tests for checking the impl self type
|
2019-12-02 19:33:13 +01:00 |
|
Aleksey Kladov
|
ccd1b0800a
|
Rename Source -> InFile
|
2019-11-28 12:50:26 +03:00 |
|
Aleksey Kladov
|
1d14fd1737
|
Use Name::missing consistently
|
2019-11-27 23:22:20 +03:00 |
|
Aleksey Kladov
|
757e593b25
|
rename ra_ide_api -> ra_ide
|
2019-11-27 21:35:06 +03:00 |
|