Igor Aleksanov
831e3d58b3
Replace String with &'static str
2020-08-12 15:33:07 +03:00
Aleksey Kladov
f73a6419d4
Allow default everywhere
...
closes #5681
2020-08-12 14:28:32 +02:00
bors[bot]
42a1692629
Merge #5720
...
5720: Fix docs
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-12 11:59:02 +00:00
Aleksey Kladov
c9a42c7c46
Fix docs
2020-08-12 13:56:58 +02:00
bors[bot]
4b3d99f98f
Merge #5699
...
5699: Fix clippy warnings r=matklad a=popzxc
Currently clippy spawns a bunch of warnings on the `rust-analyzer` project. Nothing critical, but easy to fix, so I guess it won't harm.
Co-authored-by: Igor Aleksanov <popzxc@yandex.ru>
2020-08-12 11:51:53 +00:00
Igor Aleksanov
fcd4b0176f
Revert style preference-related fixes
2020-08-12 14:08:55 +03:00
bors[bot]
f6c0b1ce59
Merge #5719
...
5719: Minor
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-12 11:04:06 +00:00
Aleksey Kladov
c81e7a3a59
Minor
2020-08-12 13:03:43 +02:00
bors[bot]
e471cb2a12
Merge #5718
...
5718: Deny clippy
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-12 10:51:02 +00:00
Aleksey Kladov
49af51129b
Deny clippy
2020-08-12 12:49:48 +02:00
bors[bot]
d0fd8eb7f6
Merge #5717
...
5717: Minor
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-12 10:35:18 +00:00
Jonas Schievink
b27d5233bb
Merge pull request #5716 from jonas-schievink/musl
...
Fix build on musl and test it in CI
2020-08-12 12:31:17 +02:00
Jonas Schievink
67b2b3d0ce
Fix build on musl and test it in CI
2020-08-12 12:23:25 +02:00
Aleksey Kladov
96001921fc
Minor
2020-08-12 12:21:03 +02:00
bors[bot]
87429768bd
Merge #5711
...
5711: Display snippet in the completion label r=matklad a=SomeoneToIgnore
Before, the completion did not show the actual snippet and it was hard to understand what to input to get the right snippet:
<img width="467" alt="image" src="https://user-images.githubusercontent.com/2690773/89941040-21f6a600-dc23-11ea-94b8-61f77f88feaf.png ">
<img width="367" alt="image" src="https://user-images.githubusercontent.com/2690773/89941046-23c06980-dc23-11ea-8034-6c4e14357c94.png ">
Now it's more clear:
<img width="315" alt="image" src="https://user-images.githubusercontent.com/2690773/89941124-42befb80-dc23-11ea-9fcc-5fd49cc92b74.png ">
<img width="210" alt="image" src="https://user-images.githubusercontent.com/2690773/89941132-4488bf00-dc23-11ea-99c2-12ec66e0a044.png ">
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
2020-08-12 10:00:08 +00:00
bors[bot]
b93408d0b2
Merge #5715
...
5715: Simplify
r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-12 08:21:19 +00:00
Aleksey Kladov
8aba6bfef5
Simplify
2020-08-12 10:14:08 +02:00
Kirill Bulatov
7543b06d30
Display snippet in the completion label
2020-08-11 22:33:17 +03:00
Kirill Bulatov
db12ccee96
Better naming and docs
2020-08-11 17:52:05 +03:00
Kirill Bulatov
188ec3459e
Simplify fix structure
2020-08-11 17:13:40 +03:00
Kirill Bulatov
37aa68f050
Add rustdocs
2020-08-11 15:09:08 +03:00
Kirill Bulatov
c8cad76d25
Improve the ide diagnostics trait API
2020-08-11 15:09:08 +03:00
Kirill Bulatov
29fbc8e021
Move the DiagnosticsWithFix trait on the ide level
2020-08-11 15:09:08 +03:00
Kirill Bulatov
9368619939
Make the fix AST source Optional
2020-08-11 15:09:08 +03:00
Kirill Bulatov
9963f43d51
Refactor the diagnostics
2020-08-11 15:09:08 +03:00
Kirill Bulatov
cfbbd91a88
Require source implementations for Diagnostic
2020-08-11 15:09:08 +03:00
Kirill Bulatov
21184a1b2a
Restore accidentally removed public method
2020-08-11 15:09:08 +03:00
Kirill Bulatov
cb0b13a583
Fix another missing fields diagnostics
2020-08-11 15:09:08 +03:00
Kirill Bulatov
ee1586c1ed
Better naming
2020-08-11 15:09:08 +03:00
Kirill Bulatov
a61f2445cb
Less stubs
2020-08-11 15:09:08 +03:00
Kirill Bulatov
21e5224484
Custom ranges for missing fields
2020-08-11 15:09:08 +03:00
Kirill Bulatov
26e102a567
Separate diagnostics and diagnostics fix ranges
2020-08-11 15:09:08 +03:00
bors[bot]
e0de247520
Merge #5708
...
5708: Use Hygiene in completion r=jonas-schievink a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-08-11 10:30:39 +00:00
bors[bot]
ef20dfc78d
Merge #5707
...
5707: Address some FIXMEs for ra_assists r=jonas-schievink a=JmPotato
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Co-authored-by: JmPotato <ghzpotato@gmail.com>
2020-08-11 10:22:57 +00:00
bors[bot]
61ee051455
Merge #5705
...
5705: Log the command flycheck runs to debug misconfigurations r=jonas-schievink a=Veetaha
Without this users have no clue why flycheck fails to run.
This is what is printed to the output channel:
```
[ERROR rust_analyzer::main_loop] cargo check failed: Cargo watcher failed,the command produced no valid metadata (exit code: ExitStatus(ExitStatus(25856)))
```
I stumbled with this figuring out that rust-analyzer adds `--all-features` which is not intended
for some crates in the workspace (i.e. they have mutually-exclusive features).
Having the command rust-analyzer ran should help a lot
Co-authored-by: Veetaha <veetaha2@gmail.com>
2020-08-11 10:15:46 +00:00
bors[bot]
c1a5257b6d
Merge #5704
...
5704: Update README.md r=jonas-schievink a=tim-weis
Fixed formatting.
Co-authored-by: Tim Weis <tim-weis@users.noreply.github.com>
2020-08-11 10:08:27 +00:00
JmPotato
6ef019bd46
Revert some FIXMEs
...
Signed-off-by: JmPotato <ghzpotato@gmail.com>
2020-08-11 17:19:02 +08:00
JmPotato
7fbc9afca4
Typo fix
...
Signed-off-by: JmPotato <ghzpotato@gmail.com>
2020-08-11 16:50:45 +08:00
Laurențiu Nicola
fc01c7846d
Use Hygiene in completion
2020-08-11 10:09:50 +03:00
JmPotato
b69dfddb57
Remove redundant dependencies
...
Signed-off-by: JmPotato <ghzpotato@gmail.com>
2020-08-11 14:35:15 +08:00
JmPotato
ace75f9590
Typo fix
...
Signed-off-by: JmPotato <ghzpotato@gmail.com>
2020-08-11 12:09:11 +08:00
JmPotato
dc6e1e0dac
Address some FIXMEs
...
Signed-off-by: JmPotato <ghzpotato@gmail.com>
2020-08-11 10:55:26 +08:00
Veetaha
4f386afb16
Log the command flycheck runs to debug misconfigurations
...
Without this users have no clue why flycheck fails to run.
This is what is printed to the output channel:
```
[ERROR rust_analyzer::main_loop] cargo check failed: Cargo watcher failed,the command produced no valid metadata (exit code: ExitStatus(ExitStatus(25856)))
```
I stumbled with this figuring out that rust-analyzer adds `--all-features` which is not intended
for some crates in the workspace (e.g. they have mutually-exclusive features.
Having the command rust-analyzer ran should help a lot
2020-08-11 03:12:09 +03:00
Tim Weis
a8beb79a16
Update README.md
...
Fixed formatting.
2020-08-11 01:01:25 +02:00
bors[bot]
b050937c10
Merge #5703
...
5703: Fix typos in syntax.md r=kjeremy a=lnicola
Closes #5700
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-08-10 19:38:19 +00:00
Laurențiu Nicola
ff60fdc315
Fix typos in syntax.md
2020-08-10 21:31:38 +03:00
bors[bot]
1e310575e3
Merge #5701
...
5701: cargo update r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
2020-08-10 17:20:14 +00:00
bors[bot]
58711bda3d
Merge #5696
...
5696: Return InvalidRequest if Shutdown has been requested r=kjeremy a=kjeremy
From the LSP 3.16 spec: "If a server receives requests after a shutdown request those requests should error with InvalidRequest."
Realized this behavior was missing while looking at #5693 . Question on notification behavior is tracked at https://github.com/microsoft/language-server-protocol/issues/1066
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
2020-08-10 15:14:02 +00:00
Jeremy Kolb
cf6d14cee7
Return InvalidRequest if Shutdown has been requested
...
From the LSP 3.16 spec: "If a server receives requests after a shutdown request those requests should error with InvalidRequest."
2020-08-10 11:03:08 -04:00
kjeremy
9842bbfd27
cargo update
2020-08-10 10:56:16 -04:00