Aleksey Kladov
4b495da368
Transition OnEnter to WorkspaceSnippetEdit
...
This also changes our handiling of snippet edits on the client side.
`editor.insertSnippet` unfortunately forces indentation, which we
really don't want to have to deal with. So, let's just implement our
manual hacky way of dealing with a simple subset of snippets we
actually use in rust-analyzer
2020-05-21 15:08:03 +02:00
bors[bot]
0c2b548b0b
Merge #4550
...
4550: Fix phrasing in inlay hints settings r=matklad a=lnicola
Part of #4549
r? @LucianoBestia
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-05-21 12:51:52 +00:00
Laurențiu Nicola
0f953ddd9e
Fix phrasing in inlay hints settings
2020-05-21 12:26:03 +03:00
Benjamin Coenen
a7c8aa7c60
add support of feature flag for runnables #4464
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-21 10:53:29 +02:00
Benjamin Coenen
c6143742bd
add support of feature flag for runnables #4464
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-21 10:48:42 +02:00
bors[bot]
a4e6963a23
Merge #4547
...
4547: Remove unused cursor positions r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-21 08:38:55 +00:00
Aleksey Kladov
4fdb1eac08
Remove unused cursor positions
2020-05-21 10:37:11 +02:00
vsrs
c41a10c293
Apply suggestions from @Veetaha code review
2020-05-21 11:34:34 +03:00
bors[bot]
42dd0ce51f
Merge #4506
...
4506: Make `find_path_inner` a query r=matklad a=jonas-schievink
This eliminates the remaining performance problems in the "Implement default members" assist (at least those that I've found).
Closes https://github.com/rust-analyzer/rust-analyzer/issues/4498
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2020-05-20 23:48:02 +00:00
bors[bot]
e632d07015
Merge #4543
...
4543: Remove unused cursor positions r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-20 23:07:23 +00:00
Aleksey Kladov
04a8daaa33
Remove unused cursor positions
2020-05-21 00:46:08 +02:00
bors[bot]
f83785a94a
Merge #4541
...
4541: Remove set_cursor r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-20 22:04:42 +00:00
Aleksey Kladov
70930d3bb2
Remove set_cursor
2020-05-21 00:03:42 +02:00
Aleksey Kladov
4ac0abd296
Snippetify unwrap -> match
2020-05-21 00:01:08 +02:00
Jonas Schievink
6cdfd1c3cf
Make find_path_inner
a query
...
This eliminates any remaining performance problems in the
"Implement default members" assist (at least that I've found).
2020-05-20 23:54:50 +02:00
Aleksey Kladov
8300132ed0
More snippets
2020-05-20 23:50:42 +02:00
bors[bot]
4677cea719
Merge #4540
...
4540: More snippets r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-20 21:33:36 +00:00
Aleksey Kladov
5e13e4eba1
More snippets
2020-05-20 23:33:03 +02:00
bors[bot]
64afbf8d95
Merge #4526
...
4526: Use a flat play icon instead of the blue emoji with test code lens r=kjeremy a=aloucks
@lnicola
Restores this commit:
55e914a2a1
That was effectively wiped out by this code formatting commit:
dc217bdf90
3d445256fe
Co-authored-by: Aaron Loucks <aloucks@cofront.net>
2020-05-20 21:23:13 +00:00
Aleksey Kladov
fd77170718
Snippetify introduce/inline var
2020-05-20 23:07:17 +02:00
bors[bot]
ee9cec56c8
Merge #4539
...
4539: Relax cursor position tests in assists r=matklad a=matklad
Those will be replaced with snippets anyway
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-20 20:56:28 +00:00
Aleksey Kladov
65fa586410
Relax cursor position tests in assists
...
Those will be replaced with snippets anyway
2020-05-20 22:55:37 +02:00
vsrs
8ee40ccbe9
vscode client side tests
2020-05-20 22:31:39 +03:00
bors[bot]
3dfc461f1e
Merge #4536
...
4536: Fix names of launch configuration in dev docs r=kjeremy a=kuy
Follows renaming of launch configurations in 80a42a0628
Co-authored-by: Yuki Kodama <endflow.net@gmail.com>
2020-05-20 19:04:02 +00:00
bors[bot]
2711454e40
Merge #4537
...
4537: Fix GNOME spelling r=matklad a=afranke
GNOME is a trademark. :-)
Co-authored-by: Alexandre Franke <alexandre.franke@gmail.com>
2020-05-20 18:18:18 +00:00
Alexandre Franke
dfb931a4f1
Fix GNOME spelling
...
GNOME is a trademark. :-)
2020-05-20 20:11:14 +02:00
Yuki Kodama
d58d6412d8
Fix names of launch configuration in dev docs
2020-05-21 03:01:37 +09:00
bors[bot]
ba51b7b045
Merge #4533
...
4533: More snippets r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-20 12:16:26 +00:00
Aleksey Kladov
ba3a58d1b2
Snippetify fix_visibility
2020-05-20 14:13:17 +02:00
Aleksey Kladov
c446fd76a2
Snippetify fill_match_arms
2020-05-20 14:01:10 +02:00
Aleksey Kladov
a622b54ac0
Don't set cursor in change_visibility
2020-05-20 13:48:31 +02:00
Aleksey Kladov
74da16f6f9
Cleanup imports
2020-05-20 13:45:00 +02:00
bors[bot]
75c7695e86
Merge #4532
...
4532: Split change_ and fix_ visibility assists r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-20 11:33:48 +00:00
Aleksey Kladov
cec773926f
Split change_ and fix_ visibility assists
2020-05-20 13:33:13 +02:00
bors[bot]
e3373629cd
Merge #4520
...
4520: Marks 2.0 r=matklad a=matklad
The main benefit here is that we no longer need to declare marks. The main drawback is that this is ~~glorious~~ horrible. WDYT?
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-20 11:03:18 +00:00
Aleksey Kladov
ecac5d7de2
Switch to new magic marks
2020-05-20 13:02:53 +02:00
Aleksey Kladov
5258c817f7
Remove cross-crate marks
...
They create quite a bit of friction. Really, we should just move the
tests to the same crate, rather than paper over existing split.
2020-05-20 13:00:50 +02:00
Aleksey Kladov
d18d1c0594
Significantly more glorious marks
2020-05-20 13:00:50 +02:00
bors[bot]
4d3fd62f89
Merge #4530
...
4530: Use snippets in change_return_type_to_result r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-20 09:10:52 +00:00
Aleksey Kladov
33e111483f
Use snippets in change_return_type_to_result
2020-05-20 11:10:15 +02:00
bors[bot]
b422cef7dc
Merge #4529
...
4529: Fix Some|None order in fill_match_arms r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-20 08:52:34 +00:00
Aleksey Kladov
d8881d98d3
Fix Some|None order in fill_match_arms
2020-05-20 10:51:48 +02:00
Aleksey Kladov
d790a443f3
wip
2020-05-20 10:30:18 +02:00
Aleksey Kladov
2e74df4e2b
Cleanup
2020-05-20 10:28:58 +02:00
Aleksey Kladov
36a5ca9a84
Minor
2020-05-20 10:26:14 +02:00
Aleksey Kladov
45e343a0ef
Minor
2020-05-20 10:20:21 +02:00
Aleksey Kladov
9b2bd022dc
Snippetify add_new
2020-05-20 10:17:46 +02:00
bors[bot]
5d080dd024
Merge #4528
...
4528: Debug lens fix for a binary. r=matklad a=vsrs
Fixes an issue reported here: https://github.com/rust-analyzer/rust-analyzer/pull/4222#issuecomment-631073448
Co-authored-by: vsrs <vit@conrlab.com>
2020-05-20 07:57:49 +00:00
bors[bot]
c0bcaea466
Merge #4505
...
4505: Infer return type of loops with value breaks r=flodiebold a=ruabmbua
Creates a type variable to represent the return value of the loop.
Uses `coerce_merge_branch` on each break with the previous value, to determine the actual return value of the loop.
Resolves: https://github.com/rust-analyzer/rust-analyzer/issues/4492 , https://github.com/rust-analyzer/rust-analyzer/issues/4512
Co-authored-by: Roland Ruckerbauer <roland.rucky@gmail.com>
2020-05-20 07:22:53 +00:00
vsrs
d264d7b9f2
Debug lens fix for a binary.
2020-05-20 09:42:00 +03:00