Dezhi Wu
74396d27c0
Fix: correct markdown link form.
2021-10-29 18:25:32 +08:00
Dezhi Wu
097d527cbd
Fix: use a concise way to change link form when generating package.json
2021-10-29 10:00:10 +08:00
Dezhi Wu
ffc6cdd871
Fix: transform the asciidoc form link to markdown style when generating the package.json
2021-10-28 10:13:43 +08:00
rainy-me
1ea2c72386
Fix: remove extra newline
2021-10-19 23:46:43 +09:00
rainy-me
adb3729b91
Fix: expand glob import to empty braces if the glob is unused
2021-10-19 23:31:30 +09:00
bors[bot]
580a6c41eb
Merge #10568
...
10568: fix(assist): fix #10566 and #10567 r=bnjjj a=bnjjj
close #10566
close #10567
Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2021-10-19 12:57:24 +00:00
Benjamin Coenen
3a5147e9fe
fix(assist): delete trailing whitespaces
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2021-10-19 14:54:29 +02:00
bors[bot]
dfa355b431
Merge #10588
...
10588: internal: Parse const trait bounds r=Veykril a=Veykril
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10582
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-10-19 12:32:30 +00:00
Lukas Wirth
b219a4c465
internal: Parse const trait bounds
2021-10-19 14:20:00 +02:00
bors[bot]
e77fc481ad
Merge #10587
...
10587: fix: Fix `add_missing_match_arm` panicking on failed upmapping r=Veykril a=Veykril
Closes https://github.com/rust-analyzer/rust-analyzer/issues/10580#issuecomment-946170475
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-10-19 12:16:30 +00:00
Lukas Wirth
7e1d6e5265
fix: Fix add_missing_match_arm panicking
2021-10-19 14:00:24 +02:00
bors[bot]
0e4c3b2c2b
Merge #10586
...
10586: internal: Derive completions work on hir, not names r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-10-19 11:51:07 +00:00
Lukas Wirth
3dfe5045c5
Derive completions work on hir, not names
2021-10-19 13:50:08 +02:00
bors[bot]
d85946b735
Merge #10585
...
10585: fix: Resolve derive attributes even when shadowed r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-10-19 11:43:08 +00:00
Lukas Wirth
aa9d093488
Resolve derive attributes even when shadowed
2021-10-19 13:42:36 +02:00
Yoshua Wuyts
e346d32e69
fix Ordering::Equal path
2021-10-18 14:45:24 +02:00
Yoshua Wuyts
41fd824415
Revert "Simplify generated PartialOrd code"
...
This reverts commit 601ed3a10d
2021-10-18 14:41:38 +02:00
bors[bot]
48c3be922e
Merge #10574
...
10574: fix: Fix PartialOrd codegen r=lnicola a=yoshuawuyts
Closes https://github.com/rust-analyzer/rust-analyzer/issues/10571#issuecomment-945516462 . Thanks!
r? `@lnicola`
Co-authored-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
2021-10-18 10:47:04 +00:00
Yoshua Wuyts
a9ec345cf7
Fix PartialOrd codegen
2021-10-18 12:44:05 +02:00
Laurențiu Nicola
29d281e523
Fix tests
2021-10-18 12:03:49 +03:00
Laurențiu Nicola
edb03ad6f1
Pull in new lsp-types for VS compat
2021-10-18 12:03:49 +03:00
Lukas Wirth
5704de66c2
Skip non clippy completions when completing a clippy path
2021-10-17 23:04:38 +02:00
Benjamin Coenen
7ee1a77235
fix(assist): fix #10566 and #10567
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2021-10-17 20:24:40 +02:00
bors[bot]
401daa5f77
Merge #10417
...
10417: feat(assist): add new assist to unwrap the result return type r=bnjjj a=bnjjj
do the opposite of assist "wrap the return type in Result"
Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Co-authored-by: Coenen Benjamin <benjamin.coenen@hotmail.com>
2021-10-17 13:32:35 +00:00
Coenen Benjamin
ccf05debfe
Update crates/ide_assists/src/handlers/unwrap_result_return_type.rs
...
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-10-17 15:24:20 +02:00
bors[bot]
d9080addf9
Merge #10562
...
10562: fix: Fix clippy attribute completions always prefixing inserting `clippy::` r=Veykril a=Veykril
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/7144
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-10-17 11:30:49 +00:00
Lukas Wirth
99906baa17
Fix clippy attribute completions always prefixing with clippy::
2021-10-17 13:07:49 +02:00
Lukas Wirth
ce47d13101
Make attribute completions more ast based
2021-10-17 12:44:44 +02:00
Lukas Wirth
e329b7742b
Reorder CompletionContext functions
2021-10-17 11:15:56 +02:00
bors[bot]
c16d04e494
Merge #10561
...
10561: internal: Don't turn local names into strings in CompletionContext r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-10-17 09:00:06 +00:00
Lukas Wirth
791a2afbf9
Don't turn local names into strings in CompletionContext
2021-10-17 10:59:06 +02:00
bors[bot]
dd8e831c51
Merge #10558
...
10558: internal: Refactor lifetime completion context fields r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-10-16 21:57:36 +00:00
Lukas Wirth
81ccebf1f2
internal: Refactor lifetime completion context fields
2021-10-16 23:56:57 +02:00
bors[bot]
2d7d7f729d
Merge #10557
...
10557: fix: Fix qualified path completion not completing macros r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-10-16 21:33:55 +00:00
Lukas Wirth
2fbd52c78f
fix: Fix qualified path completion not completing macros
2021-10-16 23:33:09 +02:00
Milo
6f28325830
fix
2021-10-16 15:02:56 +01:00
Milo
30be95a821
add a comment
2021-10-16 14:15:17 +01:00
Milo
5a93457c1b
revert
2021-10-16 14:13:43 +01:00
Milo
35e5daacc3
more clippy fixes
2021-10-16 12:32:55 +01:00
bors[bot]
3c468ab2fc
Merge #10542
...
10542: Use workspace cargo to fetch rust source's metadata r=lnicola a=Alexendoo
Previously the detected cargo is the global one, as it uses the
directory of the rust source which doesn't pick up the local override
This fixes the case in clippy where the local rust toolchain is a recent
nightly that has a 2021 edition Cargo.toml. The global (stable) cargo
returns an error attempting to parse it
Fixes #10445
Co-authored-by: Alex Macleod <alex@macleod.io>
2021-10-16 10:28:46 +00:00
Laurențiu Nicola
cd0c45fdbc
Hide private methods in generate_delegate_methods
2021-10-16 13:16:22 +03:00
bors[bot]
6c7526d308
Merge #10552
...
10552: fix: Fix missing_fields diagnostic fix replacing wrong text ranges r=Veykril a=Veykril
Fixes #5393 by replacing the problematic behaviour there with a new "problem"
It replaces the correct range now, but it potentially discards the whitespace in the macro input. This is the best we can do currently until we get a formatter.
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-10-15 17:29:03 +00:00
Lukas Wirth
ac505b21a8
Fix missing_fields diagnostic fix replacing wrong text ranges
2021-10-15 19:27:19 +02:00
bors[bot]
c67db1b952
Merge #10543
...
10543: Narrow add_missing_match_arms assist range r=Veykril a=antonfirsov
Contributes to #10220 with logic borrowed from #10267 .
Note: if anyone has recommendations for further analyzers to check, I'm happy to (hard to do it on my own, I'm completely new to the language).
Co-authored-by: Anton Firszov <antonfir@gmail.com>
2021-10-15 16:05:15 +00:00
Anton Firszov
3d9ce6b6ce
cov_mark for add_missing_match_arms special cases
2021-10-15 17:53:01 +02:00
Anton Firszov
1c0eed5f97
undo unnecessary test changes
2021-10-15 14:45:11 +02:00
Anton Firszov
cc6eee1b60
cosmetics
2021-10-15 14:36:37 +02:00
Anton Firszov
e25b20e48d
update generated.rs
2021-10-15 14:33:44 +02:00
Anton Firszov
a01a4bae18
fix sample + cosmetics + one more test
2021-10-15 14:30:22 +02:00
Anton Firszov
4e16cfbdf4
simple implementation
2021-10-15 13:19:46 +02:00
