Veetaha
7379964048
vscode: press ; to respect semicolons
2020-02-17 22:09:44 +02:00
Aleksey Kladov
94fb9ad6b3
Fix extension name
2020-02-17 15:35:06 +01:00
Aleksey Kladov
3717b0e03f
Simplify some more ctors
2020-02-17 14:23:23 +01:00
Aleksey Kladov
3c12cd49ec
Simplify ctor
2020-02-17 14:22:09 +01:00
Aleksey Kladov
7dccfd9183
remove debug print
2020-02-17 14:20:18 +01:00
Aleksey Kladov
89afb1a841
Remove two stage constuction
2020-02-17 14:11:01 +01:00
Aleksey Kladov
978bea2b31
Fix link to the manual
2020-02-17 14:04:32 +01:00
Aleksey Kladov
ee4e41cbea
Push IO and error handling up
2020-02-17 14:03:33 +01:00
Aleksey Kladov
d24e612106
Simplify startup
2020-02-17 13:40:47 +01:00
Aleksey Kladov
dcdbbddd16
Simplify TS reload logic
...
Fixes #3164
2020-02-17 13:40:47 +01:00
bors[bot]
334f53465f
Merge #3187
...
3187: ⬆️ npm deps r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-17 10:13:45 +00:00
Aleksey Kladov
48dd1d7053
⬆️ npm deps
2020-02-17 11:13:16 +01:00
Aleksey Kladov
2225cadd5a
update lockfile
2020-02-17 11:12:45 +01:00
bors[bot]
93d28fb50c
Merge #3099
...
3099: Init implementation of structural search replace r=matklad a=mikhail-m1
next steps:
* ignore space and other minor difference
* add support to ra_cli
* call rust parser to check pattern
* documentation
original issue #2267
Co-authored-by: Mikhail Modin <mikhailm1@gmail.com>
2020-02-17 10:02:54 +00:00
bors[bot]
953dbe3e02
Merge #3181
...
3181: Add ability to pass additional arguments to rustfmt. r=matklad a=Leonqn
relates to #2848
Co-authored-by: Ilya Titkov <ilya@titkov.me>
2020-02-17 09:05:01 +00:00
Ilya Titkov
a2b0bdcc24
Add arguments to rustfmt
2020-02-17 11:44:58 +03:00
Veetaha
bd113623a0
vscode: minor refactorings
2020-02-17 02:07:11 +02:00
Veetaha
31ae646448
vscode: add comment on possible UnhandledPromise rejection error
2020-02-17 01:39:58 +02:00
bors[bot]
a90f5b0787
Merge #3173
...
3173: vscode: fix stupid mistake of mine r=matklad a=Veetaha
Shame on me...
Fixes #3056
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-16 17:40:23 +00:00
Veetaha
6e22e33d7d
vscode: fix stupid mistake
2020-02-16 19:30:13 +02:00
Veetaha
56b64cac9c
vscode: added minimum bound for lruCapacity option
2020-02-16 18:00:49 +02:00
Veetaha
0565657ed1
vscode: fix all integer -> number and add nullablitiy to maxInlayHintLength
2020-02-16 17:55:15 +02:00
Veetaha
53b5f4ba98
vscode: update exclusiveMinimum validation according to JSONSchemaV4 specs
2020-02-16 16:48:17 +02:00
bors[bot]
a15c8739b9
Merge #3162
...
3162: Feature: vscode always downloads only the matching ra_lsp_server version r=matklad a=Veetaha
I tried to separate logically connected changes into separate commits, so enjoy!
Now TypeScript extension saves installed binary version in global state and always checks that the installed binary version equals the version of the TypeScript extension itself (to prevent version drifts).
Also, changed `fetchLatestArtifactReleaseInfo()` to `fetchArtifactReleaseInfo()` that takes an optional release tag (when not specified fetches the latest release). The version without a release tag will be useful in the future when adding auto-checking for updates.
I decided not to do `Download latest language server` command (I have stated the rationale for this in #3073 ) and let the extension itself decide which version of the binary it wants. This way the users will be able to get the latest `ra_lsp_server` binary after the approaching 2020-02-17 release, without having to manually delete the outdated one from `~/.config/Code/User/globalStorage/matklad.rust-analyzer`!
Closes #3073
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-16 11:54:38 +00:00
Veetaha
3068aab82d
vscode: fix the default value for withSysroot
2020-02-16 11:15:19 +02:00
Veetaha
467b925b53
vscode: save binary version when downloading and download only version that matches TypeScript extension version
2020-02-16 03:41:40 +02:00
Veetaha
b9188226fa
vscode: extract downloadArtifact() function
2020-02-16 03:41:40 +02:00
Veetaha
0f7abeb035
vscode: add release tag option to fetchArtifactReleaseInfo()
2020-02-16 03:41:40 +02:00
Veetaha
8533fc437b
vscode: add version and storage parameters to github binary source
2020-02-16 03:41:39 +02:00
Edwin Cheng
cc43f07e11
Disable rollup warning
2020-02-16 05:04:51 +08:00
Veetaha
80d5ba68da
vscode: renamed langServer to server
2020-02-15 00:42:32 +02:00
Veetaha
f61134e198
vscode: renmed ArtifactMetadata -> ArtifactReleaseInfo, languageServer -> langServer
2020-02-15 00:15:06 +02:00
Mikhail Modin
f8f454ab5c
Init implementation of structural search replace
2020-02-14 21:45:42 +00:00
bors[bot]
ab42174653
Merge #3131
...
3131: vscode: simplified config and to removed one source of truth of default values r=matklad a=Veetaha
Though not intended initially, the implementation of config design is alike [dart's one](https://github.com/Dart-Code/Dart-Code/blob/master/src/extension/config.ts ) as pointed by @matklad in PM.
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-14 21:08:47 +00:00
Veetaha
20fabaf1ee
make onConfigChange handler private
2020-02-14 23:06:11 +02:00
Veetaha
4fb427743c
vscode: moved to getters as per matklad
2020-02-14 23:04:50 +02:00
kjeremy
de3b0b43f3
Expect vscode 1.42
2020-02-14 12:02:19 -05:00
bors[bot]
7c1fb6caa5
Merge #3137
...
3137: Do not register all proposed features r=matklad a=kjeremy
Instead only opt-in to CallHierarchy since it has a vscode API but LSP support
is still proposed.
Discovered while working on SemanticTokens which does not have a vscode API
and is still in the proposed state. Somehow enabling it would crash the
language server.
See https://github.com/microsoft/vscode-languageserver-node/issues/572
Co-authored-by: kjeremy <kjeremy@gmail.com>
2020-02-14 16:50:06 +00:00
kjeremy
7a832cdf6b
Do not register all proposed features
...
Instead only opt-in to CallHierarchy since it has a vscode API but LSP support
is still proposed.
Discovered while working on SemanticTokens which does not have a vscode API
and is still in the proposed state. Somehow enabling it would crash the
language server.
See https://github.com/microsoft/vscode-languageserver-node/issues/572
2020-02-14 11:48:27 -05:00
Aleksey Kladov
bd3a41cc33
Prevent auto-update of dev extension
2020-02-14 15:29:19 +01:00
Veetaha
574dc11a2f
vscode: removed nested errors as per matklad
2020-02-14 00:33:12 +02:00
Veetaha
fd37151ade
vscode: reordered config constructor before methods
2020-02-13 23:05:32 +02:00
Veetaha
7ad15c3962
vscode: redesigned config with simplicity and Dart extension config implementation in mind
2020-02-13 22:48:20 +02:00
Veetaha
9b47124e6e
vscode: added more type safety to package.json config
2020-02-13 22:47:31 +02:00
Veetaha
da6ae3b6e0
vscode: replaced DownloadFileError with NestedError itself for simplicity
2020-02-13 22:21:19 +02:00
Veetaha
a3febc1c57
vscode: switched to stream.pipeline with .on(close) workaround
2020-02-12 21:40:35 +02:00
Veetaha
36dc3edb7a
vscode: added error handling to download file streams
2020-02-11 23:58:48 +02:00
Veetaha
b834b37682
vscode: remove chmod in favour of an option to createWriteStream()
2020-02-11 22:34:52 +02:00
bors[bot]
f55d74dc0d
Merge #3083 #3101
...
3083: Update some crates r=matklad a=kjeremy
3101: vscode: filter out arm linux from using prebuilt binaries r=matklad a=Veetaha
Closes #3076
Co-authored-by: kjeremy <kjeremy@gmail.com>
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-11 09:32:32 +00:00
bors[bot]
98aa709fa7
Merge #3100
...
3100: vscode: add error handling to downloadFile() r=matklad a=Veetaha
Inspired by #3094 .
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-11 09:25:31 +00:00
Veetaha
2344dac183
vscode: filter out arm linux from using prebuilt binaries
2020-02-11 02:29:11 +02:00
Veetaha
f2c66605c2
vscode: add error handling to downloadFile()
2020-02-11 02:14:04 +02:00
Veetaha
78ee964f7c
vscode: fix ebusy error on windows
2020-02-10 23:12:20 +02:00
Veetaha
e709f113c1
vscode: changed dns sanity-check url from google.com to example.com
2020-02-09 22:27:01 +02:00
Veetaha
5d39f6d3b2
vscode: add on-success logic to dns resolution sanity check
2020-02-09 22:00:33 +02:00
Veetaha
fa7b91a2f7
vscode: removed unnecessary awaits
2020-02-09 21:55:29 +02:00
Veetaha
7cba77ed4e
vscode: added logging when donloading binaries
2020-02-09 15:01:00 +02:00
Veetaha
f3240e22c6
vscode: move throtting of download progress to call site
2020-02-09 14:18:05 +02:00
Veetaha
a63659badb
vscode: replaced unwrapNotNil() with ! as per @matklad
2020-02-09 13:59:27 +02:00
Veetaha
7a09274e52
vscode: refactor inverted ternaries to if statements as per @matklad
2020-02-09 13:45:06 +02:00
Veetaha
34241b9af9
vscode: remove noise data fields declarations as per @matklad
2020-02-09 13:39:54 +02:00
Veetaha
3159e87c49
vscode: refactor levels of code nesting and string literals quotes
2020-02-09 13:36:36 +02:00
Veetaha
a3e3fba7bf
vscode: fix chmod to octal literal
...
Co-Authored-By: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-09 12:54:51 +02:00
Veetaha
d08ae7e82f
vscode: minor names and message contents changes
2020-02-09 00:58:53 +02:00
Veetaha
fd6a98ef6e
vscode: rename raLspServer variable to langServer
2020-02-09 00:42:51 +02:00
Veetaha
8f291c0089
vscode: refactor comment
2020-02-09 00:28:32 +02:00
Veetaha
539daf4454
vscode: refactor platform artifact name query to switch statement, move BinarySource union variants into a namespace
2020-02-09 00:27:04 +02:00
Veetaha
bdd88c2fad
vscode: reduce throttle latency of downloadFile() progress callback for smoother UX
2020-02-08 21:25:03 +02:00
Veetaha
9791b6a8de
vscode: add name to the second unused argument of withProgress() callback
2020-02-08 21:24:29 +02:00
Veetaha
4e85254444
vscode: add docs to installation module interfaces and sanity check to donloadFile()
2020-02-08 21:03:27 +02:00
Veetaha
6ef912f925
vscode: converted fetchLatestArtifactMetadata params to positional, added docs
2020-02-08 20:18:33 +02:00
Veetaha
f7ef72db64
vscode: changed chmod value to 755 as per @lnicola
2020-02-08 20:07:00 +02:00
Veetaha
5d88c1db38
vscode: amended config to use binary from globalStoragePath, added ui for downloading
2020-02-08 04:34:11 +02:00
Veetaha
3e0e4e90ae
added fetchLatestArtifactMetadata() and downloadFile() functions
2020-02-08 04:34:11 +02:00
Veetaha
1bdb78a89f
vscode: add FIXME about language client shared resource protection
2020-02-08 04:34:11 +02:00
bors[bot]
ea9d18ba83
Merge #3024
...
3024: vscode: eliminate floating promises and insane amount of resource handle leaks r=matklad a=Veetaha
Khm, yeah ...
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-05 20:57:08 +00:00
Veetaha
8153b60e1d
vscode: eliminate floating promises and insane amount of resource handle leaks
2020-02-05 22:39:47 +02:00
Veetaha
49a6814048
vscode: removed changes to integrity hash in package-lock.json
2020-02-05 21:38:19 +02:00
Veetaha
b89b22e43e
vscode: yet another refactor commit
2020-02-05 00:13:46 +02:00
Grégoire Geis
875dc6d1a4
Merge two if statements into one in editors/code/src/commands/on_enter.ts.
...
Co-Authored-By: Veetaha <veetaha2@gmail.com>
2020-02-04 01:44:12 +01:00
Gregoire Geis
7fd661f085
vscode: Only handle enter if the suggest widget is hidden.
2020-02-03 22:26:20 +01:00
Gregoire Geis
b70ad7e5f3
Remove enableEnhancedTyping and type overriding infrastructure.
2020-02-03 20:24:50 +01:00
Gregoire Geis
58c007674b
Change default enhanced typing behavior from using type to using keybindings.
2020-02-03 20:18:11 +01:00
Gregoire Geis
23ef22dd48
Add regular onEnter command, allowing onEnter to be called without overriding the type command.
2020-02-03 20:18:10 +01:00
Aleksey Kladov
f0323de7e8
Remove unnecessary flags
2020-02-03 18:05:54 +01:00
Aleksey Kladov
9b8e3b80ee
Remove rollup-typescript
...
It seems like just calling typescript directly is simpler and more reliable?
2020-02-03 17:39:34 +01:00
Aleksey Kladov
0a68dfb491
Update some rollup packages
2020-02-03 16:49:25 +01:00
Aleksey Kladov
ad57726f91
Use simple prng instead of a dependency
...
closes #2999
2020-02-03 16:37:12 +01:00
Aleksey Kladov
30f7e6590a
Remove recent improvements to the build script
...
tslib as a dev dependency and commonjs modules are definitely *wrong*
in the ideal world, **but** in the real world that's the only
combination that works. See
https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Problems.20with.20TypeScript.20build
2020-02-03 15:25:29 +01:00
Aleksey Kladov
ae42cfefbf
Fix build of typscript extension
2020-02-03 13:54:12 +01:00
Veetaha
8f25408a12
vscode: fix bundling by switching to es2015 target modules system
2020-02-03 10:50:19 +02:00
Veetaha
0ade5cb2b3
vscode: dropped npm-check-updates script
2020-02-03 00:05:49 +02:00
Veetaha
e9800b0023
vscode: updated rollup typescript so it typechecks the bundle
2020-02-03 00:05:49 +02:00
Veetaha
2fd7af2a62
vscode: use void where possible
2020-02-02 23:24:09 +02:00
Veetaha
5411d65a7f
vscode: fix, fallback to any for cmd type
2020-02-02 22:36:12 +02:00
Veetaha
12d0970f7e
vscode extension: migrate from any to unknown where possible
2020-02-02 22:19:59 +02:00
Veetaha
4bf5f59560
vscode: fix type
2020-02-02 21:38:49 +02:00
Veetaha
8184752470
vscode refactoring: use more laconic export snytax, split huge string to several lines
2020-02-02 21:37:22 +02:00
Veetaha
420462421d
vscode extension cleanup: migrate to prefer-const tslint rule
2020-02-02 21:12:59 +02:00
bors[bot]
856e4ba126
Merge #2979
...
2979: vscode: now we are actually using tslib r=matklad a=Veetaha
We had an incorrect setup where `tslib` was in `devDependencies`.
FYI:
tslib is a runtime dependency, it contains functions that are used by transpiled JavaScript in order not to inline them in each file.
For example:
```ts
// foo.ts (source code)
import * as foo from "foo";
// ---------------------------
// foo.js (compiled output)
"use strict";
var __importStar = (this && this.__importStar) || function (mod) {
if (mod && mod.__esModule) return mod;
var result = {};
if (mod != null) for (var k in mod) if (Object.hasOwnProperty.call(mod, k)) result[k] = mod[k];
result["default"] = mod;
return result;
};
Object.defineProperty(exports, "__esModule", { value: true });
const foo = __importStar(require("foo"));
```
As you see, `tsc` generated that `__importStar` helper function in compiled output. And it generates it per each file if you don't enable `"importHelpers": true`. Now with `importHelpers` enabled we get the following picture:
```ts
// foo.ts (source code)
import * as foo from "foo";
// ---------------------------
// foo.js (compiled output)
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
const tslib_1 = require("tslib");
const foo = tslib_1.__importStar(require("foo"));
```
It saves some bundle size, but I am not entirely sure wheter we want that. Discussions are welcome!
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-02 14:05:23 +00:00
Veetaha
3d6d0819cc
fix repo link in package.json
2020-02-02 12:16:41 +02:00
Veetaha
f08297983f
vscode: moved tslib to runtime dependencies and added \"importHelpers\": true
2020-02-01 23:11:39 +02:00
bors[bot]
3f499489f7
Merge #2964
...
2964: Improve responsiveness of the cargo check status label r=matklad a=lnicola
This is still not ideal because the label displays the crate that was just checked, not the one that's currently being checked. But it should give the impression of being faster.
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-02-01 15:41:55 +00:00
bjorn3
c84897bfb7
Tsfmt
2020-02-01 13:41:11 +01:00
bjorn3
5c39311f96
Fix seedrandom in packaged extension
...
Fixes #2971
2020-02-01 13:39:04 +01:00
bjorn3
f4431d2acc
[VSCode] Fix syntax highlighting
...
Fixes #2969
2020-02-01 13:12:39 +01:00
Laurențiu Nicola
d4d72e8b9b
Improve responsiveness of the cargo check status label
2020-01-31 20:55:10 +02:00
Aleksey Kladov
94784cc546
Provide better diagnostics if the server is not in path
2020-01-28 17:00:00 +01:00
Aleksey Kladov
c378133185
⬆️ node
2020-01-28 15:11:44 +01:00
kjeremy
1266810e55
vscode-languageclient 6.1.0
...
Adds support for proposed semantic highlighting extension
2020-01-27 10:25:22 -05:00
Jeremy Kolb
a0494c7237
vscode-languageclient 6.0.1
2020-01-20 19:48:32 -05:00
Kirill Bulatov
78a21253b4
Apply the api design suggestions
2020-01-15 20:17:17 +02:00
Kirill Bulatov
73dc8b6f06
Another attempt to add multiple edits
2020-01-15 20:16:27 +02:00
Aleksey Kladov
f10b209234
Extension icon
2020-01-15 16:07:39 +01:00
Emil Lauridsen
70cba0fe0f
Use types from vscode-langaugeclient
2020-01-15 12:04:35 +01:00
bors[bot]
876f92d547
Merge #2843
...
2843: Add inlay parameter name hints for call expr r=matklad a=imtsuki
This patch adds Intellij-like parameter name hints for literal values in function calls.
<img width="624" alt="Screenshot" src="https://user-images.githubusercontent.com/8423594/72366533-68d7f800-3735-11ea-9279-cf193ca8ca2f.png ">
Signed-off-by: imtsuki <me@qjx.app>
Co-authored-by: imtsuki <me@qjx.app>
2020-01-15 10:24:51 +00:00
memoryruins
896a162f55
Improve readability
2020-01-14 22:52:49 -05:00
memoryruins
edb820c329
Display vscode message after changing cargo-watch options
2020-01-14 20:52:48 -05:00
kjeremy
385c548032
Language Server Protocol 3.15 is now stable
...
Update the client
2020-01-14 14:53:38 -05:00
imtsuki
c390e92fdd
Add inlay parameter name hints for function calls
...
Signed-off-by: imtsuki <me@qjx.app>
2020-01-15 01:18:52 +08:00
kjeremy
a39fe4f1dc
vscode-languageclient 6.0.0-next.10
2020-01-13 16:49:44 -05:00
Aleksey Kladov
bd7aa5db14
Rename VS Code extension to rust-analyzer
2020-01-13 11:13:18 +01:00
Marco Groppo
08fa0151ed
Fix lruCapacity config setting type
2020-01-11 13:30:02 +01:00
bors[bot]
1953ac17fd
Merge #2714
...
2714: Sanity check for missing server binary r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-01-06 11:39:41 +00:00
Aleksey Kladov
8327049fae
Allow disabling inlay hints
2020-01-01 17:04:37 +01:00
Aleksey Kladov
ef24721640
Fixes to progress display
2019-12-31 21:13:30 +01:00
Aleksey Kladov
695b8ba0f0
Sanity check for missing server binary
2019-12-31 20:54:31 +01:00
Aleksey Kladov
ff0ceb30a9
Add semicolons
2019-12-31 18:55:34 +01:00
Aleksey Kladov
cb41ffbbbd
Fix NPEs
2019-12-31 18:50:32 +01:00
Aleksey Kladov
6368b40dd9
Work around synchrnonisation issue
2019-12-31 18:38:22 +01:00
Aleksey Kladov
087af54069
Refactor server lifecycle
2019-12-31 18:32:17 +01:00
Aleksey Kladov
0849f7001c
Refactor config
2019-12-31 17:34:52 +01:00
Aleksey Kladov
76f283108b
Drop needless pubs
2019-12-31 17:28:27 +01:00
Aleksey Kladov
433000be34
Move config to Ctx
2019-12-31 17:28:01 +01:00
Aleksey Kladov
e4b588868f
Refactor status activation
2019-12-31 17:22:43 +01:00
Aleksey Kladov
0eb254854d
Fix color name
2019-12-31 15:42:05 +01:00
Aleksey Kladov
8662a7dfe5
Drop obsolete color configurations
2019-12-31 14:37:23 +01:00
Aleksey Kladov
26bd7a896b
Drop support for legacy colorization
2019-12-31 14:11:25 +01:00
Aleksey Kladov
6c1d92d6c5
Rename file
2019-12-31 14:06:40 +01:00
Aleksey Kladov
519bd0deb5
Fix #2700
2019-12-31 11:44:52 +01:00
Aleksey Kladov
f984ef2652
Switch impure functional style to pure imperative
2019-12-31 03:33:00 +01:00
Aleksey Kladov
cfb0865929
Reduce scope
2019-12-31 02:30:43 +01:00
Aleksey Kladov
96de8076ff
Use optional value shortcut
2019-12-31 02:27:26 +01:00
Aleksey Kladov
6561634c68
Remove trivial helpers
2019-12-31 02:21:57 +01:00
Aleksey Kladov
8346bdc04d
Rearrange code
2019-12-31 02:17:50 +01:00
Aleksey Kladov
68b7d84974
Restore internal applySourceChange command
2019-12-30 23:46:13 +01:00
Aleksey Kladov
c65e90f7b8
Use Ctx in highlighter
2019-12-30 23:46:13 +01:00
Aleksey Kladov
04f0f5077a
Reformat with tsfmt
2019-12-30 23:30:35 +01:00
Aleksey Kladov
323ad13c8a
Add tsfmt
2019-12-30 23:28:13 +01:00
Aleksey Kladov
9fae4f4b99
Remove prettier
2019-12-30 23:27:13 +01:00