14707 commits

Author	SHA1	Message	Date
Florian Diebold	a49a0ab883	Add 'remove this semicolon'	2022-03-21 16:46:01 +01:00
Florian Diebold	0689fdb650	Add "add missing Ok/Some" fix	2022-03-21 16:46:01 +01:00
Florian Diebold	ab3313b1cb	Add new type-mismatch diagnostic	2022-03-21 16:46:01 +01:00
Florian Diebold	2d30dd67d3	Expose coercion logic in hir API	2022-03-21 16:45:59 +01:00
Florian Diebold	6133e6a002	Extract coercion logic to InferenceTable ... To make it accessible without an InferenceContext.	2022-03-21 16:45:30 +01:00
Laurențiu Nicola	1a37b17162	Replace write! with direct calls	2022-03-21 10:43:36 +02:00
bors[bot]	b594f9c441	Merge #11690 ... 11690: feat: Add an assist for inlining type aliases r=Veykril a=steven-joruk I'm working towards implementing #10881, but I'd like to get this in first with earlier feedback. Is `inline_type_alias` a good enough name? I guess the follow up assist would be called `inline_type_alias_into_all_users` based on that.   Co-authored-by: Steven Joruk <steven@joruk.com>	2022-03-20 21:15:49 +00:00
Steven Joruk	1381a2de23	refactor: Do more work in inline_type_alias closure	2022-03-20 20:53:03 +00:00
bors[bot]	6f2b118605	Merge #11775 ... 11775: internal: Treat `global_asm` and `asm` macros as unsafe r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <lukastw97@gmail.com>	2022-03-20 18:31:27 +00:00
Lukas Wirth	ddf144051a	internal: Treat {global_}asm macros as unsafe	2022-03-20 19:31:00 +01:00
bors[bot]	fedf724d82	Merge #11774 ... 11774: feat: Tag macro calls as unsafe if they expand to unsafe expressions r=Veykril a=Veykril as long as they aren't inside an unsafe block inside the macro that is. Co-authored-by: Lukas Wirth <lukastw97@gmail.com>	2022-03-20 18:15:29 +00:00
Lukas Wirth	3b7b223b25	Simplify	2022-03-20 19:13:50 +01:00
Lukas Wirth	68de7b30e0	feat: Tag macro calls as unsafe if they expand to unsafe expressions	2022-03-20 19:07:44 +01:00
bors[bot]	966b692422	Merge #11771 ... 11771: feat: Visualize compiler inserted reborrows via inlay hints r=Veykril a=Veykril Disabled by default.  Closes https://github.com/rust-analyzer/rust-analyzer/issues/11275 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>	2022-03-20 13:47:16 +00:00
Lukas Wirth	5a87f09a71	Update inlay hint feature docs	2022-03-20 14:41:27 +01:00
Lukas Wirth	37b48ceb8f	feat: Visualize compiler inserted reborrows via inlay hints	2022-03-20 14:38:16 +01:00
bors[bot]	a82caff588	Merge #11765 ... 11765: fix: Fix closure hints using macro ranges r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <lukastw97@gmail.com>	2022-03-19 19:26:34 +00:00
Lukas Wirth	2598575a35	fix: Fix closure hints using macro ranges	2022-03-19 20:24:09 +01:00
bors[bot]	7315d97347	Merge #11755 ... 11755: feat: Implement lifetime elision hints r=Veykril a=Veykril With names on:  With names off:  Co-authored-by: Lukas Wirth <lukastw97@gmail.com>	2022-03-19 19:15:06 +00:00
Lukas Wirth	7da5b80f25	Change skip trivial behaviour	2022-03-19 20:12:14 +01:00
Lukas Wirth	7ab0aaa82a	Add option to skip trivial cases	2022-03-19 19:01:19 +01:00
Lukas Wirth	45756c823f	Use numbers for lifetimes by default, add setting to prefer using parameter names	2022-03-19 18:11:56 +01:00
Jonas Schievink	55d2a25123	Rename call info to "signature help" ... It is no longer limited to just calls	2022-03-18 20:19:35 +01:00
Jonas Schievink	0642724e94	Provide signature help when editing generic args	2022-03-18 19:59:41 +01:00
Lukas Wirth	c22fed895e	Fix test fixtures	2022-03-18 18:57:15 +01:00
Lukas Wirth	b634d99361	Give the lifetimes better names	2022-03-18 18:55:03 +01:00
Lukas Wirth	673e2b1d8f	feat: Implement lifetime elision hints	2022-03-18 18:11:16 +01:00
bors[bot]	e3217c5015	Merge #11752 ... 11752: internal: Allow explicitly specifying end of fixture annotation r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <lukastw97@gmail.com>	2022-03-18 16:38:32 +00:00
Lukas Wirth	890f98f21f	internal: Allow explicitly specifying end of fixture annotation	2022-03-18 15:42:19 +01:00
Jonas Schievink	14203c6378	Complete assoc const patterns on builtin types	2022-03-18 15:36:18 +01:00
bors[bot]	849ac25f05	Merge #11713 ... 11713: Complete associated consts in patterns r=jonas-schievink a=hi-rustin Try close https://github.com/rust-analyzer/rust-analyzer/issues/11555 Co-authored-by: hi-rustin <rustin.liu@gmail.com> Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>	2022-03-18 13:54:09 +00:00
Jonas Schievink	e7564086f4	Update crates/ide_completion/src/tests/pattern.rs	2022-03-18 14:53:44 +01:00
bors[bot]	6ad8c022ed	Merge #11750 ... 11750: fix: Fix runnables trying to add doc tests in the crate root from #[macro_export] macros r=Veykril a=Veykril Fixes https://github.com/rust-analyzer/rust-analyzer/issues/11746 bors r+ Co-authored-by: Lukas Wirth <lukastw97@gmail.com>	2022-03-18 11:13:37 +00:00
Lukas Wirth	828196be3b	fix: Fix runnables trying to add doc tests in the crate root from #[macro_export] macros	2022-03-18 12:01:59 +01:00
Laurențiu Nicola	86b1ef9ab2	Bump deps	2022-03-17 19:24:37 +02:00
Florian Diebold	60aeb8fa1a	Move fallback_bound_vars to the only place it's used now	2022-03-17 17:08:43 +01:00
Florian Diebold	9ea2e0bd5b	Fixes for consts	2022-03-17 17:04:32 +01:00
Florian Diebold	59b5696aaa	Snapshot obligations	2022-03-17 17:04:32 +01:00
Florian Diebold	8f5b6ac556	Properly try unifying the receivers during method resolution ... Instead of hackily checking if they're equal.	2022-03-17 17:03:54 +01:00
hi-rustin	bc8665e14d	Fix typo ... Signed-off-by: hi-rustin <rustin.liu@gmail.com>	2022-03-17 22:59:47 +08:00
Florian Diebold	1b71cd074d	Add test for DynMap type inference	2022-03-17 15:44:14 +01:00
hi-rustin	2bc545d9ef	Match the enum and union ... Signed-off-by: hi-rustin <rustin.liu@gmail.com>	2022-03-17 21:38:21 +08:00
bors[bot]	631b504991	Merge #11741 ... 11741: Emit #[must_use] in Generate enum is_variant assist r=lnicola a=lnicola bors r+ Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>	2022-03-17 13:23:22 +00:00
bors[bot]	0a18e4355a	Merge #11740 ... 11740: Insert #[must_use] in generate_is_empty_from_len r=lnicola a=Walther Inserts `#[must_use]` for the generated `is_empty` methods. I also added the `#[must_use]` for the `len()` methods in the documentation examples and tests for this generator while at it, to make sure they too encourage the use of the annotation. From discussion in https://github.com/rust-analyzer/rust-analyzer/issues/11736 and https://github.com/rust-analyzer/rust-analyzer/pull/11738 Co-authored-by: Walther <veeti.haapsamo@gmail.com>	2022-03-17 13:14:26 +00:00
Laurențiu Nicola	de53232ada	Emit #[must_use] in Generate enum is_variant assist	2022-03-17 15:10:25 +02:00
Walther	217b30568e	Insert #[must_use] in generate_is_empty_from_len	2022-03-17 15:03:02 +02:00
bors[bot]	502e30e676	Merge #11737 #11739 ... 11737: Emit `#[must_use]` in `Generate new` assist r=lnicola a=lnicola Closes #11736 11739: Insert #[must_use] in generate_getter r=lnicola a=Walther Inserts `#[must_use]` for the generated getter methods. From discussion in https://github.com/rust-analyzer/rust-analyzer/issues/11736 and https://github.com/rust-analyzer/rust-analyzer/pull/11738 Co-authored-by: Laurențiu Nicola <lnicola@dend.ro> Co-authored-by: Walther <veeti.haapsamo@gmail.com>	2022-03-17 12:58:14 +00:00
Walther	e5adbd88e9	Insert #[must_use] in generate_getter	2022-03-17 14:49:22 +02:00
hi-rustin	c6ef4e830e	Fix the wrong path resolution ... Signed-off-by: hi-rustin <rustin.liu@gmail.com>	2022-03-17 20:39:04 +08:00
hi-rustin	a9aae250ed	Add completes_associated_const test ... Signed-off-by: hi-rustin <rustin.liu@gmail.com>	2022-03-17 20:39:00 +08:00
hi-rustin	37d0c722ef	Complete associated consts in patterns ... Signed-off-by: hi-rustin <rustin.liu@gmail.com>	2022-03-17 20:35:04 +08:00
Laurențiu Nicola	7e05e10495	Emit #[must_use] in Generate new assist	2022-03-17 14:21:42 +02:00
hkalbasi	0141f28475	fix regression_11688_2	2022-03-17 12:47:31 +03:30
bors[bot]	3bff42fd14	Merge #11734 ... 11734: internal: Bump `xshell` and fix `dist` r=lnicola a=lnicola bors r+ Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>	2022-03-17 06:54:27 +00:00
Laurențiu Nicola	be6d5001e4	Bump xshell and fix dist	2022-03-17 08:53:33 +02:00
bors[bot]	b3cfa1986b	Merge #11731 ... 11731: feat: Add return type hints for closures with block bodies r=Veykril a=Veykril Fixes https://github.com/rust-analyzer/rust-analyzer/issues/11386 bors r+ Co-authored-by: Lukas Wirth <lukastw97@gmail.com>	2022-03-16 20:31:47 +00:00
Lukas Wirth	bd17933c31	feat: Add return type hints for closures with block bodies	2022-03-16 21:25:03 +01:00
bors[bot]	a57fee6b6f	Merge #11694 ... 11694: fix: "Extract to function" assist preserves `break` and `continue` labels r=Veykril a=m0rg-dev Adds a label / lifetime parameter to `ide_assists::handlers::extract_function::FlowKind::{Break, Continue}`, adds support for emitting labels to `syntax::ast::make::{expr_break, expr_continue}`, and implements the required machinery to let `extract_function` make use of them. This does modify the external API of the `syntax` crate, but the changes there are simple, not used outside `ide_assists`, and, well, we should probably support emitting `break` and `continue` labels through `syntax` anyways, they're part of the language spec. Closes #11413. Co-authored-by: Morgan Thomas <corp@m0rg.dev>	2022-03-16 16:35:34 +00:00
Lukas Wirth	a40a847d77	Revert omitting field completions	2022-03-16 16:41:35 +01:00
Lukas Wirth	c1f6f135e1	Remove code duplication	2022-03-16 16:32:36 +01:00
Lukas Wirth	02b401b130	Simplify completion render functionality	2022-03-16 16:27:55 +01:00
Lukas Wirth	4fe5f03c7f	Rename compound things to variant things	2022-03-16 13:41:47 +01:00
Laurențiu Nicola	620411df80	Mark chaining hints as types, since that's what they are	2022-03-16 07:46:09 +02:00
bors[bot]	fb9e66d9fc	Merge #11718 ... 11718: Fix const generic panic r=lnicola a=HKalbasi fix https://github.com/rust-analyzer/rust-analyzer/pull/11688#issuecomment-1066824954 Co-authored-by: hkalbasi <hamidrezakalbasi@protonmail.com>	2022-03-15 20:27:51 +00:00
hkalbasi	1f3d18718c	fix const generic panic	2022-03-15 22:34:05 +03:30
bors[bot]	61b1449387	Merge #11714 ... 11714: fix: Fix completions not always working in for-loop patterns r=Veykril a=Veykril Fixes https://github.com/rust-analyzer/rust-analyzer/issues/11205 bors r+ Co-authored-by: Lukas Wirth <lukastw97@gmail.com>	2022-03-15 17:58:21 +00:00
Lukas Wirth	d5f8d91872	fix: Fix completions not always working in for-loop patterns	2022-03-15 18:46:32 +01:00
bors[bot]	683fea4de4	Merge #11707 ... 11707: minor: Simplify r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <lukastw97@gmail.com>	2022-03-14 20:05:46 +00:00
Lukas Wirth	fbc1d2a514	Simplify	2022-03-14 20:36:35 +01:00
bors[bot]	83575c96ed	Merge #11700 ... 11700: ⬆️ xshell r=matklad a=matklad Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>	2022-03-14 15:02:34 +00:00
Aleksey Kladov	56e43c34e7	⬆️ xshell	2022-03-14 14:57:24 +00:00
hkalbasi	b301b040f5	Add const generics	2022-03-14 14:38:37 +03:30
Steven Joruk	1981a3dc65	test: Make imported_external test that the full path is replaced	2022-03-13 13:25:06 +00:00
Morgan Thomas	14e20047c4	broke a test trying to make the diff look better...	2022-03-12 10:35:26 -08:00
Morgan Thomas	3fafbca32e	fix: "Extract to function" assist preserves break and continue labels ... Adds a label / lifetime parameter to `ide_assists::handlers::extract_function::FlowKind::{Break, Continue}`, adds support for emitting labels to `syntax::ast::make::{expr_break, expr_continue}`, and implements the required machinery to let `extract_function` make use of them. This does modify the external API of the `syntax` crate, but the changes there are simple, not used outside `ide_assists`, and, well, we should probably support emitting `break` and `continue` labels through `syntax` anyways, they're part of the language spec. Closes #11413.	2022-03-12 08:54:06 -08:00
Steven Joruk	2e00fa208f	chore: Remove unused import	2022-03-12 15:59:00 +00:00
Steven Joruk	d7517d8323	refactor: Veykril's code review suggestions	2022-03-12 15:55:47 +00:00
Matthias Krüger	f39cac17ce	fix clippy::needless_late_init	2022-03-12 16:50:49 +01:00
Matthias Krüger	5a0078c9d1	more clippy fixes: ... clippy::search_is_some clippy::redundant_static_lifetimes clippy::match_single_binding clippy::match_ref_pats clippy::map_entry clippy::manual_map clippy::iter_overeager_cloned clippy::into_iter_on_ref clippy::extra_unused_lifetimes	2022-03-12 16:50:49 +01:00
Matthias Krüger	56e4ea59d9	more clippy fixes: ... clippy::match_like_matches_macro clippy::to_string_in_format_args clippy::single_char_add_str clippy::filter_map_identity clippy::clone_on_copy clippy::useless_format clippy::unused_unit	2022-03-12 16:50:49 +01:00
Matthias Krüger	77790f2b8e	fix clippy::needless_return	2022-03-12 16:50:49 +01:00
Matthias Krüger	21ffc5350d	fix clippy::redundant_clone	2022-03-12 16:50:49 +01:00
Matthias Krüger	d64d711db2	fix clippy::map_flatten	2022-03-12 16:50:49 +01:00
Matthias Krüger	62ed658311	fix clippy::useless_conversion	2022-03-12 16:50:49 +01:00
Matthias Krüger	451fcd3c79	fix clippy::redundant_closure	2022-03-12 16:50:49 +01:00
Matthias Krüger	1f70886b15	fix clippy::single_char_pattern	2022-03-12 16:50:49 +01:00
Matthias Krüger	7912e33ed6	fix clippy::needless_borrow	2022-03-12 16:50:49 +01:00
bors[bot]	ff7e057dca	Merge #11691 ... 11691: feat: Suggest union literals, suggest union fields within an empty union literal r=Veykril a=m0rg-dev Adds a `Union {…}` completion in contexts where a union is expected, expanding to a choice of available fields (if snippets are supported):   Also, adds support for listing possible fields in an empty union literal.   Closes #11568. Co-authored-by: Morgan Thomas <corp@m0rg.dev>	2022-03-12 15:44:51 +00:00
Morgan Thomas	f922b805fe	- clean up match in ide_completion::completions::record::complete_record_literal ... - use original instead of adjusted type in ide_completion::completions::record::complete_record - don't even bother checking if we can complete union literals to Default or to struct update syntax	2022-03-12 07:35:13 -08:00
Lukas Wirth	301711ee71	internal: Remove ide_completion::render::build_ext module	2022-03-12 16:13:49 +01:00
Morgan Thomas	6519b0a009	Suggest union literals, suggest union fields within an empty union literal	2022-03-12 06:58:43 -08:00
Steven Joruk	5b712bd821	feat: Add an assist for inlining type aliases ... This intends to lead to a more useful assist to replace all users of an alias with its definition.	2022-03-12 13:42:24 +00:00
Steven Joruk	cdeb1b2c78	chore: fill_match_arms was renamed - update its usage in a comment	2022-03-12 13:41:23 +00:00
bors[bot]	d65f9a28fa	Merge #11687 #11689 ... 11687: Highlight escape sequences in byte strings r=Veykril a=yipinliu #11605 11689: minor: Pad type inlay hints if no colons are requested r=Veykril a=Veykril bors r+ Co-authored-by: yipinliu <ypliu18@gmail.com> Co-authored-by: Lukas Wirth <lukastw97@gmail.com>	2022-03-12 13:14:31 +00:00
Lukas Wirth	21af9ba4f0	minor: Pad type inlay hints if no colons are requested	2022-03-12 14:08:39 +01:00
yipinliu	c15ebcd84c	Optimize imports	2022-03-12 21:06:33 +08:00
bors[bot]	d75a46852a	Merge #11686 ... 11686: feat: Enum variant field completion, enum variant / struct consistency r=Veykril a=m0rg-dev This addresses several related inconsistencies: - tuple structs use tab stops instead of placeholders - tuple structs display in the completion menu as `Struct {…}` instead of `Struct(…)` - enum variants don't receive field completions at all - enum variants display differently from structs in the completion menu Also, structs now display their type in the completion detail rather than the raw snippet text to be inserted. As far as what's user-visible, that looks like this: | | Menu | Completion | Detail | |-|-|-|-| | Record struct (old) | `Struct {…}` | `Struct { x: ${1:()}, y: ${2:()} }$0` | `Struct { x: ${1:()}, y: ${2:()} }$0` | | Record struct (new) | `Struct {…}` | `Struct { x: ${1:()}, y: ${2:()} }$0` | `Struct { x: i32, y: i32 }` | | Tuple struct (old) | `Struct {…}` | `Struct($1, $2)$0` | `Struct($1, $2)` | | Tuple struct (new) | `Struct(…)` | `Struct(${1:()}, ${2:()})$0` | `Struct(i32, i32)` | | Unit variant (old) | `Variant` | `Variant` | `()` | | Unit variant (new) | `Variant` | `Variant$0` | `Variant` | | Record variant (old) | `Variant` | `Variant` | `{x: i32, y: i32}` | | Record variant (new) | `Variant {…}` | `Variant { x: ${1:()}, y: ${2:()} }$0` | `Variant { x: i32, y: i32 }` | | Tuple variant (old) | `Variant(…)` | `Variant($0)` | `(i32, i32)` | | Tuple variant (new) | `Variant(…)` | `Variant(${1:()}, ${2:()})$0` | `Variant(i32, i32)` | Additionally, tuple variants no longer set `triggers_call_info` because it conflicts with placeholder generation, and tuple variants that require a qualified path should now use the qualified path. Internally, this also lets us break the general "format an item with fields on it" code out into a shared module, so that means it'll be a lot easier to implement features like #11568. Co-authored-by: Morgan Thomas <corp@m0rg.dev>	2022-03-12 13:05:45 +00:00
Morgan Thomas	f27c0ef1cf	Reduce intermediate string allocations in render::compound::render_record and ::render_tuple	2022-03-12 05:01:25 -08:00
Morgan Thomas	d430ddd809	Extract the code for formatting struct and enum-variant literal labels out into a common function	2022-03-12 04:40:05 -08:00
yipinliu	0c54921f93	Fixed code style issues	2022-03-12 20:36:56 +08:00