6 commits

Author	SHA1	Message	Date
Aleksey Kladov	5c9f31d4c2	internal: move diagnostics to hir ... The idea here is to eventually get rid of `dyn Diagnostic` and `DiagnosticSink` infrastructure altogether, and just have a `enum hir::Diagnostic` instead. The problem with `dyn Diagnostic` is that it is defined in the lowest level of the stack (hir_expand), but is used by the highest level (ide). As a first step, we free hir_expand and hir_def from `dyn Diagnostic` and kick the can up to `hir_ty`, as an intermediate state. The plan is then to move DiagnosticSink similarly to the hir crate, and, as final third step, remove its usage from the ide. One currently unsolved problem is testing. You can notice that the test which checks precise diagnostic ranges, unresolved_import_in_use_tree, was moved to the ide layer. Logically, only IDE should have the infra to render a specific range. At the same time, the range is determined with the data produced in hir_def and hir crates, so this layering is rather unfortunate. Working on hir_def shouldn't require compiling `ide` for testing.	2021-05-25 17:49:59 +03:00
Aleksey Kladov	5a42e6bff5	Explain how we get precise spans for diagnostics.	2020-11-28 18:14:08 +03:00
Lukas Wirth	c868f0255f	Fill the diagnostic code field in publish_diagnostics	2020-11-17 16:23:53 +01:00
Aleksey Kladov	8146669542	Add type safety to diagnostic codes	2020-08-18 18:39:43 +02:00
Igor Aleksanov	c26c911ec1	Merge branch 'master' into add-disable-diagnostics	2020-08-14 07:34:07 +03:00
Aleksey Kladov	b7aa4898e0	Rename ra_hir_expand -> hir_expand	2020-08-13 16:29:33 +02:00

Renamed from crates/ra_hir_expand/src/diagnostics.rs (Browse further)