Lukas Wirth
045014c17e
minor: Shorten spans of mismatched_arg_count diag
2021-12-04 00:27:29 +01:00
Lukas Wirth
ea03defeac
fix: Diagnose invalid derive attribute input
2021-11-19 13:17:35 +01:00
Lukas Wirth
6757910934
fix: Diagnose using derive on non-adt items
2021-11-19 12:10:55 +01:00
Lukas Wirth
439a8194b0
Replace more Name::to_string usages with Name::to_smol_str
2021-11-04 18:12:05 +01:00
Lukas Wirth
ac505b21a8
Fix missing_fields diagnostic fix replacing wrong text ranges
2021-10-15 19:27:19 +02:00
bors[bot]
64ca0f63bf
Merge #10504
...
10504: Remove needless clone r=lnicola a=k-nasa
## Why
Delete clones for efficiency
## What
- I erased unnecessary clones
Co-authored-by: k-nasa <htilcs1115@gmail.com>
2021-10-10 07:17:52 +00:00
k-nasa
b50cb5c261
Remove neesless clone
2021-10-10 10:50:51 +09:00
Aleksey Kladov
a85a3d73ed
feat: be more precise in mismatch arg counts highlighting
2021-10-09 22:45:54 +03:00
crauzer
ba62a8a075
fix test
2021-10-06 23:37:43 +02:00
Lukas Wirth
7faa35cbbd
Simplify
2021-10-04 15:16:13 +02:00
Aleksey Kladov
76e875542a
fix: remove semicolon diagnostics only highlights the semi
2021-10-02 12:54:10 +03:00
Lukas Wirth
b6ed91a6de
Rename *Owner traits to Has*
2021-09-27 12:54:24 +02:00
Jonas Schievink
7860d6ade6
Fix item-level lazy macro errors
2021-09-24 21:17:25 +02:00
Jonas Schievink
5967f3d3a9
Fix diagnostics in unnamed consts
2021-09-24 20:41:24 +02:00
bors[bot]
eb17e90eba
Merge #10105
...
10105: RfC: Use `todo!()` instead of `()` for missing fields r=jonas-schievink a=jo-so
Most commonly a field of a struct can be initialized with its default value than an empty tuple.
Co-authored-by: Jörg Sommer <joerg@jo-so.de>
2021-09-24 15:12:17 +00:00
Lukas Wirth
bd8c95a580
Fix incorrect mod.rs handling in unlinked_file fixes
2021-09-24 14:20:43 +02:00
Jörg Sommer
c87b860d3d
Use todo!() instead of () for missing fields
...
The generated code with `()` doesn't compile in most of the cases. To signal
the developer there's something to do, fill in `todo!()`.
Because the file *missing_fields.rs* contains the string `todo!()` it needs
an exception for the test *check_todo*.
2021-09-09 18:04:50 +02:00
bors[bot]
20f3792d10
Merge #10089
...
10089: Fix minor mispelling r=bjorn3 a=NerdyPepper
`find_map` misspelt as `wind_map` in test identifier.
Co-authored-by: Akshay <nerdy@peppe.rs>
2021-08-30 19:35:00 +00:00
bors[bot]
02a3d898e4
Merge #10076
...
10076: Use struct init shorthand when applicable in fill struct fields assist r=matklad a=nathanwhit
This PR tweaks the fill struct fields assist to use the struct init shorthand when a local variable with a matching name and type is in scope.
For example:
```rust
struct Foo {
a: usize,
b: i32,
c: char,
}
fn main() {
let a = 1;
let b = 2;
let c = 3;
let foo = Foo { <|> };
}
```
Before we would insert
```rust
Foo {
a: (),
b: (),
c: (),
}
```
now we would insert
```rust
Foo {
a,
b,
c: ()
}
```
Co-authored-by: nathan.whitaker <nathan.whitaker01@gmail.com>
2021-08-30 18:55:18 +00:00
nathan.whitaker
e1d86a42fe
Add coverage mark for struct init shorthand test
2021-08-30 14:37:03 -04:00
Akshay
e304a623ad
fix minor mispelling
...
find_map misspelt as wind_map
2021-08-30 22:51:14 +05:30
nathan.whitaker
e4757f9407
Update existing fill struct fields test
2021-08-29 13:14:15 -04:00
nathan.whitaker
251f9dfc8a
Add tests for fill struct fields shorthand
2021-08-29 13:14:03 -04:00
nathan.whitaker
dcd4157420
Use struct init shorthand in fill struct fields assist
2021-08-29 13:12:59 -04:00
Aleksey Kladov
78365c64c8
internal: slightly improve compile times
...
As per style guide, avoid monomorphisations
2021-08-29 12:53:56 +03:00
Jonas Schievink
3047ae8d0f
Enable diagnostics in const and static items
2021-08-27 23:21:21 +02:00
bors[bot]
b07c83f8b0
Merge #9810
...
9810: Add reference here r=matklad a=ivan770
Superseds #6853
Co-authored-by: ivan770 <ivan@ivan770.me>
2021-08-08 10:35:00 +00:00
ivan770
be3e70c604
Add reference here diagnostic
2021-08-08 10:12:40 +02:00
Lukas Wirth
c4a119f433
Simplify
2021-08-07 22:16:15 +02:00
Jonas Schievink
260936d0b7
Fix detection of macro file in inactive-code diag
2021-08-04 18:02:45 +02:00
Lukas Wirth
b96f1adf5c
Give TypeInfo fields and methods more appropriate names
2021-08-03 17:28:51 +02:00
Lukas Wirth
8afa2722b2
Revise TypeInfo::ty usage
2021-08-03 17:24:43 +02:00
Lukas Wirth
25ff7171c4
Introduce TypeInfo
2021-08-03 16:41:53 +02:00
Lukas Wirth
1edbaa29f9
Wrap inner tail expressions in MissingOkOrSomeInTailExpr
2021-07-31 20:00:09 +02:00
Lukas Wirth
82c1e61887
Fix assists assuming comma belonging to MATCH_ARM_LIST
2021-07-30 16:01:26 +02:00
Jonas Schievink
18b6327a29
Remove the legacy macro scoping hack
2021-07-26 19:58:14 +02:00
Jonas Platte
c0107d2ea6
Fix some grammar / spelling mistakes
2021-07-26 10:12:41 +02:00
Aleksey Kladov
bbb053532e
internal: remove one more needless extern crate
2021-07-11 15:48:49 +03:00
Aleksey Kladov
58d2ece88a
internal: overhaul code generation
...
* Keep codegen adjacent to the relevant crates.
* Remove codgen deps from xtask, speeding-up from-source installation.
This regresses the release process a bit, as it now needs to run the
tests (and, by extension, compile the code).
2021-07-03 22:11:03 +03:00
Jonas Schievink
69dce13ddd
Make unlinked_file diagnostic a hint again
2021-07-01 19:57:50 +02:00
Aleksey Kladov
90da9fc9b3
minor: use minicore
2021-06-18 23:48:18 +03:00
Aleksey Kladov
cc73abf72c
minor: use minicore
2021-06-18 23:33:01 +03:00
Aleksey Kladov
3f4ad44082
internal: document that we don't #[ignore] tests
2021-06-15 11:46:47 +03:00
Aleksey Kladov
4cfc767d7f
internal: test diagnostic severeties and presense of fixes
2021-06-14 22:37:06 +03:00
Aleksey Kladov
58712088ac
minor: make diagnostics more similar
2021-06-14 22:37:06 +03:00
Aleksey Kladov
4768e5fb23
internal: document diagnostics crate
2021-06-14 19:45:39 +03:00
Aleksey Kladov
26c978f258
internal: adapt diagnostics to the new rename API
2021-06-14 18:46:54 +03:00
Aleksey Kladov
a91071b57b
internal: cut deps between assists and diagnostics
2021-06-14 17:45:17 +03:00
Aleksey Kladov
2e8dab631b
internal: prepare to move assist definitions
2021-06-14 17:45:17 +03:00
Aleksey Kladov
1d2772c2c7
internal: move diagnostics to a new crate
2021-06-14 17:45:17 +03:00
