mahdi-frms
311dc5b04f
add test for method generation assist
2021-08-09 21:06:24 +04:30
mahdi-frms
3c31f3831d
One assist for function and method generation
2021-08-09 21:06:24 +04:30
mahdi-frms
02f5b5e0e2
method generation assist: store owned ast nodes
2021-08-09 21:06:24 +04:30
mahdi-frms
6240b2dae2
generate method adds pub keyword
2021-08-09 21:06:24 +04:30
mahdi-frms
d38f36e5af
generate method assist uses existing impl blocks
2021-08-09 21:06:24 +04:30
mahdi-frms
99570f32d8
refactor: use single next space
2021-08-09 21:06:24 +04:30
mahdi-frms
b777e498fe
refactor: use single fn_args
2021-08-09 21:06:24 +04:30
mahdi-frms
9ca73528ee
generate method assist
2021-08-09 21:06:24 +04:30
bors[bot]
caac771439
Merge #9735
...
9735: Add assist to sort members alphabetically. r=matklad a=vsrs
Supports traits, impls, structs, unions and enums (including inner struct variants). Does not support modules yet.
```rust
en┃um Animal {
Dog(String, f64),
Cat { weight: f64, name: String },
}
```
->
```rust
enum Animal {
Cat { weight: f64, name: String },
Dog(String, f64),
}
```
---
```rust
enum Animal {
Dog(String, f64),
Cat {┃ weight: f64, name: String },
}
```
->
```rust
enum Animal {
Dog(String, f64),
Cat { name: String, weight: f64 },
}
```
---
More samples in docs 0b7835619a/crates/ide_assists/src/handlers/sort_items.rs (L12-L83)#6110
Co-authored-by: vsrs <vit@conrlab.com>
2021-08-09 10:21:14 +00:00
bors[bot]
5664a2b0b3
Merge #9814
...
9814: Generate default impl when converting `#[derive(Debug)]` to manual impl r=yoshuawuyts a=yoshuawuyts
This patch makes it so when you convert `#[derive(Debug)]` to a manual impl, a default body is provided that's equivalent to the original output of `#[derive(Debug)]`. This should make it drastically easier to write custom `Debug` impls, especially when all you want to do is quickly omit a single field which is `!Debug`.
This is implemented for enums, record structs, tuple structs, empty structs - and it sets us up to implement variations on this in the future for other traits (like `PartialEq` and `Hash`).
Thanks!
## Codegen diff
This is the difference in codegen for record structs with this patch:
```diff
struct Foo {
bar: String,
}
impl fmt::Debug for Foo {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
- todo!();
+ f.debug_struct("Foo").field("bar", &self.bar).finish()
}
}
```
Co-authored-by: Irina Shestak <shestak.irina@gmail.com>
Co-authored-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Co-authored-by: Yoshua Wuyts <yoshuawuyts+github@gmail.com>
2021-08-08 22:30:37 +00:00
Yoshua Wuyts
59cdb51ef3
Remove unwraps
2021-08-09 00:29:38 +02:00
Yoshua Wuyts
f64aacc0c1
Use minicore
2021-08-08 18:58:42 +02:00
Lukas Wirth
3b7c713af3
Implement if_to_bool_then assist
2021-08-08 17:56:34 +02:00
Yoshua Wuyts
dcbf385ffc
use make::name_ref
2021-08-08 16:31:28 +02:00
Yoshua Wuyts
e26ba72333
Update replace_derive_with_manual_impl.rs
2021-08-08 16:26:25 +02:00
Yoshua Wuyts
a2e5fc659d
Improve naming and add comments
2021-08-08 16:26:25 +02:00
Yoshua Wuyts
720508a2df
dedup struct debug impl code
2021-08-08 16:26:25 +02:00
Yoshua Wuyts
cc3ff1b486
Fix enum debug indent level
2021-08-08 16:26:25 +02:00
Yoshua Wuyts
4b7ae9fedc
generate Debug for enums
2021-08-08 16:26:25 +02:00
Yoshua Wuyts
a1f2c7adcd
rename variables
...
According to https://github.com/rust-analyzer/rust-analyzer/blob/master/docs/dev/style.md#variable-naming
2021-08-08 16:26:25 +02:00
Yoshua Wuyts
aa09141a8a
finish debug_struct impls
2021-08-08 16:26:25 +02:00
Yoshua Wuyts
fd7236c791
debug for record field structs
2021-08-08 16:26:25 +02:00
Yoshua Wuyts
e2ab2e12a0
wip
2021-08-08 16:24:54 +02:00
Irina Shestak
f2e547d587
impl Debug def from trait
2021-08-08 16:24:54 +02:00
Lukas Wirth
c4a119f433
Simplify
2021-08-07 22:16:15 +02:00
Lukas Wirth
b6d574642d
extract_type_alias extracts generics correctly
2021-08-05 02:54:06 +02:00
Lukas Wirth
01413dd7d4
extract_function does not move locals defined outside of loops
2021-08-04 20:00:45 +02:00
Lukas Wirth
29c4ae6f9a
extract_assist is aware of the expression owner
2021-08-03 20:47:51 +02:00
Lukas Wirth
9edaf0cad8
extract_function is const aware
2021-08-03 18:43:28 +02:00
Lukas Wirth
e62ce6f61a
Reorganize functions in extract_function assist
2021-08-03 18:24:33 +02:00
Lukas Wirth
027a99fc70
Do no tear comments apart in extract_function assist
2021-08-03 17:39:49 +02:00
Lukas Wirth
b96f1adf5c
Give TypeInfo fields and methods more appropriate names
2021-08-03 17:28:51 +02:00
Lukas Wirth
8afa2722b2
Revise TypeInfo::ty usage
2021-08-03 17:24:43 +02:00
Lukas Wirth
25ff7171c4
Introduce TypeInfo
2021-08-03 16:41:53 +02:00
vsrs
cc33b0dc82
Update the docs
2021-08-02 20:24:18 +03:00
vsrs
6031dee145
Enable assist only if an item is selected
2021-08-02 19:58:41 +03:00
vsrs
e71b239d37
fix generated tests
2021-08-02 19:49:36 +03:00
vsrs
0088f84c88
Allow several samples in "// Assist:" comments.
2021-08-02 19:49:36 +03:00
vsrs
580e5e277a
Some comment tests
2021-08-02 19:49:36 +03:00
vsrs
4fa66f1e1e
Sort struct enum variant fields
2021-08-02 19:49:36 +03:00
vsrs
6f8888cfe7
Sort enums
2021-08-02 19:49:36 +03:00
vsrs
2c7e99b209
Sort unions
2021-08-02 19:49:36 +03:00
vsrs
b31bf74c13
cargo fmt
2021-08-02 19:49:36 +03:00
vsrs
0694f18636
Sort struct fields
2021-08-02 19:49:36 +03:00
vsrs
643f3931f7
Sort trait and impl methods
2021-08-02 19:49:36 +03:00
Lukas Wirth
432bb222c3
Simplify inline_local_variable assist
2021-08-02 15:27:47 +02:00
bors[bot]
93873b0ce1
Merge #9739
...
9739: generate function assist favors deref cmpt types r=matklad a=mahdi-frms
Fixes #9713
Although that's still not relying on sematic info.
Co-authored-by: mahdi-frms <mahdif1380@outlook.com>
2021-07-31 15:08:29 +00:00
Lukas Wirth
b363755901
Fix hover range for derive inputs
2021-07-31 14:59:31 +02:00
Lukas Wirth
7c7c4543da
Replace useless types
2021-07-31 14:29:15 +02:00
Lukas Wirth
778e6e8ba8
add_explicit_type is applicable for closure parameters
2021-07-31 14:04:34 +02:00
