bors[bot]
ca31b1d63a
Merge #5105
...
5105: Simlify with matches!() r=matklad a=Veetaha
Co-authored-by: Veetaha <veetaha2@gmail.com>
2020-06-28 22:37:25 +00:00
Aleksey Kladov
7cf1981a2d
Don't show ra_fixture param hints
2020-06-28 13:11:41 +02:00
Veetaha
e75e2ae5b6
Simlify with matches!()
2020-06-28 04:03:59 +03:00
Aleksey Kladov
e9cb818c26
Use fixtures more
2020-06-24 11:05:47 +02:00
Florian Diebold
a4a4a1854e
Fix type parameter defaults
...
They should not be applied in expression or pattern contexts, unless there are
other explicitly given type args.
2020-06-05 20:09:13 +02:00
Aleksey Kladov
522d24a607
Inlay Hints: more directly account for self param
2020-06-05 13:58:52 +02:00
Aleksey Kladov
1c6a2eb14a
Move the rest of the features to generated docs
2020-05-31 11:29:19 +02:00
Kirill Bulatov
30817de3af
Code review fixes
...
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2020-05-04 11:04:02 +03:00
Kirill Bulatov
66882f1a24
Move snake case method to heck
2020-05-03 21:35:21 +03:00
Kirill Bulatov
ba8ffab644
Omit name hints for enum names similar to parameter names
2020-05-03 15:55:08 +03:00
Kirill Bulatov
8eb820f460
Omit name hints for method names similar to parameter names
2020-05-03 15:55:08 +03:00
Aleksey Kladov
8843588fca
Convert tests to text-size
2020-04-25 11:59:18 +02:00
Laurențiu Nicola
8a51a74556
Omit more parameter hints in the presence of underscores
2020-04-18 10:53:48 +03:00
Laurențiu Nicola
81aab500c6
Hide parameter hints for single-argument functions with the same name
2020-04-09 21:47:04 +03:00
IceSentry
ebc61709c8
use .expr() to remove ref
2020-04-09 12:26:49 -04:00
IceSentry
ae416f3c6e
clean up param hint checking
2020-04-09 10:35:07 -04:00
IceSentry
cba694c602
better &mut
and &
matching
2020-04-08 19:26:47 -04:00
IceSentry
de6db06322
ignore &mut
and &
when checking params
2020-04-08 19:07:21 -04:00
IceSentry
a2dc18f71a
remove TODO
2020-04-08 18:11:24 -04:00
IceSentry
2a582b78a5
Add more heuristics for hiding obvious param hints
...
This will now hide "value", "pat", "rhs" and "other"
These words were selected from the std because they are used in common functions with only a single param and are obvious by their use.
I think it would be good to also hide "bytes" if the type is `[u8; n]` but I'm not sure how to get the param type signature
It will also hide the hint if the passed param starts or end with the param_name
2020-04-08 17:48:16 -04:00
Laurențiu Nicola
70960df437
Don't show chaining hints for record literals and unit structs
2020-04-01 13:14:41 +03:00
Aleksey Kladov
569f47e427
Better names for config structs
2020-03-31 16:05:25 +02:00
Matt Hooper
7b35da04bf
Improvements based on code review feedback
2020-03-25 00:18:55 +01:00
Matt Hooper
9d298115a6
Fmt corrections
2020-03-24 23:22:41 +01:00
Matt Hooper
b70ce559b8
Added more unit tests
2020-03-24 23:22:41 +01:00
Matt Hooper
a197abbc7a
Added new inlay hint kind and rules for method chaining
2020-03-24 23:18:42 +01:00
Aleksey Kladov
fd3ece2b73
Make naming more uniform
2020-03-12 17:38:48 +01:00
Steffen Lyngbaek
58248e24cd
Switch from Vec<InlayKind> to object with props
...
- Instead of a single object type, use several individual nested types
to allow toggling from the settings GUI
- Remove unused struct definitions
- Install and test that the toggles work
2020-03-11 20:14:39 -07:00
Steffen Lyngbaek
cfb48df149
Address Issues from Github
...
- Updated naming of config
- Define struct in ra_ide and use remote derive in rust-analyzer/config
- Make inlayConfig type more flexible to support more future types
- Remove constructor only used in tests
2020-03-10 14:36:01 -07:00
Steffen Lyngbaek
e98aff109a
Parameter inlay hint separate from variable type inlay? #2876
...
Add setting to allow enabling either type inlay hints or parameter
inlay hints or both. Group the the max inlay hint length option
into the object.
- Add a new type for the inlayHint options.
- Add tests to ensure the inlays don't happen on the server side
2020-03-10 14:33:45 -07:00
Kirill Bulatov
605dc98451
Omit unit struct hints
2020-03-08 23:21:08 +02:00
Aleksey Kladov
584c8d9875
Slightly refactor inlay hints
2020-02-29 23:24:50 +01:00
Aleksey Kladov
c3a4c4429d
Refactor primary IDE API
...
This introduces the new type -- Semantics.
Semantics maps SyntaxNodes to various semantic info, such as type,
name resolution or macro expansions.
To do so, Semantics maintains a HashMap which maps every node it saw
to the file from which the node originated. This is enough to get all
the necessary hir bits just from syntax.
2020-02-26 12:55:50 +01:00
Kirill Bulatov
7f3c0e8564
Omit type hints for enum variant bind pats
2020-02-24 10:32:46 +03:00
Kirill Bulatov
b2a7b29bb9
Style fixes
2020-02-23 13:02:00 +03:00
Kirill Bulatov
c200dba167
Add basic parameter name hints heuristics
2020-02-23 12:49:53 +03:00
Kirill Bulatov
ca4557ac52
Fix the tests
2020-02-23 01:44:15 +03:00
Kirill Bulatov
6670868d09
Show more parameter name hints
2020-02-23 01:44:15 +03:00
Kirill Bulatov
4ca22f3a88
Simplify inlay hints processing
2020-02-23 01:44:15 +03:00
Matthew Jasper
8c8d0bb34f
Add or- and parenthesized-patterns
2020-02-09 22:06:15 +00:00
Aleksey Kladov
88267c86c0
cleanup imports
2020-02-06 14:03:45 +01:00
Kirill Bulatov
fcf5bbbbeb
Fix inlay hints test snippet compilation
2020-02-03 13:35:14 +02:00
Kirill Bulatov
4029e44102
Omit default parameters for reference types
2020-01-22 16:55:09 +02:00
Florian Diebold
18ec4e3403
Improve parameter hints a bit & add emacs support
...
- just include the name, not e.g. `mut`
- don't return empty hints (or `_`)
2020-01-18 13:40:32 +01:00
Aleksey Kladov
272f6dfd9e
Micro-optimize type hints to avoid allocations
2020-01-16 14:31:34 +01:00
Aleksey Kladov
4194e5c88c
Optimize inlay hints
2020-01-15 16:52:28 +01:00
imtsuki
d78a3cb638
Update test snapshot
...
Signed-off-by: imtsuki <me@qjx.app>
2020-01-15 01:32:03 +08:00
imtsuki
c390e92fdd
Add inlay parameter name hints for function calls
...
Signed-off-by: imtsuki <me@qjx.app>
2020-01-15 01:18:52 +08:00
Kirill Bulatov
242be3631e
Omit closure parameters
2019-12-23 18:30:25 +02:00
Aleksey Kladov
d4b135f38c
Optimize and profile
2019-12-21 18:46:21 +01:00