Commit graph

2591 commits

Author SHA1 Message Date
Aleksey Kladov
f78b092629 fix panic in call info
closes #317
closes #675
2019-01-27 00:34:18 +03:00
bors[bot]
691ffd2dcb Merge #681
681: Use the correct working directory for cargo metadata and rustfmt r=matklad a=DJMcNab

Fixes maybe #670. @bjorn3, is that true?

(Awkward wording due to GitHub's eager 'fixes' finding)

Co-authored-by: DJMcNab <36049421+djmcnab@users.noreply.github.com>
2019-01-26 21:18:52 +00:00
DJMcNab
9fbbb8f609 Don't use the reserved error code 2019-01-26 20:58:50 +00:00
DJMcNab
d9456c3989 Return an lsp error 2019-01-26 20:43:51 +00:00
bors[bot]
0974e6abeb Merge #682
682: remove Option<SourceFileItemId> hack r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-26 20:27:30 +00:00
Aleksey Kladov
a128075af9 remove Option<SourceFileItemId> hack 2019-01-26 23:27:01 +03:00
DJMcNab
632b0f2902 Use the correct working directory for cargo metadata and rustfmt 2019-01-26 20:16:15 +00:00
Aleksey Kladov
9c1a18a626 store syntax ptr in FileItems
we cache the tree in file_item query anyway
2019-01-26 22:48:04 +03:00
Aleksey Kladov
ae97a45c35 remove dead code 2019-01-26 22:43:07 +03:00
bors[bot]
2d337c88b0 Merge #680
680: Struct literals should not be a `BlockLike::Block` r=DJMcNab a=DJMcNab

Fix #674.

Co-authored-by: DJMcNab <36049421+djmcnab@users.noreply.github.com>
2019-01-26 19:17:48 +00:00
DJMcNab
7a76433c45 Struct literals should not be a BlockLike::Block 2019-01-26 18:45:29 +00:00
bors[bot]
1662eb1f8d Merge #679
679: ⬆️ salsa r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-26 18:24:30 +00:00
Aleksey Kladov
a1fb8efd7a ⬆️ salsa 2019-01-26 21:23:59 +03:00
bors[bot]
d0ef1bde89 Merge #676
676: ⬆️ rowan r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-26 16:41:40 +00:00
Aleksey Kladov
6f862a6704 ⬆️ rowan
The new rowan uses arena allocator for red nodes which helps
slightly (5% on std completion test) with performance but should help
quite a bit with avoiding memory fragmentation.
2019-01-26 19:39:31 +03:00
Jeremy Kolb
a892067951 Make doc comments optional 2019-01-26 10:35:23 -05:00
bors[bot]
a8d32c4d1a Merge #671
671: Makre VFS slightly less super obscure r=vemoo a=matklad

I've decided to better understand what we do in VFS, and this turns out to be really hard. Jugling threads and channels is one of the most unfortunately arcane bits of rust...

I had some success though by flattenning the structure so that all channel & thread creation routines are on one screen. 

r? @vemoo 

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-26 15:13:44 +00:00
Jeremy Kolb
e9e0ea0398 Do not unconditionally trim comments 2019-01-26 09:55:30 -05:00
Jeremy Kolb
8c08b6825e Preserve indentation in doc comments 2019-01-26 09:50:17 -05:00
Aleksey Kladov
9f16892b94 remove watcher ctx 2019-01-26 17:17:28 +03:00
Aleksey Kladov
bf98fc609e remove mutexes 2019-01-26 17:04:00 +03:00
Aleksey Kladov
012ea3fac6 handle all the reads on the "main" watcher thread 2019-01-26 17:01:58 +03:00
Aleksey Kladov
3ce531f95d cleanup: add result alias 2019-01-26 16:40:24 +03:00
Aleksey Kladov
390a20787e consolidate error handling 2019-01-26 16:28:04 +03:00
Aleksey Kladov
20d7a431fd refactor-fvs 2019-01-26 16:28:04 +03:00
bors[bot]
5af7b2f4af Merge #673
673: minor cleanups r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-26 13:26:56 +00:00
Aleksey Kladov
bf7a0f43d0 minor cleanups 2019-01-26 16:26:30 +03:00
bors[bot]
3feaf2a008 Merge #659
659: Fold blocks of mod items r=matklad a=eulerdisk

Fixes #572

As requested, we ignore `mod`s with a visibility specifier.

Co-authored-by: Andrea Pretto <eulerdisk@gmail.com>
2019-01-26 12:49:08 +00:00
bors[bot]
05d0c493c9 Merge #672
672: dont overwrite memfies r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-26 12:42:14 +00:00
Aleksey Kladov
07a4b9f1a0 dont overwrite memfies 2019-01-26 15:41:52 +03:00
Andrea Pretto
b9ca8ab868 Better visibility check. 2019-01-26 13:32:48 +01:00
bors[bot]
2acaa92c93 Merge #660
660: Support macro calls in type position r=matklad a=regiontog

A [playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=fdc6dd4ddaece92a72fa2a292b75e27c) demonstrating the syntax in question.

Co-authored-by: Erlend Tobiassen <erlend.tobiassen@gmail.com>
2019-01-26 10:23:28 +00:00
bors[bot]
8b6dea348f Merge #666
666: rename source_file -> parse r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-26 08:55:38 +00:00
Aleksey Kladov
9457b1f0e6 rename source_file -> parse 2019-01-26 11:51:36 +03:00
bors[bot]
c869ee219a Merge #665
665: Pr 556 r=matklad a=matklad

Rebased #556 

Thanks @vemoo, now I can change branches without reopening VS Code!

Co-authored-by: Bernardo <berublan@gmail.com>
2019-01-26 08:47:56 +00:00
Bernardo
410a3ae6e8 use entry file_type, improve test 2019-01-26 11:46:37 +03:00
Bernardo
d63e1cebff use Roots in watcher 2019-01-26 11:46:37 +03:00
Bernardo
86fadbd4e5 extract Roots struct 2019-01-26 11:46:37 +03:00
Bernardo
cfbf47b002 review fixes 2019-01-26 11:46:37 +03:00
Bernardo
34a34f9399 use released notifiy version, add TODO comment 2019-01-26 11:46:37 +03:00
Bernardo
be14ab217c better test, avoid duplicated events 2019-01-26 11:46:27 +03:00
Bernardo
0a08650852 hardcode ".git" and "node_modules" also 2019-01-26 11:46:27 +03:00
Bernardo
10a24cf649 simplify and optimize RootFilterby determining if is contained first 2019-01-26 11:46:27 +03:00
Bernardo
eeed6cf53b fix recursive watch 2019-01-26 11:46:27 +03:00
Bernardo
2a1afad3ed avoid boxing 2019-01-26 11:46:27 +03:00
Bernardo
277e0f1baa move watcher to io module 2019-01-26 11:46:27 +03:00
Bernardo
7f7c4e7465 do not emit create for directory again 2019-01-26 11:46:27 +03:00
Bernardo
f88355ccb5 refactor, put watcher with io::Worker
use `RootFilter` to filter recursive watches
untested
2019-01-26 11:46:27 +03:00
Bernardo
eacf7aeb42 ignore check event dir for ignore, cleanup tests 2019-01-26 11:46:27 +03:00
Bernardo
fb1d748a2c actually drop watcher, use parking_lot::Mutex 2019-01-26 11:46:27 +03:00