2764 commits

Author	SHA1	Message	Date
Lukas Wirth	c8f6655327	Don't emit modifiers depending on the symbol kind in lsp conversion layer	2024-03-17 10:40:32 +01:00
Lukas Wirth	66adc1cc94	Emit Const modifier in syntax highlighting for const-like things	2024-03-17 10:35:33 +01:00
hkalbasi	dcfc9ccace	Distinguish integration tests from crates in test explorer	2024-03-15 17:16:28 +03:30
hkalbasi	eeff20d172	Show compilation progress in test explorer	2024-03-15 16:28:59 +03:30
Lukas Wirth	c50c4f8bbb	internal: Use assoc items as anchors for spans	2024-03-15 09:28:39 +01:00
Lukas Wirth	9ba4493918	internal: Improve rooted upmapping	2024-03-12 13:46:58 +01:00
bors	8f8bcfc131	Auto merge of #16335 - lnicola:salsa-lz4-file-text, r=Veykril ... internal: Compress file text using LZ4 I haven't tested properly, but this roughly looks like: ``` 1246 MB 59mb 4899 FileTextQuery 1008 MB 20mb 4899 CompressedFileTextQuery 555kb 1790 FileTextQuery ``` We might want to test on something more interesting, like `bevy`.	2024-03-11 13:43:33 +00:00
bors	2f872156fe	Auto merge of #16808 - ShoyuVanilla:proc-macro-sem-token, r=Veykril ... feat: Add proc macro semantic token type Closes #11529	2024-03-11 13:20:29 +00:00
Shoyu Vanilla	fc11216ad5	feat: Add proc macro semantic token type	2024-03-11 22:14:59 +09:00
bors	2320e12541	Auto merge of #16771 - Veykril:self-param-split, r=Veykril ... internal: Don't desugar self param into a pattern Small experiment to see if this simplifies things	2024-03-11 12:45:46 +00:00
Lukas Wirth	0dbaccd484	Track vscode version for conditional bug server sided bugfixes	2024-03-11 10:31:06 +01:00
Kirill Bulatov	57a0ad4343	Stop eagerly resolving inlay hint text edits for VSCode ... After https://github.com/microsoft/vscode/issues/193124 was fixed, this change is not needed anymore.	2024-03-11 10:22:02 +01:00
Lukas Wirth	458f4a2960	internal: Treat the self param as different from patterns when lowering	2024-03-11 09:46:28 +01:00
bors	574e23ec50	Auto merge of #16794 - HKalbasi:test-explorer, r=lnicola ... Some minor changes in the test explorer lsp extension followup #16662 cc `@nemethf` `@ShuiRuTian`	2024-03-09 10:01:41 +00:00
r0cky	79508d909a	remove unused struct Snap in lsif	2024-03-09 09:09:27 +08:00
hkalbasi	dc99ad912a	Some minor changes in the test explorer lsp extension	2024-03-09 01:21:27 +03:30
Laurențiu Nicola	a12ccd5923	Fix test	2024-03-08 20:39:47 +02:00
Laurențiu Nicola	0f43b55e83	Stop using an Arc when setting the file text	2024-03-08 20:30:12 +02:00
bors	a1fda6476c	Auto merge of #16742 - alibektas:13529/source_root_tree, r=Veykril ... internal: Implement parent-child relation for `SourceRoot`s This commit adds the said relation by keeping a map of type `FxHashMap<SourceRootId,Option<SourceRootId>>` inside the `GlobalState`. Its primary use case is reading `rust-analyzer.toml`(#13529) files that can be placed in every local source root. As a config will be found by traversing this "tree" we need the parent information for every local source root. This commit omits defining this relation for library source roots entirely.	2024-03-07 10:30:08 +00:00
bors	00f6a7aced	Auto merge of #16772 - Veykril:salsa-tracing, r=Veykril ... internal: Add tracing spans to macro generated database	2024-03-07 10:16:53 +00:00
Lukas Wirth	9c2fa76c84	Dedup hprof stuff	2024-03-07 10:21:50 +01:00
Lukas Wirth	09d33f3e1e	Add diagnostics integrated benchmark	2024-03-07 09:33:48 +01:00
Ali Bektas	9c50d129da	Opt for FxHashMap<Id,Id> instead of <Id,Option<Id>> and apply requested changes	2024-03-06 19:55:04 +01:00
Ali Bektas	a15cc86c64	Implement parent-child relation for SourceRoots ... This commit adds the said relation by keeping a map of type `FxHashMap<SourceRootId,Option<SourceRootId>>` inside the `GlobalState`. Its primary use case is reading the rust-analyzer.toml files that can be placed under every local source root. As a config will be found by traversing this "tree" we need the parent information for every local source root. This commit omits defining this relation for library source roots entirely.	2024-03-06 19:55:04 +01:00
bors	ce15e73a8e	Auto merge of #16773 - Veykril:text-explorer, r=Veykril ... fix: Add config and capability for test explorer	2024-03-06 18:26:40 +00:00
Lukas Wirth	1c6d1b4f2a	fix: Add config and capability for test explorer	2024-03-06 19:20:58 +01:00
bors	b85d38f7d6	Auto merge of #16755 - Veykril:rustup-bins, r=Veykril ... For toolchain binaries use the full path found in $PATH Fixes https://github.com/rust-lang/rust-analyzer/issues/16754	2024-03-06 14:47:32 +00:00
hkalbasi	44be2432f5	Add test explorer	2024-03-06 00:05:29 +03:30
bors	676455f911	Auto merge of #16757 - Veykril:style-lints, r=Veykril ... fix: Put style lints behind disabled-by-default config Fixes https://github.com/rust-lang/rust-analyzer/issues/16542 Fixes https://github.com/rust-lang/rust-analyzer/issues/16725 cc https://github.com/rust-lang/rust-analyzer/issues/16628 Our diagnostic infra is not yet setup for those kinds of diagnostics	2024-03-05 10:45:05 +00:00
Lukas Wirth	8844640c6f	fix: Put style lints behind disabled-by-default config	2024-03-05 11:43:23 +01:00
Lukas Wirth	b20e467373	internal: Adjust a few things for trait assoc item hovers	2024-03-05 11:06:36 +01:00
Lukas Wirth	c310aee8d6	For toolchain binaries ue the full path found in $PATH	2024-03-05 10:17:09 +01:00
bors	ce3216e0ae	Auto merge of #15938 - Young-Flash:display_trait_item_when_hover, r=Veykril ... feat: add hover display for trait assoc items This PR enable preview assoc items when hover on `trait`  inspired by https://github.com/rust-lang/rust-analyzer/pull/15847	2024-03-05 08:26:53 +00:00
Lukas Wirth	0964374274	Move diagnostics docs generation into xtask/codegen	2024-03-04 17:14:14 +01:00
bors	a7e9f12bf7	Auto merge of #16748 - Veykril:on-demand-validation-err, r=Veykril ... internal: Compute syntax validation errors on demand The LRU cache causes us to re-parse trees quite often, yet we don't use the validation errors at all. With this we push calculating them off to the caller who is interested in them.	2024-03-04 11:19:16 +00:00
Lukas Wirth	c3c9f5ffe1	internal: Compute syntax validation errors on demand	2024-03-04 12:06:15 +01:00
bors	99a1b8f7a8	Auto merge of #16747 - Veykril:cleanup, r=Veykril ... internal: Clean some stuff up Just a bunch of small refactorings, mainly from browsing through `hir-def`	2024-03-04 10:30:17 +00:00
Lukas Wirth	4303e741de	Cleanup	2024-03-04 11:10:06 +01:00
bors	2074cc28de	Auto merge of #16722 - mo8it:allocations, r=Veykril ... Avoid some allocations I went on a small `.clone()` hunting tour :D	2024-03-04 09:17:23 +00:00
Young-Flash	dba67b46a1	update for review	2024-03-02 10:01:04 +08:00
Lukas Wirth	ed7e9aa5d8	Simplify	2024-03-01 13:25:24 +01:00
Lukas Wirth	c8fdcea85c	Fix targetDir config name	2024-03-01 13:19:55 +01:00
Lukas Wirth	83a1ad5bfe	Give all threads names	2024-03-01 13:19:55 +01:00
mo8it	4aab2d5cb4	Remove unneeded to_owned	2024-02-29 16:29:15 +01:00
mo8it	748f57c16d	Only clone when required	2024-02-29 16:28:59 +01:00
Lukas Wirth	4ee0dbdc04	internal: Remove load-cargo dependency on ide	2024-02-28 16:59:04 +01:00
Tavo Annus	a2bf15eede	Filter out false positive errors	2024-02-26 20:17:09 +02:00
Graeme Read	30429f8ece	feat: Add short flag -V for consistency with other rust tooling	2024-02-24 06:45:00 +00:00
Lukas Wirth	c6a6e63a45	internal: Pin commit of rust-lang/rust for rustc-test metrics	2024-02-23 17:24:29 +01:00
Lukas Wirth	9b7284dca7	fix: Fix deadlock in recreate_crate_graph <-> file_line_index	2024-02-23 10:10:48 +01:00
Young-Flash	2e87f31fe9	add HoverDisplayConfig	2024-02-22 17:37:40 +08:00
Young-Flash	35ec5955eb	add config item for hover display	2024-02-21 11:08:45 +08:00
DropDemBits	07421c13d4	fix: Don't add \ before { ... The LSP snippet grammar only specifies that `$`, `}`, and `\` can be escaped with backslashes, but not `{`.	2024-02-20 14:35:59 -05:00
Lukas Wirth	16b15a203e	internal: Attempt to add a timeout to rustc-tests	2024-02-20 18:04:53 +01:00
Lukas Wirth	9dee352da0	fix: server hanging up on build script task	2024-02-20 15:55:17 +01:00
Lukas Wirth	d93096ecc0	internal: Fetch toolchain and datalayout for DetachedFiles	2024-02-20 10:40:39 +01:00
Lukas Wirth	91a8f34aee	Deduplicate lsp locations	2024-02-19 12:23:59 +01:00
Johannes Altmanninger	30b992e95a	Deduplicate references to macro argument ... Commit 6a06f6f72 (Deduplicate reference search results, 2022-11-07) deduplicates references within each definition. There is an edge case when requesting references of a macro argument. Apparently, our descend_into_macros() stanza in references.rs produces a cartesian product of - references inside the macro times - times references outside the macro. Since the above deduplication only applies to the references within a single definition, we return them all, leading to many redundant references. Work around this by deduplicating definitions as well. Perhaps there is a better fix to not produce this cartesian product in the first place; but I think at least for definitions the problem would remain; a macro can contain multiple definitions of the same name, but since the navigation target will be the unresolved location, it's the same for all of them. We can't use unique() because we don't want to drop references that don't have a declaration (though I dont' have an example for this case). I discovered this working with the "bitflags" macro from the crate of the same name. Fixes #16357	2024-02-19 12:23:59 +01:00
Young-Flash	f3d84e86c8	minor: fix typo	2024-02-19 18:12:08 +08:00
bors	ac998a74b3	Auto merge of #16579 - DropDemBits:structured-snippet-fix-with-escaped-bits-and-cr, r=Veykril ... fix: Fix snippets being placed leftwards of where they should be Snippet bits were being escaped before placing snippets, shifting snippets leftwards. Snippets were also being shifted leftwards on files with CRLF line endings since they were placed done after the Unix -> DOS line ending conversion. Hoping this fixes all of the little bugs related to snippet rendering 😅	2024-02-16 18:45:43 +00:00
Lukas Wirth	ead369117a	CrateOrigin::Local means local to the project workspace, not cargo workspace	2024-02-16 16:28:17 +01:00
Lukas Wirth	0ccb3b8731	Move dedup-dev-deps tests into rust-analyzer crate	2024-02-16 15:47:40 +01:00
Lukas Wirth	b1404d387a	fix: Split toolchain and datalayout out of CrateData	2024-02-16 14:48:25 +01:00
DropDemBits	e8457bb78b	Escape { and } as well ... These are used in placeholder snippets, which may occur elsewhere in the insert text.	2024-02-16 00:28:02 -05:00
DropDemBits	1d8ed3408e	Escape snippet bits in-between placing snippets ... Done so that we don't shift the range that we insert the snippet at.	2024-02-16 00:28:02 -05:00
DropDemBits	1aeec93412	Only use snippet_text_edit to make snippet SnippetTextEdits ... The eventual LSP representation looks like it will diverge from RA's representation of `SnippetTextEdit`s, so this'll make it easier to transition to the LSP representation later.	2024-02-16 00:28:02 -05:00
DropDemBits	e4a3cc34d5	Add better snippet bits test	2024-02-16 00:28:01 -05:00
DropDemBits	e9efb568f6	Add dos line ending test	2024-02-16 00:28:01 -05:00
bors	b30b77d373	Auto merge of #16573 - Veykril:salsa-doc-tests, r=Veykril ... internal: Remove salsa doc compile tests These don't play well with the github CI error annotations	2024-02-15 16:29:39 +00:00
Lukas Wirth	1443d49b72	Remove salsa doc compile tests	2024-02-15 17:28:24 +01:00
bors	db277c7bb3	Auto merge of #16569 - DropDemBits:structured-snippet-fix-adjust-snippet-ranges, r=Veykril ... fix: Place snippets correctly in multi-edit assists Fixes #16539	2024-02-15 15:54:23 +00:00
DropDemBits	7cf4a8a3bf	fix: Place snippets correctly in multi-edit assists	2024-02-14 21:35:17 -05:00
DropDemBits	0d6024c021	Add tests for snippet range adjustment ... Uses actual source for tests to easily confirm the results.	2024-02-14 21:33:05 -05:00
Wilfred Hughes	dda641c62c	Set documentation field in SCIP from doc comment ... Previously, the documentation field was the same as the text shown to users when they hover over that symbol. The documentation should really just be the doc comment, and as of #16179 the signature is already stored in the signatureDocumentation field.	2024-02-14 14:46:32 -08:00
bors	3bb8d3a32f	Auto merge of #16247 - Veykril:opqueues, r=Veykril ... fix: Fix build scripts not being rebuilt in some occasions Also makes proc-macro changed flag setting async, we don't wanna block `process_changes` on the database as that is on the main thread!	2024-02-14 14:33:16 +00:00
Lukas Wirth	1e6cef94df	fix: Fix build scripts not being rebuilt in some occasions	2024-02-14 15:20:45 +01:00
Lukas Wirth	465ddef7cc	fix: Set RUSTUP_TOOLCHAIN and invoke the proxies instead of directly invoking sysroot binaries	2024-02-14 15:13:45 +01:00
Lukas Wirth	f481181a14	Run rustfmt directly on CI	2024-02-14 11:36:25 +01:00
Lukas Wirth	a981db53fa	fix: Pass .cargo/config.toml env vars to proc-macro server	2024-02-13 19:42:03 +01:00
bors	1811210339	Auto merge of #15476 - Wilfred:implement-saved-file3, r=Veykril ... Substitute $saved_file in custom check commands If the custom command has a $saved_file placeholder, and we know the file being saved, replace the placeholder and run a check command. If there's a placeholder and we don't know the saved file, do nothing. This is a simplified version of #15381, which I hope is easier to review.	2024-02-12 14:59:37 +00:00
bors	818c30c311	Auto merge of #16092 - kilpkonn:term_search_1, r=Veykril ... feat: Introduce term search to rust-analyzer # Introduce term search to `rust-analyzer` _I've marked this as draft as there might be some shortcomings, please point them out so I can fix them. Otherwise I think it is kind of ready as I think I'll rather introduce extra functionality in follow up PRs._ Term search (or I guess expression search for rust) is a technique to generate code by basically making the types match. Consider the following program ```rust fn wrap(arg: i32) -> Option<i32> { todo!(); } ``` From the types of values in scope and constructors of `Option`, we can produce the expected result of wrapping the argument in `Option` Dependently typed languages such as `Idris2` and `Agda` have similar tools to help with proofs, but this can be also used in everyday development as a "auto-complete". # Demo videos https://github.com/rust-lang/rust-analyzer/assets/19900308/7b68a1b7-7dba-4e31-9221-6c7485e77d88 https://github.com/rust-lang/rust-analyzer/assets/19900308/0fae530a-aabb-4b28-af71-e19f8d3d64b2 # What does it currently do - It works well with locals, free functions, type constructors and non-static impl methods that take items by value. - Works with functions/methods that take shared references, but not with unique references (very conservative). - Can handle projections to struct fields (eg. `foo.bar.baz`) but this might me more conservative than it has to be to avoid conflicting with borrow checker - Should create only valid programs (no type / borrow checking errors). Tested with `rust-analyzer analysis-stats /path/to/ripgrep/Cargo.toml --run-term-search --validate-term-search` (basically running `cargo check` on all of the generated programs and only error seems to be due to type inference which is more of issue of testing method. # Performace / fitness ```txt ripgrep (latest) Tail Expr syntactic hits: 130/1692 (7%) Tail Exprs found: 523/1692 (30%) Term search avg time: 9ms Term search: 15.64s, 97ginstr, 8mb rust-analyzer (on this branch) Tail Expr syntactic hits: 804/13860 (5%) Tail Exprs found: 6757/13860 (48%) Term search avg time: 78ms Term search: 1088.23s, 6765ginstr, 98mb ``` Highly generic code seems to blow up the search space so currently the amount of generics allowed is functions/methods is limited down to 0 (1 didn't give much improvement and 2 is already like 0.5+s search time) # Plans for the future (not in this PR) - ``~~Add impl methods that do not take `self` type (should be quite straight forward)~~ Done - Be smarter (aka less restrictive) about borrow checking - this seems quite hard but since the current approach is rather naive I think some easy improvement is available. - ``~~See if it works as a autocomplete while typing~~ Done _Feel free to ask questions / point of shortcoming either here or on Zulip, I'll be happy to address them. I'm doing this as part of my MSc thesis so I'll be working on it till summer anyway 😄_	2024-02-12 14:47:12 +00:00
Wilfred Hughes	cdbf54f4bd	flycheck: initial implementation of $saved_file ... If the custom command has a $saved_file placeholder, and we know the file being saved, replace the placeholder and then run a check command. If there's a placeholder and we don't know the saved file, do nothing.	2024-02-12 15:45:48 +01:00
Lukas Wirth	e2a985e93f	Encode disabled proc-macros via boolean flag, not special Expander	2024-02-12 13:39:38 +01:00
tamasfe	6d45afd8d8	feat: ignored and disabled macro expansion	2024-02-12 12:50:40 +01:00
Lukas Wirth	8f3209ba27	internal: tool discovery prefers sysroot tools	2024-02-12 12:08:18 +01:00
Tavo Annus	125791386d	Cleanup term search related changes	2024-02-11 14:35:54 +02:00
Tavo Annus	88964c0b6a	Optionally disable term search for autocompletion	2024-02-11 13:33:29 +02:00
Tavo Annus	0b838e3e23	Expand target for autocompletion	2024-02-11 13:33:29 +02:00
Tavo Annus	a946970e2d	Add quantified trees to reduce autocomplete options	2024-02-11 13:33:29 +02:00
Tavo Annus	bdbdd83ec1	Initial version of term_search for autocomplete	2024-02-11 13:33:29 +02:00
Tavo Annus	627255dd5a	Add static method tactic	2024-02-11 13:33:29 +02:00
Tavo Annus	bb3c7cff60	Introduce term search to rust-analyzer	2024-02-11 13:33:29 +02:00
Tetsuharu Ohzeki	395708d5e0	rust-analyzer: Fix warnings about clippy str_to_string rule	2024-02-10 01:00:40 +09:00
bors	13707845f7	Auto merge of #15863 - davidbarsky:davidbarsky/start-of-monorepo-mode, r=Veykril ... feature: Create `UnindexedProject` notification to be sent to the client (Note that this branch contains commits from https://github.com/rust-lang/rust-analyzer/pull/15830, which I'll rebase atop of as needed.) Based on the discussion in https://github.com/rust-lang/rust-analyzer/issues/15837, I've added a notification and off-by-default toggle to send that notification from `handle_did_open_text_document`. I'm happy to rename/tweak this as needed. I've been using this for a little bit, and it does seem to cause a little bit more indexing/work in rust-analyzer, but it's something that I'll profile as needed, I think.	2024-02-08 19:36:09 +00:00
David Barsky	6330b028b3	feature: Add a UnindexedProject notification and a corresponding setting.	2024-02-08 14:23:00 -05:00
Lukas Wirth	91dab4d720	Better error message for when proc-macros have not yet been built	2024-02-08 14:53:12 +01:00
Lukas Wirth	0258f60cfe	feat: Allow cargo check to run on only the current package	2024-02-08 10:40:42 +01:00
Lukas Wirth	9e8a0fae0c	Lint debug prints and disallowed types with clippy	2024-02-01 17:57:27 +01:00
bors	850ba2fb63	Auto merge of #16451 - Urhengulas:satisfy-clippy, r=Veykril ... internal: Work through temporarily allowed clippy lints, part 2 Another follow-up to https://github.com/rust-lang/rust-analyzer/pull/16401.	2024-02-01 14:23:18 +00:00
bors	42cb1a2bd7	Auto merge of #16465 - Veykril:eprintln, r=Veykril ... minor: Remove `stdx::eprintln` overwrite	2024-01-31 21:07:50 +00:00
Lukas Wirth	23f4b7f45f	Remove stdx::eprintln overwrite	2024-01-31 22:06:05 +01:00
bors	039681112f	Auto merge of #16456 - davidbarsky:david/tracing-followups, r=Veykril ... internal: `tracing` improvements and followups Hi folks! Building on https://github.com/rust-lang/rust-analyzer/pull/16394, I've got a few small tweaks: - Removed the accidental `mod.rs` usage that I introduced. - Removed a panic in `pat_analysis.rs`. - Recorded the event kind in `handle_event` to better distinguish what _kind_ of event is being handled. - Did a small refactor of `hprof` to have somewhat more linear control flow, and more importantly, write the recorded fields to the output. The end result is the following: <img width="1530" alt="A screenshot of Visual Studio Code on a Mac. `hprof.rs` is open, with " src="https://github.com/rust-lang/rust-analyzer/assets/2067774/bd11dde5-b2da-4774-bc38-bcb4772d1192">	2024-01-31 18:29:51 +00:00
David Barsky	44494e235a	internal: teach hprof to record tracing fields	2024-01-31 13:15:47 -05:00
Johann Hemmann	771c6c9271	format_collect	2024-01-31 19:06:36 +01:00
Johann Hemmann	04ccef80cb	field_reassign_with_default	2024-01-31 19:06:18 +01:00
Johann Hemmann	b73ee2f50d	useless_conversion	2024-01-31 19:06:18 +01:00
Johann Hemmann	f15ee8a380	unnecessary_filter_map	2024-01-31 19:06:18 +01:00
David Barsky	579e98c4c5	internal: record Event kind in handle_event	2024-01-31 13:00:40 -05:00
bors	355c9444e1	Auto merge of #16448 - Young-Flash:typos, r=lnicola ... minor: correct typos I use [crate-ci/typos](https://github.com/crate-ci/typos) to check typos in codebase, if it's ok with you, I'd like to add a typo check CI using [typos](https://github.com/crate-ci/typos) (with Apache-2.0, MIT licenses). BTW, we can add a [_typos.toml](https://github.com/crate-ci/typos/blob/master/docs/reference.md) as white list for some intentional typos	2024-01-31 13:29:55 +00:00
bors	9d837a622d	Auto merge of #16445 - lnicola:bump-scip, r=lnicola ... internal: Bump scip Fixes #16440	2024-01-31 09:27:01 +00:00
bors	e4146af294	Auto merge of #16441 - Young-Flash:exclude_tests_refs, r=Veykril ... feat: enable excluding refs search results in test ## Change Here I introduce a new `ReferenceCategory::Test` type to indicate whether the function where this reference is located is marked as `#[test]`, and expose an config item (`rust-analyzer.references.excludeTests`) to client. I also changed the signature of `ReferenceCategory::new`, adding a `sema: &Semantics<'_, RootDatabase>` param to do some hir analysis. Hope the current implementation is good to go. ## Demo `"rust-analyzer.references.excludeTests": false`  `"rust-analyzer.references.excludeTests": true`  close https://github.com/rust-lang/rust-analyzer/issues/14530	2024-01-31 07:53:28 +00:00
David Barsky	17d2e8d910	internal: remove tracing/mod.rs	2024-01-30 13:37:27 -05:00
David Barsky	e1ea7c8844	internal: switch to tracing from log ... This commit also adds `tracing` to NotificationDispatcher/RequestDispatcher, bumps `rust-analyzer-salsa` to 0.17.0-pre.6, `always-assert` to 0.2, and removes the homegrown `hprof` implementation in favor of a vendored tracing-span-tree.	2024-01-30 12:27:31 -05:00
Young-Flash	db9fd370ee	minor: correct typos	2024-01-30 21:43:43 +08:00
bors	11b401d0b4	Auto merge of #16447 - Veykril:mir-errors, r=Veykril ... intenral: Cleanup error variants in MIR code a bit	2024-01-30 11:38:41 +00:00
Lukas Wirth	5860763f18	Cleanup error variants in MIR code slightly	2024-01-30 09:53:39 +01:00
Laurențiu Nicola	20c01672a8	Bump scip	2024-01-30 08:43:17 +02:00
Young-Flash	6f303f49fe	feat: enable excluding refs search results in test	2024-01-28 18:28:13 +08:00
bors	27c3ed9de8	Auto merge of #16434 - Veykril:things, r=Veykril ... internal: Restructure and cleanup hir-expand a bit	2024-01-27 10:16:35 +00:00
Lukas Wirth	8a5829cf28	Re-order mod declarations	2024-01-27 11:02:34 +01:00
Kirill Bulatov	ad5e2cfa3b	Do not return code lens data after resolving	2024-01-27 02:03:15 +02:00
Nadrieril	2370b70f25	Replace local copy of exhaustiveness checking with upstream librarified version	2024-01-23 15:54:00 +01:00
Johann Hemmann	9e837790d1	redundant_locals	2024-01-19 18:36:32 +01:00
Johann Hemmann	b1a0c9ac40	single_match	2024-01-19 18:31:15 +01:00
Johann Hemmann	71d4dba960	redundant_pattern_matching	2024-01-19 17:31:01 +01:00
Johann Hemmann	bef355168a	non_minimal_cfg	2024-01-19 17:31:01 +01:00
Johann Hemmann	2ae2512378	if_same_then_else	2024-01-19 17:31:01 +01:00
Johann Hemmann	84494d1c8e	from_str_radix_10	2024-01-19 17:31:01 +01:00
Johann Hemmann	6709eaba2a	never_loop	2024-01-19 17:31:01 +01:00
Johann Hemmann	b5eca5f2fc	collapsible_if	2024-01-19 17:31:00 +01:00
Johann Hemmann	3041164301	Temporarily allow all lints which occur ... They will be removed one by one	2024-01-19 12:52:12 +01:00
bors	85c9a83262	Auto merge of #16398 - Urhengulas:satisfy-clippy, r=Veykril ... `cargo clippy --fix` This PR is the result of running `cargo clippy --fix && cargo fmt` in the root of the repository. I did not manually review all the changes, but just skimmed through a few of them. The tests still pass, so it seems fine.	2024-01-19 09:43:35 +00:00
bors	3f4c6dac3d	Auto merge of #16372 - davidsemakula:import-granularity-one, r=Veykril ... feat: Add "One" import granularity Adds a new import granularity option "One" that merges all imports into a single use statement as long as they have the same visibility and attributes. This is similar to [rustfmt's `imports_granularity = "One"`](https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=import#imports_granularity). Fixes: #11361	2024-01-18 15:40:12 +00:00
bors	a5b89fffb6	Auto merge of #16391 - alibektas:15656/renaming_allowed_by_config, r=Veykril ... Add a new config to allow renaming of non-local defs With #15656 we started disallowing renaming of non-local items. Although this makes sense there are some false positives that impacted users' workflows. So this config aims to mitigate this by giving users the liberty to disable this feature. The reason why this is a draft is that I saw one of the tests fail and I am not sure if the "got" result even syntactically makes sense Test case is : ```rust check( "Baz", r#" //- /lib.rs crate:lib new_source_root:library pub struct S; //- /main.rs crate:main deps:lib new_source_root:local use lib::S$0; "#, "use lib::Baz;" ); ``` ``` Left: use lib::Baz; Right: use lib::Baz;Baz Diff: use lib::Baz;Baz ```	2024-01-18 13:49:14 +00:00
Johann Hemmann	fad4fa163c	cargo clippy --fix	2024-01-18 13:59:49 +01:00
Ali Bektas	21020919e3	v2	2024-01-18 12:09:23 +01:00
roife	04ce4ce440	internal: speedup LineEndings calculation using 'memchr'	2024-01-18 17:03:29 +08:00
Ali Bektas	9bd9a17ce5	Add a new config to allow renaming of non-local items ... With #15656 we started disallowing renaming of non-local items. Although this makes sense there are some false positives that impacted users' workflows. So this config aims to mitigate this by giving users the liberty to disable this feature.	2024-01-18 00:26:22 +01:00
davidsemakula	4f176b3f7f	update import granularity config and docs	2024-01-18 01:44:57 +03:00
Lukas Wirth	0bdbf497b6	fix: Fix progress reporting getting stuck	2024-01-17 13:23:00 +01:00
Lukas Wirth	21723cb051	Run metadata on sysroot for CI metrics	2024-01-17 09:43:04 +01:00
bors	2d5ce888de	Auto merge of #16366 - Veykril:transp-queries, r=Veykril ... internal: Make data queries transparent over their diagnostics variant And a few other QoL things	2024-01-16 10:09:05 +00:00
Lukas Wirth	f675b5ead8	Don't early exit on panics in rustc_tests command	2024-01-16 11:05:50 +01:00
bors	c9afd41219	Auto merge of #15636 - 9999years:show-which-roots-are-scanned, r=Veykril ... Show which roots are being scanned in progress messages This changes the `Roots Scanned` message to include the directory being scanned. Before: `Roots Scanned 206/210 (98%)` After: `Roots Scanned 206/210: .direnv (98%)` This makes it a lot easier to tell that `rust-analyzer` isn't crashed, it's just trying to scan a huge directory. See: #12613	2024-01-16 09:44:56 +00:00
Lukas Wirth	398150827f	Rename Message::Progress::file field to dir	2024-01-16 10:43:33 +01:00
bors	87e609aa9c	Auto merge of #15868 - wasd96040501:fix/symlink2, r=Veykril ... fix: failed to infer OUT_DIR when workspace root contains symlink fix #15867	2024-01-16 09:23:54 +00:00
Lukas Wirth	c7eb52dd7b	internal: Add unstable config for loading the sysroot sources via cargo metadata	2024-01-15 09:59:32 +01:00
YangzeLuo	22cda959b3	fix: failed to infer OUT_DIR when workspace root contains symlink	2024-01-12 13:35:53 +08:00
Rebecca Turner	1ceb2ea414	Show which roots are being scanned in progress messages ... See: #12613	2024-01-09 09:16:26 -08:00
bors	9e34e643a1	Auto merge of #16319 - Veykril:no-double-load, r=Veykril ... fix: Differentiate between vfs config load and file changed events Kind of fixes https://github.com/rust-lang/rust-analyzer/issues/14730 in a pretty bad way. We need to rethink the vfs-notify layer entirely. For a decent fix.	2024-01-09 10:24:23 +00:00
bors	25f71469f1	Auto merge of #16311 - Veykril:rustc-deps, r=Veykril ... internal: Remove `rustc_dependencies ` crate The crate serves no purpose really	2024-01-09 09:37:48 +00:00
Lukas Wirth	e1c67485bf	fix: Differentiate between vfs config load and file changed events	2024-01-09 10:30:16 +01:00
Laurențiu Nicola	4413aeb9e8	Temporarily disable resolve_proc_macro test	2024-01-09 10:27:36 +02:00
Laurențiu Nicola	f52f2f9c3c	Merge branch 'master' into sync-from-rust	2024-01-09 08:46:16 +02:00
Lukas Wirth	f972da70d4	Remove rustc_dependencies crate	2024-01-08 15:39:35 +01:00
Lukas Wirth	1c40ac79c8	VFS no longer stores all source files in memory	2024-01-08 12:51:16 +01:00
Laurențiu Nicola	3afeb24198	Merge commit 'af40101841c45aa75b56f4e9ca745369da8fb4ba' into sync-from-ra	2024-01-08 11:29:25 +02:00
riverbl	3c378b9c70	Add inlay hint for exclusive ranges ... Adds an inlay hint containing a '<' character to exclusive range expressions and patterns that specify an upper bound.	2024-01-07 09:33:56 +00:00
Lukas Wirth	2666349392	Remove limit from symbol_index::Query	2024-01-04 19:20:10 +01:00
Lukas Wirth	d480525ce8	Add extern crate rustc_driver to proc-macro-srv-cli	2024-01-04 11:02:23 +01:00
Nicolas Guichard	73d9c77f2a	scip: Populate SymbolInformation::kind ... SymbolInformation::kind is finer-grained than the SCIP symbol suffix. This also fixes a bug where all type aliases where treated like type parameters. ``` trait SomeTrait { type AssociatedType; // ← this is SomeTrait#[AssociatedType] } type MyTypeAlias = u8; // ← this used to be [MyTypeAlias] // and now is MyTypeAlias# ```	2024-01-03 13:05:36 +01:00
Nicolas Guichard	566bb77f91	scip: Populate SymbolInformation::signature_documentation	2024-01-03 10:56:12 +01:00
Nicolas Guichard	495a55689b	scip: Populate SymbolInformation::enclosing_symbol ... For local variables, this gets the moniker from the enclosing definition and stores it into the TokenStaticData. Then it builds the scip symbol for that moniker when building the SymbolInformation.	2024-01-03 10:54:57 +01:00
Nicolas Guichard	62663e6d4b	scip: Refactor token_to_symbol to moniker_to_symbol ... This is meant to implement SymbolInformation::enclosing_symbol, so we can build the enclosing symbol from the enclosing moniker without having the full enclosing token's TokenStaticData.	2024-01-03 10:54:57 +01:00
Nicolas Guichard	375f1cca4f	scip: Populate SymbolInformation::display_name	2024-01-03 10:54:57 +01:00
Laurențiu Nicola	932d85b529	Merge commit '426d2842c1f0e5cc5e34bb37c7ac3ee0945f9746' into sync-from-ra2	2024-01-03 11:35:07 +02:00
bors	86e559bf3f	Auto merge of #16211 - tetsuharuohzeki:update-lint, r=Veykril ... Use Cargo's [workspace.lints.*] to config clippy This change begin to use [`[workspace.lints.*]`](https://doc.rust-lang.org/cargo/reference/workspaces.html#the-lints-table) that is stabilized since [Rust 1.74](https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html). By this change, we make the configure more readable and simplify `xargo lint` more.	2024-01-02 14:53:22 +00:00
bors	1a0b772a43	Auto merge of #16153 - Veykril:err-msg, r=Veykril ... fix: Notify user that linkedProjects is set when failing to discover projects Fixes https://github.com/rust-lang/rust-analyzer/issues/15171	2024-01-02 14:42:03 +00:00
Lukas Wirth	8136e739f5	fix: Notify user that linkedProjects is set when failing to discover projects	2024-01-02 15:24:21 +01:00
bors	9f46ff501d	Auto merge of #16062 - davidbarsky:david/fix-references-to-removed-settings, r=Veykril ... fix: Correct references from `rust-analyzer.cargo.check` to `rust-analyzer.check` When reading the manual, I noticed that the documentation referenced configurations that have since been renamed. This PR updates those references to their new names.	2024-01-02 09:57:48 +00:00
bors	f1de7d7273	Auto merge of #16011 - ClSlaid:feat/settings/proc-macro/rebuild-on-save, r=Veykril ... feat: add proc-macro rebuild on save option Related: #15033 I need some advice on how to test it.	2024-01-02 09:46:21 +00:00
Lukas Wirth	c99089c2b3	Update crates/rust-analyzer/src/handlers/notification.rs	2024-01-02 10:27:41 +01:00
Lukas Wirth	3c8dd9e89e	Expose whether a channel has been dropped in lsp-server errors	2024-01-01 14:10:46 +01:00
Martin Huschenbett	b9933fdaaa	minor: Simplify implementation of apply_document_changes ... While reading through the code base, I stumbled across a piece of code that I found hard to read despite its simple purpose. This is my attempt at making the code easier to understand for future readers. I won't be offended if this is too minor and not worth your time.	2023-12-30 19:21:35 +01:00
Tetsuharu Ohzeki	efc87092b3	Use Cargo's [workspace.lints.*] to config clippy	2023-12-29 23:51:32 +09:00
Lukas Wirth	2a5b60b186	internal: Update world symbols request definiton, prefer focus range for macros	2023-12-22 11:42:08 +01:00
Lukas Wirth	2e52aa1615	Clean up	2023-12-21 17:24:00 +01:00
Lukas Wirth	7b804552a5	Remove Delimiter::DUMMY_INVISIBLE	2023-12-20 14:00:14 +01:00
Lukas Wirth	f49a2fed3f	internal: Move out WithFixture into dev-dep only crate	2023-12-18 15:24:08 +01:00
Lukas Wirth	35620306a6	internal: Move proc-macro knowledge out of base-db	2023-12-18 12:37:18 +01:00
Laurențiu Nicola	e37cf75791	Merge commit '21b06c1beb9bb59369ffd652f5d617bcf6952e05' into sync-from-ra	2023-12-18 09:21:55 +02:00
Lukas Wirth	4c45d23948	fix: Syntax fixup now removes subtrees with fake spans	2023-12-15 13:52:49 +01:00
hkalbasi	7b9595a5ab	Run rust-analyzer on rustc tests in metrics	2023-12-15 02:10:25 +03:30
Lukas Wirth	7cc6b0f2e9	Partially revert #16101	2023-12-12 22:53:40 +01:00
Lukas Wirth	ca995d765d	fix: Fix import_map::search_dependencies getting confused by assoc and non assoc items with the same name	2023-12-12 15:45:42 +01:00
Kirill Bulatov	8ae42b55e7	Search for parent blocks and items when resolving inlay hints	2023-12-11 15:16:55 +02:00
Kirill Bulatov	be6d34b810	Query for nearest parent block around the hint to resolve ... This way, parameter hints will be found for resolution	2023-12-11 14:53:51 +02:00
Laurențiu Nicola	f532576ac5	Merge commit '457b966b171b09a7e57acb710fbca29a4b3526f0' into sync-from-ra	2023-12-11 11:16:01 +02:00
Lukas Wirth	cf083fefc4	fix: Fix completion failing in format_args! with invalid template	2023-12-08 20:35:33 +01:00
David Barsky	f556c79db8	fix: Correct references from rust-analyzer.cargo.check to rust-analyzer.check	2023-12-08 14:26:58 -05:00
蔡略	ad27b6e053	patch: only rerun build scripts when saved. ... Signed-off-by: 蔡略 <cailue@bupt.edu.cn>	2023-12-08 11:31:56 +08:00
Lukas Wirth	5544f4fa3d	Bump and unlock some dependencies	2023-12-07 11:48:58 +01:00
David Barsky	c17dcc8d90	internal: switch to Arc::from_iter	2023-12-06 13:08:45 -05:00
Lukas Wirth	ba01ff4f88	Fix diagnostics panicking when resolving to different files due to macros	2023-12-06 14:39:26 +01:00
Lukas Wirth	9cb13b6efb	Allow navigation targets to be duplicated when the focus range lies in the macro definition site	2023-12-06 12:38:19 +01:00
Igor Matuszewski	a7224c998d	Don't explicitly warn against semicolon_in_expressions_from_macros ... This has been warn-by-default for two years now and has already been added to the future-incompat lints in 1.68.	2023-12-05 11:35:09 +01:00
bors	e91fdf7860	Auto merge of #15959 - Veykril:macro-shower3, r=lnicola ... TokenMap -> SpanMap rewrite Opening early so I can have an overview over the full diff more easily, still very unfinished and lots of work to be done. The gist of what this PR does is move away from assigning IDs to tokens in arguments and expansions and instead gives the subtrees the text ranges they are sourced from (made relative to some item for incrementality). This means we now only have a single map per expension, opposed to map for expansion and arguments. A few of the things that are not done yet (in arbitrary order): - [x] generally clean up the current mess - [x] proc-macros, have been completely ignored so far - [x] syntax fixups, has been commented out for the time being needs to be rewritten on top of some marker SyntaxContextId - [x] macro invocation syntax contexts are not properly passed around yet, so $crate hygiene does not work in all cases (but most) - [x] builtin macros do not set spans properly, $crate basically does not work with them rn (which we use) ~~- [ ] remove all uses of dummy spans (or if that does not work, change the dummy entries for dummy spans so that tests will not silently pass due to havin a file id for the dummy file)~~ - [x] de-queryfy `macro_expand`, the sole caller of it is `parse_macro_expansion`, and both of these are lru-cached with the same limit so having it be a query is pointless - [x] docs and more docs - [x] fix eager macro spans and other stuff - [x] simplify include! handling - [x] Figure out how to undo the sudden `()` expression wrapping in expansions / alternatively prioritize getting invisible delimiters working again - [x] Simplify InFile stuff and HirFIleId extensions ~~- [ ] span crate containing all the file ids, span stuff, ast ids. Then remove the dependency injection generics from tt and mbe~~ Fixes https://github.com/rust-lang/rust-analyzer/issues/10300 Fixes https://github.com/rust-lang/rust-analyzer/issues/15685	2023-12-04 19:59:53 +00:00
ClSlaid	b21d68cd2a	feat: add proc-macro rebuild on save option ... Signed-off-by: ClSlaid <cailue@bupt.edu.cn>	2023-12-04 21:08:29 +08:00
Laurențiu Nicola	30fc9329d1	Merge commit 'e402c494b7c7d94a37c6d789a216187aaf9ccd3e' into sync-from-ra	2023-12-04 09:19:15 +02:00
Lukas Wirth	5edf7bddc6	Fix mod item in included file resolving incorrectly	2023-12-02 13:49:09 +01:00
hkalbasi	4d55cac466	Initial support for implicit drop inlay hint	2023-12-01 16:16:46 +03:30
Lukas Wirth	b98597f06d	Re-enable proc-macros	2023-11-28 16:28:56 +01:00
Lukas Wirth	98cfdde8ba	Thinner TokenMap	2023-11-28 10:56:25 +01:00
Lukas Wirth	6208960c48	Deduplicate dummy test span maps	2023-11-28 10:55:40 +01:00
Lukas Wirth	30093a6d81	spans always come from real file	2023-11-28 10:55:39 +01:00
Lukas Wirth	e36b3f7b8c	Proper span representation with syntax context	2023-11-28 10:55:39 +01:00
Lukas Wirth	890eb17b4e	Replace ID based TokenMap with proper relative text-ranges / spans	2023-11-28 10:55:39 +01:00
bors	9aa867cd01	Auto merge of #15946 - roife:master, r=Veykril ... internal: simplify the removal of dulicate workspaces. ### Summary: Refactoring the duplicate removal process for `workspaces` in `fetch_workspaces`. ### Changes Made: Replaced `[].iter().enumerate().skip(...).filter_map(...)` with a more concise `[i+1..].positions(...)` provided by `itertools`, which enhances clarity without changing functionality ### Impact: This change aims to enhance the duplicate removal process for `workspaces`. This change has been tested on my machine. Please review and provide feedback. Thanks!	2023-11-27 16:02:53 +00:00
Laurențiu Nicola	81606ecf68	Merge commit '237712fa314237e428e7ef2ab83b979f928a43a1' into sync-from-ra	2023-11-27 12:40:39 +02:00
Andrew Hlynskyi	94cea4663a	fix: add fallback for completion label details	2023-11-25 13:25:42 +02:00
David Tolnay	b68f5311b5	Replace option.map(cond) == Some(true) with option.is_some_and(cond)	2023-11-24 09:06:44 -08:00
Andrew Hlynskyi	615abb3c92	Improve completion label details display	2023-11-24 14:38:00 +02:00
roife	e790d7ff3a	internal: simplify the removal of dulicate workspaces. ... refactor: replace multiple steps with `positions` in `fetch_workspaces` for clarity.	2023-11-22 21:14:39 +08:00
bors	2e7e8cc7b9	Auto merge of #15940 - pascalkuthe:fix_rename, r=Veykril ... ensure renames happen after edit This is a bugfix for an issue I fould while working on helix. Rust-analyzer currently always sends any filesystem edits (rename/file creation) before any other edits. When renaming a file that is also being edited that would mean that the edit would be discarded and therefore an incomplete/incorrect refactor (or even cause the creation of a new file in helix altough that is probably a pub on our side). Example: * create a module: `mod foo` containing a `pub sturct Bar;` * reexport the struct uneder a different name in the `foo` module using a *fully qualified path*: `pub use crate::foo::Bar as Bar2`. * rename the `foo` module to `foo2` using rust-analyzer * obsereve that the path is not correctly updated (rust-analyer first sends a rename `foo.rs` to `foo2.rs` and then edits `foo.rs` after) This PR fixes that issue by simply executing all rename operations after all edit operations (while still executing file creation operations first). I also added a testcase similar to the example above. Relevent excerpt from the LSP standard: > Since version 3.13.0 a workspace edit can contain resource operations (create, delete or rename files and folders) as well. If resource operations are present clients need to execute the operations in the order in which they are provided. So a workspace edit for example can consist of the following two changes: (1) create file a.txt and (2) a text document edit which insert text into file a.txt. An invalid sequence (e.g. (1) delete file a.txt and (2) insert text into file a.txt) will cause failure of the operation. How the client recovers from the failure is described by the client capability: workspace.workspaceEdit.failureHandling	2023-11-21 09:33:01 +00:00
Laurențiu Nicola	59f5d51852	Merge commit '141fc695dca1df7cfc3c9803972ec19bb178dcbc' into sync-from-ra	2023-11-16 22:27:35 +02:00
bors	58de0b130a	Auto merge of #15902 - lnicola:bump-deps, r=Veykril ... internal: Bump deps pt. 1	2023-11-15 19:37:06 +00:00
Laurențiu Nicola	2814d646cb	Bump rayon	2023-11-15 21:14:56 +02:00
Laurențiu Nicola	b18ce4f8ea	Bump xshell	2023-11-15 21:12:18 +02:00
Lukas Wirth	e8c4007cfc	Fix builtin line! expansion	2023-11-15 14:06:10 +01:00
Laurențiu Nicola	829cf8db4c	Bump dissimilar	2023-11-15 13:34:56 +02:00
Laurențiu Nicola	c4dfa06b9d	Bump tracing-log	2023-11-15 13:25:19 +02:00
Laurențiu Nicola	2dbdaa247b	Bump tracing-subscriber	2023-11-15 13:04:39 +02:00
Laurențiu Nicola	d83620a5ba	Bump tracing-tree	2023-11-15 13:01:54 +02:00
Laurențiu Nicola	f53368dd3f	Bump tracing	2023-11-15 13:00:32 +02:00
Laurențiu Nicola	f66df10f87	Bump itertools	2023-11-15 12:53:56 +02:00
Laurențiu Nicola	dfc885e0fd	Bump anyhow	2023-11-15 12:49:32 +02:00
Laurențiu Nicola	6b53c09ef5	Merge branch 'master' into sync-from-rust	2023-11-15 09:46:27 +02:00
Laurențiu Nicola	d45ff2484f	Depend on rustc_driver	2023-11-14 18:07:02 +02:00
Laurențiu Nicola	b6951defa6	Add missing rustc_private features	2023-11-13 21:38:57 +02:00
Lukas Wirth	d6b908ec41	Fix import preference config keys	2023-11-12 17:48:40 +01:00
Lukas Wirth	ba61766217	Add config for preferring / ignoring prelude modules in find_path	2023-11-11 14:56:38 +01:00
Pascal Kuthe	0647b645cd	ensure renames happen after edit	2023-11-10 17:39:32 +01:00
Laurențiu Nicola	d1d111d09e	Merge commit '3b7c7f97e4a7bb253a8d398ee4f8346f6cf2817b' into sync-from-ra	2023-11-08 08:15:03 +02:00
cui fliter	9c99afe3aa	Fix some typos ... Signed-off-by: cui fliter <imcusg@gmail.com>	2023-10-30 10:31:50 +08:00
Roberto Bampi	99ec3aa8a3	scip: update crate to version 0.3.1. ... While the git repo has been updated constantly, crates.io has only now been updated after more than a year of activity.	2023-10-26 16:20:06 +02:00
Laurențiu Nicola	094cecd3bd	Fix VS Code detection for Insiders version	2023-10-21 19:08:41 +03:00
bors	aaa1e8e1b8	Auto merge of #15618 - shogo-nakano-desu:internal/port-anymap, r=Veykril ... internal: port anymap ## Description - The anymap crate has been ported. During this process, unnecessary features for rust-analyzer have been removed. - From the tests that were checking the existing licenses, the anymap license (`BlueOak-1.0.0 OR MIT OR Apache-2.0`) has been removed. ## Requests - While porting the code this time, I have tried to respect the original author's intentions and have kept the comments/codes as much as possible. Please don't hesitate to tell me if you think the comments/codes also need to be appropriately modified. - If there are any necessary changes regarding the licensing or anything else, please let me know so I can fix them. ## Issue https://github.com/rust-lang/rust-analyzer/issues/15500	2023-10-09 08:40:54 +00:00
Victor Song	a39d2076db	Addressed PR style comments	2023-10-09 02:15:05 -05:00
Victor Song	9771e1e18f	Don't pass any target directory options to custom flycheck	2023-10-09 02:15:05 -05:00
Victor Song	3682c3791b	Set CARGO_TARGET_DIR when using Flycheck custom command	2023-10-09 02:15:05 -05:00
Victor Song	ef0b3bbef1	Clarify documentation on new parameter	2023-10-09 02:15:05 -05:00
Victor Song	53b6700594	Add dedicated target_dir field to CargoConfig and FlycheckConfig ... Add dedicated field for `target_dir` in the configurations for Cargo and Flycheck. Also change the directory to be a `PathBuf` as opposed to a `String` to be more appropriate to the operating system.	2023-10-09 02:15:05 -05:00
Victor Song	aeef7b644b	Add config option to use rust-analyzer specific target dir ... Adds a Rust Analyzer configuration option to set a custom target directory for builds. This is a workaround for Rust Analyzer blocking debug builds while running `cargo check`. This change should close #6007	2023-10-09 02:15:05 -05:00
bors	b1f89a84ab	Auto merge of #15600 - davidbarsky:davidbarsky/broken-rustfmt-in-ra, r=Veykril ... fix: ensure `rustfmt` runs when configured with `./` (Hopefully) resolves https://github.com/rust-lang/rust-analyzer/issues/15595. This change kinda approaches canonicalization—which I am not a fan of—but only in service of making `./`-configured commands run correctly. Longer-term, I feel like this code should be removed once `rustfmt` supports recursive searches of configuration files or interpolation of values like `${workspace_folder}` lands in rust-analyzer. ## Testing I cloned `rustc`, setup rust-analyzer as suggested in the [`rustc` dev guide](https://rustc-dev-guide.rust-lang.org/building/suggested.html#configuring-rust-analyzer-for-rustc), saved and formatted files in `src/tools/miri` and `compiler`, and saw `rustfmt` (seemingly) correctly.	2023-10-06 11:33:52 +00:00
Lukas Wirth	b3ebc9ab6a	Check for both path separators on windows	2023-10-06 13:26:36 +02:00
Lukas Wirth	88a00bf49d	Shrink PatPtr by swapping its AstPtr and Either wrap order	2023-10-06 12:32:37 +02:00
David Barsky	a8ec77dc7e	address PR feedback.	2023-10-03 16:44:09 -04:00
DaniPopes	53f5c1c13f	internal: re-generate lints.rs	2023-09-29 14:20:17 +02:00
Emilio Cobos Álvarez	791e6c8b1b	scip: Allow customizing cargo config. ... Re-use the LSP config json for simplicity.	2023-09-28 17:22:19 +02:00
bors	e5e937ae5e	Auto merge of #15582 - vxpm:master, r=HKalbasi ... add option to show full function signatures in completion docs implements #15538 with `"rust-analyzer.completion.fullFunctionSignatures.enable": false`:  with `"rust-analyzer.completion.fullFunctionSignatures.enable": true`: 	2023-09-24 07:38:38 +00:00
bors	2b580a1f3c	Auto merge of #15492 - RalfJung:invocation, r=Veykril ... extend check.overrideCommand and buildScripts.overrideCommand docs Extend check.overrideCommand and buildScripts.overrideCommand docs regarding invocation strategy and location. However something still seems a bit odd -- the docs for `invocationStrategy`/`invocationLocation` talk about "workspaces", but the setting that controls which workspaces are considered is called `linkedProjects`. Is a project the same as a workspace here or is there some subtle difference?	2023-09-22 16:09:01 +00:00
shogo-nakano-desu	4b3257a365	refactor: port anymap	2023-09-20 09:02:05 +09:00
Kirill Bulatov	f9fac02c57	Use proper editor name	2023-09-19 23:34:43 +03:00
Kirill Bulatov	184119258e	Do not resolve inlayHint.textEdit for VSCode client ... VSCode behaves strangely, allowing to navigate into label location, but not allowing to apply hint's text edit, after hint is resolved. See https://github.com/microsoft/vscode/issues/193124 for details. For now, stub hint resolution for VSCode specifically.	2023-09-19 21:40:22 +03:00
bors	22b18b9f77	Auto merge of #15616 - HKalbasi:rustc-deps, r=HKalbasi ... Switch to in-tree rustc dependencies with a cfg flag We can use this flag to detect and prevent breakages in rustc CI. (see #14846 and #15569) ~The `IN_RUSTC_REPOSITORY` is just a placeholder. Is there any existing cfg flag that rustc CI sets?~	2023-09-19 17:41:12 +00:00
Emilio Cobos Álvarez	c372431123	scip: Use load_workspace_at. ... This honors the build script config, and is also simpler.	2023-09-19 13:48:05 +02:00
Laurențiu Nicola	bcfc997eac	Merge commit '258b15c506a2d3ad862fd17ae24eaf272443f477' into sync-from-ra	2023-09-18 12:33:49 +03:00
hkalbasi	f4704bc8ae	Switch to in-tree rustc dependencies with a cfg flag	2023-09-15 18:10:11 +03:30
Lukas Wirth	712e67cf11	fix: Fix lens location "above_whole_item" breaking lenses	2023-09-13 22:01:04 +02:00
David Barsky	2974416a81	fix: ensure rustfmt runs when configured with ./	2023-09-12 14:35:24 -04:00
vxpm	6b487ed4be	fix & run tests	2023-09-08 22:03:42 -03:00
vxpm	23ffda1a97	full function signatures option	2023-09-08 22:03:42 -03:00
bors	ea71a49c8e	Auto merge of #15577 - Veykril:clear-native-diags, r=Veykril ... Clear native diagnostics on file closing Fixes https://github.com/rust-lang/rust-analyzer/issues/15562	2023-09-08 11:54:59 +00:00
Lukas Wirth	297ed70a23	Clear native diagnostics on file closing	2023-09-08 13:54:44 +02:00
bors	70a6cf0ef7	Auto merge of #15522 - SomeoneToIgnore:resolve-inlay-hints, r=Veykril ... Resolve inlay hint data Part of https://github.com/rust-lang/rust-analyzer/issues/13962 Support https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#inlayHint_resolve better, by omitting all inlay hint fields specified in the client hint resolve capabilities. Current list of all capabilities possible to resolve later: ``` "textEdits" "tooltip" "label.tooltip" "label.location" "label.command" ``` and every one specified in the client capabilities is now resolved by r-a, being omitted in the initial response. -------------- When editing `inlay_hints.rs` file around line `457` with no resolve capabilities, I get <details> <summary>resolved json, 10803 characters</summary> ```json {"jsonrpc":"2.0","id":55,"result":[{"position":{"line":477,"character":1},"label":[{"value":"fn inlay_hints","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/ide/src/inlay_hints.rs","range":{"start":{"line":445,"character":14},"end":{"line":445,"character":25}}}}],"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":451,"character":10},"label":[{"value":": "},{"value":"ProfileSpan","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/profile/src/hprof.rs","range":{"start":{"line":85,"character":11},"end":{"line":85,"character":22}}}},{"value":""}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":451,"character":27},"label":[{"value":"label:","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/profile/src/hprof.rs","range":{"start":{"line":60,"character":12},"end":{"line":60,"character":17}}}}],"kind":2,"paddingLeft":false,"paddingRight":true,"data":{"file_id":0}},{"position":{"line":452,"character":12},"label":[{"value":": "},{"value":"Semantics","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/hir/src/semantics.rs","range":{"start":{"line":108,"character":11},"end":{"line":108,"character":20}}}},{"value":"<'_, "},{"value":"RootDatabase","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/ide-db/src/lib.rs","range":{"start":{"line":75,"character":11},"end":{"line":75,"character":23}}}},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":453,"character":12},"label":[{"value":": "},{"value":"SourceFile","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/ast/generated/nodes.rs","range":{"start":{"line":223,"character":11},"end":{"line":223,"character":21}}}},{"value":""}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":454,"character":12},"label":[{"value":": &"},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":456,"character":12},"label":": i32","kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":458,"character":15},"label":[{"value":": "},{"value":"Vec","location":{"uri":"file:///Users/someonetoignore/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/alloc/src/vec/mod.rs","range":{"start":{"line":395,"character":11},"end":{"line":395,"character":14}}}},{"value":"<"},{"value":"InlayHint","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/ide/src/inlay_hints.rs","range":{"start":{"line":149,"character":11},"end":{"line":149,"character":20}}}},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":460,"character":21},"label":[{"value":": "},{"value":"SemanticsScope","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/hir/src/semantics.rs","range":{"start":{"line":1651,"character":11},"end":{"line":1651,"character":25}}}},{"value":"<'_>"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":460,"character":36},"label":[{"value":"node:","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/hir/src/semantics.rs","range":{"start":{"line":482,"character":24},"end":{"line":482,"character":28}}}}],"kind":2,"paddingLeft":false,"paddingRight":true,"data":{"file_id":0}},{"position":{"line":461,"character":23},"label":[{"value":": "},{"value":"FamousDefs","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/ide-db/src/famous_defs.rs","range":{"start":{"line":20,"character":11},"end":{"line":20,"character":21}}}},{"value":"<'_, '_>"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":463,"character":17},"label":[{"value":": impl FnMut("},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">)"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":463,"character":25},"label":[{"value":": "},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":463,"character":33},"label":[{"value":"hints:","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/ide/src/inlay_hints.rs","range":{"start":{"line":480,"character":4},"end":{"line":480,"character":9}}}}],"kind":2,"paddingLeft":false,"paddingRight":true,"data":{"file_id":0}},{"position":{"line":465,"character":22},"label":[{"value":": "},{"value":"TextRange","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/text-size-1.1.0/src/range.rs","range":{"start":{"line":14,"character":11},"end":{"line":14,"character":20}}}},{"value":""}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":467,"character":35},"label":[{"value":": "},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":469,"character":92},"label":[{"value":"impl "},{"value":"Iterator","location":{"uri":"file:///Users/someonetoignore/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs","range":{"start":{"line":72,"character":10},"end":{"line":72,"character":18}}}},{"value":"<"},{"value":"Item","location":{"uri":"file:///Users/someonetoignore/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs","range":{"start":{"line":76,"character":9},"end":{"line":76,"character":13}}}},{"value":" = "},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">>"}],"kind":1,"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":468,"character":34},"label":[{"value":"impl "},{"value":"Iterator","location":{"uri":"file:///Users/someonetoignore/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs","range":{"start":{"line":72,"character":10},"end":{"line":72,"character":18}}}},{"value":"<"},{"value":"Item","location":{"uri":"file:///Users/someonetoignore/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs","range":{"start":{"line":76,"character":9},"end":{"line":76,"character":13}}}},{"value":" = "},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">>"},{"value":""}],"kind":1,"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":467,"character":41},"label":[{"value":""},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">"}],"kind":1,"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":469,"character":40},"label":" -> bool","kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":469,"character":39},"label":[{"value":": &"},{"value":"SyntaxNode","location":{"uri":"file:///Users/someonetoignore/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rowan-0.15.11/src/api.rs","range":{"start":{"line":15,"character":11},"end":{"line":15,"character":21}}}},{"value":"<"},{"value":"RustLanguage","location":{"uri":"file:///Users/someonetoignore/work/rust-analyzer/crates/syntax/src/syntax_node.rs","range":{"start":{"line":15,"character":9},"end":{"line":15,"character":21}}}},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}}]} ``` </details> for the visible editor range alone, pretty much repeated on every consequent edit. With this patch and all inlay hint resolve capabilities enabled, for the same example I observe quite a footprint reduction: <details> <summary>unresolved json, 4142 characters</summary> ```json {"jsonrpc":"2.0","id":49,"result":[{"position":{"line":477,"character":1},"label":[{"value":"fn inlay_hints"}],"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":451,"character":10},"label":[{"value":": "},{"value":"ProfileSpan"},{"value":""}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":451,"character":27},"label":[{"value":"label:"}],"kind":2,"paddingLeft":false,"paddingRight":true,"data":{"file_id":0}},{"position":{"line":452,"character":12},"label":[{"value":": "},{"value":"Semantics"},{"value":"<'_, "},{"value":"RootDatabase"},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":453,"character":12},"label":[{"value":": "},{"value":"SourceFile"},{"value":""}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":454,"character":12},"label":[{"value":": &"},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":456,"character":12},"label":": i32","kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":458,"character":15},"label":[{"value":": "},{"value":"Vec"},{"value":"<"},{"value":"InlayHint"},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":460,"character":21},"label":[{"value":": "},{"value":"SemanticsScope"},{"value":"<'_>"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":460,"character":36},"label":[{"value":"node:"}],"kind":2,"paddingLeft":false,"paddingRight":true,"data":{"file_id":0}},{"position":{"line":461,"character":23},"label":[{"value":": "},{"value":"FamousDefs"},{"value":"<'_, '_>"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":463,"character":17},"label":[{"value":": impl FnMut("},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">)"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":463,"character":25},"label":[{"value":": "},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":463,"character":33},"label":[{"value":"hints:"}],"kind":2,"paddingLeft":false,"paddingRight":true,"data":{"file_id":0}},{"position":{"line":465,"character":22},"label":[{"value":": "},{"value":"TextRange"},{"value":""}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":467,"character":35},"label":[{"value":": "},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":469,"character":92},"label":[{"value":"impl "},{"value":"Iterator"},{"value":"<"},{"value":"Item"},{"value":" = "},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">>"}],"kind":1,"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":468,"character":34},"label":[{"value":"impl "},{"value":"Iterator"},{"value":"<"},{"value":"Item"},{"value":" = "},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">>"},{"value":""}],"kind":1,"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":467,"character":41},"label":[{"value":""},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">"}],"kind":1,"paddingLeft":true,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":469,"character":40},"label":" -> bool","kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}},{"position":{"line":469,"character":39},"label":[{"value":": &"},{"value":"SyntaxNode"},{"value":"<"},{"value":"RustLanguage"},{"value":">"}],"kind":1,"paddingLeft":false,"paddingRight":false,"data":{"file_id":0}}]} ``` </details> with all unresolved parts needing only for navigation, hover or applying the hint edit — dynamic parts that are made after mouse hover or similar events, that resolve the hint data.	2023-09-08 11:12:27 +00:00
bors	b67606c4e2	Auto merge of #15529 - SomeoneToIgnore:less-inlay-hint-refreshes, r=Veykril ... Do not send inlay hint refresh requests on file edits See https://github.com/rust-lang/rust-analyzer/issues/13369#issuecomment-1695306870 Editor itself is able to invalidate hints after edits, and /refresh was sent after editor reports changes to the language server. This forces the editor to either query & invalidate the hints twice after every edit, or wait for /refresh to come before querying the hints. Both options are rather useless, so instead, send a request on server startup only: client editors do not know when the server actually starts up, this will help to query the initial hints after editor was open and the server was still starting up.	2023-09-08 10:35:23 +00:00
hkalbasi	e4c469321c	Ignore enum variants in analysis stats of mir bodies	2023-09-07 01:08:47 +03:30
bors	77b359ae31	Auto merge of #15532 - SomeoneToIgnore:more-brackets-on-type-formatting, r=Veykril ... On type format '(', by adding closing ')' automatically If I understand right, `()` can surround pretty much the same `{}` can, so add another on type formatting pair for convenience: sometimes it's not that pleasant to write parenthesis in `Some(2).map(|i| (i, i+1))` cases and I would prefer r-a to do that for me. One note: currently, b06503b6ec/crates/rust-analyzer/src/handlers/request.rs (L357) fires always. Should we remove the assertion entirely now, since apparently things work in release despite that check?	2023-09-06 20:32:04 +00:00
David Barsky	42f77f89ff	internal: use current subcrate's rustfmt.toml with all rustfmt configurations	2023-09-06 15:32:38 -04:00
Roberto Bampi	4f22e1a187	Update notify to 6.1.1 ... Unlike version 6.0.1, this does not pull windows-sys 0.4.5 as observed in #15077. $ cargo tree --target=x86_64-pc-windows-gnu --charset=ascii | grep windows-sys | | `-- windows-sys v0.42.0 | | | | | | `-- windows-sys v0.42.0 (*) | `-- windows-sys v0.48.0 | | `-- windows-sys v0.48.0 (*) | `-- windows-sys v0.48.0 (*) | `-- windows-sys v0.48.0 (*) | `-- windows-sys v0.42.0 (*)	2023-09-04 18:00:12 +02:00
Kirill Bulatov	7f450da39e	Omit hint resolve data better ... Omit sending inlay hint resolve data if inlay has no properties that client resolve capabilities support.	2023-09-02 23:56:48 +03:00
Kirill Bulatov	7b3dba5d77	Provide resolve data only when it can actually be resolved	2023-09-02 22:14:08 +03:00
Kirill Bulatov	caf018507a	Ensure resolved hint's file exists	2023-09-02 18:28:36 +03:00
Kirill Bulatov	10464c7c42	Simplify InlayFieldsToResolve handling	2023-09-02 18:28:36 +03:00
Kirill Bulatov	e07fbabcfe	Resolve inlay hint data ... Skip every propery set in inlay hint client resolve capabilities, reducing overall json footprint.	2023-09-02 18:28:35 +03:00
Lukas Wirth	81f0108067	Remove markdown module from rust-analyzer crate	2023-09-02 17:27:52 +02:00
Lukas Wirth	b1575528c0	Move doc comment handling into ide-db	2023-09-02 16:27:26 +02:00
Lukas Wirth	2dbc7e3e1a	Restructure some modules in rust-analyzer crate	2023-09-02 14:16:04 +02:00
Lukas Wirth	c19390992c	Reduce semantic token cache lock scopes	2023-09-01 21:54:29 +02:00
Kirill Bulatov	da786170f8	Use proper assertion in on-type formatting edits ... Co-authored-by: DropDemBits <r3usrlnd@gmail.com>	2023-09-01 21:49:51 +03:00
Kirill Bulatov	0f1cde709a	On type format '(', by adding closing ')' automatically	2023-09-01 21:49:50 +03:00
Lukas Wirth	cc8b78601d	Shuffle some locking around	2023-09-01 20:45:46 +02:00
Kirill Bulatov	62d189702c	Only send inlay hint refresh requests on initial load ... Editor itself is able to invalidate hints after edits, and /refresh was sent after editor reports changes to the language server. This forces the editor to either query & invalidate the hints twice after every edit, or wait for /refresh to come before querying the hints. Both options are rather useless, so instead, send a request on server startup only: client editors do not know when the server actually starts up, this will help to query the initial hints after editor was open and the server was still starting up.	2023-08-29 13:04:04 +03:00
Wilfred Hughes	bc42b9911d	SCIP: Report the correct version of rust-analyzer in the metadata ... Previously this was hard coded to "0.1". The SCIP protocol allows this to be an arbitrary string: ``` message ToolInfo { // Name of the indexer that produced this index. string name = 1; // Version of the indexer that produced this index. string version = 2; // Command-line arguments that were used to invoke this indexer. repeated string arguments = 3; } ``` so use the same string reported by `rust-analyzer --version`.	2023-08-22 18:51:39 -07:00
Laurențiu Nicola	6caf79c36e	Allow internal_features in test	2023-08-21 22:15:56 +03:00
Laurențiu Nicola	30d8aa1bec	Merge commit '9b3d03408c66749d56466bb09baf2a7177deb6ce' into sync-from-ra	2023-08-21 12:44:09 +03:00
Ralf Jung	2de62be09b	projects/workspaces	2023-08-21 10:53:37 +02:00
Ralf Jung	940d87b2d0	extend check.overrideCommand and buildScripts.overrideCommand docs regarding invocation strategy and location	2023-08-21 10:41:49 +02:00
Ralf Jung	887cc48ba8	fix help text for rust-analyzer.check.invocation{Strategy,Location}	2023-08-21 09:54:24 +02:00
Laurențiu Nicola	4c67becd44	Always collect memory usage info in analysis-stats	2023-08-15 18:22:37 +03:00
Lukas Wirth	7e04142f25	Fix pinned version of lsp-types	2023-08-09 20:06:08 +02:00
bors	e13fac379e	Auto merge of #15262 - adamse:master, r=HKalbasi ... add check.ignore to list cargo check diagnostics to ignore (dead_code, unused_imports, ...) fixes #14798	2023-08-08 18:49:45 +00:00
Adam Sandberg Ericsson	9cb1f45e6f	add check.ignore to list cargo check diagnostics to ignore (dead_code, unused_imports, ...) ... fixes #14798	2023-08-08 14:28:35 +02:00
Laurențiu Nicola	aa55ce9567	Merge commit 'baee6b338b0ea076cd7a9f18d47f175dd2ba0e5d' into sync-from-ra	2023-08-07 12:03:15 +03:00
Wilfred Hughes	edabffbd5a	SCIP: Qualify parameters by the containing function ... SCIP requires symbols to be unique, but multiple functions may have a parameter with the same name. Qualify parameters according to the containing function.	2023-08-04 16:38:31 -07:00
Lukas Wirth	bcff166b3a	Add ExternCrateDecl to HIR	2023-08-02 11:52:55 +02:00
bors	c71e1368fd	Auto merge of #15269 - DropDemBits:structured-snippets-deferred-rendering, r=Veykril ... internal: Defer structured snippet rendering to allow escaping snippet bits Since we know exactly where snippets are, we can transparently escape snippet bits to the exact text edits that need it, and not have to do it for anything other text edits. Also will eventually fix #11006 once all assists are migrated. This comes as a side-effect of text edits that don't have snippets get marked as having no insert formatting at all.	2023-08-01 09:18:46 +00:00
Lukas Wirth	bd6ec06237	Write proc-macro server spawn errors to the status text	2023-07-30 14:38:25 +02:00
Laurențiu Nicola	0155385b57	Merge commit '99718d0c8bc5aadd993acdcabc1778fc7b5cc572' into sync-from-ra	2023-07-24 12:21:34 +03:00
bors	99718d0c8b	Auto merge of #15303 - oxalica:fix/byte-escape-highlight, r=lowr ... Fix highlighting of byte escape sequences Currently non-UTF8 escape sequences in byte strings and any escape sequences in byte literals are ignored.	2023-07-22 20:25:40 +00:00