Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2025-01-14 06:03:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

editor/code: Enable noPropertyAccessFromIndexSignature ts option

Browse source
This commit is contained in:
Tetsuharu Ohzeki 2023-06-28 18:15:30 +09:00
parent 72a3883a71
commit f70845305f
6 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
editors/code/src/bootstrap.ts
View file

@ -36,7 +36,7 @@ async function getServer(
config: Config,
state: PersistentState
): Promise<string | undefined> {
const explicitPath = process.env.__RA_LSP_SERVER_DEBUG ?? config.serverPath;
const explicitPath = process.env["__RA_LSP_SERVER_DEBUG"] ?? config.serverPath;
if (explicitPath) {
if (explicitPath.startsWith("~/")) {
return os.homedir() + explicitPath.slice("~".length);

4
editors/code/src/config.ts
View file

@ -339,7 +339,7 @@ export function substituteVariablesInEnv(env: Env): Env {
const depRe = new RegExp(/\${(?<depName>.+?)}/g);
let match = undefined;
while ((match = depRe.exec(value))) {
const depName = unwrapUndefinable(match.groups?.depName);
const depName = unwrapUndefinable(match.groups?.["depName"]);
deps.add(depName);
// `depName` at this point can have a form of `expression` or
// `prefix:expression`
@ -448,7 +448,7 @@ function computeVscodeVar(varName: string): string | null {
// https://github.com/microsoft/vscode/blob/08ac1bb67ca2459496b272d8f4a908757f24f56f/src/vs/workbench/api/common/extHostVariableResolverService.ts#L81
// or
// https://github.com/microsoft/vscode/blob/29eb316bb9f154b7870eb5204ec7f2e7cf649bec/src/vs/server/node/remoteTerminalChannel.ts#L56
execPath: () => process.env.VSCODE_EXEC_PATH ?? process.execPath,
execPath: () => process.env["VSCODE_EXEC_PATH"] ?? process.execPath,
pathSeparator: () => path.sep,
};

5
editors/code/src/debug.ts
View file

@ -147,8 +147,9 @@ async function getDebugConfiguration(
debugConfig.name = `run ${path.basename(executable)}`;
}
if (debugConfig.cwd) {
debugConfig.cwd = simplifyPath(debugConfig.cwd);
const cwd = debugConfig["cwd"];
if (cwd) {
debugConfig["cwd"] = simplifyPath(cwd);
}
return debugConfig;

2
editors/code/src/toolchain.ts
View file

@ -176,7 +176,7 @@ export const getPathForExecutable = memoizeAsync(
);
async function lookupInPath(exec: string): Promise<boolean> {
const paths = process.env.PATH ?? "";
const paths = process.env["PATH"] ?? "";
const candidates = paths.split(path.delimiter).flatMap((dirInPath) => {
const candidate = path.join(dirInPath, exec);

2
editors/code/tests/unit/settings.test.ts
View file

@ -57,7 +57,7 @@ export async function getTests(ctx: Context) {
USING_VSCODE_VAR: "${workspaceFolderBasename}",
};
const actualEnv = await substituteVariablesInEnv(envJson);
assert.deepStrictEqual(actualEnv.USING_VSCODE_VAR, "code");
assert.deepStrictEqual(actualEnv["USING_VSCODE_VAR"], "code");
});
});
}

3
editors/code/tsconfig.json
View file

@ -13,8 +13,7 @@
// These disables some enhancement type checking options
// to update typescript version without any code change.
"useUnknownInCatchVariables": false,
"exactOptionalPropertyTypes": false,
"noPropertyAccessFromIndexSignature": false
"exactOptionalPropertyTypes": false
},
"exclude": ["node_modules", ".vscode-test"],
"include": ["src", "tests"]