diff --git a/crates/ra_assists/src/handlers/merge_imports.rs b/crates/ra_assists/src/handlers/merge_imports.rs index 9c57d1e309..5d4b74e567 100644 --- a/crates/ra_assists/src/handlers/merge_imports.rs +++ b/crates/ra_assists/src/handlers/merge_imports.rs @@ -170,6 +170,34 @@ use std::{fmt::<|>{Display, Debug}}; ); } + #[test] + fn test_merge_single_wildcard_diff_prefixes() { + check_assist( + merge_imports, + r" +use std<|>::cell::*; +use std::str; +", + r" +use std<|>::{cell::*, str}; +", + ) + } + + #[test] + fn test_merge_both_wildcard_diff_prefixes() { + check_assist( + merge_imports, + r" +use std<|>::cell::*; +use std::str::*; +", + r" +use std<|>::{cell::*, str::*}; +", + ) + } + #[test] fn removes_just_enough_whitespace() { check_assist( diff --git a/crates/ra_syntax/src/ast/edit.rs b/crates/ra_syntax/src/ast/edit.rs index bdaecdc43d..2304e00cf9 100644 --- a/crates/ra_syntax/src/ast/edit.rs +++ b/crates/ra_syntax/src/ast/edit.rs @@ -302,9 +302,10 @@ impl ast::UseTree { Some(it) => it, None => return self.clone(), }; - let use_tree = make::use_tree(suffix.clone(), self.use_tree_list(), self.alias()); + let use_tree = + make::use_tree(suffix.clone(), self.use_tree_list(), self.alias(), self.has_star()); let nested = make::use_tree_list(iter::once(use_tree)); - return make::use_tree(prefix.clone(), Some(nested), None); + return make::use_tree(prefix.clone(), Some(nested), None, false); fn split_path_prefix(prefix: &ast::Path) -> Option { let parent = prefix.parent_path()?; diff --git a/crates/ra_syntax/src/ast/make.rs b/crates/ra_syntax/src/ast/make.rs index 4621c98880..dbf8e63704 100644 --- a/crates/ra_syntax/src/ast/make.rs +++ b/crates/ra_syntax/src/ast/make.rs @@ -29,12 +29,17 @@ pub fn use_tree( path: ast::Path, use_tree_list: Option, alias: Option, + add_star: bool, ) -> ast::UseTree { let mut buf = "use ".to_string(); buf += &path.syntax().to_string(); if let Some(use_tree_list) = use_tree_list { buf += &format!("::{}", use_tree_list); } + if add_star { + buf += "::*"; + } + if let Some(alias) = alias { buf += &format!(" {}", alias); }