Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-12-27 05:23:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Shrink ra_parser::Event from 32 bytes to 16 bytes

Browse source 
This boxes the Error variant with the assumption that it is rarely constructed
This commit is contained in:
Simon Vandel Sillesen 2020-05-16 18:06:23 +02:00
parent ebaa05a447
commit ef6d53521f
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/ra_parser/src/lib.rs
View file

@ -25,7 +25,7 @@ pub(crate) use token_set::TokenSet;
pub use syntax_kind::SyntaxKind; pub use syntax_kind::SyntaxKind;
#[derive(Debug, Clone, PartialEq, Eq, Hash)] #[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub struct ParseError(pub String); pub struct ParseError(pub Box<String>);
/// `TokenSource` abstracts the source of the tokens parser operates on. /// `TokenSource` abstracts the source of the tokens parser operates on.
/// ///

2
crates/ra_parser/src/parser.rs
View file

@ -192,7 +192,7 @@ impl<'t> Parser<'t> {
/// structured errors with spans and notes, like rustc /// structured errors with spans and notes, like rustc
/// does. /// does.
pub(crate) fn error<T: Into<String>>(&mut self, message: T) { pub(crate) fn error<T: Into<String>>(&mut self, message: T) {
let msg = ParseError(message.into()); let msg = ParseError(Box::new(message.into()));
self.push_event(Event::Error { msg }) self.push_event(Event::Error { msg })
} }

2
crates/ra_syntax/src/syntax_node.rs
View file

@ -70,6 +70,6 @@ impl SyntaxTreeBuilder {
} }
pub fn error(&mut self, error: ra_parser::ParseError, text_pos: TextSize) { pub fn error(&mut self, error: ra_parser::ParseError, text_pos: TextSize) {
self.errors.push(SyntaxError::new_at_offset(error.0, text_pos)) self.errors.push(SyntaxError::new_at_offset(*error.0, text_pos))
} }
} }