diff --git a/crates/rust-analyzer/src/diagnostics.rs b/crates/rust-analyzer/src/diagnostics.rs
index b99a8de2fc..034c49c3d5 100644
--- a/crates/rust-analyzer/src/diagnostics.rs
+++ b/crates/rust-analyzer/src/diagnostics.rs
@@ -110,7 +110,7 @@ impl DiagnosticCollection {
                     })
                 {
                     // don't signal an update if the diagnostics are the same
-                    return;
+                    continue;
                 }
                 if *old_gen < generation || generation == 0 {
                     target.insert(file_id, (generation, diagnostics));