diff --git a/crates/rust-analyzer/src/cargo_target_spec.rs b/crates/rust-analyzer/src/cargo_target_spec.rs index 1ab72bd915..8a8b4a32cb 100644 --- a/crates/rust-analyzer/src/cargo_target_spec.rs +++ b/crates/rust-analyzer/src/cargo_target_spec.rs @@ -14,6 +14,7 @@ use crate::{global_state::GlobalStateSnapshot, Result}; #[derive(Clone)] pub(crate) struct CargoTargetSpec { pub(crate) workspace_root: AbsPathBuf, + pub(crate) cargo_toml: AbsPathBuf, pub(crate) package: String, pub(crate) target: String, pub(crate) target_kind: TargetKind, @@ -115,12 +116,17 @@ impl CargoTargetSpec { Some(it) => it, None => return Ok(None), }; + + let target_data = &cargo_ws[target]; + let package_data = &cargo_ws[target_data.package]; let res = CargoTargetSpec { workspace_root: cargo_ws.workspace_root().to_path_buf(), - package: cargo_ws.package_flag(&cargo_ws[cargo_ws[target].package]), - target: cargo_ws[target].name.clone(), - target_kind: cargo_ws[target].kind, + cargo_toml: package_data.manifest.clone(), + package: cargo_ws.package_flag(&package_data), + target: target_data.name.clone(), + target_kind: target_data.kind, }; + Ok(Some(res)) } diff --git a/crates/rust-analyzer/src/handlers.rs b/crates/rust-analyzer/src/handlers.rs index 89c7fd2c7b..94e2bfa1bb 100644 --- a/crates/rust-analyzer/src/handlers.rs +++ b/crates/rust-analyzer/src/handlers.rs @@ -1422,19 +1422,15 @@ pub(crate) fn handle_open_cargo_toml( ) -> Result> { let _p = profile::span("handle_open_cargo_toml"); let file_id = from_proto::file_id(&snap, ¶ms.text_document.uri)?; - let maybe_cargo_spec = CargoTargetSpec::for_file(&snap, file_id)?; - if maybe_cargo_spec.is_none() { - return Ok(None); - } - let cargo_spec = maybe_cargo_spec.unwrap(); - let cargo_toml_path = cargo_spec.workspace_root.join("Cargo.toml"); - if !cargo_toml_path.exists() { - return Ok(None); - } - let cargo_toml_url = to_proto::url_from_abs_path(&cargo_toml_path); - let cargo_toml_location = Location::new(cargo_toml_url, Range::default()); - let res = lsp_types::GotoDefinitionResponse::from(cargo_toml_location); + let cargo_spec = match CargoTargetSpec::for_file(&snap, file_id)? { + Some(it) => it, + None => return Ok(None), + }; + + let cargo_toml_url = to_proto::url_from_abs_path(&cargo_spec.cargo_toml); + let res: lsp_types::GotoDefinitionResponse = + Location::new(cargo_toml_url, Range::default()).into(); Ok(Some(res)) }