Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-12-26 13:03:31 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #18162 - ChayimFriedman2:gat-object-safe, r=Veykril

Browse source 
fix: Consider lifetime GATs object unsafe

Fixes #18156.
This commit is contained in:
bors 2024-09-24 08:14:00 +00:00
commit dfee4c8690
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/hir-ty/src/object_safety.rs
View file

@ -349,7 +349,7 @@ where
ControlFlow::Continue(())
} else {
let generic_params = db.generic_params(item.into());
if generic_params.len_type_or_consts() > 0 {
if !generic_params.is_empty() {
cb(ObjectSafetyViolation::GAT(it))
} else {
ControlFlow::Continue(())

13
crates/hir-ty/src/object_safety/tests.rs
View file

@ -378,3 +378,16 @@ pub trait Error: core::fmt::Debug + core::fmt::Display {
[("Error", vec![])],
);
}
#[test]
fn lifetime_gat_is_object_unsafe() {
check_object_safety(
r#"
//- minicore: dispatch_from_dyn
trait Foo {
type Bar<'a>;
}
"#,
[("Foo", vec![ObjectSafetyViolationKind::GAT])],
);
}