Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-11-15 09:27:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Emit #[must_use] in Generate enum is_variant assist

Browse source
This commit is contained in:
Laurențiu Nicola 2022-03-17 15:10:25 +02:00
parent 98143da799
commit de53232ada
2 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
crates/ide_assists/src/handlers/generate_enum_is_method.rs
View file

@ -30,6 +30,7 @@ use crate::{
// /// Returns `true` if the version is [`Minor`].
// ///
// /// [`Minor`]: Version::Minor
// #[must_use]
// fn is_minor(&self) -> bool {
// matches!(self, Self::Minor)
// }
@ -63,6 +64,7 @@ pub(crate) fn generate_enum_is_method(acc: &mut Assists, ctx: &AssistContext) ->
" /// Returns `true` if the {} is [`{variant}`].
///
/// [`{variant}`]: {}::{variant}
#[must_use]
{}fn {}(&self) -> bool {{
matches!(self, Self::{variant}{})
}}",
@ -105,6 +107,7 @@ impl Variant {
/// Returns `true` if the variant is [`Minor`].
///
/// [`Minor`]: Variant::Minor
#[must_use]
fn is_minor(&self) -> bool {
matches!(self, Self::Minor)
}
@ -151,6 +154,7 @@ impl Variant {
/// Returns `true` if the variant is [`Minor`].
///
/// [`Minor`]: Variant::Minor
#[must_use]
fn is_minor(&self) -> bool {
matches!(self, Self::Minor(..))
}
@ -178,6 +182,7 @@ impl Variant {
/// Returns `true` if the variant is [`Minor`].
///
/// [`Minor`]: Variant::Minor
#[must_use]
fn is_minor(&self) -> bool {
matches!(self, Self::Minor { .. })
}
@ -197,6 +202,7 @@ impl Variant {
/// Returns `true` if the variant is [`Undefined`].
///
/// [`Undefined`]: Variant::Undefined
#[must_use]
fn is_undefined(&self) -> bool {
matches!(self, Self::Undefined)
}
@ -224,6 +230,7 @@ impl Variant {
/// Returns `true` if the variant is [`Minor`].
///
/// [`Minor`]: Variant::Minor
#[must_use]
pub(crate) fn is_minor(&self) -> bool {
matches!(self, Self::Minor)
}
@ -246,6 +253,7 @@ impl Variant {
/// Returns `true` if the variant is [`Minor`].
///
/// [`Minor`]: Variant::Minor
#[must_use]
fn is_minor(&self) -> bool {
matches!(self, Self::Minor)
}
@ -260,6 +268,7 @@ impl Variant {
/// Returns `true` if the variant is [`Minor`].
///
/// [`Minor`]: Variant::Minor
#[must_use]
fn is_minor(&self) -> bool {
matches!(self, Self::Minor)
}
@ -267,6 +276,7 @@ impl Variant {
/// Returns `true` if the variant is [`Major`].
///
/// [`Major`]: Variant::Major
#[must_use]
fn is_major(&self) -> bool {
matches!(self, Self::Major)
}
@ -294,6 +304,7 @@ impl GeneratorState {
/// Returns `true` if the generator state is [`Complete`].
///
/// [`Complete`]: GeneratorState::Complete
#[must_use]
fn is_complete(&self) -> bool {
matches!(self, Self::Complete)
}

1
crates/ide_assists/src/tests/generated.rs
View file

@ -922,6 +922,7 @@ impl Version {
/// Returns `true` if the version is [`Minor`].
///
/// [`Minor`]: Version::Minor
#[must_use]
fn is_minor(&self) -> bool {
matches!(self, Self::Minor)
}