Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2025-01-14 14:13:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix: Don't emit semantic diagnostics in files with a lot of syntax errors

Browse source
This commit is contained in:
Lukas Wirth 2024-07-03 10:59:46 +02:00
parent 848e0c4040
commit cbcb9779f5
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
crates/ide-diagnostics/src/lib.rs
View file

@ -311,9 +311,13 @@ pub fn diagnostics(
FileRange { file_id, range: err.range() },
)
}));
let parse_errors = res.len();
let parse = sema.parse(file_id);
// FIXME: This iterates the entire file which is a rather expensive operation.
// We should implement these differently in some form?
// Salsa caching + incremental re-parse would be better here
for node in parse.syntax().descendants() {
handlers::useless_braces::useless_braces(&mut res, file_id, &node);
handlers::field_shorthand::field_shorthand(&mut res, file_id, &node);
@ -326,7 +330,10 @@ pub fn diagnostics(
let mut diags = Vec::new();
match module {
Some(m) => m.diagnostics(db, &mut diags, config.style_lints),
// A bunch of parse errors in a file indicate some bigger structural parse changes in the
// file, so we skip semantic diagnostics so we can show these faster.
Some(m) if parse_errors < 16 => m.diagnostics(db, &mut diags, config.style_lints),
Some(_) => (),
None => handlers::unlinked_file::unlinked_file(&ctx, &mut res, file_id),
}