From c0107d2ea63a5527d2990f7f322f642340ceb3cd Mon Sep 17 00:00:00 2001 From: Jonas Platte Date: Mon, 26 Jul 2021 10:12:41 +0200 Subject: [PATCH] Fix some grammar / spelling mistakes --- crates/ide_diagnostics/src/lib.rs | 2 +- docs/dev/architecture.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/ide_diagnostics/src/lib.rs b/crates/ide_diagnostics/src/lib.rs index dd87738aac..a3dc88b5f5 100644 --- a/crates/ide_diagnostics/src/lib.rs +++ b/crates/ide_diagnostics/src/lib.rs @@ -43,7 +43,7 @@ mod handlers { pub(crate) mod unresolved_module; pub(crate) mod unresolved_proc_macro; - // The handlers bellow are unusual, the implement the diagnostics as well. + // The handlers below are unusual, the implement the diagnostics as well. pub(crate) mod field_shorthand; pub(crate) mod useless_braces; pub(crate) mod unlinked_file; diff --git a/docs/dev/architecture.md b/docs/dev/architecture.md index 9d1b098723..5ca63e27cf 100644 --- a/docs/dev/architecture.md +++ b/docs/dev/architecture.md @@ -461,9 +461,9 @@ Mind the code--architecture gap: at the moment, we are using fewer feature flags In Rust, it is easy (often too easy) to add serialization to any type by adding `#[derive(Serialize)]`. This easiness is misleading -- serializable types impose significant backwards compatability constraints. If a type is serializable, then it is a part of some IPC boundary. -You often don't control the other side of this boundary, so changing serializable types are hard. +You often don't control the other side of this boundary, so changing serializable types is hard. -For this reason, the types in `ide`, `base_db` and bellow are not serializable by design. +For this reason, the types in `ide`, `base_db` and below are not serializable by design. If such types need to cross an IPC boundary, then the client of rust-analyzer needs to provide custom, client-specific serialization format. This isolates backwards compatibility and migration concerns to a specific client.