Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-12-25 20:43:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

Update parser tests with env var

Browse source
This commit is contained in:
Aleksey Kladov 2020-06-15 11:02:17 +02:00
parent d739731830
commit b5c4f2faa2
3 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
crates/ra_syntax/test_data/parser/inline/err/0009_attr_on_expr_not_allowed.rast
View file

@ -56,4 +56,3 @@ SOURCE_FILE@0..48
R_CURLY@46..47 "}" R_CURLY@46..47 "}"
WHITESPACE@47..48 "\n" WHITESPACE@47..48 "\n"
error 24..24: attributes are not allowed on BIN_EXPR error 24..24: attributes are not allowed on BIN_EXPR
error 44..44: attributes are not allowed on IF_EXPR

12
crates/test_utils/src/lib.rs
View file

@ -10,17 +10,17 @@
pub mod mark; pub mod mark;
use std::{ use std::{
fs, env, fs,
path::{Path, PathBuf}, path::{Path, PathBuf},
}; };
pub use ra_cfg::CfgOptions; use serde_json::Value;
use stdx::split1; use stdx::split1;
use text_size::{TextRange, TextSize};
pub use ra_cfg::CfgOptions;
pub use relative_path::{RelativePath, RelativePathBuf}; pub use relative_path::{RelativePath, RelativePathBuf};
pub use rustc_hash::FxHashMap; pub use rustc_hash::FxHashMap;
use serde_json::Value;
use text_size::{TextRange, TextSize};
pub use difference::Changeset as __Changeset; pub use difference::Changeset as __Changeset;
@ -625,8 +625,6 @@ pub fn skip_slow_tests() -> bool {
should_skip should_skip
} }
const REWRITE: bool = false;
/// Asserts that `expected` and `actual` strings are equal. If they differ only /// Asserts that `expected` and `actual` strings are equal. If they differ only
/// in trailing or leading whitespace the test won't fail and /// in trailing or leading whitespace the test won't fail and
/// the contents of `actual` will be written to the file located at `path`. /// the contents of `actual` will be written to the file located at `path`.
@ -642,7 +640,7 @@ fn assert_equal_text(expected: &str, actual: &str, path: &Path) {
fs::write(path, actual).unwrap(); fs::write(path, actual).unwrap();
return; return;
} }
if REWRITE { if env::var("UPDATE_EXPECTATIONS").is_ok() {
println!("rewriting {}", pretty_path.display()); println!("rewriting {}", pretty_path.display());
fs::write(path, actual).unwrap(); fs::write(path, actual).unwrap();
return; return;

6
docs/dev/README.md
View file

@ -342,6 +342,12 @@ There are two kinds of tests:
The purpose of inline tests is not to achieve full coverage by test cases, but to explain to the reader of the code what each particular `if` and `match` is responsible for. The purpose of inline tests is not to achieve full coverage by test cases, but to explain to the reader of the code what each particular `if` and `match` is responsible for.
If you are tempted to add a large inline test, it might be a good idea to leave only the simplest example in place, and move the test to a manual `parser/ok` test. If you are tempted to add a large inline test, it might be a good idea to leave only the simplest example in place, and move the test to a manual `parser/ok` test.
To update test data, run with `UPDATE_EXPECTATIONS` variable:
```bash
env UPDATE_EXPECTATIONS=1 cargo qt
```
# Logging # Logging
Logging is done by both rust-analyzer and VS Code, so it might be tricky to Logging is done by both rust-analyzer and VS Code, so it might be tricky to