Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-12-26 13:03:31 +00:00
Code Issues Projects Releases Packages Wiki Activity

add error handling to fetchArtifactReleaseInfo(), throw Error when no artifact found

Browse source
This commit is contained in:
Veetaha 2020-02-24 21:13:10 +02:00
parent bd4ea87f74
commit b4db089a6b
1 changed files with 37 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
editors/code/src/installation/fetch_artifact_release_info.ts
View file

@ -4,41 +4,59 @@ import { log } from "../util";
const GITHUB_API_ENDPOINT_URL = "https://api.github.com"; const GITHUB_API_ENDPOINT_URL = "https://api.github.com";
/** /**
* Fetches the release with `releaseTag` (or just latest release when not specified) * Fetches the release with `releaseTag` from GitHub `repo` and
* from GitHub `repo` and returns metadata about `artifactFileName` shipped with * returns metadata about `artifactFileName` shipped with
* this release or `null` if no such artifact was published. * this release.
*
* @throws Error upon network failure or if no such repository, release, or artifact exists.
*/ */
export async function fetchArtifactReleaseInfo( export async function fetchArtifactReleaseInfo(
repo: GithubRepo, artifactFileName: string, releaseTag?: string repo: GithubRepo,
): Promise<null | ArtifactReleaseInfo> { artifactFileName: string,
releaseTag: string
): Promise<ArtifactReleaseInfo> {
const repoOwner = encodeURIComponent(repo.owner); const repoOwner = encodeURIComponent(repo.owner);
const repoName = encodeURIComponent(repo.name); const repoName = encodeURIComponent(repo.name);
const apiEndpointPath = releaseTag const apiEndpointPath = `/repos/${repoOwner}/${repoName}/releases/tags/${releaseTag}`;
? `/repos/${repoOwner}/${repoName}/releases/tags/${releaseTag}`
: `/repos/${repoOwner}/${repoName}/releases/latest`;
const requestUrl = GITHUB_API_ENDPOINT_URL + apiEndpointPath; const requestUrl = GITHUB_API_ENDPOINT_URL + apiEndpointPath;
// We skip runtime type checks for simplicity (here we cast from `any` to `GithubRelease`)
log.debug("Issuing request for released artifacts metadata to", requestUrl); log.debug("Issuing request for released artifacts metadata to", requestUrl);
// FIXME: handle non-ok response const response = await fetch(requestUrl, { headers: { Accept: "application/vnd.github.v3+json" } });
const response: GithubRelease = await fetch(requestUrl, {
headers: { Accept: "application/vnd.github.v3+json" }
})
.then(res => res.json());
const artifact = response.assets.find(artifact => artifact.name === artifactFileName); if (!response.ok) {
log.error("Error fetching artifact release info", {
requestUrl,
releaseTag,
artifactFileName,
response: {
headers: response.headers,
status: response.status,
body: await response.text(),
}
});
if (!artifact) return null; throw new Error(
`Got response ${response.status} when trying to fetch ` +
`"${artifactFileName}" artifact release info for ${releaseTag} release`
);
}
// We skip runtime type checks for simplicity (here we cast from `any` to `GithubRelease`)
const release: GithubRelease = await response.json();
const artifact = release.assets.find(artifact => artifact.name === artifactFileName);
if (!artifact) throw new Error(
`Artifact ${artifactFileName} was not found in ${release.name} release!`
);
return { return {
releaseName: response.name, releaseName: release.name,
downloadUrl: artifact.browser_download_url downloadUrl: artifact.browser_download_url
}; };