Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2025-01-14 14:13:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #12475 - Veykril:trait-impl-completion, r=Veykril

Browse source 
fix: Fix trait impl completions using wrong insert position

Fixes https://github.com/rust-lang/rust-analyzer/issues/12474
This commit is contained in:
bors 2022-06-05 18:29:59 +00:00
commit ad6810e90b
1 changed files with 22 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
crates/ide-completion/src/completions/item_list/trait_impl.rs
View file

@ -118,7 +118,7 @@ fn completion_match(ctx: &CompletionContext) -> Option<(ImplCompletionKind, Text
ImplCompletionKind::All,
match nameref {
Some(name) => name.syntax().text_range(),
None => TextRange::empty(ctx.position.offset),
None => ctx.source_range(),
},
ctx.impl_def.clone()?,
)),
@ -688,6 +688,27 @@ trait Test {
type SomeType;
}
impl Test for () {
type SomeType = $0;\n\
}
",
);
check_edit(
"type SomeType",
r#"
trait Test {
type SomeType;
}
impl Test for () {
type$0
}
"#,
"
trait Test {
type SomeType;
}
impl Test for () {
type SomeType = $0;\n\
}