mirror of
https://github.com/rust-lang/rust-analyzer
synced 2024-12-26 13:03:31 +00:00
internal: document review requesting etiquette
* don't feel obliged to quickly review every PR assigned to you * so that other folks can notify you about interesting PRs without thinking to much about creating additional work for you
This commit is contained in:
parent
3f1a220f32
commit
ad24310d41
1 changed files with 3 additions and 0 deletions
|
@ -242,6 +242,9 @@ There are three sets of people with extra permissions:
|
||||||
They also have direct commit access, but all changes should via bors queue.
|
They also have direct commit access, but all changes should via bors queue.
|
||||||
It's ok to self-approve if you think you know what you are doing!
|
It's ok to self-approve if you think you know what you are doing!
|
||||||
bors should automatically sync the permissions.
|
bors should automatically sync the permissions.
|
||||||
|
Feel free to assign any PR to a reviewer with the relevant expertise to bring the work to their attention.
|
||||||
|
Don't feel pressured to review assigned PRs though.
|
||||||
|
If you don't feel like reviewing for whatever reason, someone else will pick the review up!
|
||||||
* [**triage**](https://github.com/orgs/rust-analyzer/teams/triage) team in the organization.
|
* [**triage**](https://github.com/orgs/rust-analyzer/teams/triage) team in the organization.
|
||||||
This team can label and close issues.
|
This team can label and close issues.
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue