Record derive helper attributes, resolve them in IDE layer

This commit is contained in:
Lukas Wirth 2022-07-24 14:05:37 +02:00
parent 4e60db2d07
commit aa1491ecde
22 changed files with 144 additions and 58 deletions

View file

@ -934,11 +934,11 @@ fn derive_macro_as_call_id(
derive_attr: AttrId, derive_attr: AttrId,
derive_pos: u32, derive_pos: u32,
krate: CrateId, krate: CrateId,
resolver: impl Fn(path::ModPath) -> Option<MacroDefId>, resolver: impl Fn(path::ModPath) -> Option<(MacroId, MacroDefId)>,
) -> Result<MacroCallId, UnresolvedMacro> { ) -> Result<(MacroId, MacroDefId, MacroCallId), UnresolvedMacro> {
let def: MacroDefId = resolver(item_attr.path.clone()) let (macro_id, def_id) = resolver(item_attr.path.clone())
.ok_or_else(|| UnresolvedMacro { path: item_attr.path.clone() })?; .ok_or_else(|| UnresolvedMacro { path: item_attr.path.clone() })?;
let res = def.as_lazy_macro( let call_id = def_id.as_lazy_macro(
db.upcast(), db.upcast(),
krate, krate,
MacroCallKind::Derive { MacroCallKind::Derive {
@ -947,7 +947,7 @@ fn derive_macro_as_call_id(
derive_attr_index: derive_attr.ast_index, derive_attr_index: derive_attr.ast_index,
}, },
); );
Ok(res) Ok((macro_id, def_id, call_id))
} }
fn attr_macro_as_call_id( fn attr_macro_as_call_id(

View file

@ -76,7 +76,7 @@ use crate::{
path::ModPath, path::ModPath,
per_ns::PerNs, per_ns::PerNs,
visibility::Visibility, visibility::Visibility,
AstId, BlockId, BlockLoc, FunctionId, LocalModuleId, ModuleId, ProcMacroId, AstId, BlockId, BlockLoc, FunctionId, LocalModuleId, MacroId, ModuleId, ProcMacroId,
}; };
/// Contains the results of (early) name resolution. /// Contains the results of (early) name resolution.
@ -108,7 +108,7 @@ pub struct DefMap {
proc_macro_loading_error: Option<Box<str>>, proc_macro_loading_error: Option<Box<str>>,
/// Tracks which custom derives are in scope for an item, to allow resolution of derive helper /// Tracks which custom derives are in scope for an item, to allow resolution of derive helper
/// attributes. /// attributes.
derive_helpers_in_scope: FxHashMap<AstId<ast::Item>, Vec<(Name, MacroCallId)>>, derive_helpers_in_scope: FxHashMap<AstId<ast::Item>, Vec<(Name, MacroId, MacroCallId)>>,
/// Custom attributes registered with `#![register_attr]`. /// Custom attributes registered with `#![register_attr]`.
registered_attrs: Vec<SmolStr>, registered_attrs: Vec<SmolStr>,
@ -299,7 +299,10 @@ impl DefMap {
self.modules.iter() self.modules.iter()
} }
pub fn derive_helpers_in_scope(&self, id: AstId<ast::Adt>) -> Option<&[(Name, MacroCallId)]> { pub fn derive_helpers_in_scope(
&self,
id: AstId<ast::Adt>,
) -> Option<&[(Name, MacroId, MacroCallId)]> {
self.derive_helpers_in_scope.get(&id.map(|it| it.upcast())).map(Deref::deref) self.derive_helpers_in_scope.get(&id.map(|it| it.upcast())).map(Deref::deref)
} }

View file

@ -18,7 +18,7 @@ use hir_expand::{
ExpandTo, HirFileId, InFile, MacroCallId, MacroCallKind, MacroCallLoc, MacroDefId, ExpandTo, HirFileId, InFile, MacroCallId, MacroCallKind, MacroCallLoc, MacroDefId,
MacroDefKind, MacroDefKind,
}; };
use itertools::Itertools; use itertools::{izip, Itertools};
use la_arena::Idx; use la_arena::Idx;
use limit::Limit; use limit::Limit;
use rustc_hash::{FxHashMap, FxHashSet}; use rustc_hash::{FxHashMap, FxHashSet};
@ -1055,7 +1055,7 @@ impl DefCollector<'_> {
}; };
let mut res = ReachedFixedPoint::Yes; let mut res = ReachedFixedPoint::Yes;
macros.retain(|directive| { macros.retain(|directive| {
let resolver = |path| { let resolver2 = |path| {
let resolved_res = self.def_map.resolve_path_fp_with_macro( let resolved_res = self.def_map.resolve_path_fp_with_macro(
self.db, self.db,
ResolveMode::Other, ResolveMode::Other,
@ -1063,8 +1063,12 @@ impl DefCollector<'_> {
&path, &path,
BuiltinShadowMode::Module, BuiltinShadowMode::Module,
); );
resolved_res.resolved_def.take_macros().map(|it| macro_id_to_def_id(self.db, it)) resolved_res
.resolved_def
.take_macros()
.map(|it| (it, macro_id_to_def_id(self.db, it)))
}; };
let resolver = |path| resolver2(path).map(|(_, it)| it);
match &directive.kind { match &directive.kind {
MacroDirectiveKind::FnLike { ast_id, expand_to } => { MacroDirectiveKind::FnLike { ast_id, expand_to } => {
@ -1083,21 +1087,37 @@ impl DefCollector<'_> {
} }
} }
MacroDirectiveKind::Derive { ast_id, derive_attr, derive_pos } => { MacroDirectiveKind::Derive { ast_id, derive_attr, derive_pos } => {
let call_id = derive_macro_as_call_id( let id = derive_macro_as_call_id(
self.db, self.db,
ast_id, ast_id,
*derive_attr, *derive_attr,
*derive_pos as u32, *derive_pos as u32,
self.def_map.krate, self.def_map.krate,
&resolver, &resolver2,
); );
if let Ok(call_id) = call_id {
if let Ok((macro_id, def_id, call_id)) = id {
self.def_map.modules[directive.module_id].scope.set_derive_macro_invoc( self.def_map.modules[directive.module_id].scope.set_derive_macro_invoc(
ast_id.ast_id, ast_id.ast_id,
call_id, call_id,
*derive_attr, *derive_attr,
*derive_pos, *derive_pos,
); );
// Record its helper attributes.
if def_id.krate != self.def_map.krate {
let def_map = self.db.crate_def_map(def_id.krate);
if let Some(helpers) = def_map.exported_derives.get(&def_id) {
self.def_map
.derive_helpers_in_scope
.entry(ast_id.ast_id.map(|it| it.upcast()))
.or_default()
.extend(izip!(
helpers.iter().cloned(),
iter::repeat(macro_id),
iter::repeat(call_id),
));
}
}
push_resolved(directive, call_id); push_resolved(directive, call_id);
res = ReachedFixedPoint::No; res = ReachedFixedPoint::No;
@ -1129,7 +1149,7 @@ impl DefCollector<'_> {
if let Some(ident) = path.as_ident() { if let Some(ident) = path.as_ident() {
if let Some(helpers) = self.def_map.derive_helpers_in_scope.get(&ast_id) { if let Some(helpers) = self.def_map.derive_helpers_in_scope.get(&ast_id) {
if helpers.iter().any(|(it, _)| it == ident) { if helpers.iter().any(|(it, ..)| it == ident) {
cov_mark::hit!(resolved_derive_helper); cov_mark::hit!(resolved_derive_helper);
// Resolved to derive helper. Collect the item's attributes again, // Resolved to derive helper. Collect the item's attributes again,
// starting after the derive helper. // starting after the derive helper.
@ -1144,7 +1164,7 @@ impl DefCollector<'_> {
}; };
if matches!( if matches!(
def, def,
MacroDefId { kind:MacroDefKind::BuiltInAttr(expander, _),.. } MacroDefId { kind:MacroDefKind::BuiltInAttr(expander, _),.. }
if expander.is_derive() if expander.is_derive()
) { ) {
// Resolved to `#[derive]` // Resolved to `#[derive]`
@ -1313,20 +1333,6 @@ impl DefCollector<'_> {
self.def_map.diagnostics.push(diag); self.def_map.diagnostics.push(diag);
} }
// If we've just resolved a derive, record its helper attributes.
if let MacroCallKind::Derive { ast_id, .. } = &loc.kind {
if loc.def.krate != self.def_map.krate {
let def_map = self.db.crate_def_map(loc.def.krate);
if let Some(helpers) = def_map.exported_derives.get(&loc.def) {
self.def_map
.derive_helpers_in_scope
.entry(ast_id.map(|it| it.upcast()))
.or_default()
.extend(helpers.iter().cloned().zip(std::iter::repeat(macro_call_id)));
}
}
}
// Then, fetch and process the item tree. This will reuse the expansion result from above. // Then, fetch and process the item tree. This will reuse the expansion result from above.
let item_tree = self.db.file_item_tree(file_id); let item_tree = self.db.file_item_tree(file_id);
let mod_dir = self.mod_dirs[&module_id].clone(); let mod_dir = self.mod_dirs[&module_id].clone();

View file

@ -149,6 +149,7 @@ impl Resolver {
self.resolve_module_path(db, path, BuiltinShadowMode::Module) self.resolve_module_path(db, path, BuiltinShadowMode::Module)
} }
// FIXME: This shouldn't exist
pub fn resolve_module_path_in_trait_assoc_items( pub fn resolve_module_path_in_trait_assoc_items(
&self, &self,
db: &dyn DefDatabase, db: &dyn DefDatabase,

View file

@ -2252,6 +2252,17 @@ impl Local {
} }
} }
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
pub struct DeriveHelper {
pub(crate) derive: MacroId,
}
impl DeriveHelper {
pub fn derive(&self) -> Macro {
Macro { id: self.derive.into() }
}
}
// FIXME: Wrong name? This is could also be a registered attribute // FIXME: Wrong name? This is could also be a registered attribute
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)] #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
pub struct BuiltinAttr { pub struct BuiltinAttr {

View file

@ -29,9 +29,9 @@ use crate::{
db::HirDatabase, db::HirDatabase,
semantics::source_to_def::{ChildContainer, SourceToDefCache, SourceToDefCtx}, semantics::source_to_def::{ChildContainer, SourceToDefCache, SourceToDefCtx},
source_analyzer::{resolve_hir_path, SourceAnalyzer}, source_analyzer::{resolve_hir_path, SourceAnalyzer},
Access, BindingMode, BuiltinAttr, Callable, ConstParam, Crate, Field, Function, HasSource, Access, BindingMode, BuiltinAttr, Callable, ConstParam, Crate, DeriveHelper, Field, Function,
HirFileId, Impl, InFile, Label, LifetimeParam, Local, Macro, Module, ModuleDef, Name, Path, HasSource, HirFileId, Impl, InFile, Label, LifetimeParam, Local, Macro, Module, ModuleDef,
ScopeDef, ToolModule, Trait, Type, TypeAlias, TypeParam, VariantDef, Name, Path, ScopeDef, ToolModule, Trait, Type, TypeAlias, TypeParam, VariantDef,
}; };
#[derive(Debug, Clone, PartialEq, Eq)] #[derive(Debug, Clone, PartialEq, Eq)]
@ -47,6 +47,7 @@ pub enum PathResolution {
SelfType(Impl), SelfType(Impl),
BuiltinAttr(BuiltinAttr), BuiltinAttr(BuiltinAttr),
ToolModule(ToolModule), ToolModule(ToolModule),
DeriveHelper(DeriveHelper),
} }
impl PathResolution { impl PathResolution {
@ -71,6 +72,7 @@ impl PathResolution {
PathResolution::BuiltinAttr(_) PathResolution::BuiltinAttr(_)
| PathResolution::ToolModule(_) | PathResolution::ToolModule(_)
| PathResolution::Local(_) | PathResolution::Local(_)
| PathResolution::DeriveHelper(_)
| PathResolution::ConstParam(_) => None, | PathResolution::ConstParam(_) => None,
PathResolution::TypeParam(param) => Some(TypeNs::GenericParam((*param).into())), PathResolution::TypeParam(param) => Some(TypeNs::GenericParam((*param).into())),
PathResolution::SelfType(impl_def) => Some(TypeNs::SelfType((*impl_def).into())), PathResolution::SelfType(impl_def) => Some(TypeNs::SelfType((*impl_def).into())),
@ -856,7 +858,9 @@ impl<'db> SemanticsImpl<'db> {
None None
} }
}?; }?;
if !self.with_ctx(|ctx| ctx.has_derives(InFile::new(token.file_id, &adt))) {
return None;
}
// Not an attribute, nor a derive, so it's either a builtin or a derive helper // Not an attribute, nor a derive, so it's either a builtin or a derive helper
// Try to resolve to a derive helper and downmap // Try to resolve to a derive helper and downmap
let attr_name = attr.path().and_then(|it| it.as_single_name_ref())?.as_name(); let attr_name = attr.path().and_then(|it| it.as_single_name_ref())?.as_name();
@ -865,7 +869,7 @@ impl<'db> SemanticsImpl<'db> {
def_map.derive_helpers_in_scope(InFile::new(token.file_id, id))?; def_map.derive_helpers_in_scope(InFile::new(token.file_id, id))?;
let item = Some(adt.into()); let item = Some(adt.into());
let mut res = None; let mut res = None;
for (_, derive) in helpers.iter().filter(|(helper, _)| *helper == attr_name) { for (.., derive) in helpers.iter().filter(|(helper, ..)| *helper == attr_name) {
res = res.or(process_expansion_for_token( res = res.or(process_expansion_for_token(
&mut stack, &mut stack,
derive.as_file(), derive.as_file(),

View file

@ -43,8 +43,8 @@ use syntax::{
use crate::{ use crate::{
db::HirDatabase, semantics::PathResolution, Adt, AssocItem, BindingMode, BuiltinAttr, db::HirDatabase, semantics::PathResolution, Adt, AssocItem, BindingMode, BuiltinAttr,
BuiltinType, Callable, Const, Field, Function, Local, Macro, ModuleDef, Static, Struct, BuiltinType, Callable, Const, DeriveHelper, Field, Function, Local, Macro, ModuleDef, Static,
ToolModule, Trait, Type, TypeAlias, Variant, Struct, ToolModule, Trait, Type, TypeAlias, Variant,
}; };
/// `SourceAnalyzer` is a convenience wrapper which exposes HIR API in terms of /// `SourceAnalyzer` is a convenience wrapper which exposes HIR API in terms of
@ -429,19 +429,21 @@ impl SourceAnalyzer {
} }
} }
let is_path_of_attr = path let meta_path = path
.syntax() .syntax()
.ancestors() .ancestors()
.map(|it| it.kind()) .take_while(|it| {
.take_while(|&kind| ast::Path::can_cast(kind) || ast::Meta::can_cast(kind)) let kind = it.kind();
ast::Path::can_cast(kind) || ast::Meta::can_cast(kind)
})
.last() .last()
.map_or(false, ast::Meta::can_cast); .and_then(ast::Meta::cast);
// Case where path is a qualifier of another path, e.g. foo::bar::Baz where we are // Case where path is a qualifier of another path, e.g. foo::bar::Baz where we are
// trying to resolve foo::bar. // trying to resolve foo::bar.
if path.parent_path().is_some() { if path.parent_path().is_some() {
return match resolve_hir_path_qualifier(db, &self.resolver, &hir_path) { return match resolve_hir_path_qualifier(db, &self.resolver, &hir_path) {
None if is_path_of_attr => { None if meta_path.is_some() => {
path.first_segment().and_then(|it| it.name_ref()).and_then(|name_ref| { path.first_segment().and_then(|it| it.name_ref()).and_then(|name_ref| {
ToolModule::by_name(db, self.resolver.krate().into(), &name_ref.text()) ToolModule::by_name(db, self.resolver.krate().into(), &name_ref.text())
.map(PathResolution::ToolModule) .map(PathResolution::ToolModule)
@ -449,16 +451,50 @@ impl SourceAnalyzer {
} }
res => res, res => res,
}; };
} else if is_path_of_attr { } else if let Some(meta_path) = meta_path {
// Case where we are resolving the final path segment of a path in an attribute // Case where we are resolving the final path segment of a path in an attribute
// in this case we have to check for inert/builtin attributes and tools and prioritize // in this case we have to check for inert/builtin attributes and tools and prioritize
// resolution of attributes over other namespaces // resolution of attributes over other namespaces
let name_ref = path.as_single_name_ref(); if let Some(name_ref) = path.as_single_name_ref() {
let builtin = name_ref.as_ref().and_then(|name_ref| { let builtin =
BuiltinAttr::by_name(db, self.resolver.krate().into(), &name_ref.text()) BuiltinAttr::by_name(db, self.resolver.krate().into(), &name_ref.text());
}); if let Some(_) = builtin {
if let Some(_) = builtin { return builtin.map(PathResolution::BuiltinAttr);
return builtin.map(PathResolution::BuiltinAttr); }
if let Some(attr) = meta_path.parent_attr() {
let adt = if let Some(field) =
attr.syntax().parent().and_then(ast::RecordField::cast)
{
field.syntax().ancestors().take(4).find_map(ast::Adt::cast)
} else if let Some(field) =
attr.syntax().parent().and_then(ast::TupleField::cast)
{
field.syntax().ancestors().take(4).find_map(ast::Adt::cast)
} else if let Some(variant) =
attr.syntax().parent().and_then(ast::Variant::cast)
{
variant.syntax().ancestors().nth(2).and_then(ast::Adt::cast)
} else {
None
};
if let Some(adt) = adt {
let ast_id = db.ast_id_map(self.file_id).ast_id(&adt);
if let Some(helpers) = self
.resolver
.def_map()
.derive_helpers_in_scope(InFile::new(self.file_id, ast_id))
{
// FIXME: Multiple derives can have the same helper
let name_ref = name_ref.as_name();
if let Some(&(_, derive, _)) =
helpers.iter().find(|(name, ..)| *name == name_ref)
{
return Some(PathResolution::DeriveHelper(DeriveHelper { derive }));
}
}
}
}
} }
return match resolve_hir_path_as_macro(db, &self.resolver, &hir_path) { return match resolve_hir_path_as_macro(db, &self.resolver, &hir_path) {
Some(m) => Some(PathResolution::Def(ModuleDef::Macro(m))), Some(m) => Some(PathResolution::Def(ModuleDef::Macro(m))),

View file

@ -292,6 +292,7 @@ impl CompletionItemKind {
SymbolKind::Const => "ct", SymbolKind::Const => "ct",
SymbolKind::ConstParam => "cp", SymbolKind::ConstParam => "cp",
SymbolKind::Derive => "de", SymbolKind::Derive => "de",
SymbolKind::DeriveHelper => "dh",
SymbolKind::Enum => "en", SymbolKind::Enum => "en",
SymbolKind::Field => "fd", SymbolKind::Field => "fd",
SymbolKind::Function => "fn", SymbolKind::Function => "fn",

View file

@ -7,9 +7,9 @@
use arrayvec::ArrayVec; use arrayvec::ArrayVec;
use hir::{ use hir::{
Adt, AsAssocItem, AssocItem, BuiltinAttr, BuiltinType, Const, Crate, Field, Function, Adt, AsAssocItem, AssocItem, BuiltinAttr, BuiltinType, Const, Crate, DeriveHelper, Field,
GenericParam, HasVisibility, Impl, ItemInNs, Label, Local, Macro, Module, ModuleDef, Name, Function, GenericParam, HasVisibility, Impl, ItemInNs, Label, Local, Macro, Module, ModuleDef,
PathResolution, Semantics, Static, ToolModule, Trait, TypeAlias, Variant, Visibility, Name, PathResolution, Semantics, Static, ToolModule, Trait, TypeAlias, Variant, Visibility,
}; };
use stdx::impl_from; use stdx::impl_from;
use syntax::{ use syntax::{
@ -37,6 +37,7 @@ pub enum Definition {
Local(Local), Local(Local),
GenericParam(GenericParam), GenericParam(GenericParam),
Label(Label), Label(Label),
DeriveHelper(DeriveHelper),
BuiltinAttr(BuiltinAttr), BuiltinAttr(BuiltinAttr),
ToolModule(ToolModule), ToolModule(ToolModule),
} }
@ -69,6 +70,7 @@ impl Definition {
Definition::Local(it) => it.module(db), Definition::Local(it) => it.module(db),
Definition::GenericParam(it) => it.module(db), Definition::GenericParam(it) => it.module(db),
Definition::Label(it) => it.module(db), Definition::Label(it) => it.module(db),
Definition::DeriveHelper(it) => it.derive().module(db),
Definition::BuiltinAttr(_) | Definition::BuiltinType(_) | Definition::ToolModule(_) => { Definition::BuiltinAttr(_) | Definition::BuiltinType(_) | Definition::ToolModule(_) => {
return None return None
} }
@ -94,7 +96,8 @@ impl Definition {
| Definition::SelfType(_) | Definition::SelfType(_)
| Definition::Local(_) | Definition::Local(_)
| Definition::GenericParam(_) | Definition::GenericParam(_)
| Definition::Label(_) => return None, | Definition::Label(_)
| Definition::DeriveHelper(_) => return None,
}; };
Some(vis) Some(vis)
} }
@ -118,6 +121,7 @@ impl Definition {
Definition::Label(it) => it.name(db), Definition::Label(it) => it.name(db),
Definition::BuiltinAttr(_) => return None, // FIXME Definition::BuiltinAttr(_) => return None, // FIXME
Definition::ToolModule(_) => return None, // FIXME Definition::ToolModule(_) => return None, // FIXME
Definition::DeriveHelper(_) => return None, // FIXME
}; };
Some(name) Some(name)
} }
@ -500,6 +504,7 @@ impl From<PathResolution> for Definition {
PathResolution::SelfType(impl_def) => Definition::SelfType(impl_def), PathResolution::SelfType(impl_def) => Definition::SelfType(impl_def),
PathResolution::BuiltinAttr(attr) => Definition::BuiltinAttr(attr), PathResolution::BuiltinAttr(attr) => Definition::BuiltinAttr(attr),
PathResolution::ToolModule(tool) => Definition::ToolModule(tool), PathResolution::ToolModule(tool) => Definition::ToolModule(tool),
PathResolution::DeriveHelper(helper) => Definition::DeriveHelper(helper),
} }
} }
} }

View file

@ -173,6 +173,7 @@ pub enum SymbolKind {
Const, Const,
ConstParam, ConstParam,
Derive, Derive,
DeriveHelper,
Enum, Enum,
Field, Field,
Function, Function,

View file

@ -224,7 +224,8 @@ impl<'a> Ctx<'a> {
| hir::PathResolution::SelfType(_) | hir::PathResolution::SelfType(_)
| hir::PathResolution::Def(_) | hir::PathResolution::Def(_)
| hir::PathResolution::BuiltinAttr(_) | hir::PathResolution::BuiltinAttr(_)
| hir::PathResolution::ToolModule(_) => (), | hir::PathResolution::ToolModule(_)
| hir::PathResolution::DeriveHelper(_) => (),
} }
Some(()) Some(())
} }

View file

@ -156,6 +156,8 @@ impl Definition {
Definition::SelfType(_) => return None, Definition::SelfType(_) => return None,
Definition::BuiltinAttr(_) => return None, Definition::BuiltinAttr(_) => return None,
Definition::ToolModule(_) => return None, Definition::ToolModule(_) => return None,
// FIXME: This should be doable in theory
Definition::DeriveHelper(_) => return None,
}; };
return res; return res;

View file

@ -190,7 +190,8 @@ pub(crate) fn resolve_doc_path_for_def(
| Definition::SelfType(_) | Definition::SelfType(_)
| Definition::Local(_) | Definition::Local(_)
| Definition::GenericParam(_) | Definition::GenericParam(_)
| Definition::Label(_) => None, | Definition::Label(_)
| Definition::DeriveHelper(_) => None,
} }
.map(Definition::from) .map(Definition::from)
} }
@ -515,7 +516,8 @@ fn filename_and_frag_for_def(
| Definition::GenericParam(_) | Definition::GenericParam(_)
| Definition::Label(_) | Definition::Label(_)
| Definition::BuiltinAttr(_) | Definition::BuiltinAttr(_)
| Definition::ToolModule(_) => return None, | Definition::ToolModule(_)
| Definition::DeriveHelper(_) => return None,
}; };
Some((def, res, None)) Some((def, res, None))

View file

@ -370,6 +370,8 @@ pub(super) fn definition(
// FIXME: We should be able to show more info about these // FIXME: We should be able to show more info about these
Definition::BuiltinAttr(it) => return render_builtin_attr(db, it), Definition::BuiltinAttr(it) => return render_builtin_attr(db, it),
Definition::ToolModule(it) => return Some(Markup::fenced_block(&it.name(db))), Definition::ToolModule(it) => return Some(Markup::fenced_block(&it.name(db))),
// FIXME: it.name(db)
Definition::DeriveHelper(_it) => ("derive-helper".to_owned(), None),
}; };
let docs = match config.documentation { let docs = match config.documentation {

View file

@ -196,6 +196,8 @@ impl TryToNav for Definition {
Definition::BuiltinType(_) => None, Definition::BuiltinType(_) => None,
Definition::ToolModule(_) => None, Definition::ToolModule(_) => None,
Definition::BuiltinAttr(_) => None, Definition::BuiltinAttr(_) => None,
// FIXME: The focus range should be set to the helper declaration
Definition::DeriveHelper(it) => it.derive().try_to_nav(db),
} }
} }
} }

View file

@ -237,7 +237,8 @@ fn signature_help_for_generics(
| hir::PathResolution::Local(_) | hir::PathResolution::Local(_)
| hir::PathResolution::TypeParam(_) | hir::PathResolution::TypeParam(_)
| hir::PathResolution::ConstParam(_) | hir::PathResolution::ConstParam(_)
| hir::PathResolution::SelfType(_) => return None, | hir::PathResolution::SelfType(_)
| hir::PathResolution::DeriveHelper(_) => return None,
}; };
generic_def generic_def

View file

@ -107,6 +107,7 @@ pub struct HlRange {
// builtinType:: Emitted for builtin types like `u32`, `str` and `f32`. // builtinType:: Emitted for builtin types like `u32`, `str` and `f32`.
// comment:: Emitted for comments. // comment:: Emitted for comments.
// constParameter:: Emitted for const parameters. // constParameter:: Emitted for const parameters.
// deriveHelper:: Emitted for derive helper attributes.
// enumMember:: Emitted for enum variants. // enumMember:: Emitted for enum variants.
// generic:: Emitted for generic tokens that have no mapping. // generic:: Emitted for generic tokens that have no mapping.
// keyword:: Emitted for keywords. // keyword:: Emitted for keywords.

View file

@ -472,6 +472,7 @@ fn highlight_def(
Definition::Label(_) => Highlight::new(HlTag::Symbol(SymbolKind::Label)), Definition::Label(_) => Highlight::new(HlTag::Symbol(SymbolKind::Label)),
Definition::BuiltinAttr(_) => Highlight::new(HlTag::Symbol(SymbolKind::BuiltinAttr)), Definition::BuiltinAttr(_) => Highlight::new(HlTag::Symbol(SymbolKind::BuiltinAttr)),
Definition::ToolModule(_) => Highlight::new(HlTag::Symbol(SymbolKind::ToolModule)), Definition::ToolModule(_) => Highlight::new(HlTag::Symbol(SymbolKind::ToolModule)),
Definition::DeriveHelper(_) => Highlight::new(HlTag::Symbol(SymbolKind::DeriveHelper)),
}; };
let def_crate = def.krate(db); let def_crate = def.krate(db);

View file

@ -270,6 +270,7 @@ fn module_def_to_hl_tag(def: Definition) -> HlTag {
Definition::Label(_) => SymbolKind::Label, Definition::Label(_) => SymbolKind::Label,
Definition::BuiltinAttr(_) => SymbolKind::BuiltinAttr, Definition::BuiltinAttr(_) => SymbolKind::BuiltinAttr,
Definition::ToolModule(_) => SymbolKind::ToolModule, Definition::ToolModule(_) => SymbolKind::ToolModule,
Definition::DeriveHelper(_) => SymbolKind::DeriveHelper,
}; };
HlTag::Symbol(symbol) HlTag::Symbol(symbol)
} }

View file

@ -134,6 +134,7 @@ impl HlTag {
SymbolKind::Const => "constant", SymbolKind::Const => "constant",
SymbolKind::ConstParam => "const_param", SymbolKind::ConstParam => "const_param",
SymbolKind::Derive => "derive", SymbolKind::Derive => "derive",
SymbolKind::DeriveHelper => "derive_helper",
SymbolKind::Enum => "enum", SymbolKind::Enum => "enum",
SymbolKind::Field => "field", SymbolKind::Field => "field",
SymbolKind::Function => "function", SymbolKind::Function => "function",

View file

@ -54,6 +54,7 @@ define_semantic_token_types![
(COMPARISON, "comparison"), (COMPARISON, "comparison"),
(CONST_PARAMETER, "constParameter"), (CONST_PARAMETER, "constParameter"),
(DERIVE, "derive"), (DERIVE, "derive"),
(DERIVE_HELPER, "deriveHelper"),
(DOT, "dot"), (DOT, "dot"),
(ESCAPE_SEQUENCE, "escapeSequence"), (ESCAPE_SEQUENCE, "escapeSequence"),
(FORMAT_SPECIFIER, "formatSpecifier"), (FORMAT_SPECIFIER, "formatSpecifier"),

View file

@ -53,7 +53,8 @@ pub(crate) fn symbol_kind(symbol_kind: SymbolKind) -> lsp_types::SymbolKind {
SymbolKind::Macro SymbolKind::Macro
| SymbolKind::BuiltinAttr | SymbolKind::BuiltinAttr
| SymbolKind::Attribute | SymbolKind::Attribute
| SymbolKind::Derive => lsp_types::SymbolKind::FUNCTION, | SymbolKind::Derive
| SymbolKind::DeriveHelper => lsp_types::SymbolKind::FUNCTION,
SymbolKind::Module | SymbolKind::ToolModule => lsp_types::SymbolKind::MODULE, SymbolKind::Module | SymbolKind::ToolModule => lsp_types::SymbolKind::MODULE,
SymbolKind::TypeAlias | SymbolKind::TypeParam | SymbolKind::SelfType => { SymbolKind::TypeAlias | SymbolKind::TypeParam | SymbolKind::SelfType => {
lsp_types::SymbolKind::TYPE_PARAMETER lsp_types::SymbolKind::TYPE_PARAMETER
@ -117,6 +118,7 @@ pub(crate) fn completion_item_kind(
SymbolKind::Const => lsp_types::CompletionItemKind::CONSTANT, SymbolKind::Const => lsp_types::CompletionItemKind::CONSTANT,
SymbolKind::ConstParam => lsp_types::CompletionItemKind::TYPE_PARAMETER, SymbolKind::ConstParam => lsp_types::CompletionItemKind::TYPE_PARAMETER,
SymbolKind::Derive => lsp_types::CompletionItemKind::FUNCTION, SymbolKind::Derive => lsp_types::CompletionItemKind::FUNCTION,
SymbolKind::DeriveHelper => lsp_types::CompletionItemKind::FUNCTION,
SymbolKind::Enum => lsp_types::CompletionItemKind::ENUM, SymbolKind::Enum => lsp_types::CompletionItemKind::ENUM,
SymbolKind::Field => lsp_types::CompletionItemKind::FIELD, SymbolKind::Field => lsp_types::CompletionItemKind::FIELD,
SymbolKind::Function => lsp_types::CompletionItemKind::FUNCTION, SymbolKind::Function => lsp_types::CompletionItemKind::FUNCTION,
@ -561,6 +563,7 @@ fn semantic_token_type_and_modifiers(
HlTag::Symbol(symbol) => match symbol { HlTag::Symbol(symbol) => match symbol {
SymbolKind::Attribute => semantic_tokens::ATTRIBUTE, SymbolKind::Attribute => semantic_tokens::ATTRIBUTE,
SymbolKind::Derive => semantic_tokens::DERIVE, SymbolKind::Derive => semantic_tokens::DERIVE,
SymbolKind::DeriveHelper => semantic_tokens::DERIVE_HELPER,
SymbolKind::Module => lsp_types::SemanticTokenType::NAMESPACE, SymbolKind::Module => lsp_types::SemanticTokenType::NAMESPACE,
SymbolKind::Impl => semantic_tokens::TYPE_ALIAS, SymbolKind::Impl => semantic_tokens::TYPE_ALIAS,
SymbolKind::Field => lsp_types::SemanticTokenType::PROPERTY, SymbolKind::Field => lsp_types::SemanticTokenType::PROPERTY,