diff --git a/crates/hir-ty/src/lib.rs b/crates/hir-ty/src/lib.rs
index 61055583fc..19052a18b1 100644
--- a/crates/hir-ty/src/lib.rs
+++ b/crates/hir-ty/src/lib.rs
@@ -414,6 +414,7 @@ impl Hash for FnAbi {
 }
 
 impl FnAbi {
+    #[allow(clippy::should_implement_trait)]
     pub fn from_str(s: &str) -> FnAbi {
         match s {
             "aapcs-unwind" => FnAbi::AapcsUnwind,